Re: CVS GLX oddity
On Fri, Mar 24, 2006 at 10:13:25AM -0800, Mark Vojkovich wrote:
> Is that the final fix or is there something else I should test?
>That one works for me.
That is the final fix. I'll commit it soon.
David
>
>
> Mark.
>
>On Thu, 23 Mar 2006, Mark Vojkovich wrote:
>
>>
>>Yes, that works.
>>
>> Mark.
>>
>> On Thu, 23 Mar 2006, David Dawes wrote:
>>
>> > On Wed, Mar 22, 2006 at 08:52:00PM -0800, Mark Vojkovich wrote:
>> > > initdata is still NULL even after your call to LoaderSymbol() in
>> > >that patch.
>> >
>> > The module name needs to be prepended. Something like:
>> >
>> > if (!initdata) {
>> > char *md;
>> >
>> > xasprintf(&md, "%s" MODULE_DATA_NAME, name);
>> > if (md) {
>> > initdata = LoaderSymbol(md);
>> > xfree(md);
>> > }
>> > }
>> >
>> >
>> > David
>> >
>> > >
>> > > Mark.
>> > >
>> > >On Wed, 22 Mar 2006, David Dawes wrote:
>> > >
>> > >> On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote:
>> > >> > I can't get CVS to load NVIDIA's GLX module. It complains:
>> > >> >
>> > >> >(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so
>> > >> >(EE) LoadModule: Module glx does not have a glxModuleData data object.
>> > >> >(II) UnloadModule: "glx"
>> > >> >
>> > >> >Did something change with regards to this? It was working before
>> > >> >I updated.
>> > >>
>> > >> dlopen modules have always had different semantics than XFree86 modules.
>> > >> These differences will only get greater as additional features are added
>> > >> to the XFree86 loader and as the newly added features are used more
>> > >> widely.
>> > >>
>> > >> The following (untested) patch may solve this particular problem. Let
>> > >> me know
>> > >> how it goes.
>> > >>
>> > >> David
>> > >> --
>> > >> David Dawes X-Oz Technologies
>> > >> www.XFree86.org/~dawes www.x-oz.com
>> > >>
>> > >___
>> > >Devel mailing list
>> > >Devel@XFree86.Org
>> > >http://XFree86.Org/mailman/listinfo/devel
>> >
>> > ___
>> > Devel mailing list
>> > Devel@XFree86.Org
>> > http://XFree86.Org/mailman/listinfo/devel
>> >
>>
>___
>Devel mailing list
>Devel@XFree86.Org
>http://XFree86.Org/mailman/listinfo/devel
--
David Dawes X-Oz Technologies
www.XFree86.org/~dawes www.x-oz.com
___
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
Re: CVS GLX oddity
Is that the final fix or is there something else I should test?
That one works for me.
Mark.
On Thu, 23 Mar 2006, Mark Vojkovich wrote:
>
>Yes, that works.
>
> Mark.
>
> On Thu, 23 Mar 2006, David Dawes wrote:
>
> > On Wed, Mar 22, 2006 at 08:52:00PM -0800, Mark Vojkovich wrote:
> > > initdata is still NULL even after your call to LoaderSymbol() in
> > >that patch.
> >
> > The module name needs to be prepended. Something like:
> >
> > if (!initdata) {
> > char *md;
> >
> > xasprintf(&md, "%s" MODULE_DATA_NAME, name);
> > if (md) {
> > initdata = LoaderSymbol(md);
> > xfree(md);
> > }
> > }
> >
> >
> > David
> >
> > >
> > > Mark.
> > >
> > >On Wed, 22 Mar 2006, David Dawes wrote:
> > >
> > >> On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote:
> > >> > I can't get CVS to load NVIDIA's GLX module. It complains:
> > >> >
> > >> >(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so
> > >> >(EE) LoadModule: Module glx does not have a glxModuleData data object.
> > >> >(II) UnloadModule: "glx"
> > >> >
> > >> >Did something change with regards to this? It was working before
> > >> >I updated.
> > >>
> > >> dlopen modules have always had different semantics than XFree86 modules.
> > >> These differences will only get greater as additional features are added
> > >> to the XFree86 loader and as the newly added features are used more
> > >> widely.
> > >>
> > >> The following (untested) patch may solve this particular problem. Let
> > >> me know
> > >> how it goes.
> > >>
> > >> David
> > >> --
> > >> David Dawes X-Oz Technologies
> > >> www.XFree86.org/~dawes www.x-oz.com
> > >>
> > >___
> > >Devel mailing list
> > >Devel@XFree86.Org
> > >http://XFree86.Org/mailman/listinfo/devel
> >
> > ___
> > Devel mailing list
> > Devel@XFree86.Org
> > http://XFree86.Org/mailman/listinfo/devel
> >
>
___
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
Re: CVS GLX oddity
Yes, that works.
Mark.
On Thu, 23 Mar 2006, David Dawes wrote:
> On Wed, Mar 22, 2006 at 08:52:00PM -0800, Mark Vojkovich wrote:
> > initdata is still NULL even after your call to LoaderSymbol() in
> >that patch.
>
> The module name needs to be prepended. Something like:
>
> if (!initdata) {
> char *md;
>
> xasprintf(&md, "%s" MODULE_DATA_NAME, name);
> if (md) {
> initdata = LoaderSymbol(md);
> xfree(md);
> }
> }
>
>
> David
>
> >
> > Mark.
> >
> >On Wed, 22 Mar 2006, David Dawes wrote:
> >
> >> On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote:
> >> > I can't get CVS to load NVIDIA's GLX module. It complains:
> >> >
> >> >(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so
> >> >(EE) LoadModule: Module glx does not have a glxModuleData data object.
> >> >(II) UnloadModule: "glx"
> >> >
> >> >Did something change with regards to this? It was working before
> >> >I updated.
> >>
> >> dlopen modules have always had different semantics than XFree86 modules.
> >> These differences will only get greater as additional features are added
> >> to the XFree86 loader and as the newly added features are used more
> >> widely.
> >>
> >> The following (untested) patch may solve this particular problem. Let me
> >> know
> >> how it goes.
> >>
> >> David
> >> --
> >> David Dawes X-Oz Technologies
> >> www.XFree86.org/~dawes www.x-oz.com
> >>
> >___
> >Devel mailing list
> >Devel@XFree86.Org
> >http://XFree86.Org/mailman/listinfo/devel
>
> ___
> Devel mailing list
> Devel@XFree86.Org
> http://XFree86.Org/mailman/listinfo/devel
>
___
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
Re: CVS GLX oddity
On Wed, Mar 22, 2006 at 08:52:00PM -0800, Mark Vojkovich wrote:
> initdata is still NULL even after your call to LoaderSymbol() in
>that patch.
The module name needs to be prepended. Something like:
if (!initdata) {
char *md;
xasprintf(&md, "%s" MODULE_DATA_NAME, name);
if (md) {
initdata = LoaderSymbol(md);
xfree(md);
}
}
David
>
> Mark.
>
>On Wed, 22 Mar 2006, David Dawes wrote:
>
>> On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote:
>> > I can't get CVS to load NVIDIA's GLX module. It complains:
>> >
>> >(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so
>> >(EE) LoadModule: Module glx does not have a glxModuleData data object.
>> >(II) UnloadModule: "glx"
>> >
>> >Did something change with regards to this? It was working before
>> >I updated.
>>
>> dlopen modules have always had different semantics than XFree86 modules.
>> These differences will only get greater as additional features are added
>> to the XFree86 loader and as the newly added features are used more
>> widely.
>>
>> The following (untested) patch may solve this particular problem. Let me
>> know
>> how it goes.
>>
>> David
>> --
>> David Dawes X-Oz Technologies
>> www.XFree86.org/~dawes www.x-oz.com
>>
>___
>Devel mailing list
>Devel@XFree86.Org
>http://XFree86.Org/mailman/listinfo/devel
___
Devel mailing list
Devel@XFree86.Org
http://XFree86.Org/mailman/listinfo/devel
Re: CVS GLX oddity
initdata is still NULL even after your call to LoaderSymbol() in that patch. Mark. On Wed, 22 Mar 2006, David Dawes wrote: > On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote: > > I can't get CVS to load NVIDIA's GLX module. It complains: > > > >(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so > >(EE) LoadModule: Module glx does not have a glxModuleData data object. > >(II) UnloadModule: "glx" > > > >Did something change with regards to this? It was working before > >I updated. > > dlopen modules have always had different semantics than XFree86 modules. > These differences will only get greater as additional features are added > to the XFree86 loader and as the newly added features are used more > widely. > > The following (untested) patch may solve this particular problem. Let me know > how it goes. > > David > -- > David Dawes X-Oz Technologies > www.XFree86.org/~dawes www.x-oz.com > ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
Re: CVS GLX oddity
On Wed, Mar 22, 2006 at 06:57:17PM -0800, Mark Vojkovich wrote:
> I can't get CVS to load NVIDIA's GLX module. It complains:
>
>(II) Loading /usr/X11R6/lib/modules/extensions/libglx.so
>(EE) LoadModule: Module glx does not have a glxModuleData data object.
>(II) UnloadModule: "glx"
>
>Did something change with regards to this? It was working before
>I updated.
dlopen modules have always had different semantics than XFree86 modules.
These differences will only get greater as additional features are added
to the XFree86 loader and as the newly added features are used more
widely.
The following (untested) patch may solve this particular problem. Let me know
how it goes.
David
--
David Dawes X-Oz Technologies
www.XFree86.org/~dawes www.x-oz.com
Index: loadmod.c
===
RCS file: /home/x-cvs/xc/programs/Xserver/hw/xfree86/loader/loadmod.c,v
retrieving revision 1.78
diff -u -r1.78 loadmod.c
--- loadmod.c 16 Mar 2006 16:50:34 - 1.78
+++ loadmod.c 23 Mar 2006 03:29:57 -
@@ -1084,6 +1084,10 @@
ret->filename = xstrdup(found);
+/* This is needed for dlopen modules. */
+if (!initdata)
+ initdata = LoaderSymbol(MODULE_DATA_NAME);
+
if (initdata) {
ModuleSetupProc setup;
ModuleTearDownProc teardown;
CVS GLX oddity
I can't get CVS to load NVIDIA's GLX module. It complains: (II) Loading /usr/X11R6/lib/modules/extensions/libglx.so (EE) LoadModule: Module glx does not have a glxModuleData data object. (II) UnloadModule: "glx" Did something change with regards to this? It was working before I updated. Mark. ___ Devel mailing list Devel@XFree86.Org http://XFree86.Org/mailman/listinfo/devel
