Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-31 Thread Egbert Eich
Alan Hourihane writes:
  Well, if someone else has a chip, or wants to update and test other
  drivers (but be careful with DRI enabled drivers as it needs more work
  in the driver). Here's a patch to the neomagic that should work, and
  could be used as a template for the other drivers.
  
  That's all. Most Xv (if not all) use linear allocation already and will
  take advantage of it straight away without any furthur modifications.
  
  
  Index: neo_driver.c
  ===
  RCS file: 
  /X11R6/x-cvs/xc/programs/Xserver/hw/xfree86/drivers/neomagic/neo_driver.c,v
  retrieving revision 1.71
  diff -u -r1.71 neo_driver.c
  --- neo_driver.c 24 Sep 2003 03:16:55 -  1.71
  +++ neo_driver.c 30 Oct 2003 10:05:04 -
  @@ -1685,11 +1685,20 @@
   AvailFBArea.y1 = 0;



I'm not sure if this will solve the problems we see on neomagic.
I will take a look at it but I won't be able to do this in time for
4.4.


Egbert.
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
On Thu, Oct 30, 2003 at 10:07:13AM +, Alan Hourihane wrote:
 On Thu, Oct 30, 2003 at 08:09:05AM +, Andrew C Aitchison wrote:
  On Wed, 29 Oct 2003, Alan Hourihane wrote:
  
   On Wed, Oct 29, 2003 at 12:26:45PM -0800, Alex Deucher wrote:
As I recall we had problems with allocating additional memory for Xv on
neomagic chips (hence the overly_mem option).  As I recall there was an
issue with allocating memory beyond the limits of the blitter, similar
to the problems with Xv on via (bug 525).  Could this issue be resolved
with Alan H's new linear allocator?
   
   From looking at the driver. Yes it can. But I don't have a neomagic
   chipset to test.
  
  I have a chipset, if someone can can give me pointers to what to look at.
  
  I wont be able to look for a week or two, since the hard disk on the 
  laptop has died, and needs to be replaced.
 
 Well, if someone else has a chip, or wants to update and test other
 drivers (but be careful with DRI enabled drivers as it needs more work
 in the driver). Here's a patch to the neomagic that should work, and
 could be used as a template for the other drivers.
 
 That's all. Most Xv (if not all) use linear allocation already and will
 take advantage of it straight away without any furthur modifications.

Actually,

Due to the neomagic driver having different use of NeoFbMapSize, here's
a new followup.

Alan.

Index: neo_driver.c
===
RCS file: /X11R6/x-cvs/xc/programs/Xserver/hw/xfree86/drivers/neomagic/neo_driver.c,v
retrieving revision 1.71
diff -u -r1.71 neo_driver.c
--- neo_driver.c24 Sep 2003 03:16:55 -  1.71
+++ neo_driver.c30 Oct 2003 11:05:23 -
@@ -1685,11 +1685,21 @@
AvailFBArea.y1 = 0;
AvailFBArea.x2 = pScrn-displayWidth;
AvailFBArea.y2 = lines;
-   xf86InitFBManager(pScreen, AvailFBArea); 
-   
-   xf86DrvMsg(pScrn-scrnIndex, X_INFO, 
-  Using %i scanlines of offscreen memory \n,
+   if (xf86InitFBManager(pScreen, AvailFBArea)) {
+   int cpp = pScrn-bitsPerPixel / 8;
+   int area = lines * pScrn-displayWidth;
+   int areaoffset = area * cpp;
+   int totalmapsize = (pScrn-videoRam * 1024);
+
+   xf86DrvMsg(pScrn-scrnIndex, X_INFO, 
+  Using %i scanlines of offscreen memory for area's \n,
   lines - pScrn-virtualY);
+
+   if ( xf86InitFBManagerLinear(pScreen, area, (totalmapsize - area))) {
+   xf86DrvMsg(scrnIndex, X_INFO, 
+   Using the rest of offscreen memory for linear 
(offset=0x%x,size=%3.1fMB)\n, areaoffset, (float)(totalmapsize - 
(areaoffset/(1024*1024;
+   }
+   }
}
 
/* Setup the acceleration primitives */
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
On Thu, Oct 30, 2003 at 11:06:45AM +, Alan Hourihane wrote:
 On Thu, Oct 30, 2003 at 10:07:13AM +, Alan Hourihane wrote:
  On Thu, Oct 30, 2003 at 08:09:05AM +, Andrew C Aitchison wrote:
   On Wed, 29 Oct 2003, Alan Hourihane wrote:
   
On Wed, Oct 29, 2003 at 12:26:45PM -0800, Alex Deucher wrote:
 As I recall we had problems with allocating additional memory for Xv on
 neomagic chips (hence the overly_mem option).  As I recall there was an
 issue with allocating memory beyond the limits of the blitter, similar
 to the problems with Xv on via (bug 525).  Could this issue be resolved
 with Alan H's new linear allocator?

From looking at the driver. Yes it can. But I don't have a neomagic
chipset to test.
   
   I have a chipset, if someone can can give me pointers to what to look at.
   
   I wont be able to look for a week or two, since the hard disk on the 
   laptop has died, and needs to be replaced.
  
  Well, if someone else has a chip, or wants to update and test other
  drivers (but be careful with DRI enabled drivers as it needs more work
  in the driver). Here's a patch to the neomagic that should work, and
  could be used as a template for the other drivers.
  
  That's all. Most Xv (if not all) use linear allocation already and will
  take advantage of it straight away without any furthur modifications.
 
 Actually,
 
 Due to the neomagic driver having different use of NeoFbMapSize, here's
 a new followup.

Sorry, another followup for Andrew really.

The hardware cursor code should be made to use the linear allocator too,
and the overlay_mem code could be removed.

Alan.
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
Andrew,

I've just committed a patch to the trident driver to enable it.

Best use that as the basis for the neomagic work.

Alan.
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Billy Biggs
Alan Hourihane ([EMAIL PROTECTED]):

 Well, if someone else has a chip, or wants to update and test other
 drivers (but be careful with DRI enabled drivers as it needs more work
 in the driver). Here's a patch to the neomagic that should work, and
 could be used as a template for the other drivers.
 
 That's all. Most Xv (if not all) use linear allocation already and will
 take advantage of it straight away without any furthur modifications.

  Alan, do you know if it would help with the Radeon driver, re bug 830?

  http://bugs.xfree86.org/show_bug.cgi?id=830

  -Billy

___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
On Thu, Oct 30, 2003 at 07:47:06AM -0600, Billy Biggs wrote:
 Alan Hourihane ([EMAIL PROTECTED]):
 
  Well, if someone else has a chip, or wants to update and test other
  drivers (but be careful with DRI enabled drivers as it needs more work
  in the driver). Here's a patch to the neomagic that should work, and
  could be used as a template for the other drivers.
  
  That's all. Most Xv (if not all) use linear allocation already and will
  take advantage of it straight away without any furthur modifications.
 
   Alan, do you know if it would help with the Radeon driver, re bug 830?
 
   http://bugs.xfree86.org/show_bug.cgi?id=830

Potentially - yes. But the DRI parts need a little more work to play
nicely with the Linear allocator.

Alan.
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alex Deucher
I'll take a look at fixing this in the radeon driver.  What needs to be
done to play nice with the DRI?

Alex

--- Alan Hourihane [EMAIL PROTECTED] wrote:
 On Thu, Oct 30, 2003 at 07:47:06AM -0600, Billy Biggs wrote:
  Alan Hourihane ([EMAIL PROTECTED]):
  
   Well, if someone else has a chip, or wants to update and test
 other
   drivers (but be careful with DRI enabled drivers as it needs more
 work
   in the driver). Here's a patch to the neomagic that should work,
 and
   could be used as a template for the other drivers.
   
   That's all. Most Xv (if not all) use linear allocation already
 and will
   take advantage of it straight away without any furthur
 modifications.
  
Alan, do you know if it would help with the Radeon driver, re bug
 830?
  
http://bugs.xfree86.org/show_bug.cgi?id=830
 
 Potentially - yes. But the DRI parts need a little more work to play
 nicely with the Linear allocator.
 
 Alan.


__
Do you Yahoo!?
Exclusive Video Premiere - Britney Spears
http://launch.yahoo.com/promos/britneyspears/
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
I've actually already done it, but I'll probably leave it till after
XFree86 4.4.0.

Once 4.4.0 is out, I'll merge that into the DRI CVS and create a branch
for this work I've been doing on the radeon with regard to dynamic
allocation  the DRI.

Alan.

On Thu, Oct 30, 2003 at 07:36:42AM -0800, Alex Deucher wrote:
 I'll take a look at fixing this in the radeon driver.  What needs to be
 done to play nice with the DRI?
 
 Alex
 
 --- Alan Hourihane [EMAIL PROTECTED] wrote:
  On Thu, Oct 30, 2003 at 07:47:06AM -0600, Billy Biggs wrote:
   Alan Hourihane ([EMAIL PROTECTED]):
   
Well, if someone else has a chip, or wants to update and test
  other
drivers (but be careful with DRI enabled drivers as it needs more
  work
in the driver). Here's a patch to the neomagic that should work,
  and
could be used as a template for the other drivers.

That's all. Most Xv (if not all) use linear allocation already
  and will
take advantage of it straight away without any furthur
  modifications.
   
 Alan, do you know if it would help with the Radeon driver, re bug
  830?
   
 http://bugs.xfree86.org/show_bug.cgi?id=830
  
  Potentially - yes. But the DRI parts need a little more work to play
  nicely with the Linear allocator.
  
  Alan.
 
 
 __
 Do you Yahoo!?
 Exclusive Video Premiere - Britney Spears
 http://launch.yahoo.com/promos/britneyspears/
 ___
 Devel mailing list
 [EMAIL PROTECTED]
 http://XFree86.Org/mailman/listinfo/devel
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Billy Biggs
Alan Hourihane ([EMAIL PROTECTED]):

 I've actually already done it, but I'll probably leave it till after
 XFree86 4.4.0.

  Regarding bug 830, does this mean my users can expect to sometimes hit
these situations where XVIDEO apps can't run until they shut down a
large application like their web browser?

  Don't take this the wrong way, I don't mind, I just want to understand
the situation so I can design appropriate error messages.

  -Billy

 Once 4.4.0 is out, I'll merge that into the DRI CVS and create a branch
 for this work I've been doing on the radeon with regard to dynamic
 allocation  the DRI.
 
 Alan.
 
 On Thu, Oct 30, 2003 at 07:36:42AM -0800, Alex Deucher wrote:
  I'll take a look at fixing this in the radeon driver.  What needs to be
  done to play nice with the DRI?
  
  Alex
  
  --- Alan Hourihane [EMAIL PROTECTED] wrote:
   On Thu, Oct 30, 2003 at 07:47:06AM -0600, Billy Biggs wrote:
Alan Hourihane ([EMAIL PROTECTED]):

 Well, if someone else has a chip, or wants to update and test
   other
 drivers (but be careful with DRI enabled drivers as it needs more
   work
 in the driver). Here's a patch to the neomagic that should work,
   and
 could be used as a template for the other drivers.
 
 That's all. Most Xv (if not all) use linear allocation already
   and will
 take advantage of it straight away without any furthur
   modifications.

  Alan, do you know if it would help with the Radeon driver, re bug
   830?

  http://bugs.xfree86.org/show_bug.cgi?id=830
   
   Potentially - yes. But the DRI parts need a little more work to play
   nicely with the Linear allocator.
   
   Alan.
  
  
  __
  Do you Yahoo!?
  Exclusive Video Premiere - Britney Spears
  http://launch.yahoo.com/promos/britneyspears/
  ___
  Devel mailing list
  [EMAIL PROTECTED]
  http://XFree86.Org/mailman/listinfo/devel
 ___
 Devel mailing list
 [EMAIL PROTECTED]
 http://XFree86.Org/mailman/listinfo/devel
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel


Re: Linear Allocator (Was Re: Alan H's new linear allocator and Neomagic Xv)

2003-10-30 Thread Alan Hourihane
On Thu, Oct 30, 2003 at 10:59:41AM -0600, Billy Biggs wrote:
 Alan Hourihane ([EMAIL PROTECTED]):
 
  I've actually already done it, but I'll probably leave it till after
  XFree86 4.4.0.
 
   Regarding bug 830, does this mean my users can expect to sometimes hit
 these situations where XVIDEO apps can't run until they shut down a
 large application like their web browser?
 
   Don't take this the wrong way, I don't mind, I just want to understand
 the situation so I can design appropriate error messages.

Low memory situations should only happen when a 3D application is
also running. I'm not sure why you'd be hitting it when it's not.

Alan.
___
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel