Re: [developer] propose update for sys/types.h
On Thu, 5 Oct 2017 07:42:21 -0700, Robert Mustacchi wrote: On 10/5/17 7:29 , Gordon Ross wrote: I don't think you can "just add those" without breaking some namespace pollution rules (i.e. XPG etc.) I'm not sure what the right #ifdef guard would be, but I'm pretty sure it would need one. This would require: #if !defined(_STRICT_SYMBOLS) ... #endif But those aren't really symbols. I wonder what namespace pollution we are talking about here? On Sun, Oct 1, 2017 at 12:25 PM, Igor Kozhukhovwrote: Hi All, i’d like proposed try to update sys/typs.h by changes what are available in FreeBSD for better portality: igor@z172:~/users/igor/dilos-illumos$ g diff diff --git a/usr/src/uts/common/sys/types.h b/usr/src/uts/common/sys/types.h index dcb2c86283..a2e37263b8 100644 --- a/usr/src/uts/common/sys/types.h +++ b/usr/src/uts/common/sys/types.h @@ -58,6 +58,11 @@ #include #endif +typedef uint8_tu_int8_t; /* unsigned integrals (deprecated) */ +typedef uint16_t u_int16_t; +typedef uint32_t u_int32_t; +typedef uint64_t u_int64_t; + #ifdef __cplusplus extern "C" { #endif i have found several userland apps what are needs where changes and I understand - they are deprocated, but it can helps and reduce additional patches in userland apps with portability and builds based on illumos env. If you are agreed - i can file a bug for it. -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T0cc9a914d001ea54-Mbc684ec12d0c443add201848 Powered by Topicbox: https://topicbox.com
Re: [developer] propose update for sys/types.h
I don't think you can "just add those" without breaking some namespace pollution rules (i.e. XPG etc.) I'm not sure what the right #ifdef guard would be, but I'm pretty sure it would need one. On Sun, Oct 1, 2017 at 12:25 PM, Igor Kozhukhovwrote: > Hi All, > > i’d like proposed try to update sys/typs.h by changes what are available in > FreeBSD for better portality: > > igor@z172:~/users/igor/dilos-illumos$ g diff > diff --git a/usr/src/uts/common/sys/types.h b/usr/src/uts/common/sys/types.h > index dcb2c86283..a2e37263b8 100644 > --- a/usr/src/uts/common/sys/types.h > +++ b/usr/src/uts/common/sys/types.h > @@ -58,6 +58,11 @@ > #include > #endif > > > > +typedef uint8_tu_int8_t; /* unsigned integrals > (deprecated) */ > +typedef uint16_t u_int16_t; > +typedef uint32_t u_int32_t; > +typedef uint64_t u_int64_t; > + > #ifdef __cplusplus > extern "C" { > #endif > > > > i have found several userland apps what are needs where changes and I > understand - they are deprocated, but it can helps and reduce additional > patches in userland apps with portability and builds based on illumos env. > > If you are agreed - i can file a bug for it. > > best regards, > -Igor > > openzfs-developer | Archives | Powered by Topicbox -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T0cc9a914d001ea54-M2e955b705f75b539397a32a2 Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)
sorry to report that send/receive (see Aug. 18th/19th) still crashes when testing with more than 10GB of data: panic[cpu1]/thread=ff000faf4c40: BAD TRAP: type=e (#pf Page fault) rp=ff000faf4870 addr=68 occurred in module "zfs" due to a NULL pointer dereference sched: #pf Page fault Bad kernel fault at addr=0x68 pid=0, pc=0xf7d49176, sp=0xff000faf4960, eflags=0x10202 cr0: 8005003bcr4: 6f8 cr2: 68 cr3: 1dc0 cr8: c rdi: 68 rsi: ff03dde12120 rdx: ff000faf4c40 rcx:d r8: ff03db3662a0 r9:0 rax:0 rbx: ff03dde12120 rbp: ff000faf4970 r10: fb858740 r11: fb800983 r12:0 r13: c001af00 r14: c001e890 r15: ff03dde12120 fsb:0 gsb: ff03c9b89080 ds: 4b es: 4b fs:0 gs: 1c3 trp:e err:0 rip: f7d49176 cs: 30 rfl:10202 rsp: ff000faf4960 ss: 38 ff000faf4750 unix:real_mode_stop_cpu_stage2_end+b21c () ff000faf4860 unix:trap+e08 () ff000faf4870 unix:_cmntrap+e6 () ff000faf4970 zfs:arc_buf_remove+16 () ff000faf49b0 zfs:arc_buf_destroy_impl+bd () ff000faf4a10 zfs:arc_evict_hdr+b3 () ff000faf4aa0 zfs:arc_evict_state_impl+154 () ff000faf4b40 zfs:arc_evict_state+12e () ff000faf4b70 zfs:arc_adjust_impl+44 () ff000faf4ba0 zfs:arc_adjust+d9 () ff000faf4c20 zfs:arc_reclaim_thread+ae () ff000faf4c30 unix:thread_start+8 () -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-334371066 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Ta17fb0edb29e7895-Mcf62774af91f4436a8fac9ff Powered by Topicbox: https://topicbox.com