[developer] Re: [openzfs/openzfs] Merge remote-tracking branch 'illumos/master' into illumos-sync (#621)
Merged #621. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/621#event-1574214232 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T8fb394c1a93a5d8c-M0fac8e488499b7ed9ec28dbc Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] Merge remote-tracking branch 'illumos/master' into illumos-sync (#621)
prakashsurya approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/621#pullrequestreview-112170242 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T8fb394c1a93a5d8c-M04e8a5519256f3e5d59729a6 Delivery options: https://openzfs.topicbox.com/groups
[developer] [openzfs/openzfs] Merge remote-tracking branch 'illumos/master' into illumos-sync (#621)
You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/621 -- Commit Summary -- * 9231 nightly should create a log/latest/ symlink * 9206 Move getsecs() prototype to stand.h from net.h so it can be used everywhere * 9106 praudit could go faster * 9179 gss_mechs/mech_krb5 this use of "defined" may not be portable * 9144 libsqlite: this statement may fall through * 9213 zfs: sytem typo * 9214 typo: sytem should be system * 9198 libstand: Const-ify buffer argument of write(2) analog * 9228 zone_getattr(ZONE_ATTR_NETWORK) returns uninitialised value * 9226 fd: this statement may fall through * 9216 awk: this statement may fall through * 8659 ata: unused but set warnings with GCC 5.X * 9121 dladm: addrval can be NULL, need to check in iptun_process_addrarg() * 9146 libdtrace: this statement may fall through * 9174 smbsrv/libsmbns: duplicate 'const' declaration specifier * 9175 smbsrv/libfksmbsrv: this statement may fall through * 9251 p123_pcbe is useless and can be removed * 9164 assert: newds == os->os_dsl_dataset * 9166 zfs storage pool checkpoint * 9260 nsmb driver 32-bit ioctl check broken after 8685 * 9173 smbsrv: we do not build all * 8980 BIOS clock is sometimes one hour fast * 8808 nvme: Software Progress Marker feature is optional * 5404 smbfs needs mmap support * 9076 ZFS Performance test concurrency should be lowered for better latency * 9187 racing condition between vdev label and spa_last_synced_txg in vdev_validate * 9190 Fix cleanup routine in import_cachefile_device_replaced.ksh * 9191 dump vdev tree to zfs_dbgmsg when spa load fails due to missing log devices * 9235 rename zpool_rewind_policy_t to zpool_load_policy_t * 9193 bootcfg -C doesn't work * 9317 FMD crashes with zero-length allocation * 9321 arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value * 9188 increase size of dbuf cache to reduce indirect block decompression * 9322 Print stats since boot for first line of arcstat.pl * 9280 Assertion failure while running removal_with_ganging test with 4K devices * 9284 arc_reclaim_thread has 2 jobs * 9189 Add debug to vdev_label_read_config when txg check fails * 8758 loader: boot1.efi needs versioning * 9269 uts/i86pc: rootnex comparison between pointer and zero character constant * 9292 snoop: this statement may fall through * 9294 ipqosconf: comparison between pointer and zero character constant * 9295 ifconfig: this statement may fall through * 9296 ipsecutils: this statement may fall through * 9297 in.telnetd: comparison between pointer and zero character constant * 9298 inetadm: this statement may fall through * 9299 ilbd: comparison between pointer and zero character constant * 9300 in.mpathd: this statement may fall through * 9302 dhcpagent: this statement may fall through * 9303 chat: this statement may fall through * 9304 ftp: this statement may fall through * 9310 smbstat: this statement may fall through * 9311 ufs/mount: comparison between pointer and zero character constant * 9315 ldap: this statement may fall through * 9313 cmd/fs.d: this statement may fall through * 9316 ldap: comparison between pointer and zero character constant * 9336 addr::conn_status crashes mdb * 9067 Support PMBR customisation with EFI label * 8699 Want NIC transceiver visibility (fix sparc build) * 9142 libxcurses: comparison between pointer and zero character constant * 9131 regexp.h: this statement may fall through * 9240 nxge: this statement may fall through * 9263 rdc: comparison between pointer and zero character constant * 9343 ib: comparison between pointer and zero character constant * 9347 c2audit: comparison between pointer and zero character constant * 9348 mii: duplicate 'const' declaration specifier * 9349 dnet: this statement may fall through * 9306 pppd: this use of "defined" may not be portable * 9305 pppdump: this statement may fall through * 9307 rdist: this statement may fall through * 9308 mdnsd: this statement may fall through * 9181 ipf: this use of "defined" may not be portable * 9301 nvme: Package description out of date * 9286 want refreservation=auto * 9238 ZFS Spacemap Encoding V2 * 9350 ypcmd: this statement may fall through * 1575 untangle libmlrpc from SMB server * 3328 smbutil view does't work with Win2008 and later * 9112 Improve allocation performance on high-end systems * 9044 Need support for mpt_sas tri-mode parts * 9352 netstat(1M) should be able to print IPv4 networks in CIDR form * 9359 uts: audio this statement may fall through * 9360 pam_modules/tsol_acct: comparison between pointer and zero character constant * 9363 savecore: this statement may fall through * 9368 tsol: this statement may fall through * 9369 tr: this statement may fall through * 9371 poolstat: this statement may fall through * 9372 tcpd: this
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I I believe I've fixed the CI failure. Can you rebase onto the latest master to pick up the fix and trigger a new build/test run? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381238379 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mf9ca669fea300782e822c318 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] Merge remote-tracking branch 'illumos/master' into illumos-sync (#594)
Closed #594. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/594#event-1573939985 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/Tbcd0ef93d93382dc-Mfdd4688041f3de124b6af405 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] Update AMI to OpenIndiana Hipster 2018.04.13 (#620)
Closed #620 via 7db3b2a0c5c300fdcffea11bfa0e5a71926ecaa6. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/620#event-1573936909 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T8e87c167d584f30c-Mb00fd4d7b39efd17e19ef687 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
sdimitro commented on this pull request. > +# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE +# or http://www.opensolaris.org/os/licensing. +# See the License for the specific language governing permissions +# and limitations under the License. +# +# When distributing Covered Code, usr/src/common/zfs this CDDL HEADER in each +# file and usr/src/common/zfs the License file at usr/src/OPENSOLARIS.LICENSE. +# If applicable, add the following below this CDDL HEADER, with the +# fields enclosed by brackets "[]" replaced with your own identifying +# information: Portions Copyright [] [name of copyright owner] +# +# CDDL HEADER END +# + +# +# Copyright 2007 Sun Microsystems, Inc. All rights reserved. Yeah you are right, it seems like they were wrong from the ZoL review (should have been `...2018 Datto..` instead of `...2007 Sun..`. At this point, I wouldn't worry about it :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/619#discussion_r181476307 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-M6c0bbb76ceb1c755c8a9aafe Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
sdimitro commented on this pull request.
> +# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source. A copy is of the CDDL is also available via the Internet
+# at http://www.illumos.org/license/CDDL.
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright (c) 2018 Datto Inc.
+#
+
+. $STF_SUITE/usr/src/common/zfs/libtest.shlib
I'm sorry, my mistake. I meant the new `cleanup.ksh` and `setup.ksh` have the
same issue (should be `. $STF_SUITE/include/libtest.shlib` instead of
`$STF_SUITE/usr/src/common/zfs/libtest.shlib`) - not Makefiles.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/619#discussion_r181475688
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-Mf63dcfa23223d944774524d1
Delivery options: https://openzfs.topicbox.com/groups
[developer] [openzfs/openzfs] Update AMI to OpenIndiana Hipster 2018.04.13 (#620)
You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/620 -- Commit Summary -- * Update AMI to OpenIndiana Hipster 2018.04.13 -- File Changes -- M Jenkinsfile (2) M jenkins/pipelines/miscellaneous.groovy (2) -- Patch Links -- https://github.com/openzfs/openzfs/pull/620.patch https://github.com/openzfs/openzfs/pull/620.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/620 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T8e87c167d584f30c-M1f741886deedf81e084486a5 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
alek-p commented on this pull request. > +# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE +# or http://www.opensolaris.org/os/licensing. +# See the License for the specific language governing permissions +# and limitations under the License. +# +# When distributing Covered Code, usr/src/common/zfs this CDDL HEADER in each +# file and usr/src/common/zfs the License file at usr/src/OPENSOLARIS.LICENSE. +# If applicable, add the following below this CDDL HEADER, with the +# fields enclosed by brackets "[]" replaced with your own identifying +# information: Portions Copyright [] [name of copyright owner] +# +# CDDL HEADER END +# + +# +# Copyright 2007 Sun Microsystems, Inc. All rights reserved. no, I didn't touch the contents of the file so didn't need to update the copyright -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/619#discussion_r181470170 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-M6e9380cb423419710db27ccf Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
alek-p commented on this pull request. > +# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE +# or http://www.opensolaris.org/os/licensing. +# See the License for the specific language governing permissions +# and limitations under the License. +# +# When distributing Covered Code, usr/src/common/zfs this CDDL HEADER in each +# file and usr/src/common/zfs the License file at usr/src/OPENSOLARIS.LICENSE. +# If applicable, add the following below this CDDL HEADER, with the +# fields enclosed by brackets "[]" replaced with your own identifying +# information: Portions Copyright [] [name of copyright owner] +# +# CDDL HEADER END +# + +# +# Copyright 2007 Sun Microsystems, Inc. All rights reserved. no, I didn't touch the contents of the file so didn't need to update the copyright -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/619#discussion_r181470141 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-M3305787f8ed001a09db4c7be Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
alek-p commented on this pull request.
> +# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source. A copy is of the CDDL is also available via the Internet
+# at http://www.illumos.org/license/CDDL.
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright (c) 2018 Datto Inc.
+#
+
+. $STF_SUITE/usr/src/common/zfs/libtest.shlib
fixed this in the test but not sure which Makefile you were talking about
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/619#discussion_r181469923
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-Mc3c9953118d9cd790da46dce
Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9464 txg_kick() fails to see that we are quiescing, forcing transacti… (#616)
@avg-I I've updated the description to add the legend. (and yes, it is https://github.com/ahrens/dtrace/blob/master/txg.xd) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/616#issuecomment-381176864 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T482138142f6adde1-M8fc5bf19c9c18f011ea73e2e Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
sdimitro approved this pull request.
Can you add an entry in `usr/src/pkg/manifests/system-test-zfstest.mf` for the
new test that you added?
Things look good to me overall since I've had a sneak peek of the ZoL review.
I'd have @jwk404 take a look at the new test case though just in case.
> +# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
+# or http://www.opensolaris.org/os/licensing.
+# See the License for the specific language governing permissions
+# and limitations under the License.
+#
+# When distributing Covered Code, usr/src/common/zfs this CDDL HEADER in each
+# file and usr/src/common/zfs the License file at usr/src/OPENSOLARIS.LICENSE.
+# If applicable, add the following below this CDDL HEADER, with the
+# fields enclosed by brackets "[]" replaced with your own identifying
+# information: Portions Copyright [] [name of copyright owner]
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright 2007 Sun Microsystems, Inc. All rights reserved.
Copy paste error?
> +# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
+# or http://www.opensolaris.org/os/licensing.
+# See the License for the specific language governing permissions
+# and limitations under the License.
+#
+# When distributing Covered Code, usr/src/common/zfs this CDDL HEADER in each
+# file and usr/src/common/zfs the License file at usr/src/OPENSOLARIS.LICENSE.
+# If applicable, add the following below this CDDL HEADER, with the
+# fields enclosed by brackets "[]" replaced with your own identifying
+# information: Portions Copyright [] [name of copyright owner]
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright 2007 Sun Microsystems, Inc. All rights reserved.
Copy-paste error?
> +# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source. A copy is of the CDDL is also available via the Internet
+# at http://www.illumos.org/license/CDDL.
+#
+# CDDL HEADER END
+#
+
+#
+# Copyright (c) 2018 Datto Inc.
+#
+
+. $STF_SUITE/usr/src/common/zfs/libtest.shlib
why `$STF_SUITE/usr/src/common/zfs/libtest.shlib`?
and not `. $STF_SUITE/include/libtest.shlib`?
I saw your makefiles doing that too. Could you maybe change the Makefiles and
the include in that file to be consistent with the rest of the stuff under
`cli_root`?
> +"{
+\"return\": {
+\"failed\": {},
+\"succeeded\": {
+\"$TESTDS\": \"filesystem\"
+}
+}
+}")
+typeset -i cnt=0
+typeset usr/src/cmd
+for usr/src/cmd in ${pos_usr/src/cmds[@]}; do
+ log_must zfs program $TESTPOOL $TESTZCP $TESTDS $usr/src/cmd 2>&1
+ log_must zfs program $TESTPOOL -j $TESTZCP $TESTDS $usr/src/cmd 2>&1
+ # json.tool is needed to guarantee consistent ordering of fields
+ # sed is needed to trim trailing space in CentOS 6's json.tool output
+ OUTPUT=$(zfs program $TESTPOOL -j $TESTZCP $TESTDS $usr/src/cmd 2>&1 |
python -m json.tool | sed 's/[[:space:]]*$//')
[nit] Not sure if we do style checks for shell scripts too but can you maybe
wrap this line?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/619#pullrequestreview-112048253
--
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-Mf71c8e37ec32e2b89c1f82d0
Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9464 txg_kick() fails to see that we are quiescing, forcing transacti… (#616)
@avg-I here is the txg.d that I used: https://gist.github.com/sdimitro/23ed816690faa412ddf0b00ae9cd49e8 and here is another ad hoc dtrace script that I make for dynamically tracing txg_kick(): https://gist.github.com/sdimitro/4eac9894d4a109ad5774d0e3b07f20a0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/616#issuecomment-381162803 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T482138142f6adde1-M6d738b0b46083f9a4dc5a306 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9464 txg_kick() fails to see that we are quiescing, forcing transacti… (#616)
@avg-I I would presume it's either https://github.com/ahrens/dtrace/blob/master/txg.xd or some later iteration thereof. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/616#issuecomment-381095726 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T482138142f6adde1-Md86ea0167b8fe172582a68cd Delivery options: https://openzfs.topicbox.com/groups
