[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)

2018-05-16 Thread Richard Elling
richardelling commented on this pull request.



> @@ -0,0 +1,30 @@
+#!/bin/ksh -p
+#
+# CDDL HEADER START
+#
+# The contents of this file are subject to the terms of the
+# Common Development and Distribution License (the "License").
+# You may not use this file except in compliance with the License.
+#
+# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
+# or http://www.opensolaris.org/os/licensing.

nit: but while we're copying... opensolaris.org is long gone. This is a better 
URL:
https://opensource.org/licenses/CDDL-1.0


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/619#pullrequestreview-120817324
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-M89cef064143e9a6809261ec0
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

2018-05-16 Thread Prakash Surya
Thanks @yuripv, no worries! Sorry for the noise. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#issuecomment-389658953
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-M0a87b3534592a57a807629aa
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

2018-05-16 Thread Yuri Pankov
I'm sorry this didn't work out, but it really looks like a 
distribution-specific configuration issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#issuecomment-389646880
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-M91dff22f662e3ac97691627e
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)

2018-05-16 Thread Matthew Ahrens
ahrens approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/619#pullrequestreview-120752037
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T0465226805877059-M1559a236d170caeb22943d6d
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

2018-05-16 Thread Prakash Surya
Based on the discussion between @yuripv @ikozhukhov and @jwk404, I'm going to 
close this out. It sounds like it's not worth pushing this change outside of 
Delphix.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#issuecomment-389605390
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-M53e4bab57d4ee21381eea3e7
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

2018-05-16 Thread Prakash Surya
Closed #571.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/571#event-1630204035
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Ta01e586f3e29f982-Mf63413ad067ead717ad2
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-16 Thread Igor K
@lundman i hope it can be integrated before next year anniversary :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/489#issuecomment-389523909
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Te9a3d86d2367f775-M0e0f148bbba006e0b4caf23f
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-05-16 Thread Jorgen Lundman
latest rebase was non-trivial due to the parallel mount commit. I had to guess 
a bit. But good news, we are coming up to 2 year anniversary! \o/


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/489#issuecomment-389409212
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/Te9a3d86d2367f775-M7032b2a51e6e3378e083f5bb
Delivery options: https://openzfs.topicbox.com/groups