[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I pushed 1 commit. d1cd233 ashift seems to be a valid pool property in ZoL but not here -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/600/files/dc11cd3b27dcd485b3b4d2ea7d531f0344980723..d1cd233636baebab0580e567b7e6fd168d5a -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T15f12678e376235c-M8402ff99e81f284e5700bfea Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I pushed 1 commit. 2d827de perhaps ZoL allows to specify pool name before options but we do not -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/600/files/fd1817c5b4c6b558592ad6f39331984387104404..2d827de153892fda4ca5c768584253ee04f32a00 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M4599d9a37ba3ed4a4cd2dba9 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
zpool_create_tempname failure is obvious and I am pushing a fix. It seems that ZoL allows placing a pool name on zpool create command line before options. E.g., zpool create newpool -o xxx ... import_rewind_device_replaced is not obvious and I am not sure if it's related to this merge request. Some details: ``` 19:08:59.94 SUCCESS: wait_for_pool_config testpool1 /dev_import-test/disk0 /dev_import-test/disk2 19:09:00.32 SUCCESS: zpool export testpool1 19:09:00.32 SUCCESS: mv /dev_import-test/disk2 /dev_import-test/backup/ 19:09:01.20 ERROR: zpool import -d /dev_import-test -T 52 testpool1 exited 1 19:09:01.20 cannot import 'testpool1': one or more devices is currently unavailable ``` >From zfs_dbgmsg log: ``` 19:09:01.94 spa_tryimport: importing testpool1, max_txg=52 19:09:01.94 spa_load($import, config trusted): LOADING 19:09:01.94 file vdev '/dev_import-test/disk0': best uberblock found for spa $import. txg 50 19:09:01.94 file vdev '/dev_import-test/disk0': label discarded as txg is too large (101 > 50) 19:09:01.94 file vdev '/dev_import-test/disk0': failed to read label config. Trying again without txg restrictions. 19:09:01.94 spa_load($import, config untrusted): using uberblock with txg=50 19:09:01.94 spa_load($import, config untrusted): FAILED: unable to open rootbp in dsl_pool_init [error=5] 19:09:01.94 spa_load($import, config untrusted): UNLOADING 19:09:01.94 spa_import: importing testpool1, max_txg=52 (RECOVERY MODE) 19:09:01.94 spa_load(testpool1, config trusted): LOADING 19:09:01.94 file vdev '/dev_import-test/disk0': best uberblock found for spa testpool1. txg 50 19:09:01.94 file vdev '/dev_import-test/disk0': label discarded as txg is too large (101 > 50) 19:09:01.94 file vdev '/dev_import-test/disk0': failed to read label config. Trying again without txg restrictions. 19:09:01.94 spa_load(testpool1, config untrusted): using uberblock with txg=50 19:09:01.94 spa_load(testpool1, config untrusted): FAILED: unable to open rootbp in dsl_pool_init [error=5] 19:09:01.94 spa_load(testpool1, config untrusted): UNLOADING 19:09:01.94 spa_load(testpool1, config untrusted): spa_load_retry: rewind, max txg: 49 ... 19:09:01.94 spa_load(testpool1, config untrusted): spa_load_retry: rewind, max txg: 46 ... 19:09:01.94 spa_load(testpool1, config untrusted): spa_load_retry: rewind, max txg: 43 ... ... 19:09:01.94 spa_load(testpool1, config untrusted): spa_load_retry: rewind, max txg: 4 19:09:01.94 spa_load(testpool1, config untrusted): LOADING 19:09:01.94 file vdev '/dev_import-test/disk0': best uberblock found for spa testpool1. txg 4 19:09:01.94 file vdev '/dev_import-test/disk0': label discarded as txg is too large (101 > 4) 19:09:01.94 file vdev '/dev_import-test/disk0': failed to read label config. Trying again without txg restrictions. 19:09:01.94 spa_load(testpool1, config untrusted): using uberblock with txg=4 19:09:01.94 spa_load(testpool1, config untrusted): FAILED: unable to open rootbp in dsl_pool_init [error=5] 19:09:01.94 spa_load(testpool1, config untrusted): UNLOADING 19:09:01.94 spa_load(testpool1, config untrusted): spa_load_retry: rewind, max txg: 3 19:09:01.94 spa_load(testpool1, config untrusted): LOADING 19:09:01.94 spa_load(testpool1, config untrusted): FAILED: no valid uberblock found 19:09:01.94 spa_load(testpool1, config untrusted): UNLOADING ``` Direct link to the log file [40MB]: http://jenkins.open-zfs.org/job/openzfs/job/openzfs/job/PR-600/9/artifact/run-zfs-tests.log -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-389138480 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mf1333b7f35b38ff6f4d09957 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
Two test failures: ``` Tests with results other than PASS that are unexpected: FAIL cli_root/zpool_create/zpool_create_tempname (expected PASS) FAIL cli_root/zpool_import/import_rewind_device_replaced (expected PASS) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-389132635 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M82f9f01215d359147df2485a Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
Most likely yes. I will test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-387482483 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mafd5e2fe84153da8bc515740 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
Does this also need to pull in https://github.com/zfsonlinux/zfs/pull/7509 ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-387477230 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M303e6de8a344628c89f131c9 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
good idea in general: kill studio lint :) because this one eat a lot of RAM + swap :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381636138 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M63044ffcb98acbe538c10a92 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@ikozhukhov Thanks. That sounds like a good idea in general; I opened #624 to do this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381632061 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M335789f18eef4312af4c4021 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
hey - you have to move TMPDIR to another place from /tmp by: export TMPDIR=/var/tmp because /tmp=swapfs and it is depend on SWAP size. also - add more space to swap -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381628847 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M3d6b36a7998a0b1fa66e27d9 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I I kicked of another run, and started a run using our internal tests. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381626704 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M6ef31921c2b2679295482f18 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
`../port/regex/regcomp.c:1783: fatal error: error writing to /tmp/nightly.tmpdir.2594/ccLaaq0L.s: No space left on device` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381610321 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M42c479fa4176b0a6ab14ab31 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I I believe I've fixed the CI failure. Can you rebase onto the latest master to pick up the fix and trigger a new build/test run? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-381238379 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mf9ca669fea300782e822c318 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
How about adding the tests from ZoL? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-380263327 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M6c81df38303649560bcec45b Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
ahrens approved this pull request. > @@ -136,6 +136,8 @@ zpool_prop_init(void) PROP_READONLY, ZFS_TYPE_POOL, "NAME"); zprop_register_hidden(ZPOOL_PROP_MAXBLOCKSIZE, "maxblocksize", PROP_TYPE_NUMBER, PROP_READONLY, ZFS_TYPE_POOL, "MAXBLOCKSIZE"); + zprop_register_hidden(ZPOOL_PROP_TNAME, "tname", PROP_TYPE_STRING, + PROP_ONETIME, ZFS_TYPE_POOL, "TNAME"); This should really be `"tempname"` and `ZPOOL_PROP_TEMPNAME`. Unfortunately, ZoL has already set the precedent of `-o tname=`, so I guess we should stick with that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#pullrequestreview-111022346 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M456eaca8f07c43a98ae083e3 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
Yes, I’ll take a look next week. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-379260180 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mfab38815df78298be1260d0d Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I pushed 1 commit. 7806e35 address feedback from Steven Hartland -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/600/files/639a1ca0aedcdcb1931d6c837b3028539b7f9d26..7806e35fe7d016c27e03ca5693a0f7fcef067905 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mda2fdda84a094bff67e6fd70 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I pushed 1 commit. 639a1ca fix add_prop_list_default to not ignore poolprop -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/600/files/b4cd8198df7ec91fb1d45f06514689543ff20a70..639a1ca0aedcdcb1931d6c837b3028539b7f9d26 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M5cb7b4119a089d15e12dcd06 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@prakashsurya thank you for the report. Hmm, the code is this way in ZoL too. I see two ways of fixing it: 1. remove the parameter 1. pass through the parameter to `add_prop_list` instead of the currently hardcoded `B_TRUE` Both approaches should work as all callers of `add_prop_list_default` pass `B_TRUE` in `poolprop`. I guess that the second approach is more flexible, so I am leaning to it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-379197785 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-Mf4d32e0a1f41eae1277bc735 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@avg-I this is failing lint: ``` "zpool_main.c", line 494: warning: argument unused in function: poolprop in add_prop_list_default (E_FUNC_ARG_UNUSED) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-378987602 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M0cfcd012bdf5f5c43f77b5a3 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)
@prakashsurya Prakash, no problem and thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-378881501 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T900a082ade0bdbd3-M4bd17cf9b23417fea7964ff6 Delivery options: https://openzfs.topicbox.com/groups
