[Development] Namespaces (was: Qt Platform Extras)
On Sep 14, 2013, at 2:56 AM, Sze Howe Koh szehowe@gmail.com wrote: On 11 September 2013 01:07, Laszlo Papp lp...@kde.org wrote: On Tue, Sep 10, 2013 at 4:46 PM, Thiago Macieira thiago.macie...@intel.com wrote: On terça-feira, 10 de setembro de 2013 22:31:53, Sze Howe Koh wrote: On 10 September 2013 14:27, Knoll Lars lars.kn...@digia.com wrote: Ok, let's use QtWin for the namespace. For the module itself it makes IMO to keep the 'Extras' in the name. Cheers, Lars QtWin or QWin? QtWin, it's a namespace. I believe he is aware of that... I think, Sze please correct me if I am wrong, he just wanted to make sure because there was several emails last year about QFoo or QtFoo for the namespace, and it seemed that the suboptimal naming was chosen for other reasons. Laszlo is correct. Before Qt 5 was released, most public namespaces had the QFoo format -- QSsl, QDBus, QAudio, etc. A few had the QtFoo format -- QtMultimedia::MetaData (unreleased), QtMultimedia (unreleased), and QtConcurrent. I suggested making them uniform. [1] Lars said that he preferred QFoo - QtFoo, but that change was the much more intrusive one. Qt 5 was close to Beta 2 at the time, so he chose the lower-risk QtFoo - QFoo. [2] As of Qt 5.1, all public namespaces are QFoo, except Qt and QtConcurrent. Thiago blocked the latter on the basis that (i) development on that module has stopped, and (ii) QtConcurrent is quite different from all the other namespaces anyway. [3] With all that in mind, do we want QtWin or QWin? The benefit of QWin is consistency with existing conventions; the downside is having to wait till Qt 6 if we want to switch to the preferred QtFoo. QtWin has the benefit of introducing users to the preferred naming convention now (and a smaller list of namespace changes if/when the change occurs), at the cost of introducing more inconsistencies. I vote for QWin for consistency, and I'm not sure that an extra ':%s/QWin::/QtWin::/g' will make a difference to users if they're doing the same for all other namespaces in Qt 6. Consistent or not, do we want to introduce more namespaces with suboptimal names? IMHO it would be better to go for the optimal naming with new namespaces, and eventually fix the old remaining ones in Qt 6. That would give us cute names and less changes needed in the future while porting to Qt 6. One could also argue whether for example the QSsl namespace is that bad after all. The scope of that particular namespace is to provide enums for a small set of SSL classes, whereas namespaces like QtWin and QtMac are module-wide. To me it would make sense to enforce the QtFoo naming convention for such module-wide enums, but still allow QFoo style naming for targeted namespaces. -- J-P Nurmi ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Mac build fails due to qlobal.h being modified?
Hi, I'm trying to do a clean build on Mac of current dev branch, but I keep getting the error: fatal error: file '/Users/odysseus/Development/Qt/src/qt5/qtbase/src/corelib/../../include/QtCore/qglobal.h' has been modified since the precompiled header was built. Any clues on how to fix that besides passing -no-pch? Cheers! John. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Source build woes on windows
I'm trying to build 5.1.1 from source (.zip download) on Windows using MSVC2012, in a separate prefix (shadow) build. So far I've run into two issues: 1. configure.bat fails to bootstrap without .gitignore being present. Wouldn't it be better to check for presence of configure.exe? Are we only supposed to build from a git clone? If so, is there any purpose for the .zip/.tar.gz downloads? The workaround is to manually add .gitignore. Or else I'm just very confused :( 2. Having configured with -qt-zlib, prefix/qtbase/include/QtZlib is missing. In other words, the zlib headers are not copied over from the source to the build prefix. This makes the qtsvg build fail. I've looked for a file that has a list of headers to copy over during qtbase build, but couldn't find it. Any pointers? I'd like to add QtZlib there and see if it would succeed. https://bugreports.qt-project.org/browse/QTBUG-32641 seems related, but without QtZlib even being in $$[QT_INSTALL_HEADERS/get], it won't work. Thanks, Kuba ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Source build woes on windows
On segunda-feira, 16 de setembro de 2013 14:17:41, Kuba Ober wrote: I'm trying to build 5.1.1 from source (.zip download) on Windows using MSVC2012, in a separate prefix (shadow) build. So far I've run into two issues: 1. configure.bat fails to bootstrap without .gitignore being present. Wouldn't it be better to check for presence of configure.exe? Are we only supposed to build from a git clone? If so, is there any purpose for the .zip/.tar.gz downloads? The workaround is to manually add .gitignore. Or else I'm just very confused :( You're supposed to build only from a) a git clone or b) the official tarballs or .zip. Downloading a .zip file from Gitorious is not supported. The absence or presence of configure.exe is not the only issue. There's also the question whether perl is required at build time, due to the need to update the include dir. The decision was made for 5.1 that perl should not be required during builds from official tarballs, which means the code to bootstrap configure.exe and to create the include/ dir is disabled. It must be run during our package creation process. 2. Having configured with -qt-zlib, prefix/qtbase/include/QtZlib is missing. In other words, the zlib headers are not copied over from the source to the build prefix. This makes the qtsvg build fail. I've looked for a file that has a list of headers to copy over during qtbase build, but couldn't find it. Any pointers? I'd like to add QtZlib there and see if it would succeed. https://bugreports.qt-project.org/browse/QTBUG-32641 seems related, but without QtZlib even being in $$[QT_INSTALL_HEADERS/get], it won't work. Can you report this issue? It looks genuine. My suggestion is, of course, that qtsvg gets its own copy of zlib in src/3rdparty. Anyone who can't or won't have a system-installed shared zlib will pay the penalty of having zlib duplicated in memory up to 6 times. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Mac build fails due to qlobal.h being modified?
On segunda-feira, 16 de setembro de 2013 17:19:04, John Layt wrote: Hi, I'm trying to do a clean build on Mac of current dev branch, but I keep getting the error: fatal error: file '/Users/odysseus/Development/Qt/src/qt5/qtbase/src/corelib/../../include/QtC ore/qglobal.h' has been modified since the precompiled header was built. Any clues on how to fix that besides passing -no-pch? No source file is modified. Check your date/time settings. You might have a file modified in the future. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
