[Development] Behaviour change in QML in Qt 5.8 regarding null

[Chris Adams]

Hi,

Recently, a few unit test failures[1] in the (unreleased) QtPIM module
showed that the recent change[2] which changes the semantics of null
assignment (from JS) to a QVariant Q_PROPERTY can affect existing client
code.

Certainly, the cases which are affected are most likely edge-cases (that
is, specifically testing the type or value of the QVariant within C++ code
to detect "null" assignment), however it is probably worth raising for
discussion.

Why was the change made?  The commit message tells us what was changed, but
not the reasoning behind the change.  The unit tests were changed, so the
behaviour change was clearly intentional (and the old behaviour considered
problematic), and I assume that there must be very good reasons to make
such a change, but it wasn't discussed on the mailing list, so I don't know
what those reasons are.

Best regards,
Chris.

[1] https://codereview.qt-project.org/#/c/170491/
[2] https://codereview.qt-project.org/#/c/167062/


www.qinetic.com.au - Qt And QML User Experience Specialists
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Help! configure won't configure on Windows

[Thiago Macieira]

On segunda-feira, 19 de setembro de 2016 00:22:42 PDT Jake Petroules wrote:
> > It's worked for over 4 years. I may not be the only one doing this.
> > 
> > Please fix it.
> 
> I don't see why we should, it seems an illogical workflow to configure qt5
> and then expect to be able to configure from qtbase...

I don't configure qt5. I have never, ever run configure from there.

I configure qtbase and run qmake in the other modules. There's a .pro file in 
qt5.git and it was useful to use it to generate a Makefile to build the other 
modules.

And, like I said, others may have done the same. See the discussion on the 
Coverity issue.

Please fix.

> >>> cd qtbase
> >>> configure
> >>> make
> >>> repeat for a month
> >>> cd .. # to qt5.git
> >>> qmake && make
> >> 
> >> ___
> >> Development mailing list
> >> Development@qt-project.org
> >> http://lists.qt-project.org/mailman/listinfo/development


-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Help! configure won't configure on Windows

[Jake Petroules]

> On Sep 18, 2016, at 4:44 PM, Thiago Macieira  
> wrote:
> 
> On domingo, 18 de setembro de 2016 22:22:57 PDT Oswald Buddenhagen wrote:
>> On Sat, Sep 17, 2016 at 12:49:36PM -0700, Thiago Macieira wrote:
>>> So how am I going to reconfigure qtbase once I've built the rest of qt5?
>> 
>> you don't. you keep configuring qt5, or you clean out the non-qtbase
>> artifacts first.
>> 
>>> My workflow is:
>> you should consider yourself lucky that this ever worked.
> 
> It's worked for over 4 years. I may not be the only one doing this.
> 
> Please fix it.

I don't see why we should, it seems an illogical workflow to configure qt5 and 
then expect to be able to configure from qtbase...

> 
>> 
>>> cd qtbase
>>> configure
>>> make
>>> repeat for a month
>>> cd ..   # to qt5.git
>>> qmake && make
>> 
>> ___
>> Development mailing list
>> Development@qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/development
> 
> 
> -- 
> Thiago Macieira - thiago.macieira (AT) intel.com
>  Software Architect - Intel Open Source Technology Center
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Jake Petroules - jake.petrou...@qt.io
The Qt Company - Silicon Valley
Qbs build tool evangelist - qbs.io

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Help! configure won't configure on Windows

[Thiago Macieira]

On domingo, 18 de setembro de 2016 22:22:57 PDT Oswald Buddenhagen wrote:
> On Sat, Sep 17, 2016 at 12:49:36PM -0700, Thiago Macieira wrote:
> > So how am I going to reconfigure qtbase once I've built the rest of qt5?
> 
> you don't. you keep configuring qt5, or you clean out the non-qtbase
> artifacts first.
> 
> > My workflow is:
> you should consider yourself lucky that this ever worked.

It's worked for over 4 years. I may not be the only one doing this.

Please fix it.

> 
> > cd qtbase
> > configure
> > make
> > repeat for a month
> > cd ..   # to qt5.git
> > qmake && make
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development


-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Help! configure won't configure on Windows

[Oswald Buddenhagen]

On Sat, Sep 17, 2016 at 12:49:36PM -0700, Thiago Macieira wrote:
> So how am I going to reconfigure qtbase once I've built the rest of qt5?
>
you don't. you keep configuring qt5, or you clean out the non-qtbase
artifacts first.

> My workflow is:
> 
you should consider yourself lucky that this ever worked.

> cd qtbase
> configure
> make
> repeat for a month
> cd .. # to qt5.git
> qmake && make
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Missing Qt modules from Coverity Scan

[Thiago Macieira]

On domingo, 18 de setembro de 2016 19:59:24 PDT Holger Freyther wrote:
> > On 18 Sep 2016, at 17:12, Marc Mutz  wrote:
> > 
> > 
> > This is another issue. This week's report only contains issues in code
> > built by qmake, probably caused by the configure problem you mention.
> > 
> > Last week's report, to which Peppe referred, however, contained all of
> > qtbase, but none of the other modules.
> 
> The build script driving the build didn't do set -e so I think it just
> errored out on qtbase compilation and uploaded a partial result. The system
> is a Ubuntu 14.04.03 and it seems Qt requires a newer system:
> 
> /home/qt-project/coverity/qt5/qtbase/src/plugins/platforms/xcb/qxcbconnectio
> n.h:689:20: error: 'TabletData' is not a member of 'QXcbConnection'
> Q_DECLARE_TYPEINFO(QXcbConnection::TabletData::ValuatorClassInfo,
> Q_PRIMITIVE_TYPE); ^

Maybe fixed by 

commit 8cedf59a6815bf6457879822c0429f4becf85567
Author: Allan Sandfeld Jensen , Tue Sep 6 
12:30:33 2016 +0200 (12 days ago)

Fix Linux build without XINPUT2


-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Missing Qt modules from Coverity Scan

[Holger Freyther]

> On 18 Sep 2016, at 17:12, Marc Mutz  wrote:
> 
> 
> This is another issue. This week's report only contains issues in code built 
> by qmake, probably caused by the configure problem you mention.
> 
> Last week's report, to which Peppe referred, however, contained all of 
> qtbase, 
> but none of the other modules.

The build script driving the build didn't do set -e so I think it just errored 
out on qtbase compilation and uploaded a partial result. The system is a Ubuntu 
14.04.03 and it seems Qt requires a newer system:

/home/qt-project/coverity/qt5/qtbase/src/plugins/platforms/xcb/qxcbconnection.h:689:20:
 error: 'TabletData' is not a member of 'QXcbConnection'
 Q_DECLARE_TYPEINFO(QXcbConnection::TabletData::ValuatorClassInfo, 
Q_PRIMITIVE_TYPE);
^

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Missing Qt modules from Coverity Scan

[Marc Mutz]

On Saturday 17 September 2016 09:51:02 Holger Freyther wrote:
> > On 15 Sep 2016, at 14:51, Giuseppe D'Angelo 
> > wrote:
> > 
> > Howdy,
> 
> Hi!
> 
> > while playing around with Coverity Scan with a few colleagues of mine we
> > noticed that only qtbase is getting uploaded and therefore checked
> > (instead of the complete qt5.git).
> > 
> > I'm fairly sure that this has changed recently, as there are bugs in
> > there against other modules which were automatically marked as "fixed"
> > by Coverity (because the corresponding code is now gone).
> > 
> > May I ask the Good Samaritan who is regularly uploading builds of Qt to
> > Coverity to double check the configuration?
> 
> thanks for pointing it out. It seems that qt5.git/configure in the dev
> branch is broken (or has changed behavior).

This is another issue. This week's report only contains issues in code built 
by qmake, probably caused by the configure problem you mention.

Last week's report, to which Peppe referred, however, contained all of qtbase, 
but none of the other modules.

Thanks,
Marc

-- 
Marc Mutz  | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
Tel: +49-30-521325470
KDAB - Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development