Re: [Development] Naming convention for (scoped) enums
On Thu, 17 May 2018 08:14:15 + Alex Blasche wrote: > The naming conventions for enums state that each enum value name must repeat > a part of the enum Type name (for details see > https://wiki.qt.io/API_Design_Principles#Naming_Enum_Types_and_Values) > > In case of scoped enums this becomes a superfluous rule as the type has to be > mentioned anyway. Does anybody object to modifying the above definition by > adding an exception for scoped enums where you do not have to repeat a part > of the enum type name? I would not have even assumed that the rule applies to scoped enums, but it can't hurt to write it down explicitly. Perhaps the section should be rewritten so that the unscoped enums are the special case rather than the other way around. Christian ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Naming convention for (scoped) enums
> On 17 May 2018, at 10:14, Alex Blasche wrote: > > Hi, > > The naming conventions for enums state that each enum value name must repeat > a part of the enum Type name (for details see > https://wiki.qt.io/API_Design_Principles#Naming_Enum_Types_and_Values) > > In case of scoped enums this becomes a superfluous rule as the type has to be > mentioned anyway. Does anybody object to modifying the above definition by > adding an exception for scoped enums where you do not have to repeat a part > of the enum type name? Sounds like a sensible thing +1 Tor Arne > -- > Alex > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Naming convention for (scoped) enums
Il 17/05/2018 10:14, Alex Blasche ha scritto: In case of scoped enums this becomes a superfluous rule as the type has to be mentioned anyway. Does anybody object to modifying the above definition by adding an exception for scoped enums where you do not have to repeat a part of the enum type name? I approve of the change. In Qt 5.11 we've already started introducing enum classes that do not repeat the enumeration name in the enumerators (e.g. QAbstractItemModel::CheckIndexOption). I would also double-down and say that every new enumeration in Qt has to be an enum class. My 2 cents, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com KDAB - The Qt, C++ and OpenGL Experts smime.p7s Description: Firma crittografica S/MIME ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Nominating Mårten Nordheim as an approver
Congratulations to Mårten. The rights have been adjusted. -- Alex From: Development on behalf of Edward Welbourne Sent: Wednesday, 25 April 2018 1:40:41 PM To: development@qt-project.org Subject: [Development] Nominating Mårten Nordheim as an approver Hi all, I'd like to nominate Mårten Nordheim for Approver. We've had him here at TQtC, in the Core & Network team, for a bit over a year; he's been reviewing steadily and finding mistakes I miss. As well as diverse work in qtbase, he's also dabbled in the qtnetworkauth and qtwebsockets modules. Here's his list of changes in gerrit: https://codereview.qt-project.org/#/q/owner:"M%25C3%25A5rten+Nordheim",n,z and the (somewhat busier) list of what he's reviewed: https://codereview.qt-project.org/#/q/reviewer:"M%25C3%25A5rten+Nordheim",n,z Eddy. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Naming convention for (scoped) enums
Hi, The naming conventions for enums state that each enum value name must repeat a part of the enum Type name (for details see https://wiki.qt.io/API_Design_Principles#Naming_Enum_Types_and_Values) In case of scoped enums this becomes a superfluous rule as the type has to be mentioned anyway. Does anybody object to modifying the above definition by adding an exception for scoped enums where you do not have to repeat a part of the enum type name? -- Alex ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Code contributions via bug reports and forum posts
On 16/05/2018, 19.07, "Development on behalf of Thiago Macieira" wrote: > > To all users: please continue submitting contributions through the >contribution system as much as you can. Submitting patches via the bug >reporting tool may not work if the assignee or maintainer in question does > not >work for the Qt Company and there's no one who does that is willing to > accept >the responsibility of submitting it on your behalf. Yes, absolutely. We should not reduce normal codereview use. For any of these "casual contributions", someone needs to do the work to get the patch in via codereview (and in most cases also do some changes to the patch as well). Intention is not do regular contributions in this way, just to allow similar approach for all users as has been the case for commercial license holders since ages. Yours, Tuukka ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
