Re: [Development] Requesting a repository for Alexa integration
Now I'm looking forward to seeing what you've come up with :) https://codereview.qt-project.org/#/admin/projects/qt/qtvoiceassistant Cheers, Frederik On onsdag 8. mai 2019 16:47:24 CEST Minenko, Vladimir wrote: > Thanks fort he feedback! > > > > "qt/qtvoiceassistant" > > > Sounds good! Thanks! > > -- > Vladimir > > On 08.05.19, 16:41, "Frederik Gladhorn" wrote: > > Hi Vladimir, > > It's great to hear that you've been looking into integrating Alexa and > other assistants as well, we have a few thoughts around this in The Qt > Company and have been drawing how a rough abstraction for several > assistants could look like. Sadly it's not easy to hook deeply into e.g. > Alexa, but what you've done sounds very interesting. A later extension > could also be to use QtMultiMedia with the Alexa SDK. > > Moving/renaming repositories is generally a not very fun exercise, so > we've been aiming to just use the final name, independent of the state. > I'd suggest "qt/qtvoiceassistant", does that sound OK? > > Cheers, > Frederik > > > On onsdag 10. april 2019 14:23:54 CEST Minenko, Vladimir wrote: > > > Hi, > > > > > > > > I would like to request for a new repository: > > > > > > > > Name of the repository: qt-labs/qtalexa.git > > Description: A environment enabling a use of Alexa an Qt based UI > > systems. > > Responsible person: Vladimir Minenko > > Gerrit user/email: vladimir.mine...@pelagicore.com > > > > > > > > We developed an initial version of integration of Amazon Alexa in > > Qt-based > > UI. It can currently visualize selected cards (known as "Display > > Cards") as well as use Custom Skills to post control command to a > > system using Qt as UI framework. > > > > > The current implementation is fully functional and was already used in > > a > > joint-development prototype with a customer. The mid- to long-term > > intention is to create a new extension for Qt which would enable using > > of a voice assistance in Qt based applications and systems. The code > > will be licensed under (L)GLPv3 and commercial licenses. > > > > > -- > > Vladimir Minenko – Qt Automotive Platform, Luxoft Automotive * Munich > > * > > Germany * +49 170 8583617 * https://www.qt.io/qt-automotive-suite/ * > > https://doc.qt.io/QtAutomotiveSuite/ > > > > > > > > > > > > > > > > > > > This e-mail and any attachment(s) are intended only for the > > recipient(s) > > named above and others who have been specifically authorized to > > receive > > them. They may contain confidential information. If you are not the > > intended recipient, please do not read this email or its > > attachment(s). > > Furthermore, you are hereby notified that any dissemination, > > distribution > > or copying of this e-mail and any attachment(s) is strictly > > prohibited. If > > you have received this e-mail in error, please immediately notify the > > sender by replying to this e-mail and then delete this e-mail and any > > attachment(s) or copies thereof from your system. Thank you. > > ___ > > Development mailing list > > Development@qt-project.org > > https://lists.qt-project.org/listinfo/development > > > > > > > > > > > This e-mail and any attachment(s) are intended only for the recipient(s) > named above and others who have been specifically authorized to receive > them. They may contain confidential information. If you are not the > intended recipient, please do not read this email or its attachment(s). > Furthermore, you are hereby notified that any dissemination, distribution > or copying of this e-mail and any attachment(s) is strictly prohibited. If > you have received this e-mail in error, please immediately notify the > sender by replying to this e-mail and then delete this e-mail and any > attachment(s) or copies thereof from your system. Thank you. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit
On onsdag 8. mai 2019 16:06:02 CEST Edward Welbourne wrote: > On 8 May 2019, at 10:24, Liang Qi mentioned: > https://codereview.qt-project.org/260927 > > Shawn Rutledge (8 May 2019 15:43) replied > > > I don’t understand why a change that is just sitting there on Gerrit > > can affect the merge. Nobody ever staged that one onto the “wrong” > > branch, right? > > None the less, IIUC, apparently the automation involved did stage the > 5.13.0 one when a merge to 5.13.0 (presumably the end of soft-branching) > brought in the change from 5.13 with the same ID, that had been merged > to 5.13 earlier. Quite why that would happen is unclear, and may be > considered a bug in whatever automation did it, but it seems this does > happen. > > > And then the bot detected the duplication and auto-abandoned it. > > No, the whole point of Liang's message is that he had to abort the build > (it wasn't auto-detected) and Frederik (an admin) had to manually > abandon it so that he could get on with his merge. Actually I don't understand why it had to be abandoned, but since it was clearly a duplicate, I didn't really care. Cheers, Frederik > > Eddy. > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Requesting a repository for UI analytics
Hello Vladimir, On onsdag 10. april 2019 14:21:21 CEST Minenko, Vladimir wrote: > Hi, > > I would like to request for a new repository: > > Name of the repository: qt-labs/qtuianalytics.git > Description: An plugin for Qt Quick allowing collection of UI usage > analytics. Responsible person: Vladimir Minenko > Gerrit user/email: vladimir.mine...@pelagicore.com > > We developed an initial version of a Qt Quick plug in allowing collection of > UI usage analytics. It can be used in almost any QML item. It currently > uses Matomo (former Piwik) as a web-based storage and visualization > backend. > The current implementation is fully functional and was already used in a > joint-development prototype with a customer. The mid- to long-term > intention is to create a new extension for Qt which would enable collection > of UI usage data and a basic visualization with standard, mostly web-based > analytics services, like Matomo. The code will be licensed under LGLPv3 and > commercial licenses. Is it always going to be UI? Maybe a more general name would make sense? I struggle to come up with a great name though. The Qt Company plans to gather some usage statistics from our products, e.g. Qt Creator, to learn better which platforms matter to our users. There is indeed some overlap, but in the meantime we have settled on using KUserFeedback, since Volker Krause has been really helpful and it provides what we need. It will be interesting to see how your implementation is different. I'd vote for creating the repository, but assuming it aims to become part of Qt, with qt as namespace. "qt/qtuianalytics", unless someone comes up with a better name. Cheers, Frederik > -- > Vladimir Minenko – Qt Automotive Platform, Luxoft Automotive * Munich * > Germany * +49 170 8583617 * https://www.qt.io/qt-automotive-suite/ * > https://doc.qt.io/QtAutomotiveSuite/ > > > > This e-mail and any attachment(s) are intended only for the recipient(s) > named above and others who have been specifically authorized to receive > them. They may contain confidential information. If you are not the > intended recipient, please do not read this email or its attachment(s). > Furthermore, you are hereby notified that any dissemination, distribution > or copying of this e-mail and any attachment(s) is strictly prohibited. If > you have received this e-mail in error, please immediately notify the > sender by replying to this e-mail and then delete this e-mail and any > attachment(s) or copies thereof from your system. Thank you. > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Requesting a repository for Alexa integration
Thanks fort he feedback! > "qt/qtvoiceassistant" Sounds good! Thanks! -- Vladimir On 08.05.19, 16:41, "Frederik Gladhorn" wrote: Hi Vladimir, It's great to hear that you've been looking into integrating Alexa and other assistants as well, we have a few thoughts around this in The Qt Company and have been drawing how a rough abstraction for several assistants could look like. Sadly it's not easy to hook deeply into e.g. Alexa, but what you've done sounds very interesting. A later extension could also be to use QtMultiMedia with the Alexa SDK. Moving/renaming repositories is generally a not very fun exercise, so we've been aiming to just use the final name, independent of the state. I'd suggest "qt/qtvoiceassistant", does that sound OK? Cheers, Frederik On onsdag 10. april 2019 14:23:54 CEST Minenko, Vladimir wrote: > Hi, > > I would like to request for a new repository: > > Name of the repository: qt-labs/qtalexa.git > Description: A environment enabling a use of Alexa an Qt based UI systems. > Responsible person: Vladimir Minenko > Gerrit user/email: vladimir.mine...@pelagicore.com > > We developed an initial version of integration of Amazon Alexa in Qt-based > UI. It can currently visualize selected cards (known as "Display Cards") as > well as use Custom Skills to post control command to a system using Qt as > UI framework. > The current implementation is fully functional and was already used in a > joint-development prototype with a customer. The mid- to long-term > intention is to create a new extension for Qt which would enable using of a > voice assistance in Qt based applications and systems. The code will be > licensed under (L)GLPv3 and commercial licenses. > -- > Vladimir Minenko – Qt Automotive Platform, Luxoft Automotive * Munich * > Germany * +49 170 8583617 * https://www.qt.io/qt-automotive-suite/ * > https://doc.qt.io/QtAutomotiveSuite/ > > > > > This e-mail and any attachment(s) are intended only for the recipient(s) > named above and others who have been specifically authorized to receive > them. They may contain confidential information. If you are not the > intended recipient, please do not read this email or its attachment(s). > Furthermore, you are hereby notified that any dissemination, distribution > or copying of this e-mail and any attachment(s) is strictly prohibited. If > you have received this e-mail in error, please immediately notify the > sender by replying to this e-mail and then delete this e-mail and any > attachment(s) or copies thereof from your system. Thank you. > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development This e-mail and any attachment(s) are intended only for the recipient(s) named above and others who have been specifically authorized to receive them. They may contain confidential information. If you are not the intended recipient, please do not read this email or its attachment(s). Furthermore, you are hereby notified that any dissemination, distribution or copying of this e-mail and any attachment(s) is strictly prohibited. If you have received this e-mail in error, please immediately notify the sender by replying to this e-mail and then delete this e-mail and any attachment(s) or copies thereof from your system. Thank you. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Requesting a repository for Alexa integration
Hi Vladimir, It's great to hear that you've been looking into integrating Alexa and other assistants as well, we have a few thoughts around this in The Qt Company and have been drawing how a rough abstraction for several assistants could look like. Sadly it's not easy to hook deeply into e.g. Alexa, but what you've done sounds very interesting. A later extension could also be to use QtMultiMedia with the Alexa SDK. Moving/renaming repositories is generally a not very fun exercise, so we've been aiming to just use the final name, independent of the state. I'd suggest "qt/qtvoiceassistant", does that sound OK? Cheers, Frederik On onsdag 10. april 2019 14:23:54 CEST Minenko, Vladimir wrote: > Hi, > > I would like to request for a new repository: > > Name of the repository: qt-labs/qtalexa.git > Description: A environment enabling a use of Alexa an Qt based UI systems. > Responsible person: Vladimir Minenko > Gerrit user/email: vladimir.mine...@pelagicore.com > > We developed an initial version of integration of Amazon Alexa in Qt-based > UI. It can currently visualize selected cards (known as "Display Cards") as > well as use Custom Skills to post control command to a system using Qt as > UI framework. > The current implementation is fully functional and was already used in a > joint-development prototype with a customer. The mid- to long-term > intention is to create a new extension for Qt which would enable using of a > voice assistance in Qt based applications and systems. The code will be > licensed under (L)GLPv3 and commercial licenses. > -- > Vladimir Minenko – Qt Automotive Platform, Luxoft Automotive * Munich * > Germany * +49 170 8583617 * https://www.qt.io/qt-automotive-suite/ * > https://doc.qt.io/QtAutomotiveSuite/ > > > > > This e-mail and any attachment(s) are intended only for the recipient(s) > named above and others who have been specifically authorized to receive > them. They may contain confidential information. If you are not the > intended recipient, please do not read this email or its attachment(s). > Furthermore, you are hereby notified that any dissemination, distribution > or copying of this e-mail and any attachment(s) is strictly prohibited. If > you have received this e-mail in error, please immediately notify the > sender by replying to this e-mail and then delete this e-mail and any > attachment(s) or copies thereof from your system. Thank you. > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit
On 8 May 2019, at 10:24, Liang Qi mentioned: https://codereview.qt-project.org/260927 Shawn Rutledge (8 May 2019 15:43) replied > I don’t understand why a change that is just sitting there on Gerrit > can affect the merge. Nobody ever staged that one onto the “wrong” > branch, right? None the less, IIUC, apparently the automation involved did stage the 5.13.0 one when a merge to 5.13.0 (presumably the end of soft-branching) brought in the change from 5.13 with the same ID, that had been merged to 5.13 earlier. Quite why that would happen is unclear, and may be considered a bug in whatever automation did it, but it seems this does happen. > And then the bot detected the duplication and auto-abandoned it. No, the whole point of Liang's message is that he had to abort the build (it wasn't auto-detected) and Frederik (an admin) had to manually abandon it so that he could get on with his merge. Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit
> On 8 May 2019, at 10:24, Liang Qi wrote: > > > >> On 7 May 2019, at 22:13, Oswald Buddenhagen >> wrote: >> >> On Tue, May 07, 2019 at 01:52:48PM +, Liang Qi wrote: >>> This is a very common issue when I do the integraton work in qt5. >>> >>> For example, currently we have 5.12->5.13->dev merge order, and the last >>> round 5.13->5.13.0 today. One change(changeA) had been integrated in 5.13, >>> and another change(changeB) with duplicate Change-Id was pushed to 5.13.0 >>> branch with status:open. When I try to merge 5.13 to 5.13.0, the changeB >>> will be picked up by gerrit and be part of the integration, which I found >>> in COIN. Normally that integation will fail, but I am not 100% sure. >>> >>> I only know the phenomenon, but not the root cause. >>> >>> If you have a change was merged in lower branch, please try to avoid use >>> duplicate Change-Id in upper branch, at least in the current merge order. >>> >> please don't give such bad advice. > > It’s not advice, more strict than that. This situation had wasted quite some > time and energy from me and CI/COIN. > > Here is just the latest case which happened yesterday. > > When I tried to do the final down merge qt5 5.13->5.13.0 plus the submodule > update in 5.13.0, after staged, I got > https://codereview.qt-project.org/#/c/260927/ included in the integration in > COIN. I need to cancel it and ask the owner or gerrit admin to abandon it. > That takes too much time, especially if I tried it during midnight… I don’t understand why a change that is just sitting there on Gerrit can affect the merge. Nobody ever staged that one onto the “wrong” branch, right? And then the bot detected the duplication and auto-abandoned it. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit
> On 7 May 2019, at 22:13, Oswald Buddenhagen wrote: > > On Tue, May 07, 2019 at 01:52:48PM +, Liang Qi wrote: >> This is a very common issue when I do the integraton work in qt5. >> >> For example, currently we have 5.12->5.13->dev merge order, and the last >> round 5.13->5.13.0 today. One change(changeA) had been integrated in 5.13, >> and another change(changeB) with duplicate Change-Id was pushed to 5.13.0 >> branch with status:open. When I try to merge 5.13 to 5.13.0, the changeB >> will be picked up by gerrit and be part of the integration, which I found in >> COIN. Normally that integation will fail, but I am not 100% sure. >> >> I only know the phenomenon, but not the root cause. >> >> If you have a change was merged in lower branch, please try to avoid use >> duplicate Change-Id in upper branch, at least in the current merge order. >> > please don't give such bad advice. It’s not advice, more strict than that. This situation had wasted quite some time and energy from me and CI/COIN. Here is just the latest case which happened yesterday. When I tried to do the final down merge qt5 5.13->5.13.0 plus the submodule update in 5.13.0, after staged, I got https://codereview.qt-project.org/#/c/260927/ included in the integration in COIN. I need to cancel it and ask the owner or gerrit admin to abandon it. That takes too much time, especially if I tried it during midnight… I don’t blame the owner of the changes, because they are not familiar with gerrit, especially the situation in Qt Project. Or perhaps this should be one of the reasons of switching to one dev branch and cherry-pick to other branches development model. —Liang > > firstly, the issue occurs only if neither change was integrated yet. > i've yet to see actual evidence of another case. > and yes, that's a bug in the gerrit CI customization. one can only hope > that The Upgrade will fix it. > > secondly, if you're doing a cherry-pick which will be followed by a > merge, _then you're doing it wrong_. most commonly, that will be the > effect of client-side re-targeting where the original change was not > abandoned. > >> If you have a change landed in 5.12, and it's ok to have duplicate Change-Id >> when you cherry-picked it to 5.9, because we don't do merge from 5.9 to 5.12. >> >> Best Regards, >> Liang >> ___ >> Development mailing list >> Development@qt-project.org >> https://lists.qt-project.org/listinfo/development > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] unique_ptr and Qt, Take 2
The patch I propose does not take that into account and is indeed almost entirely source compatible. Scratch the "not". And while I'd encourage someone to try it out, I'm of the firm opinion that Qt should try to get over its NIH attitude. One of the issues with Qt in the real world is that it's just that tiny bit differently than what non Qt C++ users are familiar with for. Sometimes that's for a good reason. but there's a cost there that is imho unappreciated inside the Qt bubble. That sounds a bit harsher than intended and I should expand a bit on the costs: * Non Qt C++ developers can be expected to be familiar with how unique_ptr works. Today that might not be a entirely true, but we aren't deciding the api for today. We are deciding on the api for the next years. * Static analyzers understand standard c++ but are unlikely to understand the Qt dialect. [1] * Using standard c++ means, that any evolution in c++ benefits Qt automatically. daniel [1] For another example, clang-tidy knows about standard smart pointers for its use after move check: https://clang.llvm.org/extra/clang-tidy/checks/bugprone-use-after-move.html ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
