Re: [Development] Gerrit is back / email template changed
On Dienstag, 28. Mai 2019 16:53:20 CEST Frederik Gladhorn wrote: > On tirsdag 28. mai 2019 16:26:18 CEST Florian Bruhin wrote: > > On Tue, May 28, 2019 at 02:17:19PM +, Frederik Gladhorn wrote: > > > If someone has other ideas, we can discuss them! > > > > On a related note - I'm a bit confused about the ellipsis in the subject. > > Why "Change in ...qtgamepad[5.12.4]:" and not just "Change in > > qtgamepad[5.12.4]:"? > > In the mail template there is a short project name. > > $shortProjectName > The project name with the path abbreviated. > > https://codereview.qt-project.org/Documentation/config-mail.html > > Which replaces qt/ with ... as far as I can tell. > We could use the full project name instead, then you't get > Change in qt/qtgamepad[5.12.4] > > I'm not sure which one I find better. > When the ellipsis isn't shorter than the full name, then I would personally prefer the full name. Cheers 'Allan ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] QList for Qt 6
On Monday, 27 May 2019 04:51:35 PDT Eike Ziller wrote: > > * QVector for Qt 6 will most likely be updated with the changes Thiago has > > waiting since quite some years > What is the summary for these? The long story short is that the begin pointer and size members move from the d pointer to the actual object. The slightly longer story is that it's implemented using QArrayDataPointer and the supposedly exception-safe, tag- dispatched operations in QArrayDataOps that João wrote 7-8 years ago. I also introduced a QGenericArray class that QVector derives from and QList could have, but doesn't look like it will be necessary for Qt 6. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Gerrit is back / email template changed
On tirsdag 28. mai 2019 16:26:18 CEST Florian Bruhin wrote: > On Tue, May 28, 2019 at 02:17:19PM +, Frederik Gladhorn wrote: > > If someone has other ideas, we can discuss them! > > On a related note - I'm a bit confused about the ellipsis in the subject. > Why "Change in ...qtgamepad[5.12.4]:" and not just "Change in > qtgamepad[5.12.4]:"? In the mail template there is a short project name. $shortProjectName The project name with the path abbreviated. https://codereview.qt-project.org/Documentation/config-mail.html Which replaces qt/ with ... as far as I can tell. We could use the full project name instead, then you't get Change in qt/qtgamepad[5.12.4] I'm not sure which one I find better. Cheers, Frederik > > Florian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Qt 5.12.4 changes files
> -Original Message- > From: Frederik Gladhorn > Sent: tiistai 28. toukokuuta 2019 15.44 > To: development@qt-project.org > Cc: Jani Heikkinen > Subject: Re: [Development] Qt 5.12.4 changes files > > On mandag 27. mai 2019 10:42:44 CEST Jani Heikkinen wrote: > > Hi, > > Initial ones here: > > https://codereview.qt- > project.org/q/message:%2522Add+changes+file+for+Qt+5. > > 12.4%2522+status:open > > > > Maintainers, please do needed modifications & make sure reviews are > > done during this week > > Did the git log in the commit message get lost again? > I thought that was super helpful to confirm that there was no event (e.g. > when the only commit was a version bump, I feel much better about > approving the change stating that there was no change). Yes, unfortunately that was forgotten at this time, sorry about that. It was turned off for creating changes files for 5.13.0. For it (and all .0 releases) the feature isn't that qood; there is too much changes to list those on commit messages. We fixed the script now and from now on all patch level releases should have git logs included in commit message and for .0 releases not br, Jani > > Cheers, > Frederik > > > > > br, > > Jani > > ___ > > Development mailing list > > Development@qt-project.org > > https://lists.qt-project.org/listinfo/development > > > ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Gerrit is back / email template changed
On Tue, May 28, 2019 at 02:17:19PM +, Frederik Gladhorn wrote: > If someone has other ideas, we can discuss them! On a related note - I'm a bit confused about the ellipsis in the subject. Why "Change in ...qtgamepad[5.12.4]:" and not just "Change in qtgamepad[5.12.4]:"? Florian -- https://www.qutebrowser.org | m...@the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ signature.asc Description: PGP signature ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Gerrit is back / email template changed
Quick update... ... after some contemplation and being made aware that the subject becomes rather long, we removed the [Gerrit] from the subject again. Filtering on the sender is easy enough. If someone has other ideas, we can discuss them! Cheers, Frederik On Tuesday, May 28, 2019 3:17:24 PM CEST Frederik Gladhorn wrote: > Hi all, > > We got the suggestion to change the email template, now the subject lines of > what Gerrit sends to your inbox will be a bit more helpful. > > Old: > Change in ...qtgamepad[5.12.4]: Add changes file for Qt 5.12.4 > > New: > [Gerrit] Merged - ...qtgamepad[5.12.4]: Add changes file for Qt 5.12.4 > > So you get [Gerrit] as prefix and what happend after that. > > Cheers, > Frederik > > > On mandag 20. mai 2019 15:00:57 CEST Jukka Jokiniva wrote: > > > Dear all, > > > > we are happy to inform you that Gerrit and COIN are back online and all > > operation can resume. All access has been restored. > > Please refer to the > > > public wiki for further information, > > https://wiki.qt.io/Gerrit_Upgrade_2019. > > Bug reports and improvement ideas can be reported to bugreports.qt.io > > (project=QTQAINFRA component= Gerrit). Here is a tiny link: > > http://tiny.cc/new-qt-gerrit-issue > > > > > Best regards, > > your friendly Gerrit admin team. > > > > > > ___ > > Development mailing list > > Development@qt-project.org > > https://lists.qt-project.org/listinfo/development > > > > > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Gerrit is back / email template changed
Hi all, We got the suggestion to change the email template, now the subject lines of what Gerrit sends to your inbox will be a bit more helpful. Old: Change in ...qtgamepad[5.12.4]: Add changes file for Qt 5.12.4 New: [Gerrit] Merged - ...qtgamepad[5.12.4]: Add changes file for Qt 5.12.4 So you get [Gerrit] as prefix and what happend after that. Cheers, Frederik On mandag 20. mai 2019 15:00:57 CEST Jukka Jokiniva wrote: > Dear all, > > we are happy to inform you that Gerrit and COIN are back online and all > operation can resume. All access has been restored. Please refer to the > public wiki for further information, > https://wiki.qt.io/Gerrit_Upgrade_2019. > Bug reports and improvement ideas can be reported to bugreports.qt.io > (project=QTQAINFRA component= Gerrit). Here is a tiny link: > http://tiny.cc/new-qt-gerrit-issue > Best regards, > your friendly Gerrit admin team. > > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Gerrit is back
On lørdag 25. mai 2019 18:11:59 CEST Richard Weickelt wrote: > > There are more tweaks that would be nice to apply to the UI to make it > > better. Does the new version make this any easier? What's your advice for > > people who'd like to contribute UI tweaks? What's the best way to > > proceed? (in the sense of empowering potential contributors instead of > > asking you to do all the changes) > > This is a very very positive way of saying that the new UI is: > - less structured > - less intuitive > > The update contains indeed nice new features, but as an occasional > contributor I feel less productive because I need to learn where to click > every other day. The old gerrit was certainly ugly, but it felt much more > tidy. > > I would be very happy if someone with UI experience could clean up the > stylesheet. :) Please contribute upstream :) I'm sure they would also be happy about improved design. We will simply follow upstream as much as possible, since lagging behind is not very sensible and forking doesn't help us either. I was also a bit puzzled with the new UI at first, but after a few days I feel just as effective as in the old one. And the new UI works on mobile etc, which is also nice. Cheers, Frederik > > Thanks > Richard > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Qt 5.12.4 changes files
On mandag 27. mai 2019 10:42:44 CEST Jani Heikkinen wrote: > Hi, > Initial ones here: > https://codereview.qt-project.org/q/message:%2522Add+changes+file+for+Qt+5. > 12.4%2522+status:open > > Maintainers, please do needed modifications & make sure reviews are done > during this week Did the git log in the commit message get lost again? I thought that was super helpful to confirm that there was no event (e.g. when the only commit was a version bump, I feel much better about approving the change stating that there was no change). Cheers, Frederik > > br, > Jani > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
[Development] [Announce] Qt Creator 4.9.1 released
We are happy to announce the release of Qt Creator 4.9.1 ! https://blog.qt.io/blog/2019/05/28/qt-creator-4-9-1-released/ -- Eike Ziller Principal Software Engineer The Qt Company GmbH Rudower Chaussee 13 D-12489 Berlin eike.zil...@qt.io http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B ___ Announce mailing list annou...@qt-project.org https://lists.qt-project.org/listinfo/announce ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Proposal: Using Gerrit for new approver proposals?
22.05.2019, 15:54, "Florian Bruhin" :> On Wed, May 22, 2019 at 08:09:59AM +, Alex Blasche wrote:>> It is readable for all just not editable: https://codereview.qt-project.org/admin/groups/12,members>> What's up with "removed " in that list? It sounds like the> user isn't interested in contributing anymore, and thus it might be good to> remove that entry, to avoid future account takeovers and such? In the group of approvers there is much more obviously inactive members, including a few peoplewith @nokia.com addresses. -- Regards,Konstantin ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
