Re: [Development] [Gerrit-admin] Cherry-pick mode for 5.12
It happened so fast this time. But 5.12.5 was branched out before this cherry-pick mode change on 5.12 branch, I plan to do the 5.12.5->5.12->5.13 merges after 5.12.5 is out. Is it OK? —Liang > On 2 Sep 2019, at 15:13, Kari Oikarinen wrote: > > > > On 2.9.2019 15.23, Lars Knoll wrote: >> Hi all, >> >> According to QUIP-5 (http://quips-qt-io.herokuapp.com/quip-0005.html), we >> should move the 5.12 branch into cherry-pick mode now that we have created >> the 5.14 branch. >> >> Gerrit admins, could you please do the required changes in gerrit and for >> the sanity bot? Let’s do one final down-merge of 5.12 to 5.13 once that’s >> done. >> > > Sanity bot should now recognize 5.12 as an LTS branch and not complain about > cherry-picks there. > > -- > Kari > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating David Edmundson as approver
+1 Allan On Monday, 2 September 2019 16:37:29 CEST Simon Hausmann wrote: > +1 > > > Simon > > From: Development on behalf of Johan > Helsing Sent: Friday, August 23, 2019 14:15 > To: development@qt-project.org > Subject: [Development] Nominating David Edmundson as approver > > Hi all, > > I'd like to nominate David Edmundson as approver for the Qt Project. David > started contributing to Qt in 2013 and has been active contributing and > reviewing patches in QtWayland for the past two years. His patches and > reviews have a very high quality and I trust he will use his rights > responsibly. > > Here is his list of contributions: > https://codereview.qt-project.org/q/owner:davidedmundson%2540kde.org > > And reviews: > https://codereview.qt-project.org/q/reviewer:davidedmundson%2540kde.org > > Best regards, > Johan Helsing ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating David Edmundson as approver
+1 Simon From: Development on behalf of Johan Helsing Sent: Friday, August 23, 2019 14:15 To: development@qt-project.org Subject: [Development] Nominating David Edmundson as approver Hi all, I'd like to nominate David Edmundson as approver for the Qt Project. David started contributing to Qt in 2013 and has been active contributing and reviewing patches in QtWayland for the past two years. His patches and reviews have a very high quality and I trust he will use his rights responsibly. Here is his list of contributions: https://codereview.qt-project.org/q/owner:davidedmundson%2540kde.org And reviews: https://codereview.qt-project.org/q/reviewer:davidedmundson%2540kde.org Best regards, Johan Helsing ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating David Edmundson as approver
+1 from me as well, also from working on KDE things with David. And he's been upstreaming stuff - yay :) Cheers, Frederik On fredag 23. august 2019 14:15:59 CEST Johan Helsing wrote: > Hi all, > > I'd like to nominate David Edmundson as approver for the Qt Project. David > started contributing to Qt in 2013 and has been active contributing and > reviewing patches in QtWayland for the past two years. His patches and > reviews have a very high quality and I trust he will use his rights > responsibly. > > Here is his list of contributions: > https://codereview.qt-project.org/q/owner:davidedmundson%2540kde.org > > And reviews: > https://codereview.qt-project.org/q/reviewer:davidedmundson%2540kde.org > > Best regards, > Johan Helsing ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] [Gerrit-admin] Cherry-pick mode for 5.12
On 2.9.2019 16.27, Edward Welbourne wrote: > On 2.9.2019 15.23, Lars Knoll wrote: >>> According to QUIP-5 >>> (http://quips-qt-io.herokuapp.com/quip-0005.html), we should move the >>> 5.12 branch into cherry-pick mode now that we have created the 5.14 >>> branch. >>> >>> Gerrit admins, could you please do the required changes in gerrit and >>> for the sanity bot? Let’s do one final down-merge of 5.12 to 5.13 >>> once that’s done. > > Kari Oikarinen (2 September 2019 15:13) replied: >> Sanity bot should now recognize 5.12 as an LTS branch and not complain >> about cherry-picks there. > > ... and complain about non-cherry-picks there. > (It's just done so to me, for a change that was already underway.) > > Eddy. > True, it's an awkward transition period. But you can of course override the bot's verdict. As long as the change gets in before the final merge. As soon as the risk of missing the merge is high, the bot is actually right and it's better to retarget to 5.13. -- Kari ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] [Gerrit-admin] Cherry-pick mode for 5.12
On 2.9.2019 15.23, Lars Knoll wrote: >> According to QUIP-5 >> (http://quips-qt-io.herokuapp.com/quip-0005.html), we should move the >> 5.12 branch into cherry-pick mode now that we have created the 5.14 >> branch. >> >> Gerrit admins, could you please do the required changes in gerrit and >> for the sanity bot? Let’s do one final down-merge of 5.12 to 5.13 >> once that’s done. Kari Oikarinen (2 September 2019 15:13) replied: > Sanity bot should now recognize 5.12 as an LTS branch and not complain > about cherry-picks there. ... and complain about non-cherry-picks there. (It's just done so to me, for a change that was already underway.) Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] [Gerrit-admin] Cherry-pick mode for 5.12
On 2.9.2019 15.23, Lars Knoll wrote: > Hi all, > > According to QUIP-5 (http://quips-qt-io.herokuapp.com/quip-0005.html), we > should move the 5.12 branch into cherry-pick mode now that we have created > the 5.14 branch. > > Gerrit admins, could you please do the required changes in gerrit and for the > sanity bot? Let’s do one final down-merge of 5.12 to 5.13 once that’s done. > Sanity bot should now recognize 5.12 as an LTS branch and not complain about cherry-picks there. -- Kari ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
[Development] Cherry-pick mode for 5.12
Hi all, According to QUIP-5 (http://quips-qt-io.herokuapp.com/quip-0005.html), we should move the 5.12 branch into cherry-pick mode now that we have created the 5.14 branch. Gerrit admins, could you please do the required changes in gerrit and for the sanity bot? Let’s do one final down-merge of 5.12 to 5.13 once that’s done. Thanks, Lars ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating Kirill Burtsev as Approver
+1 On 8/30/19 11:38 AM, Jüri Valdmann wrote: > +1 > > *From:* Development on behalf of > Alexandru Croitor > *Sent:* Thursday, August 29, 2019 4:08 PM > *To:* Allan Sandfeld Jensen > *Cc:* Qt development mailing list > *Subject:* Re: [Development] Nominating Kirill Burtsev as Approver > +1 > >> On 29. Aug 2019, at 15:29, Allan Sandfeld Jensen wrote: >> >> On Thursday, 29 August 2019 14:54:45 CEST Michael Bruning wrote: >>> Hi all, >>> >>> I would like to nominate Kirill Burtsev as approver for the Qt Project. >>> Kirill joined the Qt WebEngine team about a year ago and has been mainly >>> contributing to the web engine module, but also to qtbase and >>> qtdeclarative. I trust that he will follow Qt guidelines and will use the >>> approver rights responsibly. >>> >>> Here is his list of changes: >>> https://codereview.qt-project.org/q/owner:kirill.burtsev%2540qt.io>> odereview.qt-project.org/q/owner:kirill.burtsev%40qt.io> >>> >>> and reviews: >>> https://codereview.qt-project.org/q/reviewer:kirill.burtsev%2540qt.io>> //codereview.qt-project.org/q/reviewer:kirill.burtsev%40qt.io> >>> >>> Disclaimer: we are working in the same company and the same team. >>> >> >> +1 :) >> >> 'Allan >> >> >> ___ >> Development mailing list >> Development@qt-project.org >> https://lists.qt-project.org/listinfo/development > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development > > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development > ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
