Re: [Development] Nominating David Skoland as approver

[Lorn Potter]

+1

On 21/4/2022 10:00 PM, Morten Sørvig wrote:

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since 
late 2020, with patches and reviews to several modules. He has recently 
shifted focus to work on Qt for WebAssembly, where he’s already made 
several good contributions and is currently taking on getting auto-tests 
running in the CI system.


I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io 

https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io 



Best Regards,
Morten Sørvig



___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QRect::contains and undocumented(?) edge

[Allan Sandfeld Jensen]

On Donnerstag, 21. April 2022 16:09:37 CEST Thiago Macieira wrote:
> On Thursday, 21 April 2022 06:22:57 PDT Tomi Pannila wrote:
> > Is there a possibility to add a picture to Qt documentation where you
> > have a rectangle grid and shade the
> > edge cells with some color to identify them as edges? If I'm the only
> > one confused of the term edge, not edge cell, in integer
> > rectangle, then this is not needed.
> 
> You're not. The problem is that, as Aavit described, the class was designed
> as an intuitive chess board or pixel board, not as a mathematical
> construct.
> 
> A QRect of (0,0) to (1,1) is a 2x2 square. So a square of a single pixel is
> (0,0) to (0,0). But then how do you make an empty QRect, that is, a (0,0)
> +0+0?
> 
(0,0) to (-1,-1)

When the "bottom-right" corner is above and to the left of the "top-left" 
corner, the borders excluded instead of included. Weird but it works, and I 
made it consistent in Qt6 (I believe it was 6.0, could have been before). 

So (1,1)->(2,2) is the same as (3,3)->(0,0)

But yes. It is weird and ugly logic, to keep this old nonsense going.

'Allan


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QRect::contains and undocumented(?) edge

[Giuseppe D'Angelo via Development]

On 21/04/2022 16:09, Thiago Macieira wrote:


It has some unintuitive defects and flaws, but they can't be fixed because
this class is OLD. We can improve documentation, but that's all. If drawing
the chess board as a stand-in for the pixel helps understand, then it might be
a good idea.


There used to be a bunch of pictures like

https://doc.qt.io/qt-5/coordsys.html#aliased-painting

but I have no idea where they are right now. Maybe in some QQ article...


HTH,
--
Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
KDAB - The Qt, C++ and OpenGL Experts


smime.p7s
Description: S/MIME Cryptographic Signature
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QRect::contains and undocumented(?) edge

[Thiago Macieira]

On Thursday, 21 April 2022 06:22:57 PDT Tomi Pannila wrote:
> Is there a possibility to add a picture to Qt documentation where you
> have a rectangle grid and shade the
> edge cells with some color to identify them as edges? If I'm the only
> one confused of the term edge, not edge cell, in integer
> rectangle, then this is not needed.

You're not. The problem is that, as Aavit described, the class was designed as 
an intuitive chess board or pixel board, not as a mathematical construct.

A QRect of (0,0) to (1,1) is a 2x2 square. So a square of a single pixel is 
(0,0) to (0,0). But then how do you make an empty QRect, that is, a (0,0) 
+0+0?

It has some unintuitive defects and flaws, but they can't be fixed because 
this class is OLD. We can improve documentation, but that's all. If drawing 
the chess board as a stand-in for the pixel helps understand, then it might be 
a good idea.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel DPG Cloud Engineering



___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QRect::contains and undocumented(?) edge

[Tomi Pannila]

Hi Eirik,

I start to understand your point of view. You view edge from programming 
point of view?
Like if you have a chess board, an edge cell is one where one cannot 
take one cell step to all directions?
If I would have to point an edge of a chess board, I would point to the 
physical edge.
If you draw a chess board to a grid and ask for an edge, I would point 
the line intervals at the edges.


Is there a possibility to add a picture to Qt documentation where you 
have a rectangle grid and shade the
edge cells with some color to identify them as edges? If I'm the only 
one confused of the term edge, not edge cell, in integer

rectangle, then this is not needed.

Best Regards,
Tomi Pannila

On 21.4.2022 11.39, Eirik Aavitsland wrote:

On 4/20/22 17:50, Tomi Pannila wrote:

Hi Lars and Eirik,


thank you for the explanations. I guess Eirik kind of guessed right 
that I view QRect from $\mathbb{R}^2$ point of view.
I'm a mathematician and this is the most natural point of view for 
me. For me, rectangles have edges=boundary which are measure zero.



But QRect is not a mathematical (cartesian) rectangle, instead it 
describes a chess board. If one asks anybody which squares are on the 
edge of the board, they will correctly point out row 1 and 8, and 
column A and H. That is exactly the meaning of "edge" in the doc of 
QRect::contains() - it is the everyday, intuitive and obvious meaning. 
So I don't see the problem with the current api, except for the 
anonymosity of the bool parameter, as Lars pointed out. Also, there is 
an overload of QRect::contains() without the bool parameter, so no 
edge to worry about at all, so I don't really understand what the 
problem is.
(And if one wants to do operate on rects with borders, one can simply 
use QMargins together with QRect, e.g. QRect::marginsAdded()).


Cheers,
- Eirik Aa.


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating David Skoland as approver

[Daniel Smith]

+1

From: Development  On Behalf Of Morten 
Sørvig
Sent: Thursday, April 21, 2022 2:01 PM
To: development@qt-project.org
Subject: [Development] Nominating David Skoland as approver

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating David Skoland as approver

[Timur Pocheptsov]

+1.

Best regards,
 Timur.

From: Development  on behalf of Tor Arne 
Vestbø 
Sent: Thursday, April 21, 2022 2:20 PM
To: Morten Sørvig 
Cc: development@qt-project.org 
Subject: Re: [Development] Nominating David Skoland as approver

+1!

Disclaimer: I am David's line manager in The Qt Company.

Cheers,
Tor Arne

On 21 Apr 2022, at 14:00, Morten Sørvig 
mailto:morten.sor...@qt.io>> wrote:

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating David Skoland as approver

[Tor Arne Vestbø]

+1!

Disclaimer: I am David's line manager in The Qt Company.

Cheers,
Tor Arne

On 21 Apr 2022, at 14:00, Morten Sørvig 
mailto:morten.sor...@qt.io>> wrote:

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating David Skoland as approver

[Paul Wicking]

+1.


From: Development  on behalf of Morten 
Sørvig 
Sent: Thursday, April 21, 2022 14:00
To: development@qt-project.org
Subject: [Development] Nominating David Skoland as approver

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating David Skoland as approver

[Shawn Rutledge]

+1

On 2022 Apr 21, at 14:00, Morten Sørvig 
mailto:morten.sor...@qt.io>> wrote:

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

[Development] Nominating David Skoland as approver

[Morten Sørvig]

I'd like to nominate David Skoland as approver for the Qt Project.

David is employed by the Qt company has been contributing to Qt since late 
2020, with patches and reviews to several modules. He has recently shifted 
focus to work on Qt for WebAssembly, where he’s already made several good 
contributions and is currently taking on getting auto-tests running in the CI 
system.

I trust him to be a good approver.

https://codereview.qt-project.org/q/owner:david.skoland%2540qt.io
https://codereview.qt-project.org/q/reviewer:david.skoland%2540qt.io

Best Regards,
Morten Sørvig


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QRect::contains and undocumented(?) edge

[Eirik Aavitsland]

On 4/20/22 17:50, Tomi Pannila wrote:

Hi Lars and Eirik,


thank you for the explanations. I guess Eirik kind of guessed right that 
I view QRect from $\mathbb{R}^2$ point of view.
I'm a mathematician and this is the most natural point of view for me. 
For me, rectangles have edges=boundary which are measure zero.



But QRect is not a mathematical (cartesian) rectangle, instead it 
describes a chess board. If one asks anybody which squares are on the 
edge of the board, they will correctly point out row 1 and 8, and column 
A and H. That is exactly the meaning of "edge" in the doc of 
QRect::contains() - it is the everyday, intuitive and obvious meaning. 
So I don't see the problem with the current api, except for the 
anonymosity of the bool parameter, as Lars pointed out. Also, there is 
an overload of QRect::contains() without the bool parameter, so no edge 
to worry about at all, so I don't really understand what the problem is.
(And if one wants to do operate on rects with borders, one can simply 
use QMargins together with QRect, e.g. QRect::marginsAdded()).


Cheers,
- Eirik Aa.
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development