Re: [Development] Nominating Ahmad Samir for approver
On Monday, 11 September 2023 02:16:25 PDT Volker Hilsheimer via Development wrote: > Hello all, > > I would like to nominate Ahmad Samir for approver rights in the Qt project. > > For many months, Ahmad has produced a consistent flow of good contributions > and reviews to Qt: +1 from me -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering smime.p7s Description: S/MIME cryptographic signature -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating Ahmad Samir for approver
Volker Hilsheimer (11 September 2023 11:16) wrote: > I would like to nominate Ahmad Samir for approver rights in the Qt project. > > For many months, Ahmad has produced a consistent flow of good contributions > and reviews to Qt: Indeed, very much appreciated, Eddy. -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] On the use of the inline keyword
On 26.08.23 10:51, Volker Hilsheimer via Development wrote: > It seems to be a rare issue, triggered by specific circumstances. With the > knowledge that we have now, we can fix issues when they arise, and don’t have > to change all the problematic use right now. Yes, this email was to ensure people are aware of the issue and make fixing inline keyword use part of their drive-by fix toolbox, both for reviewing as well as authoring code. Since this seems to be about using such functions in other out-of-body inline functions, it should be limited to Qt code and there to the actual patch introducing such a use. Unless and until we get user bug reports about this, I don't think there's anything we need to do to existing code. But when we hit it, we should do the whole header, not just that one function. > That’s my understanding at least; I might be wrong, but we have been building > Qt for a few decades on MinGW without this constantly blocking us. Ack. Thanks, Marc -- Marc Mutz Principal Software Engineer The Qt Company Erich-Thilo-Str. 10 12489 Berlin, Germany www.qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating Ahmad Samir for approver
+1 -- Ivan Solovev Senior Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 12489 Berlin, Germany ivan.solo...@qt.io www.qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B From: Development on behalf of Mårten Nordheim via Development Sent: Monday, September 11, 2023 11:29 AM To: development@qt-project.org ; Volker Hilsheimer Subject: Re: [Development] Nominating Ahmad Samir for approver +1 Mårten From: Development on behalf of Volker Hilsheimer via Development Sent: Monday, September 11, 2023 11:16 To: development@qt-project.org Subject: [Development] Nominating Ahmad Samir for approver Hello all, I would like to nominate Ahmad Samir for approver rights in the Qt project. For many months, Ahmad has produced a consistent flow of good contributions and reviews to Qt: Changes owned: * https://codereview.qt-project.org/q/owner:a.samirh78%2540gmail.com Changes commented/voted on: * https://codereview.qt-project.org/q/commentby:a.samirh78%2540gmail.com+-owner:a.samirh78%2540gmail.com Cheers, Volker -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Changes to automatic cherry-picking
Hi all, I'll be going live today with these changes to the automatic cherry-pick processes. I'll be monitoring the systems for the next few days at least to catch any issues. If you experience any oddities or unexpected behavior, please contact me at daniel.sm...@qt.io directly with a report. Reminder: You do not need to change the way that you work, but the resulting cherry-picks from your footers will now be created in order of newest-to-oldest branches. This means that cherry-picks will now block the propagation of your change to older branches if a merge conflict exists in a cherry-pick or the pick fails to integrate, so please try to take action on cherry-picks with issues ASAP. Best regards, -Daniel From: Daniel Smith Sent: Friday, July 28, 2023 12:31 PM To: Tor Arne Vestbø Subject: Re: [Development] Changes to automatic cherry-picking > I would recommend skipping this new footer. There’s nothing preventing manual > cherry-picks, either locally via git, or via Gerrit’s UI, and doing those > manualy seems more appropriate anyways for the exception when a change needs > to be rushed into a branch. I think I ultimately agree with this. It would be ideal for even hotfixes to go into dev first, and then be manually picked if a faster turnaround is needed for an impending release. It's worth noting that it would still be best to specify all the intended pick targets in the Pick-to footer, even if one intends to pick some of them manually. The bot will simply ignore any targets that already exist (and are merged). In such cases where a pre-emptive pick is performed from an unmerged change on dev, we would need to accept that it won't be possible to reference a valid sha in the footer generated by cherry-pick -x. Gerrit would still show the correct relation in the UI, but the commit history would be a little less traceable. Perhaps for urgent issues in impending releases, a Fixes: footer referencing a P0 could be required in practice. -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating Ahmad Samir for approver
+1 Mårten From: Development on behalf of Volker Hilsheimer via Development Sent: Monday, September 11, 2023 11:16 To: development@qt-project.org Subject: [Development] Nominating Ahmad Samir for approver Hello all, I would like to nominate Ahmad Samir for approver rights in the Qt project. For many months, Ahmad has produced a consistent flow of good contributions and reviews to Qt: Changes owned: * https://codereview.qt-project.org/q/owner:a.samirh78%2540gmail.com Changes commented/voted on: * https://codereview.qt-project.org/q/commentby:a.samirh78%2540gmail.com+-owner:a.samirh78%2540gmail.com Cheers, Volker -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
[Development] Nominating Ahmad Samir for approver
Hello all, I would like to nominate Ahmad Samir for approver rights in the Qt project. For many months, Ahmad has produced a consistent flow of good contributions and reviews to Qt: Changes owned: * https://codereview.qt-project.org/q/owner:a.samirh78%2540gmail.com Changes commented/voted on: * https://codereview.qt-project.org/q/commentby:a.samirh78%2540gmail.com+-owner:a.samirh78%2540gmail.com Cheers, Volker -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
