Re: [Development] Please help me get my pending review count down
On Wed, Jul 29, 2015 at 11:47 AM, Marc Mutz marc.m...@kdab.com wrote: On Wednesday 29 July 2015 09:04:42 Martin Klapetek wrote: Can you perhaps create a single diff against 5.5/dev/master which could be easily applied? That should make things much easier to help :) Assuming you're talking about the dbus changes, wouldn't you actually want to cherry-pick them one by one and see which one breaks? Perhaps that should be done as well, yes, although Thiago requested the /whole set of changes/ to be tested: I need someone to take the whole set of changes, apply to their Qt 5.5 build and test KF5-powered applications to see what gets broken and why. Please provide patches to either QtDBus, KF5 or the applications. Which would be much simpler with a single diff. Cheers -- Martin Klapetek | KDE Developer ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Please help me get my pending review count down
Can you perhaps create a single diff against 5.5/dev/master which could be easily applied? That should make things much easier to help :) Cheers -- Martin Klapetek | KDE Developer ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt Quick Controls Calendar
: public QAbstractCalendarModel { ... }
It can still use the base QAbstractCalendarModel implementation for
it's grid stuff and re-implement the containsEvents property to be
filled with data from akonadi.
How would that be filled with data if it returns boolean? I mean, what do
you want to fill where? :)
Overall I like the real model backend, however I think your proposal also
could use definition of roles for the model and what would be returned
for
those roles (what comes to mind is single vs. multiple events in one day,
would it always return a list or a string in one case and list in other
case...etc).
The return for those roles is decided in the class re-implementing
QAbstractCalendarModel. In this case the akonadi implementation.
How that would look like is completely unknown right now. You can
however expect it to resemble the stuff i already made for my calendar
components ;)
Sure, but you need to define which roles is the subclass going to
reimplement and also define what those roles actually mean.
But i guess there is one class missing here.
The object it returns for events in a day must be known in
QAbstractCalendarModel thus a class has to be defined for that as
well.
Just on the top of my head i'd like to propose (probably very incomplete):
QAbstractCalendarData
{
public:
QVariant data(int col) { return QVariant(); }
}
That class is intended to used per calendar day where the class is the
wrapper around an event, journal item, holiday or todo item. So you
will very likely get multiple instances of that class per day. As much
as you have events/jour you get the point.
Why not simply return a list in the main QAbstractCalendarModel rather than
reimplementing a whole model? Sounds overly complicated...?
Cheers
--
Martin Klapetek | KDE Developer
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt Quick Controls Calendar
QAbstractCalendarModel implementation
that uses akonadi data. That would be a class like:
(K)AconadiCalendarModel : public QAbstractCalendarModel { ... }
It can still use the base QAbstractCalendarModel implementation for
it's grid stuff and re-implement the containsEvents property to be
filled with data from akonadi.
How would that be filled with data if it returns boolean? I mean, what do
you want to fill where? :)
Overall I like the real model backend, however I think your proposal also
could use definition of roles for the model and what would be returned for
those roles (what comes to mind is single vs. multiple events in one day,
would it always return a list or a string in one case and list in other
case...etc).
Cheers
--
Martin Klapetek | KDE Developer
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt Quick Controls Calendar
On Tue, Jan 7, 2014 at 1:43 PM, Mark Gaiser mark...@gmail.com wrote: Feedback.. Anyone? If there is no feedback this week then i'm going to assume that my proposal is probably the best way to go and start implementing it. It's actually kinda demotivating since i would expect the plasma folks to care, welcome it and have tons of feedback and suggestions which would benefit everyone involved. Note that the Plasma folks (those interested, anyway) have quite a lot on their plate already. It's mostly lack of time and (competent) people to blame. Kinda makes me feel sorry for Mitch for listening to me and posting this here. Mitch is going to the Plasma sprint and me and Sebas plan to spend some time with him on the calendars; I've also started looking at his code yesterday and already gave some feedback. I'll have a look at your ideas today and give some feedback as well. Cheers -- Martin Klapetek | KDE Developer ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt Quick Controls Calendar
On Fri, Dec 6, 2013 at 3:08 PM, Mark Gaiser mark...@gmail.com wrote: -- Locale -- In KDE there was already an issue with differences between the JavaScript date object and the QDate object. I don't know the fine details here, someone else will probably fill that in i hope. I know there where issues, just not what exactly. The problem is different values for same things - JS Date object numbers months from 0 to 11 whereas QDate's months are from 1 to 12. Same goes for days-in-the-week enum - JS Date starts at 0 = Sunday .. 6 = Saturday, while QDate has 1 = Monday .. 7 = Sunday. There might be more differences. So you cannot pass direct values between QML and C++ (like passing QDate::month() to JS), passing whole date objects should be fine afaik (eg. passing JS Date to a C++ function expecting QDate). Cheers -- Martin Klapetek | KDE Developer ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
