Re: [Development] Nominating Vlad Zahorodnii for approval status

2024-02-01 Thread Paul Tvete via Development
+1

- ​ Paul

From: Development  on behalf of David 
Edmundson 
Sent: Thursday, February 1, 2024 3:11 PM
To: development 
Subject: [Development] Nominating Vlad Zahorodnii for approval status

I would like to nominate Vlad Zahorodnii for approver rights in the Qt project.

Vlad has also been working on the QtWayland backend, providing insight
based on his other role as one of the kwin maintainers.
Vlad and I have been working together at Blue Systems for 5 years. He
is extremely technically competent and very thorough in reviews. I
trust that he would exercise approver rights responsibly.

Changes where he is the author:
https://codereview.qt-project.org/q/author:vlad.zahorodnii%2540kde.org
Changes where he commented/voted
https://codereview.qt-project.org/q/reviewer:vlad.zahorodnii%2540kde.org
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Nominating David Redondo for approval status

2024-02-01 Thread Paul Tvete via Development
+ 1

- ​Paul

From: Development  on behalf of David 
Edmundson 
Sent: Thursday, February 1, 2024 3:10 PM
To: development 
Subject: [Development] Nominating David Redondo for approval status

I would like to nominate David Redondo for approver rights in the Qt project.

David's first contributions to Qt started in November 2020, but has
ramped up this last year working on the Qt Wayland platform. Not only
has he fixed a lot of issues within Qt Wayland, but he has also
managed to push changes into upstream wayland and un-break a lot of
important Qt functionality.
David and I work together at Blue Systems for the last 4 years. I have
full confidence in his ability to review code correctly and also to
use any new privileges appropriately.

Changes where he is the author:
https://codereview.qt-project.org/q/author:qt%2540david-redondo.de
Changes where he commented/voted on:
https://codereview.qt-project.org/q/reviewer:qt%2540david-redondo.de

David
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


[Development] Nominating Matthias Rauter for approval status

2024-01-30 Thread Paul Tvete via Development
Hi,

I would like to nominate Matthias Rauter as an approver for the Qt Project.

Matthias has been working on Qt for more than a year now. In this time, he has 
done great work on Qt Location and Qt SVG, among other. I have had the pleasure 
to work with him on the Curve Rendering project in Qt Quick Shapes where he has 
made impressive contributions. He has been consistently professional in 
development and review, and I am certain that he will exercise his approver 
powers responsibly.

List of changes made by Matthias: 
https://codereview.qt-project.org/q/owner:matthias.rauter%2540qt.io
Matthias's review activity: 
https://codereview.qt-project.org/q/commentby:matthias.rauter%2540qt.io

Cheers,
 - Paul
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


[Development] Nominating Jonas Karlsson as maintainer for Qt Quick 3D Physics (and consequently for approver status)

2022-05-12 Thread Paul Tvete
Jonas has been working for the Qt Company since April 2020, and we somehow 
forgot to nominate him for approver status before now. He has been working on 
the Qt Quick 3D module, as part of the Oslo graphics team.

His current project has been to turn Andy Nichols's proof-of-concept physics 
module (based on the Bullet engine) into a proper Qt module (based on Nvidia 
PhysX): Qt Quick 3D Physics 
(https://codereview.qt-project.org/c/qt/qtquick3dphysics/+/410063). This module 
is planned to be released as a tech preview in Qt 6.4. The previous commit 
history can be found on https://git.qt.io/jokarlss/qtquick3dphysics
[https://git.qt.io/assets/gitlab_logo-7ae504fe4f68fdebb3c2034e36621930cd36ea87924c11ff65dbcb8ed50dca58.png]
Jonas Karlsson / QtQuick3DPhysics
GitLab Community Edition
git.qt.io



I therefore nominate Jonas as maintainer for Qt Quick 3D Physics. According to 
my interpretation of QUIP 2, this implies approver status, but to be on the 
safe side, I also explicitly nominate him as approver.

- Paul

(Not currently maintaining any modules, but since I still have maintainer 
status, I think I am able to nominate a maintainer)
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


[Development] Nominating Inho Lee as an approver

2020-10-28 Thread Paul Tvete
Hi all,

I would like to nominate Inho Lee as an approver for the Qt Project.

Inho has been working for the Qt Company for over a year now, and he has 
contributed extensively to Qt Quick 3D during this time.

Here is the list of his commits on Gerrit: 
https://codereview.qt-project.org/q/owner:inho.lee%2540qt.io

Disclaimer: I share an office with Inho, or at least did back when offices were 
a thing.

Best regards,

- Paul
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Updated high-DPI support for Qt 5.14

2019-09-16 Thread Paul Tvete
On Monday, 16 September 2019 15:21:38 CEST Florian Bruhin wrote:
> I guess with "in 2016" you mean the change this email is talking about:
> https://codereview.qt-project.org/c/qt/qtbase/+/176381
> 
> That commit was merged for Qt 5.14 a couple of weeks ago, not in 2016:

Oops! Yes, that's the change. Sorry for causing confusion.

- Paul



___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Updated high-DPI support for Qt 5.14

2019-09-16 Thread Paul Tvete
On Friday, 13 September 2019 17:14:32 CEST Thiago Macieira wrote:

> What happened to QT_AUTO_SCREEN_SCALE_FACTOR and QT_SCREEN_SCALE_FACTORS?

QT_AUTO_SCREEN_SCALE_FACTOR was deprecated in 2016. The recommended 
replacement is QT_ENABLE_HIGHDPI_SCALING. 

It looks like QT_SCREEN_SCALE_FACTORS was briefly broken, but I see there was 
a fix by David Faure that was merged last week: 
https://codereview.qt-project.org/c/qt/qtbase/+/273182

- Paul


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] HEADS-UP: QStringLiteral

2019-08-28 Thread Paul Tvete
On Wednesday, 28 August 2019 07:21:06 CEST Thiago Macieira wrote:
> Anyway, doing a memory wipe. Aside from ISO-8859-1, I don't want to think of
> any of the others for another 15 years.

I apologize deeply, but I cannot resist the temptation to share the diagram of 
Japanese character encodings from Wikipedia: https://en.wikipedia.org/wiki/
Shift_JIS#/media/File:JIS_and_Shift-JIS_variants.svg

- Paul


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Nominating David Edmundson as approver

2019-08-23 Thread Paul Tvete
On Friday, 23 August 2019 14:15:59 CEST Johan Helsing wrote:
> I'd like to nominate David Edmundson as approver for the Qt Project.

+1

Consistently good contributions. I guess I just assumed he was already an 
approver :)

- Paul


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Nominating Kavindra Palaraja for approvership

2019-07-15 Thread Paul Tvete
On Thursday, 11 July 2019 17:27:29 CEST Paul Wicking wrote:
> I’d like to nominate Kavindra Palaraja as approver.

+1

- Paul



___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Proposal: New branch model

2019-01-25 Thread Paul Tvete
On Friday, 25 January 2019 09:05:45 CET Lars Knoll wrote:
> * I think it makes the life of casual/new contributors easier. Simply always
> develop and push against the development branch. The more experienced
> reviewer can then easily decide that the fix should be cherry-picked into a
> stable branch.

This could also be accomplished by moving the change to the correct branch in 
gerrit as part of the review process.

Currently, only the owner can ask the bot to move the change, but since this 
is our bot I assume that we can change that policy.

- Paul


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Qt 5.13 feature freeze is getting closer

2019-01-17 Thread Paul Tvete
On Thursday, 17 January 2019 15:11:13 CET Edward Welbourne wrote:
>Tuukka Turunen (17 January 2019 15:00)
>> I think best would be to do the API review in codereview tool 

> As I suspect you're thinking of the API reviews I create in the run-up
> to a release, I feel obliged to point out these are really API *change*
> reviews.

I suspect that Tuukka did mean an actual code review, and not the header-diff-
sanity-check, but he can speak for himself. 

I'm taking the opportunity to yet again point out that the term "API review" 
has a long history inside and outside of the Qt Project, and we need another 
name for the just-before-release check. This misunderstanding shows that the 
risk of miscommunication is not merely theoretical.

- Paul (aka. Cato the Elder)


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


[Development] Nominating Johan Helsing for Approver status

2016-08-04 Thread Paul Tvete
Hi all,


I'd like to nominate Johan Helsing for Approver status. He joined The Qt 
Company half a year ago, and has been working full time on Qt since. Johan has 
been actively involved in making the QtWaylandCompositor module ready for Qt 
5.8, as well as doing a major part of the bug fixes for Qt Wayland in 5.6 and 
5.7.

Here is his gerrit dashboard:

https://codereview.qt-project.org/#/q/owner:%22Johan+Helsing%22,n,z

Johan's list of reviews can be found at:

https://codereview.qt-project.org/#/q/reviewer:%22Johan+Helsing+%253Cjohan.helsing%2540theqtcompany.com%253E%22,p,003e6e7d0002807d

Cheers,

- Paul


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development