Re: [Development] Having a reserved value for the platform enums was RE: Binary incompatible changes to Qt 4.8
On 5/24/12 1:31 PM, ext Shaw Andy andy.s...@digia.com wrote: [snip] The warning needs to go away, at least, provided that Qt *is* tested on Windows 8. Whether we add the enum or not, that's a bit orthogonal. Yes, the warning needs to be fixed. But I don't have any problems with adding the new enum in a patch level release. The only thing it can break is that your code won't compile against 4.8.1 anymore if you use it. This is really one of these cases where we should make a small exception to our rule of not adding any API to a patch level release. Please go ahead and back port the change to 4.8. Since this could easily be a problem again in the future should we consider having a reserved value for the Windows and Mac platform version enums? That way should it be decided that we want to add support for a new version of a platform in a maintenance release we could easily utilize the reserved one and then bump up the reserved one in the next minor release. I don't think that really changes anything. In this case I think simply adding new ones when required is ok. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Having a reserved value for the platform enums was RE: Binary incompatible changes to Qt 4.8
On quinta-feira, 24 de maio de 2012 11.31.19, Shaw Andy wrote: Since this could easily be a problem again in the future should we consider having a reserved value for the Windows and Mac platform version enums? That way should it be decided that we want to add support for a new version of a platform in a maintenance release we could easily utilize the reserved one and then bump up the reserved one in the next minor release. We don't know what the next version is going to be, at least its marketing name. Windows 7 and 8, despite the names, are still Windows 6.x, which is the Vista kernel. We could add the Mac OS X 10.9 macro, but not its cat name because we don't know which one it will be. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center Intel Sweden AB - Registration Number: 556189-6027 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Having a reserved value for the platform enums was RE: Binary incompatible changes to Qt 4.8
[snip] The warning needs to go away, at least, provided that Qt *is* tested on Windows 8. Whether we add the enum or not, that's a bit orthogonal. Yes, the warning needs to be fixed. But I don't have any problems with adding the new enum in a patch level release. The only thing it can break is that your code won't compile against 4.8.1 anymore if you use it. This is really one of these cases where we should make a small exception to our rule of not adding any API to a patch level release. Please go ahead and back port the change to 4.8. Since this could easily be a problem again in the future should we consider having a reserved value for the Windows and Mac platform version enums? That way should it be decided that we want to add support for a new version of a platform in a maintenance release we could easily utilize the reserved one and then bump up the reserved one in the next minor release. Andy ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
