Re: [Development] Neat feature in gerrit: drafts

[Tobias Hunger]

Hi Edward,

Am 10.11.2016 17:18 schrieb "Edward Welbourne" :
>
> A review puzzled several of us today by (apparently) starting at patch
> set 6.  Jesus had discovered a gerrit feature we hadn't heard of:
> drafts.  If you push to refs/drafts/blah instead of refs/for/blah, you
> get a review on gerrit with much of the effect we normally achieve using
> WIP but without the sanity-bot's complaint about WIP and without the
> buttons that would allow staging.  Folk can comment on it, they just
> can't actually accept it yet.  Later you can push to refs/for/blah as
> usual and the review turns into a real review.  Further pushes to
> refs/drafts/blah will be added as later patch sets without spamming
> those watching the review, while being visible to anyone actually
> looking at it; and you can delete drafts from the history once all they
> are is clutter.  There's probably more fun I've yet to learn.
>
> This seemed worth publicizing; so now you all know :-)

Qt Creator supports drafts, too.

You can also push a draft over an existing patch set in review. That draft
can then be discussed and "published" to become a "real" patch in the patch
set.

Best Regards,
Tobias
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Neat feature in gerrit: drafts

[Sergio Ahumada]

On 10.11.2016 17:20, Konstantin Tokarev wrote:



10.11.2016, 19:18, "Edward Welbourne" :

A review puzzled several of us today by (apparently) starting at patch
set 6. Jesus had discovered a gerrit feature we hadn't heard of:
drafts.


FYI, it was around for ages, since 2.3 release


git-gpush has it since 2014

https://codereview.qt-project.org/88136


If you push to refs/drafts/blah instead of refs/for/blah, you
get a review on gerrit with much of the effect we normally achieve using
WIP but without the sanity-bot's complaint about WIP and without the
buttons that would allow staging. Folk can comment on it, they just
can't actually accept it yet. Later you can push to refs/for/blah as
usual and the review turns into a real review. Further pushes to
refs/drafts/blah will be added as later patch sets without spamming
those watching the review, while being visible to anyone actually
looking at it; and you can delete drafts from the history once all they
are is clutter. There's probably more fun I've yet to learn.

This seemed worth publicizing; so now you all know :-)

Eddy.



--
Sergio Ahumada
sahum...@texla.cl

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Neat feature in gerrit: drafts

[Konstantin Tokarev]

10.11.2016, 19:18, "Edward Welbourne" :
> A review puzzled several of us today by (apparently) starting at patch
> set 6. Jesus had discovered a gerrit feature we hadn't heard of:
> drafts.

FYI, it was around for ages, since 2.3 release

> If you push to refs/drafts/blah instead of refs/for/blah, you
> get a review on gerrit with much of the effect we normally achieve using
> WIP but without the sanity-bot's complaint about WIP and without the
> buttons that would allow staging. Folk can comment on it, they just
> can't actually accept it yet. Later you can push to refs/for/blah as
> usual and the review turns into a real review. Further pushes to
> refs/drafts/blah will be added as later patch sets without spamming
> those watching the review, while being visible to anyone actually
> looking at it; and you can delete drafts from the history once all they
> are is clutter. There's probably more fun I've yet to learn.
>
> This seemed worth publicizing; so now you all know :-)
>
> Eddy.
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Neat feature in gerrit: drafts

[Edward Welbourne]

A review puzzled several of us today by (apparently) starting at patch
set 6.  Jesus had discovered a gerrit feature we hadn't heard of:
drafts.  If you push to refs/drafts/blah instead of refs/for/blah, you
get a review on gerrit with much of the effect we normally achieve using
WIP but without the sanity-bot's complaint about WIP and without the
buttons that would allow staging.  Folk can comment on it, they just
can't actually accept it yet.  Later you can push to refs/for/blah as
usual and the review turns into a real review.  Further pushes to
refs/drafts/blah will be added as later patch sets without spamming
those watching the review, while being visible to anyone actually
looking at it; and you can delete drafts from the history once all they
are is clutter.  There's probably more fun I've yet to learn.

This seemed worth publicizing; so now you all know :-)

Eddy.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development