Re: [Development] Q_WS_* used in Qt sources
On Wednesday 12 March 2014 10:57:19 Thiago Macieira wrote: Em qua 12 mar 2014, às 18:46:15, Martin Koller escreveu: For me the code porting looks a bit unfinished due to this Q_WS artefacts, so I just fear that problems arise. It's possible. Yes, there are still probably some regressions from 4.x left after the QPA rewrite of the Qt internals. However, the fact that we have not cleaned up all the #ifdefs yet is not an indication of that. In Qt4 times, QPA was one of several platforms. At that time we kept the old Q_WS_* code alive while creating the QPA plugins. We could not remove the old #ifdefs then, even after implementing the corresponding functionality in QPA. The fact that we have not removed all the old dead code afterwards is mainly an indication of how much time we have to fix P2 and P3 tasks: it mainly happens when someone is working on the relevant part of the code anyway. - Paul ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Q_WS_* used in Qt sources
On Thursday 13 March 2014 10:57:38 Paul Olav Tvete wrote: On Wednesday 12 March 2014 10:57:19 Thiago Macieira wrote: Em qua 12 mar 2014, às 18:46:15, Martin Koller escreveu: For me the code porting looks a bit unfinished due to this Q_WS artefacts, so I just fear that problems arise. It's possible. Yes, there are still probably some regressions from 4.x left after the QPA rewrite of the Qt internals. However, the fact that we have not cleaned up all the #ifdefs yet is not an indication of that. In Qt4 times, QPA was one of several platforms. At that time we kept the old Q_WS_* code alive while creating the QPA plugins. We could not remove the old #ifdefs then, even after implementing the corresponding functionality in QPA. The fact that we have not removed all the old dead code afterwards is mainly an indication of how much time we have to fix P2 and P3 tasks: it mainly happens when someone is working on the relevant part of the code anyway. Thanks for the explanation. It's very welcome! -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Q_WS_* used in Qt sources
I find a lot #ifdef Q_WS_* code in Qt sources (widgets). AFAIK Q_WS_ is no longer defined due to QPA. Is this something which has not been ported over to Q_OS_ and/or to QPA and do I need to expect problems (missing functionality) when I port my app from Qt4 to Qt5 ? -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Q_WS_* used in Qt sources
Em qua 12 mar 2014, às 12:23:33, Martin Koller escreveu: I find a lot #ifdef Q_WS_* code in Qt sources (widgets). AFAIK Q_WS_ is no longer defined due to QPA. Is this something which has not been ported over to Q_OS_ and/or to QPA and do I need to expect problems (missing functionality) when I port my app from Qt4 to Qt5 ? The functionality is completely gone. The selection of the windowing system is now a runtime decision. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Q_WS_* used in Qt sources
On Wednesday, 2014-03-12, 08:10:18, Thiago Macieira wrote: Em qua 12 mar 2014, às 12:23:33, Martin Koller escreveu: I find a lot #ifdef Q_WS_* code in Qt sources (widgets). AFAIK Q_WS_ is no longer defined due to QPA. Is this something which has not been ported over to Q_OS_ and/or to QPA and do I need to expect problems (missing functionality) when I port my app from Qt4 to Qt5 ? The functionality is completely gone. The selection of the windowing system is now a runtime decision. I think there might still be some integration hooks that haven't been fully ported yet. Like the QSystemTrayIcon code that Martin Gräßlin only recently refactored. Cheers, Kevin -- Qt Developer Days 2014, October 6 - 8 at BCC, Berlin. Save the dates! Kevin Krammer | kevin.kram...@kdab.com | Senior Software Engineer Klarälvdalens Datakonsult AB, a KDAB Group company Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - Qt Experts - Platform-independent software solutions smime.p7s Description: S/MIME cryptographic signature ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Q_WS_* used in Qt sources
On Wednesday 12 March 2014 08:10:18 Thiago Macieira wrote: Em qua 12 mar 2014, às 12:23:33, Martin Koller escreveu: I find a lot #ifdef Q_WS_* code in Qt sources (widgets). AFAIK Q_WS_ is no longer defined due to QPA. Is this something which has not been ported over to Q_OS_ and/or to QPA and do I need to expect problems (missing functionality) when I port my app from Qt4 to Qt5 ? The functionality is completely gone. The selection of the windowing system is now a runtime decision. I know. This is what I wrote as AFAIK Q_WS_ is no longer defined due to QPA. Still my question remains: do I need to expect problems (missing functionality) ? For me the code porting looks a bit unfinished due to this Q_WS artefacts, so I just fear that problems arise. -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html e-mail /\- against proprietary attachments Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Q_WS_* used in Qt sources
Em qua 12 mar 2014, às 18:46:15, Martin Koller escreveu: On Wednesday 12 March 2014 08:10:18 Thiago Macieira wrote: Em qua 12 mar 2014, às 12:23:33, Martin Koller escreveu: I find a lot #ifdef Q_WS_* code in Qt sources (widgets). AFAIK Q_WS_ is no longer defined due to QPA. Is this something which has not been ported over to Q_OS_ and/or to QPA and do I need to expect problems (missing functionality) when I port my app from Qt4 to Qt5 ? The functionality is completely gone. The selection of the windowing system is now a runtime decision. I know. This is what I wrote as AFAIK Q_WS_ is no longer defined due to QPA. Still my question remains: do I need to expect problems (missing functionality) ? I think that the last remaining part (the system tray) was ported in Qt 5.3. Therefore, all the functionality is (supposed to be) now present. For me the code porting looks a bit unfinished due to this Q_WS artefacts, so I just fear that problems arise. It's possible. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
