Re: [Development] Qt5 release integration build
On 12/10/2013 08:18 PM, Kurt Pattyn wrote: Thanks for the info. Is there a target date for 5.2.1? I want to give a helping hand, but how can this be coordinated so that no two people are fixing the same warnings? I don't think that you'll have that problem! :D Regards, Kurt On 10 Dec 2013, at 20:13, Liang Qi cavendish...@gmail.com mailto:cavendish...@gmail.com wrote: Those changes happened in stable branch, it means they will be part of 5.2.1, then doesn't block 5.2.0 final release. Anyway, patches are welcome! Regards, Liang On 10 December 2013 20:06, Kurt Pattyn pattyn.k...@gmail.com mailto:pattyn.k...@gmail.com wrote: I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). Cheers, Kurt On 10 Dec 2013, at 17:30, Mitch Curtis mitch.cur...@digia.com mailto:mitch.cur...@digia.com wrote: https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https://codereview.qt-project.org/#q,owner:Friedemann.Kleint%2540digia.com+message:warnings,n,z or Git: git submodule foreach git log | grep warning ||: Patches are welcome. :) On 12/10/2013 11:40 AM, Kurt Pattyn wrote: Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.txt.gz), contains the following warnings: ... Cheers, Kurt -- http://www.qiliang.net http://www.qiliang.net/ ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
Hi, I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). The libraries and examples should be fairly clean; we keep an eye on it (MSVC2012 or MinGW64, typically). Fixing all warnings in the tests is a different matter. Warnings there are not that critical and things like 'unsafe std::copy()' or similar can be safely be ignored there. Talking about tests: The test .pro-files still have a lot of DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0 . Getting rid of those (unless the test actually tests deprecated API) is IMO more important than fixing other warnings since that is going to hit us at some point (in Qt 6 at the very latest). The usual technique for fixing warnings is to push one change per warning type for easier review (for example, fix all signed/unsigned comparisons in one change). Regards, Friedemann -- Friedemann Kleint Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
On quarta-feira, 11 de dezembro de 2013 13:30:15, Friedemann Kleint wrote: The usual technique for fixing warnings is to push one change per warning type for easier review (for example, fix all signed/unsigned comparisons in one change). If it's not obvious what the warning you're fixing is or what the compiler meant, paste one example of the warning in the commit message. I do it for all commits, unless I'm being lazy. :-) PS: don't wrap the compiler output. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https://codereview.qt-project.org/#q,owner:Friedemann.Kleint%2540digia.com+message:warnings,n,z or Git: git submodule foreach git log | grep warning ||: Patches are welcome. :) On 12/10/2013 11:40 AM, Kurt Pattyn wrote: Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.txt.gz), contains the following warnings: warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. And a lot more of these ‘unsafe’ warnings, probably harmless. I think the following ones needs more attention: warning C4018: '' : signed/unsigned mismatch warning C4146: unary minus operator applied to unsigned type, result still unsigned warning C4305: 'argument' : truncation from 'double' to 'float' warning C4138: '*/' found outside of comment Command line warning D9025 : overriding '/Zm200' with '/Zm500' warning C4996: 'putenv': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _putenv. See online help for details. warning C4189: 'eventDispatcher' : local variable is initialized but not referenced testqrc\test.qrc: Warning: potential duplicate alias detected: 'aliasdir.txt' warning C4341: 'EnumTest_Enum1_bigValue' : signed value is out of range for enum constant warning C4309: 'initializing' : truncation of constant value warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow) warning C4996: 'FunctionWithAttributes::test2': was declared deprecated warning C4723: potential divide by 0 warning C4005: 'M_E' : macro redefinition warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc warning C4307: '*' : integral constant overflow warning D9002 : ignoring unknown option '-g' warning C4995: 'UnknownBaud': name was marked as #pragma deprecated warning C4244: 'function' : conversion from 'uint64' to 'size_t', possible loss of data warning C4345: behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized Cheers, Kurt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). Cheers, Kurt On 10 Dec 2013, at 17:30, Mitch Curtis mitch.cur...@digia.com wrote: https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https://codereview.qt-project.org/#q,owner:Friedemann.Kleint%2540digia.com+message:warnings,n,z or Git: git submodule foreach git log | grep warning ||: Patches are welcome. :) On 12/10/2013 11:40 AM, Kurt Pattyn wrote: Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.txt.gz), contains the following warnings: warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. And a lot more of these ‘unsafe’ warnings, probably harmless. I think the following ones needs more attention: warning C4018: '' : signed/unsigned mismatch warning C4146: unary minus operator applied to unsigned type, result still unsigned warning C4305: 'argument' : truncation from 'double' to 'float' warning C4138: '*/' found outside of comment Command line warning D9025 : overriding '/Zm200' with '/Zm500' warning C4996: 'putenv': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _putenv. See online help for details. warning C4189: 'eventDispatcher' : local variable is initialized but not referenced testqrc\test.qrc: Warning: potential duplicate alias detected: 'aliasdir.txt' warning C4341: 'EnumTest_Enum1_bigValue' : signed value is out of range for enum constant warning C4309: 'initializing' : truncation of constant value warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow) warning C4996: 'FunctionWithAttributes::test2': was declared deprecated warning C4723: potential divide by 0 warning C4005: 'M_E' : macro redefinition warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc warning C4307: '*' : integral constant overflow warning D9002 : ignoring unknown option '-g' warning C4995: 'UnknownBaud': name was marked as #pragma deprecated warning C4244: 'function' : conversion from 'uint64' to 'size_t', possible loss of data warning C4345: behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized Cheers, Kurt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
Those changes happened in stable branch, it means they will be part of 5.2.1, then doesn't block 5.2.0 final release. Anyway, patches are welcome! Regards, Liang On 10 December 2013 20:06, Kurt Pattyn pattyn.k...@gmail.com wrote: I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). Cheers, Kurt On 10 Dec 2013, at 17:30, Mitch Curtis mitch.cur...@digia.com wrote: https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https://codereview.qt-project.org/#q,owner:Friedemann.Kleint%2540digia.com+message:warnings,n,z or Git: git submodule foreach git log | grep warning ||: Patches are welcome. :) On 12/10/2013 11:40 AM, Kurt Pattyn wrote: Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.txt.gz ), contains the following warnings: ... Cheers, Kurt -- http://www.qiliang.net ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
Thanks for the info. Is there a target date for 5.2.1? I want to give a helping hand, but how can this be coordinated so that no two people are fixing the same warnings? Regards, Kurt On 10 Dec 2013, at 20:13, Liang Qi cavendish...@gmail.com wrote: Those changes happened in stable branch, it means they will be part of 5.2.1, then doesn't block 5.2.0 final release. Anyway, patches are welcome! Regards, Liang On 10 December 2013 20:06, Kurt Pattyn pattyn.k...@gmail.com wrote: I suppose that the warnings in the list beneath are still unsolved. Is that correct? How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). Cheers, Kurt On 10 Dec 2013, at 17:30, Mitch Curtis mitch.cur...@digia.com wrote: https://codereview.qt-project.org/#change,65936 https://codereview.qt-project.org/#change,66052 https://codereview.qt-project.org/#change,66018 https://codereview.qt-project.org/#change,66061 https://codereview.qt-project.org/#change,66041 You can see more by searching through gerrit. E.g.: https://codereview.qt-project.org/#q,owner:Friedemann.Kleint%2540digia.com+message:warnings,n,z or Git: git submodule foreach git log | grep warning ||: Patches are welcome. :) On 12/10/2013 11:40 AM, Kurt Pattyn wrote: Hi, is anybody aware of the many warnings of Qt5 release build for Windows? For instance the build win32-msvc2010_developer-build_qtnamespace_Windows_7 (build log: http://testresults.qt-project.org/ci/Qt5_release_Integration/build_00286/win32-msvc2010_developer-build_qtnamespace_Windows_7/log.txt.gz), contains the following warnings: ... Cheers, Kurt -- http://www.qiliang.net ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
On terça-feira, 10 de dezembro de 2013 20:18:11, Kurt Pattyn wrote: Thanks for the info. Is there a target date for 5.2.1? See the minutes for yesterday's release team meeting. It's going to be either January of February, depending on the timing of Qt 4.8.6. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt5 release integration build
On terça-feira, 10 de dezembro de 2013 20:06:24, Kurt Pattyn wrote: How critical is it to solve those warnings? If they are critical for the release, I want to give a helping hand to remove them (after all there are more than 900, the list below is a synopsis). MSVC warnings are not critical. No one can compile MSVC code with /WX because the Microsoft headers fail that check. Still, fixing the warnings would be nice. I'd give them a P2 priority. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
