Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Adel Atallah
I've created a Jira issue, I would appreciate to have some feedback or
changes if needed: https://jira.xwiki.org/browse/XWIKI-15582

Thanks,
Adel


On Fri, Sep 7, 2018 at 3:02 PM, Thomas Mortagne
 wrote:
> On Thu, Sep 6, 2018 at 2:58 PM Adel Atallah  wrote:
>>
>> Hi devs,
>>
>> Working on the auto-suggestion feature [1], I've been integrating it
>> in xproperties holding a reference to a page. Those xproperties are of
>> type String and have been changed to the Page type so that the page
>> displayer is used and shows the auto-suggestion when needed.
>
> Since we talk about new entity properties types and bring back the
> following subject: a pity the type is called "page" since it actually
> contain document reference and collide with the new page reference.
> But hard to change now...
>
> We'll need to introduce a new type which store serialized
> PageReference at some point since that's what most new xobjects should
> use ideally. But it can't be used for existing property which
> currently contain document references since the syntax is different.
>
> The best to avoid confusion with two different "page*" types names
> would probably be to have the PageClass have a type which could be:
> * document (set to existing page properties with a migration)
> * page (the default)
> * space ?
>
> BaseClass#addPageField hasn't been released yet (@since 10.8RC1) so
> it's the right time, later we would have to keep "document" as the
> default in it which would not be very elegant since we want people to
> use page reference in the future as much as possible.
>
>>
>> I now need to implement an auto-suggestion on xproperties holding a
>> reference to a space (e.g [2]), a wiki (e.g [2]) and an attachment
>> (e.g. [3]).
>> I think the best would be to create an Attachment and Wiki xproperty
>> type and create new displayers exactly like the Page type.
>>
>> I don't think we can create a Space xproperty because it's not meant
>> to be visible by the end user.
>> Maybe we could use the Page xproperty type and have a parameter inside
>> to select only spaces.
>>
>> WDYT?
>>
>> Thanks,
>> Adel
>>
>> 
>> [1] https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference
>> [2] 
>> https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference#HClass:XWiki.WatchListClass
>> [3] 
>> https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference#HClass:XWiki.XWikiUsers
>
>
>
> --
> Thomas Mortagne


Re: [xwiki-devs] [XWiki Day] BFD#187

2018-09-07 Thread Vincent Massol
That was a nice BFD, well done everyone: 13 bugs closed

Let’s do the same next week! 
Thanks
-Vincent

> On 7 Sep 2018, at 16:04, Alex Cotiugă  wrote:
> 
> Results: https://www.xwiki.org/xwiki/bin/view/Blog/Bug%20Fixing%20Day%20187
> 
> Thanks,
> Alex
> 
> On Thu, Sep 6, 2018 at 8:37 AM, Alex Cotiugă 
> wrote:
> 
>> Hello devs,
>> 
>> This Thursday is BFD#187:
>> http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday
>> 
>> 
>> Our current status is:
>> * -54 bugs over 120 days (4 months), i.e. we need to close 54 bugs to have
>> created bugs # = closed bugs #
>> * -116 bugs over 365 days (1 year)
>> * -157 bugs over 500 days (between 1 and 2 years)
>> * -371 bugs over 1600 days (4.3 years)
>> 
>> See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352
>> 
>> Here's the BFD#187 dashboard to follow the progress during the day:
>> https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14317
>> 
>> Happy Bug Fixing Day,
>> Alex
>> 
>> 
>> 



Re: [xwiki-devs] [XWiki Day] BFD#187

2018-09-07 Thread Alex Cotiugă
Results: https://www.xwiki.org/xwiki/bin/view/Blog/Bug%20Fixing%20Day%20187

Thanks,
Alex

On Thu, Sep 6, 2018 at 8:37 AM, Alex Cotiugă 
wrote:

> Hello devs,
>
> This Thursday is BFD#187:
> http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday
> 
>
> Our current status is:
> * -54 bugs over 120 days (4 months), i.e. we need to close 54 bugs to have
> created bugs # = closed bugs #
> * -116 bugs over 365 days (1 year)
> * -157 bugs over 500 days (between 1 and 2 years)
> * -371 bugs over 1600 days (4.3 years)
>
> See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352
>
> Here's the BFD#187 dashboard to follow the progress during the day:
> https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14317
>
> Happy Bug Fixing Day,
> Alex
>
>
>


Re: [xwiki-devs] [Proposal] Strategy to Recommend/Unrecomend extensions on e.x.o

2018-09-07 Thread Thomas Mortagne
On Fri, Sep 7, 2018 at 2:37 PM Vincent Massol  wrote:
>
> Hi devs,
>
> Regarding Recommended extensions on e.x.o.
>
> What we don’t FTM is strategy for:
> * A) When do we review the list of recommended and move some out when they’re 
> no longer matching the recommended criteria
> * B) When do we review the list of not recommended and propose to move some 
> to recommended
>
> I guess for A) it could be when someone (community, committers) discovers 
> some important problems on the extension or if committers just notice it by 
> chance. In the future we could imagine having a “Unrecommend” button in the 
> UI to allow users to provide feedback as to why an extension should be 
> unrecommended.
>
> For B) it could the extension author proposing an extension to be recommended 
> (or committers noticing a good supported extension and asking the author(s) 
> if they’re willing to comply with the recommended rules).  In the future we 
> could imagine having a “Recommend” button in the UI to allow users to provide 
> feedback as to why an extension should be recommended.
>
> WDYT? Any better or others ideas?
>
> Thanks
> -Vincent
>

A) I think someone who think an extension should not be recommended
anymore should send a vote mail with the reasons.

B) -1 for the “Recommend” button. The most important criteria for
recommended extensions is to have an active maintainer and that
maintainer should be active enough to send a vote on the dev mailing
list to ask for the extension to become recommended IMO.

-- 
Thomas Mortagne


Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Thomas Mortagne
On Thu, Sep 6, 2018 at 2:58 PM Adel Atallah  wrote:
>
> Hi devs,
>
> Working on the auto-suggestion feature [1], I've been integrating it
> in xproperties holding a reference to a page. Those xproperties are of
> type String and have been changed to the Page type so that the page
> displayer is used and shows the auto-suggestion when needed.

Since we talk about new entity properties types and bring back the
following subject: a pity the type is called "page" since it actually
contain document reference and collide with the new page reference.
But hard to change now...

We'll need to introduce a new type which store serialized
PageReference at some point since that's what most new xobjects should
use ideally. But it can't be used for existing property which
currently contain document references since the syntax is different.

The best to avoid confusion with two different "page*" types names
would probably be to have the PageClass have a type which could be:
* document (set to existing page properties with a migration)
* page (the default)
* space ?

BaseClass#addPageField hasn't been released yet (@since 10.8RC1) so
it's the right time, later we would have to keep "document" as the
default in it which would not be very elegant since we want people to
use page reference in the future as much as possible.

>
> I now need to implement an auto-suggestion on xproperties holding a
> reference to a space (e.g [2]), a wiki (e.g [2]) and an attachment
> (e.g. [3]).
> I think the best would be to create an Attachment and Wiki xproperty
> type and create new displayers exactly like the Page type.
>
> I don't think we can create a Space xproperty because it's not meant
> to be visible by the end user.
> Maybe we could use the Page xproperty type and have a parameter inside
> to select only spaces.
>
> WDYT?
>
> Thanks,
> Adel
>
> 
> [1] https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference
> [2] 
> https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference#HClass:XWiki.WatchListClass
> [3] 
> https://design.xwiki.org/xwiki/bin/view/Proposal/AutocompleteOnReference#HClass:XWiki.XWikiUsers



-- 
Thomas Mortagne


[xwiki-devs] [Proposal] Strategy to Recommend/Unrecomend extensions on e.x.o

2018-09-07 Thread Vincent Massol
Hi devs,

Regarding Recommended extensions on e.x.o.

What we don’t FTM is strategy for:
* A) When do we review the list of recommended and move some out when they’re 
no longer matching the recommended criteria
* B) When do we review the list of not recommended and propose to move some to 
recommended

I guess for A) it could be when someone (community, committers) discovers some 
important problems on the extension or if committers just notice it by chance. 
In the future we could imagine having a “Unrecommend” button in the UI to allow 
users to provide feedback as to why an extension should be unrecommended.

For B) it could the extension author proposing an extension to be recommended 
(or committers noticing a good supported extension and asking the author(s) if 
they’re willing to comply with the recommended rules).  In the future we could 
imagine having a “Recommend” button in the UI to allow users to provide 
feedback as to why an extension should be recommended.

WDYT? Any better or others ideas?

Thanks
-Vincent



Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Marius Dumitru Florea
On Thu, Sep 6, 2018 at 3:57 PM, Adel Atallah  wrote:

> Hi devs,
>
> Working on the auto-suggestion feature [1], I've been integrating it
> in xproperties holding a reference to a page. Those xproperties are of
> type String and have been changed to the Page type so that the page
> displayer is used and shows the auto-suggestion when needed.
>
> I now need to implement an auto-suggestion on xproperties holding a
> reference to a space (e.g [2]), a wiki (e.g [2]) and an attachment
> (e.g. [3]).
>


> I think the best would be to create an Attachment and Wiki xproperty
> type and create new displayers exactly like the Page type.
>

+1


>
> I don't think we can create a Space xproperty because it's not meant
> to be visible by the end user.
>


> Maybe we could use the Page xproperty type and have a parameter inside
> to select only spaces.
>

+1, that's actually useful for enforcing the selection of non-terminal
pages. That's useful for instance when you want to select the location
where to create some pages: the selected page should not be terminal.

Thanks,
Marius


>
> WDYT?
>
> Thanks,
> Adel
>
> 
> [1] https://design.xwiki.org/xwiki/bin/view/Proposal/
> AutocompleteOnReference
> [2] https://design.xwiki.org/xwiki/bin/view/Proposal/
> AutocompleteOnReference#HClass:XWiki.WatchListClass
> [3] https://design.xwiki.org/xwiki/bin/view/Proposal/
> AutocompleteOnReference#HClass:XWiki.XWikiUsers
>