[xwiki-devs] BFD#194

[Oana-Lavinia Florean]

Hello devs,

This Thursday is BFD#194:
http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday

Our current status is:
* -66 bugs over 120 days (4 months), i.e. we need to close 66 bugs to have
created bugs == closed bugs
* -130 bugs over 365 days (1 year)
* -174 bugs over 500 days (between 1 and 2 years)
* -373 bugs over 1600 days (4.3 years)

See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352

Here's the BFD#194 dashboard to follow the progress during the day:
*https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=14332
*

Good luck at fixing bugs,
Lavinia

Re: [xwiki-devs] [Best Practice] Use lowercase for JIRA labels

[Thomas Mortagne]

+0
On Tue, Oct 23, 2018 at 6:54 AM Marius Dumitru Florea
 wrote:
>
> +0, I would have preferred camel case for composite names (like
> bugfixingday)
>
> On Mon, Oct 22, 2018 at 4:17 PM Vincent Massol  wrote:
>
> > Hi,
> >
> > I’d like to propose to use a consistent naming scheme for jira labels and
> > use lowercase (and fix all the upper case we can find).
> >
> > Ok for everyone?
> >
> > Thanks
> > -Vincent
> >
> >



-- 
Thomas Mortagne

Re: [xwiki-devs] What do we do with Watchlist and Activity Stream

[Thomas Mortagne]

What is this code about exactly ? If it's the kind of thing that make
the user profile take ages to load then it's a B for me, if not then A
is fine.
On Mon, Oct 22, 2018 at 3:14 PM Guillaume Delhumeau
 wrote:
>
> Hi.
>
> For 10.9RC1, my objective was to stop bundling the Activity Stream UI in
> the default flavor. Several months before, I did the same with the
> Watchlist. Now both of them are replaced by Notifications.
>
> Even if they are not bundled anymore by default, I have let the modules in
> the "platform" repository. The idea was to maintain them until 11.x is
> started (while we stabilize notifications), and to move them in "attic" at
> the beginning of next year.
>
> Recently, while removing Activity Stream calls in our wiki pages, I
> discovered some code in the User Profile that was handling both Activity
> Stream and the Watchlist. I removed it, since it was handling deprecated
> code. But maybe I should have not, since the modules are not moved into the
> "attic" repository yet. Anyway, it is not clean to have special code for AS
> and Watchlist in the User Profile module, we need to create a proper
> mechanism to inject code into the user profile (see:
> https://jira.xwiki.org/browse/XWIKI-12639).
>
> The removing of the code has broken some functional tests in the watchlist
> module, that were precisely testing this code. So now, we have several
> options:
>
> A - Put back the code I have removed, until Activity Stream UI and
> Watchlist are moved outside the "platform" repository. So the build would
> be fixed.
> B - Remove the failing functional test since it is testing a code we have
> been removed. So the build would be fixed.
> C - Put back the code I have removed, but inside the Watchlist module and
> injected into the User profile via a clean injection system (again:
> https://jira.xwiki.org/browse/XWIKI-12639). The build would be fixed but it
> requires more time to develop, and we risk to miss 10.9RC1.
>
> The release of 10.9RC1 is already late, so what do you think is the best
> option?
>
> Thanks,
>
> --
> Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
> Research & Development Engineer at XWiki SAS
> Committer on the XWiki.org project



-- 
Thomas Mortagne

Re: [xwiki-devs] [Proposal] Remove MenuIT that is not using Docker

[Vincent Massol]

> On 24 Oct 2018, at 12:14, Adel Atallah  wrote:
> 
> Hello Vincent,
> 
> I'd like to try the new tests on my machine if that's ok. I remember
> having some issues in the past.

sure, just do: "mvn clean install” inside 
https://github.com/xwiki/xwiki-platform/tree/b4432820f7c3f9e9c13d4767b514546daad77540/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-docker

What is good is that the test passes consistently on a4 in our CI (+ on my mac 
ofc). So at least, I know they can pass on unix and if there’s a problem it can 
probably be fixed at the computer level.

Thanks
-Vincent

> 
> Thanks,
> Adel
> 
> On Wed, Oct 24, 2018 at 12:11 PM Vincent Massol  wrote:
>> 
>> Hi devs,
>> 
>> Now that the docker-based MenuIT test is working and passing in our CI, I’m 
>> proposing to remove the MenuIT version using the XWiki Maven Packager plugin.
>> 
>> More Precisely, replace:
>> 
>> https://github.com/xwiki/xwiki-platform/tree/ac542d169957d4315fc4eb9d7329a5d866e361cb/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-tests
>> 
>> by
>> 
>> https://github.com/xwiki/xwiki-platform/tree/b4432820f7c3f9e9c13d4767b514546daad77540/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-docker
>> 
>> Note that this means you need to have docker installed locally if you need 
>> to run the functional tests for the menu module.
>> 
>> Ok with everyone?
>> 
>> Thanks
>> -Vincent
>> 

Re: [xwiki-devs] [Proposal] Remove MenuIT that is not using Docker

[Adel Atallah]

Hello Vincent,

I'd like to try the new tests on my machine if that's ok. I remember
having some issues in the past.

Thanks,
Adel

On Wed, Oct 24, 2018 at 12:11 PM Vincent Massol  wrote:
>
> Hi devs,
>
> Now that the docker-based MenuIT test is working and passing in our CI, I’m 
> proposing to remove the MenuIT version using the XWiki Maven Packager plugin.
>
> More Precisely, replace:
>
> https://github.com/xwiki/xwiki-platform/tree/ac542d169957d4315fc4eb9d7329a5d866e361cb/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-tests
>
> by
>
> https://github.com/xwiki/xwiki-platform/tree/b4432820f7c3f9e9c13d4767b514546daad77540/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-docker
>
> Note that this means you need to have docker installed locally if you need to 
> run the functional tests for the menu module.
>
> Ok with everyone?
>
> Thanks
> -Vincent
>

[xwiki-devs] [Proposal] Remove MenuIT that is not using Docker

[Vincent Massol]

Hi devs,

Now that the docker-based MenuIT test is working and passing in our CI, I’m 
proposing to remove the MenuIT version using the XWiki Maven Packager plugin.

More Precisely, replace:

https://github.com/xwiki/xwiki-platform/tree/ac542d169957d4315fc4eb9d7329a5d866e361cb/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-tests

by

https://github.com/xwiki/xwiki-platform/tree/b4432820f7c3f9e9c13d4767b514546daad77540/xwiki-platform-core/xwiki-platform-menu/xwiki-platform-menu-test/xwiki-platform-menu-test-docker

Note that this means you need to have docker installed locally if you need to 
run the functional tests for the menu module.

Ok with everyone?

Thanks
-Vincent