Re: [xwiki-devs] [PROPOSAL] Stabilize filesystem templates rights

2016-10-06 Thread Sergiu Dumitriu 
+1 for 1.

On 10/05/2016 05:29 AM, Thomas Mortagne wrote:
> Hi devs,
> 
> Right now (and since forever) the default behavior for templates is to
> be executed with the right of the current document content author
> (it's not really explicit, it's just how PR works when there is no
> sdoc). This means that unless you explicitly indicate an author for
> your template (possible since 7.x) you don't really have any idea
> which right it's going to have at runtime. It also make harder to
> properly execute templates outside of main rendering thread where the
> "current document" often don't really make much sense.
> 
> I think we should make the default more stable.
> 
> I can think of two possibilities:
> 
> 1) with what we got right now the only real possibility is to execute
> the filesystem template with superadmin right (which is only an option
> right now). Makes it consistent with the "code is executed with the
> right of its author" rule we have for wiki pages
> 2) introduce some new virtual user (like "templateauthor" or
> "scripter" or whatever) which only have script right and use that as
> filesystem template author if we absolutely want template to not have
> too many rights by default (even if modifying a filesystem template
> require much more access than superadmin in practice)
> 
> +1 for 1)
> 


-- 
Sergiu Dumitriu
http://purl.org/net/sergiu
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [PROPOSAL] Stabilize filesystem templates rights

2016-10-06 Thread Guillaume Delhumeau 
+1 for 1)

2016-10-06 17:19 GMT+02:00 Thomas Mortagne :

> On Thu, Oct 6, 2016 at 5:16 PM, Ecaterina Moraru (Valica)
>  wrote:
> > I don't really understand what this is about, but aren't all the
> templates
> > overriddeble from the Skin?
>
> Forget about wiki templates for now. I'm only talking about the rights
> filesystem templates should have here :)
>
> > Anyway, I wouldn't want to have an additional virtual user.
> >
> > Thanks,
> > Caty
> >
> > On Wed, Oct 5, 2016 at 7:03 PM, Eduard Moraru 
> wrote:
> >
> >> +1 for 1), with the reminder that filesystem templates are considered
> to be
> >> managed/authored by the superadmin, while Skin template overrides will
> be
> >> managed/authored by the Skin document's author, so overriding a template
> >> from a skin will not give you superadmin author rights.
> >>
> >> Thanks,
> >> Eduard
> >>
> >> On Wed, Oct 5, 2016 at 12:29 PM, Thomas Mortagne <
> >> thomas.morta...@xwiki.com>
> >> wrote:
> >>
> >> > Hi devs,
> >> >
> >> > Right now (and since forever) the default behavior for templates is to
> >> > be executed with the right of the current document content author
> >> > (it's not really explicit, it's just how PR works when there is no
> >> > sdoc). This means that unless you explicitly indicate an author for
> >> > your template (possible since 7.x) you don't really have any idea
> >> > which right it's going to have at runtime. It also make harder to
> >> > properly execute templates outside of main rendering thread where the
> >> > "current document" often don't really make much sense.
> >> >
> >> > I think we should make the default more stable.
> >> >
> >> > I can think of two possibilities:
> >> >
> >> > 1) with what we got right now the only real possibility is to execute
> >> > the filesystem template with superadmin right (which is only an option
> >> > right now). Makes it consistent with the "code is executed with the
> >> > right of its author" rule we have for wiki pages
> >> > 2) introduce some new virtual user (like "templateauthor" or
> >> > "scripter" or whatever) which only have script right and use that as
> >> > filesystem template author if we absolutely want template to not have
> >> > too many rights by default (even if modifying a filesystem template
> >> > require much more access than superadmin in practice)
> >> >
> >> > +1 for 1)
> >> >
> >> > --
> >> > Thomas Mortagne
> >> > ___
> >> > devs mailing list
> >> > devs@xwiki.org
> >> > http://lists.xwiki.org/mailman/listinfo/devs
> >> >
> >> ___
> >> devs mailing list
> >> devs@xwiki.org
> >> http://lists.xwiki.org/mailman/listinfo/devs
> >>
> > ___
> > devs mailing list
> > devs@xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>



-- 
Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [PROPOSAL] Stabilize filesystem templates rights

2016-10-06 Thread Ecaterina Moraru (Valica) 
I don't really understand what this is about, but aren't all the templates
overriddeble from the Skin?
Anyway, I wouldn't want to have an additional virtual user.

Thanks,
Caty

On Wed, Oct 5, 2016 at 7:03 PM, Eduard Moraru  wrote:

> +1 for 1), with the reminder that filesystem templates are considered to be
> managed/authored by the superadmin, while Skin template overrides will be
> managed/authored by the Skin document's author, so overriding a template
> from a skin will not give you superadmin author rights.
>
> Thanks,
> Eduard
>
> On Wed, Oct 5, 2016 at 12:29 PM, Thomas Mortagne <
> thomas.morta...@xwiki.com>
> wrote:
>
> > Hi devs,
> >
> > Right now (and since forever) the default behavior for templates is to
> > be executed with the right of the current document content author
> > (it's not really explicit, it's just how PR works when there is no
> > sdoc). This means that unless you explicitly indicate an author for
> > your template (possible since 7.x) you don't really have any idea
> > which right it's going to have at runtime. It also make harder to
> > properly execute templates outside of main rendering thread where the
> > "current document" often don't really make much sense.
> >
> > I think we should make the default more stable.
> >
> > I can think of two possibilities:
> >
> > 1) with what we got right now the only real possibility is to execute
> > the filesystem template with superadmin right (which is only an option
> > right now). Makes it consistent with the "code is executed with the
> > right of its author" rule we have for wiki pages
> > 2) introduce some new virtual user (like "templateauthor" or
> > "scripter" or whatever) which only have script right and use that as
> > filesystem template author if we absolutely want template to not have
> > too many rights by default (even if modifying a filesystem template
> > require much more access than superadmin in practice)
> >
> > +1 for 1)
> >
> > --
> > Thomas Mortagne
> > ___
> > devs mailing list
> > devs@xwiki.org
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Re: [xwiki-devs] [PROPOSAL] Stabilize filesystem templates rights

2016-10-05 Thread Eduard Moraru 
+1 for 1), with the reminder that filesystem templates are considered to be
managed/authored by the superadmin, while Skin template overrides will be
managed/authored by the Skin document's author, so overriding a template
from a skin will not give you superadmin author rights.

Thanks,
Eduard

On Wed, Oct 5, 2016 at 12:29 PM, Thomas Mortagne 
wrote:

> Hi devs,
>
> Right now (and since forever) the default behavior for templates is to
> be executed with the right of the current document content author
> (it's not really explicit, it's just how PR works when there is no
> sdoc). This means that unless you explicitly indicate an author for
> your template (possible since 7.x) you don't really have any idea
> which right it's going to have at runtime. It also make harder to
> properly execute templates outside of main rendering thread where the
> "current document" often don't really make much sense.
>
> I think we should make the default more stable.
>
> I can think of two possibilities:
>
> 1) with what we got right now the only real possibility is to execute
> the filesystem template with superadmin right (which is only an option
> right now). Makes it consistent with the "code is executed with the
> right of its author" rule we have for wiki pages
> 2) introduce some new virtual user (like "templateauthor" or
> "scripter" or whatever) which only have script right and use that as
> filesystem template author if we absolutely want template to not have
> too many rights by default (even if modifying a filesystem template
> require much more access than superadmin in practice)
>
> +1 for 1)
>
> --
> Thomas Mortagne
> ___
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

[xwiki-devs] [PROPOSAL] Stabilize filesystem templates rights

2016-10-05 Thread Thomas Mortagne 
Hi devs,

Right now (and since forever) the default behavior for templates is to
be executed with the right of the current document content author
(it's not really explicit, it's just how PR works when there is no
sdoc). This means that unless you explicitly indicate an author for
your template (possible since 7.x) you don't really have any idea
which right it's going to have at runtime. It also make harder to
properly execute templates outside of main rendering thread where the
"current document" often don't really make much sense.

I think we should make the default more stable.

I can think of two possibilities:

1) with what we got right now the only real possibility is to execute
the filesystem template with superadmin right (which is only an option
right now). Makes it consistent with the "code is executed with the
right of its author" rule we have for wiki pages
2) introduce some new virtual user (like "templateauthor" or
"scripter" or whatever) which only have script right and use that as
filesystem template author if we absolutely want template to not have
too many rights by default (even if modifying a filesystem template
require much more access than superadmin in practice)

+1 for 1)

-- 
Thomas Mortagne
___
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs