Re: [xwiki-devs] [Proposal] New xwiki-clover-maven repository

2018-11-30 Thread Adel Atallah
+1 as well
On Fri, Nov 30, 2018 at 9:11 AM Thomas Mortagne
 wrote:
>
> +1
> On Thu, Nov 29, 2018 at 6:41 PM Vincent Massol  wrote:
> >
> > Hi devs,
> >
> > I’d like to refactor the groovy code that I’ve currently put at 
> > https://github.com/xwiki/xwiki-jenkins-pipeline/blob/59051fd8f61bd5a65db790684eff8679d17c51f1/src/org/xwiki/jenkins/Clover.groovy
> >  and to move it into an XWiki Maven plugin for Clover.
> >
> > The goal of this plugin is to take as input two clover.xml Clover data 
> > files and to generate a diff report (example: 
> > http://maven.xwiki.org/site/clover/20181120/XWikiReport-20171222-1835-20181120-1737.html).
> >
> > Rationale for move this outside of Jenkins:
> > * Less dependency on Jenkins
> > * Much easier to test
> > * Better versioning and release
> > * Increased reuse (any project in the world will be able to use it whereas 
> > the pipeline is specific to xwiki and not reusable easily)
> >
> > It’s not linked to releases of XWiki. But it should be maintained by the 
> > xwiki dev team since we use it in our pipeline to compute the global 
> > coverage and generate reports/emails when global TPC is lowered.
> >
> > WDYT?
> >
> > Thanks
> > -Vincent
>
>
>
> --
> Thomas Mortagne


Re: [xwiki-devs] [Proposal] New xwiki-clover-maven repository

2018-11-30 Thread Thomas Mortagne
+1
On Thu, Nov 29, 2018 at 6:41 PM Vincent Massol  wrote:
>
> Hi devs,
>
> I’d like to refactor the groovy code that I’ve currently put at 
> https://github.com/xwiki/xwiki-jenkins-pipeline/blob/59051fd8f61bd5a65db790684eff8679d17c51f1/src/org/xwiki/jenkins/Clover.groovy
>  and to move it into an XWiki Maven plugin for Clover.
>
> The goal of this plugin is to take as input two clover.xml Clover data files 
> and to generate a diff report (example: 
> http://maven.xwiki.org/site/clover/20181120/XWikiReport-20171222-1835-20181120-1737.html).
>
> Rationale for move this outside of Jenkins:
> * Less dependency on Jenkins
> * Much easier to test
> * Better versioning and release
> * Increased reuse (any project in the world will be able to use it whereas 
> the pipeline is specific to xwiki and not reusable easily)
>
> It’s not linked to releases of XWiki. But it should be maintained by the 
> xwiki dev team since we use it in our pipeline to compute the global coverage 
> and generate reports/emails when global TPC is lowered.
>
> WDYT?
>
> Thanks
> -Vincent



-- 
Thomas Mortagne


[xwiki-devs] [Proposal] New xwiki-clover-maven repository

2018-11-29 Thread Vincent Massol
Hi devs,

I’d like to refactor the groovy code that I’ve currently put at 
https://github.com/xwiki/xwiki-jenkins-pipeline/blob/59051fd8f61bd5a65db790684eff8679d17c51f1/src/org/xwiki/jenkins/Clover.groovy
 and to move it into an XWiki Maven plugin for Clover.

The goal of this plugin is to take as input two clover.xml Clover data files 
and to generate a diff report (example: 
http://maven.xwiki.org/site/clover/20181120/XWikiReport-20171222-1835-20181120-1737.html).

Rationale for move this outside of Jenkins:
* Less dependency on Jenkins
* Much easier to test
* Better versioning and release
* Increased reuse (any project in the world will be able to use it whereas the 
pipeline is specific to xwiki and not reusable easily)

It’s not linked to releases of XWiki. But it should be maintained by the xwiki 
dev team since we use it in our pipeline to compute the global coverage and 
generate reports/emails when global TPC is lowered.

WDYT?

Thanks
-Vincent