[Dhis2-devs] Tasks for community system

2010-01-22 Thread John lewis
Hi Abyot,
Its good idea to add attribute Group. Some more requirement or change that
is required in attribute are
 1) It have a compulsory field: which is mandatory to entry this would be
good to identify duplication patient registration
  2) To have option in attribute file just like catergory option so that the
patient can select it and we can avoid free text.

Apart from Attribute some more requirements are:
*Program:*
In your mail you have explained about date of incident. When we implement it
hard to get this message across different people. What will be good is to
have two more field in the program saying date of incident description and
date of enrollment description: As for Mother care program the date of
Incident is LMP date and date of enrolment is when the pregnant women come
to clinic. Where as for child health program the date of incident is date of
birth and date of enrolment is when baby comes to hospital.
*Patient module*
there are list of modification while adding a patient.
Currently in the system we first add the patient primary information and
then fill the attribute. We have to change that. We should not add a patient
unless we are sure that its not a duplicate registration. For doing that we
need to check the patient at two level one at the Identifier which
patient/case specify whether it already in the system and the other place is
the combination of name, age/dob, address/contact number/ or husband name.
once we have the confirmation we should add the patient not before. In case
of child their mother information should be given if mother information is
already there we should check the dob of the child if it is already in the
system. Incase of twins or more we should display a message that this mother
already have child with dob blabla is this a twin.

blood group should be moved from the attribute section to patient as when
we inherit the parent attribute this should not be copied. and it static for
a case.

not all the orgunit will be having patient registration. it depend on
particular orgunit. Yes sevices can be provided at any orgunit but patient
registration should be done in specific orgunit. Thus we should have a
facility like assiging dataset to orgunit even for adding/ modify patient.
*Searching Patient*
We have single search depending on the attribute but we need to improve it
by added nested search. to search within the searched result.
*System generated unique number: *
currently the system will generate identifier as orgunitname plus some
number. This should be change to system generate unique number without any
meaning associated to the unique number. Just a random number.
___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


Re: [Dhis2-devs] Excel reports module

2010-01-22 Thread Jason Pickering
Hi Murod,
Not sure about your questions regarding weekly periods. Will leave
this to the team from Viet Nam to answer .

Have you seen the newest manuals?

I am currently working on expanding the manual to cover all aspects of
the application.The Vietnamese  team have authored the module on Excel
 reporting. Bleeding edge documentation is available
here..http://dhis.uio.no/ci/job/Dhis2%20documentation/

If there is something missing, let me know specifically, and I will
liaise with the Vietnamese team to get it expanded.

Thanks,
jason


On Fri, Jan 22, 2010 at 4:46 PM, Murodullo Latifov
 wrote:
> Hi,
>
> Just looked at Excel reports module, quite useful, very intuitive and easy to 
> use. Excellent work. But couldn't find "weekly" and "daily" periods on the 
> list of periods, also when generating reports, it only shows monthly period, 
> though particular report is based on weekly period. There are no much 
> information in this regards in manual I have. Manual also does not cover 
> Excel Items option in Administration menu also, which has weekly and daily 
> periods. Is this new feature? Please help.
>
> regards,
> murod
>
>
>
>
>
> ___
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


[Dhis2-devs] Excel reports module

2010-01-22 Thread Murodullo Latifov
Hi,

Just looked at Excel reports module, quite useful, very intuitive and easy to 
use. Excellent work. But couldn't find "weekly" and "daily" periods on the list 
of periods, also when generating reports, it only shows monthly period, though 
particular report is based on weekly period. There are no much information in 
this regards in manual I have. Manual also does not cover Excel Items option in 
Administration menu also, which has weekly and daily periods. Is this new 
feature? Please help.

regards,
murod



  

___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


Re: [Dhis2-devs] Minor javascript cross-browser hack

2010-01-22 Thread Viet Nguyen
Hi,

If you want to use jQuery, I think the best way is create an array of string
then append them into the select tag

var options = [ ] ;

for( .. ) {
  options.push("$title");// collect items
}

jQuery("#selector").append(options.join(""));  // append a string into a
tag.



Regards,


2010/1/22 Lars Helge Øverland 

>
>
> On Fri, Jan 22, 2010 at 12:16 PM, Viet Nguyen wrote:
>
>> Hi,
>>
>> Just a minor javascript cross-browser hack.
>>
>> When adding an options to a select tag using javascript, I can see in DHIS
>> you are doing like this :
>>
>>  optionComboSelector.add( option, null );
>>
>> This will only work on gecko-based browsers. For IE ( tested with IE 8  &
>> 7 ) it will throw error ,  the right one should be like this :
>>
>>  optionComboSelector.add( option ); // only one param
>>
>> So the solution should be :
>>
>>try {
>> optionComboSelector.add( option, null );  // for gecko-based
>> browser...not tested with other webkit-based browsers ...
>> }catch(e){
>> optionComboSelector.add(option);  // just for IE
>> }
>>
>> A common method in common.js should be useful.
>>
>> Regards,
>>
>
>
>
> OK thanks for pointing this out. There might be a centralised method for
> this in commons.js or lists.js. Is this already taken care of in jQuery, if
> so could we use that instead?
>



-- 
Viet Nguyen
___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


Re: [Dhis2-devs] Minor javascript cross-browser hack

2010-01-22 Thread Lars Helge Øverland
On Fri, Jan 22, 2010 at 12:16 PM, Viet Nguyen wrote:

> Hi,
>
> Just a minor javascript cross-browser hack.
>
> When adding an options to a select tag using javascript, I can see in DHIS
> you are doing like this :
>
>  optionComboSelector.add( option, null );
>
> This will only work on gecko-based browsers. For IE ( tested with IE 8  & 7
> ) it will throw error ,  the right one should be like this :
>
>  optionComboSelector.add( option ); // only one param
>
> So the solution should be :
>
>try {
> optionComboSelector.add( option, null );  // for gecko-based
> browser...not tested with other webkit-based browsers ...
> }catch(e){
> optionComboSelector.add(option);  // just for IE
> }
>
> A common method in common.js should be useful.
>
> Regards,
>



OK thanks for pointing this out. There might be a centralised method for
this in commons.js or lists.js. Is this already taken care of in jQuery, if
so could we use that instead?
___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


[Dhis2-devs] Minor javascript cross-browser hack

2010-01-22 Thread Viet Nguyen
Hi,

Just a minor javascript cross-browser hack.

When adding an options to a select tag using javascript, I can see in DHIS
you are doing like this :

 optionComboSelector.add( option, null );

This will only work on gecko-based browsers. For IE ( tested with IE 8  & 7
) it will throw error ,  the right one should be like this :

 optionComboSelector.add( option ); // only one param

So the solution should be :

   try {
optionComboSelector.add( option, null );  // for gecko-based
browser...not tested with other webkit-based browsers ...
}catch(e){
optionComboSelector.add(option);  // just for IE
}

A common method in common.js should be useful.

Regards,

-- 
Viet Nguyen
___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


[Dhis2-devs] [Branch ~dhis2-devs-core/dhis2/trunk] Rev 1328: Added unit test for getDataElementsByZeroIsSignificant.

2010-01-22 Thread noreply

revno: 1328
committer: Lars Helge Oeverland 
branch nick: trunk
timestamp: Fri 2010-01-22 11:15:02 +0100
message:
  Added unit test for getDataElementsByZeroIsSignificant.
modified:
  dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java
  
dhis-2/dhis-services/dhis-service-core/src/test/java/org/hisp/dhis/dataelement/DataElementStoreTest.java
  
dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/index.vm


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to 
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.
=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java'
--- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java	2010-01-22 09:23:03 +
+++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java	2010-01-22 10:15:02 +
@@ -259,7 +259,7 @@
 // Logic
 // -
 
-public boolean isZeroIsSignificantNullSafe()
+public boolean isZeroIsSignificant()
 {
 return zeroIsSignificant != null && zeroIsSignificant;
 }
@@ -546,7 +546,7 @@
 this.aggregationLevels = aggregationLevels;
 }
 
-public Boolean isZeroIsSignificant()
+public Boolean getZeroIsSignificant()
 {
 return zeroIsSignificant;
 }

=== modified file 'dhis-2/dhis-services/dhis-service-core/src/test/java/org/hisp/dhis/dataelement/DataElementStoreTest.java'
--- dhis-2/dhis-services/dhis-service-core/src/test/java/org/hisp/dhis/dataelement/DataElementStoreTest.java	2009-11-07 14:09:00 +
+++ dhis-2/dhis-services/dhis-service-core/src/test/java/org/hisp/dhis/dataelement/DataElementStoreTest.java	2010-01-22 10:15:02 +
@@ -505,6 +505,27 @@
 assertTrue( dataElements.contains( dataElementB ) );
 assertTrue( dataElements.contains( dataElementD ) );
 }
+
+@Test
+public void testGetDataElementsZeroIsSignificant()
+{
+DataElement dataElementA = createDataElement( 'A' );
+DataElement dataElementB = createDataElement( 'B' );
+DataElement dataElementC = createDataElement( 'C' );
+DataElement dataElementD = createDataElement( 'D' );
+
+dataElementA.setZeroIsSignificant( true );
+dataElementB.setZeroIsSignificant( true );
+
+dataElementStore.addDataElement( dataElementA );
+dataElementStore.addDataElement( dataElementB );
+dataElementStore.addDataElement( dataElementC );
+dataElementStore.addDataElement( dataElementD );
+
+Collection dataElements = dataElementStore.getDataElementsByZeroIsSignificant( true );
+
+assertTrue( equals( dataElements, dataElementA, dataElementB ) );
+}
 
 // -
 // CalculatedDataElements

=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/index.vm'
--- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/index.vm	2010-01-22 03:15:07 +
+++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/index.vm	2010-01-22 10:15:02 +
@@ -7,8 +7,8 @@
 #introListItem( "displayMaintenanceForm.action" "maintenance" )
 #introListItem( "displayResourceTableForm.action" "resource_table" )
 #introListItem( "viewStatistics.action" "data_statistics" )
+#introListItem( "displayLockingForm.action" "data_locking" )
+#introListItem( "zeroValueStorageManagement.action" "dataelement_zero_storage_management" ) 
 #introListItem( "showCache.action" "cache_statistics" )
-#introListItem( "displayLockingForm.action" "data_locking" )
-	#introListItem( "zeroValueStorageManagement.action" "dataelement_zero_storage_management" )	
 
 
\ No newline at end of file

___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp


[Dhis2-devs] [Branch ~dhis2-documenters/dhis2/dhis2-docbook-docs] Rev 83: Modified pom for production of chunked and non-chunked HTML. Mogrified some images to try and red...

2010-01-22 Thread noreply

revno: 83
committer: Jason Pickering 
branch nick: dhis2-docbook-docs
timestamp: Fri 2010-01-22 10:55:40 +0200
message:
  Modified pom for production of chunked and non-chunked HTML. Mogrified some 
images to try and reduce download size a bit.
removed:
  src/docbkx/en/resources/images/ExcelReportModule/Thumbs.db
modified:
  pom.xml
  src/docbkx/en/dhis2_user_man_mod2.xml
  src/docbkx/en/dhis2_user_manual_en.xml
  src/docbkx/en/resources/glossary/glossary_en.xml
  src/docbkx/en/resources/images/ExcelReportModule/NewReportItem.jpg
  src/docbkx/en/resources/images/ExcelReportModule/add_dataset.jpg
  src/docbkx/en/resources/images/ExcelReportModule/add_dataset1.jpg
  src/docbkx/en/resources/images/ExcelReportModule/add_new_report_button.jpg
  src/docbkx/en/resources/images/ExcelReportModule/administration_page.jpg
  src/docbkx/en/resources/images/ExcelReportModule/advanced_generate_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/assign_data_element_group.jpg
  src/docbkx/en/resources/images/ExcelReportModule/assign_org_unit_group.jpg
  src/docbkx/en/resources/images/ExcelReportModule/assign_user_role.jpg
  src/docbkx/en/resources/images/ExcelReportModule/association_org_unit.jpg
  src/docbkx/en/resources/images/ExcelReportModule/configure_directory.jpg
  src/docbkx/en/resources/images/ExcelReportModule/configure_directory1.jpg
  src/docbkx/en/resources/images/ExcelReportModule/copy_report_item.jpg
  src/docbkx/en/resources/images/ExcelReportModule/create_expression.jpg
  src/docbkx/en/resources/images/ExcelReportModule/create_expression1.jpg
  src/docbkx/en/resources/images/ExcelReportModule/create_item.jpg
  src/docbkx/en/resources/images/ExcelReportModule/create_new_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/create_report_item.jpg
  src/docbkx/en/resources/images/ExcelReportModule/data_entry_status.jpg
  src/docbkx/en/resources/images/ExcelReportModule/data_entry_status1.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/dataelement_category_report_template.jpg
  src/docbkx/en/resources/images/ExcelReportModule/edit_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/edit_user_role.jpg
  src/docbkx/en/resources/images/ExcelReportModule/enter_report_information.jpg
  src/docbkx/en/resources/images/ExcelReportModule/enter_report_item_infor.jpg
  src/docbkx/en/resources/images/ExcelReportModule/excel_report_left_menu.jpg
  src/docbkx/en/resources/images/ExcelReportModule/excel_template_file.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/excel_template_file_with_data_values.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/generate_individual_report.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/generate_individual_report1.jpg
  src/docbkx/en/resources/images/ExcelReportModule/generate_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/generate_report_introduce.jpg
  src/docbkx/en/resources/images/ExcelReportModule/import_data_from_excel.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/import_data_from_excel_file.jpg
  src/docbkx/en/resources/images/ExcelReportModule/list_of_reports.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/list_org_unit_group_report_template.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/list_time_period_report_template.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/main_feature_of_excel_report_module.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/navigate_to_list_of_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/new_report_item.jpg
  src/docbkx/en/resources/images/ExcelReportModule/note.jpg
  src/docbkx/en/resources/images/ExcelReportModule/one of data enetry form of 
reports.jpg
  src/docbkx/en/resources/images/ExcelReportModule/open_excel_report_module.jpg
  src/docbkx/en/resources/images/ExcelReportModule/operating_buttons.jpg
  src/docbkx/en/resources/images/ExcelReportModule/remove_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/report_association.jpg
  src/docbkx/en/resources/images/ExcelReportModule/report_item.jpg
  src/docbkx/en/resources/images/ExcelReportModule/report_item_function.jpg
  src/docbkx/en/resources/images/ExcelReportModule/select_excel_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/select_org_unit.jpg
  src/docbkx/en/resources/images/ExcelReportModule/select_org_unit_group.jpg
  src/docbkx/en/resources/images/ExcelReportModule/select_org_unit_group1.jpg
  src/docbkx/en/resources/images/ExcelReportModule/standard_report_template.jpg
  src/docbkx/en/resources/images/ExcelReportModule/steps_generate_report.jpg
  src/docbkx/en/resources/images/ExcelReportModule/view_data_entry_status.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/view_data_set_completed_report.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/view_data_set_completed_report_dataset.jpg
  
src/docbkx/en/resources/images/ExcelReportModule/view_data_set_completed_

[Dhis2-devs] [Branch ~dhis2-devs-core/dhis2/trunk] Rev 1327: Changed zeroIsSignificant to Boolean and added null-safe get method.

2010-01-22 Thread noreply

revno: 1327
committer: Lars Helge Oeverland 
branch nick: trunk
timestamp: Fri 2010-01-22 10:23:03 +0100
message:
  Changed zeroIsSignificant to Boolean and added null-safe get method.
modified:
  dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java


--
lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.
To unsubscribe from this branch go to 
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.
=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java'
--- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java	2010-01-22 03:15:07 +
+++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java	2010-01-22 09:23:03 +
@@ -163,7 +163,7 @@
  * There is no point of saving 0's for this data element default is false
  * ,we don't want to store 0's if not set to true
  */
-private boolean zeroIsSignificant;
+private Boolean zeroIsSignificant;
 
 // -
 // Constructors
@@ -237,14 +237,12 @@
 
 public DimensionType getDimensionType()
 {
-return null; // DataElement is DimensionOption for the static
-// DataElement dimension
+return null; // DataElement is DimensionOption for the static DataElement dimension
 }
 
 public Set getDimensionOptionElements()
 {
-return null; // DataElement is DimensionOption for the static
-// DataElement dimension
+return null; // DataElement is DimensionOption for the static DataElement dimension
 }
 
 public List getDimensionOptions()
@@ -258,6 +256,15 @@
 }
 
 // -
+// Logic
+// -
+
+public boolean isZeroIsSignificantNullSafe()
+{
+return zeroIsSignificant != null && zeroIsSignificant;
+}
+
+// -
 // hashCode, equals and toString
 // -
 
@@ -539,14 +546,13 @@
 this.aggregationLevels = aggregationLevels;
 }
 
-public boolean isZeroIsSignificant()
+public Boolean isZeroIsSignificant()
 {
 return zeroIsSignificant;
 }
 
-public void setZeroIsSignificant( boolean zeroIsSignificant )
+public void setZeroIsSignificant( Boolean zeroIsSignificant )
 {
 this.zeroIsSignificant = zeroIsSignificant;
 }
-
 }

___
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help   : https://help.launchpad.net/ListHelp