Re: [Dhis2-devs] Defect with the Aggregation Query feature?
Hi Tran, Thanks for looking at this and getting back to us. Thanks, Shantala On Thu, May 21, 2015 at 8:31 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, I took a look at your database and run it on 2.19 version. It seems that you want to overwrite some data in aggregate side (dataSet values) by removing events on event side and running the manual aggregation, correct? If so, DHIS 'aggregation' from event side does not work like that. If there is no events, the aggregation process simply skips aggregation for that. It does not write over '0' values to aggregation side (dataSet values). . Best regards, Tran Chau On Tue, May 19, 2015 at 9:42 AM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: HI Shantala, I will take a look at it couple days later. I will inform you if I find out the issue. ... Best regards, Tran Chau On Mon, May 18, 2015 at 7:54 PM, Shantala Raman sra...@thoughtworks.com wrote: Hi Tran, Here https://www.dropbox.com/s/zywgr1sys7crx4k/dhis2_db.dump?dl=0 is the link to the DB dump of DHIS in dropbox where we have setup the data needed to replicate the defect. We have associated the *Cholera CTC* program under the organization hierarchy, MSF-OCP-A new country-A new project-New Hospital-Cholera-Origin 1. The program is of type *Single event without registration*. Steps to reproduce the defect: 1. In event capture, register an event for the *Cholera CTC* program under the *Origin 1* org unit. 2. Preview the manual aggregation results for *Geographic Origin* data set for *Origin 1* org unit for the week of the *Incident date* and save all values. 3. In data entry, you will see that the value of the *Number of Patients (Cholera CTC) *data element for the *Geographic Origin* data set for the week of the *Incident date* is 1. 4. In event capture, remove the event for the *Cholera CTC* program under the *Origin 1* org unit. 5. Preview the manual aggregation results for *Geographic Origin* data set for *Origin 1* org unit for the week of the *Incident date*. This won't return any changes to be updated while the expected behavior is that preview shows that the value for the *Number of Patients (Cholera CTC)* data element will change from 1 to 0. Save all values. 6. In data entry, you will see the value of the *Number of Patients (Cholera CTC)* data element remains as 1 for the *Geographic Origin* data set for the week while the expected behavior is that the value of the *Number of Patients (Cholera CTC)* data element is 0. Thanks, Shantala On Tue, May 12, 2015 at 3:05 PM, Shantala Raman sra...@thoughtworks.com wrote: Hi Tran, We are on 2.19 rev 19092. We are not using SQL queries for generating summary data values. We are using the aggregation query builder to setup the queries. Could you explain how the SQL query is linked to aggregation query builder? Thanks, Shantala On Mon, May 11, 2015 at 7:10 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, The first, please make sure if the snapshots are from 2.19 version, R 19075 ? It looks like old version. I couldn't create an example on dev server ( apps.dhis2.org/dev ) because the internet is still slow here. I cannot login the dev server to create an example. I am sending the SQL statement which I used to generate the data values from aggregate query formulas. Can you change the IDs in the SQL statement below according to one of your formula and see if it is generated NULL value records or not ( these NULL values will be displayed/saved as 0 values in Manual Aggregate ) SELECT '55' as dataelementid, '16' as categoryoptioncomboid, '16' as attributeoptioncomboid, ou.organisationunitid as sourceid, '1234' as periodid,'aggregated_from_tracker' as storedby, '201505' as periodIsoDate,'Agg DE 1' as dataelementname, '(default)' as categoryoptioncomboname, ou.name as organisationunitname, ( select count(psi.programinstanceid) as value FROM programinstance as pi INNER JOIN programstageinstance psi ON pi.programinstanceid=psi.programinstanceid WHERE EXISTS ( SELECT * FROM trackedentitydatavalue _pdv inner join programstageinstance _psi ON _pdv.programstageinstanceid=_psi.programstageinstanceid JOIN programinstance _pi ON _pi.programinstanceid=_psi.programinstanceid WHERE psi.programstageinstanceid=_pdv.programstageinstanceid AND _pdv.dataelementid=53 AND _psi.organisationunitid in (50, 51, 52) AND _pi.programid = 60 AND _psi.executionDate='2015-05-01' AND _psi.executionDate = '2015-05-31' AND _psi.programstageid = 63 AND _pdv.value is not null ) and psi.organisationunitid=ou.organisationunitid GROUP BY ou.organisationunitid ) from organisationunit ou where ou.organisationunitid in ( 50, 51, 52
Re: [Dhis2-devs] Defect with the Aggregation Query feature?
Hi Tran, Here https://www.dropbox.com/s/zywgr1sys7crx4k/dhis2_db.dump?dl=0 is the link to the DB dump of DHIS in dropbox where we have setup the data needed to replicate the defect. We have associated the *Cholera CTC* program under the organization hierarchy, MSF-OCP-A new country-A new project-New Hospital-Cholera-Origin 1. The program is of type *Single event without registration*. Steps to reproduce the defect: 1. In event capture, register an event for the *Cholera CTC* program under the *Origin 1* org unit. 2. Preview the manual aggregation results for *Geographic Origin* data set for *Origin 1* org unit for the week of the *Incident date* and save all values. 3. In data entry, you will see that the value of the *Number of Patients (Cholera CTC) *data element for the *Geographic Origin* data set for the week of the *Incident date* is 1. 4. In event capture, remove the event for the *Cholera CTC* program under the *Origin 1* org unit. 5. Preview the manual aggregation results for *Geographic Origin* data set for *Origin 1* org unit for the week of the *Incident date*. This won't return any changes to be updated while the expected behavior is that preview shows that the value for the *Number of Patients (Cholera CTC)* data element will change from 1 to 0. Save all values. 6. In data entry, you will see the value of the *Number of Patients (Cholera CTC)* data element remains as 1 for the *Geographic Origin* data set for the week while the expected behavior is that the value of the *Number of Patients (Cholera CTC)* data element is 0. Thanks, Shantala On Tue, May 12, 2015 at 3:05 PM, Shantala Raman sra...@thoughtworks.com wrote: Hi Tran, We are on 2.19 rev 19092. We are not using SQL queries for generating summary data values. We are using the aggregation query builder to setup the queries. Could you explain how the SQL query is linked to aggregation query builder? Thanks, Shantala On Mon, May 11, 2015 at 7:10 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, The first, please make sure if the snapshots are from 2.19 version, R 19075 ? It looks like old version. I couldn't create an example on dev server ( apps.dhis2.org/dev ) because the internet is still slow here. I cannot login the dev server to create an example. I am sending the SQL statement which I used to generate the data values from aggregate query formulas. Can you change the IDs in the SQL statement below according to one of your formula and see if it is generated NULL value records or not ( these NULL values will be displayed/saved as 0 values in Manual Aggregate ) SELECT '55' as dataelementid, '16' as categoryoptioncomboid, '16' as attributeoptioncomboid, ou.organisationunitid as sourceid, '1234' as periodid,'aggregated_from_tracker' as storedby, '201505' as periodIsoDate,'Agg DE 1' as dataelementname, '(default)' as categoryoptioncomboname, ou.name as organisationunitname, ( select count(psi.programinstanceid) as value FROM programinstance as pi INNER JOIN programstageinstance psi ON pi.programinstanceid=psi.programinstanceid WHERE EXISTS ( SELECT * FROM trackedentitydatavalue _pdv inner join programstageinstance _psi ON _pdv.programstageinstanceid=_psi.programstageinstanceid JOIN programinstance _pi ON _pi.programinstanceid=_psi.programinstanceid WHERE psi.programstageinstanceid=_pdv.programstageinstanceid AND _pdv.dataelementid=53 AND _psi.organisationunitid in (50, 51, 52) AND _pi.programid = 60 AND _psi.executionDate='2015-05-01' AND _psi.executionDate = '2015-05-31' AND _psi.programstageid = 63 AND _pdv.value is not null ) and psi.organisationunitid=ou.organisationunitid GROUP BY ou.organisationunitid ) from organisationunit ou where ou.organisationunitid in ( 50, 51, 52 ) ... Best regards Tran Chau On Mon, May 11, 2015 at 8:02 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, Are you sure if the snapshots are from 2.19 version, R 19075 ? It looks like old version. ... Best regards, Tran Chau Hi Tran, We are still seeing issues with the aggregation. We followed the below steps - - Created a data element with *Store zero data values* property set to Yes - Created an aggregation query for the data element - Created 3 events for the program of type* single event without registration* - 2 events under orgunit 1 (origin 1) and 1 event under orgunit 2 (origin 2) - Ran manual aggregation for both org units - Deleted the event under org unit 2 (origin 2) - Ran manual aggregation for both org units We observe that the data entry screen for org unit 2 (origin 2) still has the number of events as 1. Please find attached the screenshots for the various steps. Please let us know if you need any other information. Thanks, Shantala Shashank On Fri
Re: [Dhis2-devs] Defect with the Aggregation Query feature?
Hi Tran, We are on 2.19 rev 19092. We are not using SQL queries for generating summary data values. We are using the aggregation query builder to setup the queries. Could you explain how the SQL query is linked to aggregation query builder? Thanks, Shantala On Mon, May 11, 2015 at 7:10 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, The first, please make sure if the snapshots are from 2.19 version, R 19075 ? It looks like old version. I couldn't create an example on dev server ( apps.dhis2.org/dev ) because the internet is still slow here. I cannot login the dev server to create an example. I am sending the SQL statement which I used to generate the data values from aggregate query formulas. Can you change the IDs in the SQL statement below according to one of your formula and see if it is generated NULL value records or not ( these NULL values will be displayed/saved as 0 values in Manual Aggregate ) SELECT '55' as dataelementid, '16' as categoryoptioncomboid, '16' as attributeoptioncomboid, ou.organisationunitid as sourceid, '1234' as periodid,'aggregated_from_tracker' as storedby, '201505' as periodIsoDate,'Agg DE 1' as dataelementname, '(default)' as categoryoptioncomboname, ou.name as organisationunitname, ( select count(psi.programinstanceid) as value FROM programinstance as pi INNER JOIN programstageinstance psi ON pi.programinstanceid=psi.programinstanceid WHERE EXISTS ( SELECT * FROM trackedentitydatavalue _pdv inner join programstageinstance _psi ON _pdv.programstageinstanceid=_psi.programstageinstanceid JOIN programinstance _pi ON _pi.programinstanceid=_psi.programinstanceid WHERE psi.programstageinstanceid=_pdv.programstageinstanceid AND _pdv.dataelementid=53 AND _psi.organisationunitid in (50, 51, 52) AND _pi.programid = 60 AND _psi.executionDate='2015-05-01' AND _psi.executionDate = '2015-05-31' AND _psi.programstageid = 63 AND _pdv.value is not null ) and psi.organisationunitid=ou.organisationunitid GROUP BY ou.organisationunitid ) from organisationunit ou where ou.organisationunitid in ( 50, 51, 52 ) ... Best regards Tran Chau On Mon, May 11, 2015 at 8:02 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: Hi Shantala, Are you sure if the snapshots are from 2.19 version, R 19075 ? It looks like old version. ... Best regards, Tran Chau Hi Tran, We are still seeing issues with the aggregation. We followed the below steps - - Created a data element with *Store zero data values* property set to Yes - Created an aggregation query for the data element - Created 3 events for the program of type* single event without registration* - 2 events under orgunit 1 (origin 1) and 1 event under orgunit 2 (origin 2) - Ran manual aggregation for both org units - Deleted the event under org unit 2 (origin 2) - Ran manual aggregation for both org units We observe that the data entry screen for org unit 2 (origin 2) still has the number of events as 1. Please find attached the screenshots for the various steps. Please let us know if you need any other information. Thanks, Shantala Shashank On Fri, May 8, 2015 at 8:12 AM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: HI Simata, Yes, this bug is fixed on 19075, trunk version. I created an example on dev server ( https://apps.dhis2.org/dev/ ) for testing. I am sending snapshot about the test step by step on dev server here. *Step 1 - Create a data element and an aggregate query builder formula* *Step 1.1* - Create a data element with* '**Store zero data values' *property as '*Yes' ( see snapshot [1.1] ). And add it into a dataset.* *Step 1.2* - Defined an aggregate query builder formula* ( see snapshot [1.2] )* *Step 2 - Generate data values* *Step 2.1* - Create a new person and an event in April 2015. Fill a data value for data element which I used in Step 1.2 ( see snapshot [ *2.1*] ) *Step 2.2 *- Run Aggregate Manual ( see snapshot [*2.2*] ) *Step 2.3 *- Result after clicking Preview button ( see snapshot [ *2.3*] ) *Step 2.4* - Data values imported in the data set ( see snapshot [*2.4* ] , [*2.5*] ) *Step 3 - Modified data value of event in Step 2.1 and see the result after aggregate* *Step 3.1* - Remove the data which was filled in Step* 2.1* ( see snapshot [*3.1*] ) *Step 32 *- Run Aggregate Manual ( see snapshot [*3.2*] ) *Step 3.3 *- Result after clicking *Preview* button ( see snapshot [ *3.3*] ) *Step 3.4* - Data values imported in the data set ( see snapshot [*3.4* ] , [*3.5*] ). We can see the data value in April ( snapshot [*3.4*] ) is 0 now ) . If you got different result, send me the images and description like these. We will take a look at it.
Re: [Dhis2-devs] Defect with the Aggregation Query feature?
Hi Tran, We are still seeing issues with the aggregation. We followed the below steps - - Created a data element with *Store zero data values* property set to Yes - Created an aggregation query for the data element - Created 3 events for the program of type* single event without registration* - 2 events under orgunit 1 (origin 1) and 1 event under orgunit 2 (origin 2) - Ran manual aggregation for both org units - Deleted the event under org unit 2 (origin 2) - Ran manual aggregation for both org units We observe that the data entry screen for org unit 2 (origin 2) still has the number of events as 1. Please find attached the screenshots for the various steps. Please let us know if you need any other information. Thanks, Shantala Shashank On Fri, May 8, 2015 at 8:12 AM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: HI Simata, Yes, this bug is fixed on 19075, trunk version. I created an example on dev server ( https://apps.dhis2.org/dev/ ) for testing. I am sending snapshot about the test step by step on dev server here. *Step 1 - Create a data element and an aggregate query builder formula* *Step 1.1* - Create a data element with* '**Store zero data values' *property as '*Yes' ( see snapshot [1.1] ). And add it into a dataset.* *Step 1.2* - Defined an aggregate query builder formula* ( see snapshot [1.2] )* *Step 2 - Generate data values* *Step 2.1* - Create a new person and an event in April 2015. Fill a data value for data element which I used in Step 1.2 ( see snapshot [*2.1*] ) *Step 2.2 *- Run Aggregate Manual ( see snapshot [*2.2*] ) *Step 2.3 *- Result after clicking Preview button ( see snapshot [*2.3*] ) *Step 2.4* - Data values imported in the data set ( see snapshot [*2.4*] , [*2.5*] ) *Step 3 - Modified data value of event in Step 2.1 and see the result after aggregate* *Step 3.1* - Remove the data which was filled in Step* 2.1* ( see snapshot [*3.1*] ) *Step 32 *- Run Aggregate Manual ( see snapshot [*3.2*] ) *Step 3.3 *- Result after clicking *Preview* button ( see snapshot [ *3.3*] ) *Step 3.4* - Data values imported in the data set ( see snapshot [*3.4*] , [*3.5*] ). We can see the data value in April ( snapshot [*3.4*] ) is 0 now ) . If you got different result, send me the images and description like these. We will take a look at it. . Best regards, Tran Chau. On May 7, 2015 1:03 PM, Simanta Jyoti Handique shandi...@thoughtworks.com wrote: Hello, We were wondering if this bug has been fixed as part of rev #19075. We are on rev #19097 and are still facing this issue Regards, Simanta On Tue, Apr 28, 2015 at 5:51 PM, Tran Chau (HISP Vietnam) tran.hispviet...@gmail.com wrote: HI Simanta and others, The issue is in Manual Aggregate, the 0 values are not displayed/saved. I am working on it to display and save 0 values in Manual Aggregate functionality. Thank you for reporting this bug. .. Best regards, Tran Chau On Mon, Apr 27, 2015 at 5:48 PM, Simanta Jyoti Handique shandi...@thoughtworks.com wrote: Hi, thanks for the response. The data elements were already configured to store zero data values. This may be another symptom to the problem: If I run the aggregation manually and preview the data that will be saved, there are no results with 0 values Regards, Simanta On Mon, Apr 27, 2015 at 1:58 PM, Adebusoye Anifalaje bus...@hisp.org wrote: Sorry, Just re read your question. My mistake. To overwrite values with 0, you have to choose to store zero data values when creating the aggregate data element. On Monday, April 27, 2015, Adebusoye Anifalaje bus...@hisp.org wrote: Hi Simanta, You should try changing the Operator to Number of tracked entities. Visits are technically for program stages and since you are not registering programs then you can't have visits. Try tracked entities and let's know whether it worked. Cheers. Busoye On Monday, April 27, 2015, Simanta Jyoti Handique shandi...@thoughtworks.com wrote: Hi, We have set up an aggregation query with the following details: Name: Number of Patients (Measles Outbreak) Operator: Number of Visits Data set: Geographic Origin Data Element: Number of Patients (Measles Outbreak) - Geographic Origin (Number) Condition: [Measles Outbreak.Measles Outbreak stage.Date of admission] is not null Measles Outbreak is a Single Event without Registration type program. Date of admission is a Data Element of type Date We register an event, run the aggregation query and the Number of Patients (Measles Outbreak) - Geographic Origin (Number) data element is correctly populated with the count of the number of patients. We delete the event and re-run the query. The data element for
Re: [Dhis2-devs] Hide unapproved data is not working on DHIS trunk
Any updates on when this will be fixed? On Wed, Mar 11, 2015 at 1:39 PM, Marta Vila martav...@gmail.com wrote: Good morning, just to add we are experiencing the same issue and it is also important for the our field pilot in April. Thanks! On 11 March 2015 at 07:28, Shashank Raghavendra shash...@thoughtworks.com wrote: Hi Lars, On the latest DHIS build on trunk, unapproved data is showing up both on the data visualiser and also on the data set reports even when the Hide unapproved data in the 'Approval settings' is marked YES. For this respective data set, we have marked Approve Data as YES. For our next release in early April, we have a combination of data sets which require approval and some which don't. Hence we need this defect fix to go live. Could you please have a look at this on priority. Thanks*Shashank Raghavendra**Quality Analyst* Skype shashank.raghavendra Telephone+91 9632802392 [image: ThoughtWorks] http://www.thoughtworks.com/ ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
Re: [Dhis2-devs] Attributes for Program
Hi Lars, It would be great if you could pick this up in 2.18. Thanks, Shantala On Tue, Nov 18, 2014 at 4:01 PM, Lars Helge Øverland larshe...@gmail.com wrote: Hi Mahendra, no it is not at the moment. However the attribute solution we have for data elements, org units, etc is easily extensible and it is a good idea to add it to programs. I have written a blueprint here: https://blueprints.launchpad.net/dhis2/+spec/dynamic-attributes-for-programs If you feel like taking it on it should be pretty straightforward. Basically you need to add a: SetAttributeValue attributeValues to Program, and then add the corresponding hibernate mapping for the join table: set name=attributeValues table=programattributevalues cache usage=read-write / key column=programid / many-to-many class=org.hisp.dhis.attribute.AttributeValue column=attributevalueid unique=true / /set Then add to the UI in data admin module. If not, then we can do it early in the 2.18 iteration. best regards, Lars On Tue, Nov 18, 2014 at 8:04 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi, We have a requirement to capture custom metadata field for programs. For org units, datasets etc. we create a new custom attribute. Is there anything similar for programs? ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
Re: [Dhis2-devs] /multiple api for acceptance
Awesome, thanks a lot, Jim. We will let you know if it doesn't go well - no mails from us on this would mean it works like a charm :). On Thu, Nov 13, 2014 at 6:33 PM, Jim Grace jimgr...@gmail.com wrote: Hi Shantala, Sorry for the silence. The features are in trunk now. We've been doing quite a bit of work to both simplify and speed up the code. Please test and give any feedback. I don't know the 2.17 release date but hopefully it's very soon. Cheers, Jim On Thu, Nov 13, 2014 at 12:01 AM, Shantala Raman sra...@thoughtworks.com wrote: Hi Jim, Just wanted to check on the status of approval and acceptance related changes being implemented. By when do you think these will be completed? Also, what is the release date for 2.17? Thanks, Shantala On Tue, Oct 28, 2014 at 2:57 PM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: It would also be great if you can point us to any APIs that have changed while you were refactoring. On Tue, Oct 28, 2014 at 10:49 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, I saw a lot of commits regarding approval over the weekend. I am not sure if /acceptance/multiple was one of them. So I was just wondering if it is there in the trunk. If you are too busy and need some help with it, please let us know. On Mon, Oct 20, 2014 at 4:16 PM, Jim Grace jimgr...@gmail.com wrote: Hi Mansi, My time has been hijacked by some critical work supporting a deployment, but I'm now back to work on this. I need to get it done within the next couple of days. Sorry about the further delay. Cheers, Jim On Mon, Oct 20, 2014 at 1:31 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, Just wondering if you got time to work on this api. On Fri, Oct 10, 2014 at 3:37 PM, Jim Grace jimgr...@gmail.com wrote: Sorry, not yet. The work on this was a bit disrupted this week by other things. But I'm trying for the end of the weekend. On Fri, Oct 10, 2014 at 1:58 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, We were wondering these changes have been checked in to trunk. On Mon, Oct 6, 2014 at 5:42 PM, Mansi Singhal msing...@thoughtworks.com wrote: Thanks. On Mon, Oct 6, 2014 at 5:35 PM, Jim Grace jimgr...@gmail.com wrote: Should be some time this week. On Mon, Oct 6, 2014 at 7:51 AM, Mansi Singhal msing...@thoughtworks.com wrote: Hey Jim, Can you please tell us, By when these changes are expected to be there in trunk ? On Mon, Oct 6, 2014 at 4:52 PM, Jim Grace jimgr...@gmail.com wrote: Hi Mansi, We are refactoring some of the approvals service layer for 2.17, and will have the ability there already for multiple acceptances. I will add support for this in the API controller as well. Cheers, Jim On Mon, Oct 6, 2014 at 4:56 AM, Mansi Singhal msing...@thoughtworks.com wrote: Hi, There is an API (/dataApprovals/multiple) for approving multiple datasets for a given period and org unit. But we don't have /multiple api for accepting data (/acceptances). We have a scenario where we need to accept data for multiple datasets for a given period and org unit. Would it make sense to the broader DHIS2 community to have this API? Are you planning to write api for the same or should we submit a patch? -- Regards, Mansi Singhal ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp -- Regards, Mansi Singhal -- Regards, Mansi Singhal ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
Re: [Dhis2-devs] /multiple api for acceptance
Hi Jim, Just wanted to check on the status of approval and acceptance related changes being implemented. By when do you think these will be completed? Also, what is the release date for 2.17? Thanks, Shantala On Tue, Oct 28, 2014 at 2:57 PM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: It would also be great if you can point us to any APIs that have changed while you were refactoring. On Tue, Oct 28, 2014 at 10:49 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, I saw a lot of commits regarding approval over the weekend. I am not sure if /acceptance/multiple was one of them. So I was just wondering if it is there in the trunk. If you are too busy and need some help with it, please let us know. On Mon, Oct 20, 2014 at 4:16 PM, Jim Grace jimgr...@gmail.com wrote: Hi Mansi, My time has been hijacked by some critical work supporting a deployment, but I'm now back to work on this. I need to get it done within the next couple of days. Sorry about the further delay. Cheers, Jim On Mon, Oct 20, 2014 at 1:31 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, Just wondering if you got time to work on this api. On Fri, Oct 10, 2014 at 3:37 PM, Jim Grace jimgr...@gmail.com wrote: Sorry, not yet. The work on this was a bit disrupted this week by other things. But I'm trying for the end of the weekend. On Fri, Oct 10, 2014 at 1:58 AM, Mahendra Kariya mahendra.kar...@thoughtworks.com wrote: Hi Jim, We were wondering these changes have been checked in to trunk. On Mon, Oct 6, 2014 at 5:42 PM, Mansi Singhal msing...@thoughtworks.com wrote: Thanks. On Mon, Oct 6, 2014 at 5:35 PM, Jim Grace jimgr...@gmail.com wrote: Should be some time this week. On Mon, Oct 6, 2014 at 7:51 AM, Mansi Singhal msing...@thoughtworks.com wrote: Hey Jim, Can you please tell us, By when these changes are expected to be there in trunk ? On Mon, Oct 6, 2014 at 4:52 PM, Jim Grace jimgr...@gmail.com wrote: Hi Mansi, We are refactoring some of the approvals service layer for 2.17, and will have the ability there already for multiple acceptances. I will add support for this in the API controller as well. Cheers, Jim On Mon, Oct 6, 2014 at 4:56 AM, Mansi Singhal msing...@thoughtworks.com wrote: Hi, There is an API (/dataApprovals/multiple) for approving multiple datasets for a given period and org unit. But we don't have /multiple api for accepting data (/acceptances). We have a scenario where we need to accept data for multiple datasets for a given period and org unit. Would it make sense to the broader DHIS2 community to have this API? Are you planning to write api for the same or should we submit a patch? -- Regards, Mansi Singhal ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp -- Regards, Mansi Singhal -- Regards, Mansi Singhal ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
Re: [Dhis2-devs] Contract changes in User Controller.
Hi Lars, The organization structure we are setting up has one special case - a particular org unit type could be either at level 5 or 6. We associate data sets and capture data against org units of this particular type. Also, organization units get added from our client application and the client application needs to be aware of the org unit type. Would it be possible to use organization unit groups and group sets in this case where the organization units are not a fixed/static list? Regards, Shantala On Mon, Jun 16, 2014 at 10:36 PM, Lars Helge Øverland larshe...@gmail.com wrote: Good. On Mon, Jun 16, 2014 at 7:05 PM, Kiran Prakash kprak...@thoughtworks.com wrote: oh ok. Thanks Lars, We will look into this. Regards, Kiran. On Mon, Jun 16, 2014 at 5:22 PM, Lars Helge Øverland larshe...@gmail.com wrote: Hi Kiran, it could be I get this wrong, however just a suggestion: When classifying the organisation units in DHIS it is useful to utilize an organisation unit group set (Org unit type) and organisation unit groups for each type. This makes is possible to later do data analysis broken down on org unit type, ie. org unit type will become a data dimension and appear in left side menu in pivot table / visualizer apps. It is also possible to get org units and group membership in lists now e.g. like this: http://apps.dhis2.org/dev/api/organisationUnits.json?fields=id,name,organisationUnitGroups cheers Lars On Wed, Jun 11, 2014 at 12:03 PM, Kiran Prakash kprak...@thoughtworks.com wrote: Is it possible to keep backward compatibility intact while making API changes? We're already seeing lot of issues on our side, and I'm sure others who're using the API will also face these problems. One more place where the API change is breaking our code is this, while querying the org hierarchy. for eg: http://localhost:8080/api/organisationUnits/d06372e4302?includeDescendants=true Would give the queried organization and all its descendents and its custom attributes etc. with the new API, we're trying to get http://localhost:8080/api/organisationUnits/d06372e4302?fields=:all,children[:all] http://localhost:8080/api/organisationUnits/d06372e4302?fields=:all,children[:all] the decendents of the org has been renamed to 'children', but the children does not have all the custom attributes set. We are using a custom attribute on the organization to figure the type of node in the hierarchy (eg. country, hospital, etc ) and some of our domain logic is based on this type. Are we missing something in our query? Please let us know. Thanks in advance, Kiran. On Wed, Jun 11, 2014 at 3:16 PM, Morten Olav Hansen morte...@gmail.com wrote: Yes, This is by design, :all merely means give me all property on current level. It will by default render idObjects with just idObject properties, and Collections of idObject as a collection of idObject properties. I know this breaks things, but we were really not happy with the current use of viewClasses (@JsonView), I hope it won't be too difficult to implement. We do support recursive expansion of the fields properties, so you can do ?fields=a,b,c[a,b,c[a,b]],d[:all] etc, but yes.. this requires changes to your code (most of this is supported in 2.15, but you will to use include= instead) -- Morten On Wed, Jun 11, 2014 at 11:40 AM, Aravind Muralikrishnan aravi...@thoughtworks.com wrote: Hello Morten, Thank you for the quick fix! We were trying the new api and it works. We also looked at the code a little bit, and we saw that if we don't give any query params, we are defaulting it to :all. However this retrieves fields only at the first level and does not retrieve fields for the nested entities. Ex: When we get user object using say */api/users/OYLGMiazHtW.json *it just gets the user object and does not get all the fields of the userCredentials object. This might break backwards compatibility of the api, as the older api was giving out all the fields by default including nested objects. Is this the expected behaviour? Thanks, Aravind On Wed, Jun 11, 2014 at 1:19 PM, Morten Olav Hansen morte...@gmail.com wrote: Hi This should now be working in rev 15615. /api/users/OYLGMiazHtW.json?fields=:all,userCredentials[:all] Please try it out and report any issues back -- Morten On Tue, Jun 10, 2014 at 1:33 PM, Morten Olav Hansen morte...@gmail.com wrote: Hi All our endpoint have now been switched our to using the new field filtering (similar to the old inclusion/exclusion), so the data you want is probably there, but you have to tell the system you want to have it. I do see that there is a bug in the UserCredentials class, I will fix that tomorrow. Please see the documentation here: http://www.dhis2.org/doc/snapshot/en/user/html/ch30s07.html Regarding the the custom serializers, we needed a bit more custom control over the output, we still use
Re: [Dhis2-devs] [Dhis2-users] DHIS 2 - week
Yes, it would be great if the week numbers in a year and start end days can be made configurable. I will wait to hear from this group on whether this is possible. Regards, Shantala On Tue, Mar 25, 2014 at 2:32 AM, Jason Pickering jason.p.picker...@gmail.com wrote: Hi Shantala, As Knut's email alludes to , along the article which you shared hints at, there may be different definitions of what an Epi Week actually is. It is therefore that DHIS2 has adopted the ISO standard definition, which can be determined with precision, due to the rigor of its definition. In your case, is you requirement that your week begins on Sunday instead of Monday, with the first week being determined by the The first epi week of the year ends, by definition, on the first Saturday of January, as long as it falls at least four days into the month? A question to the developers...would it be possible to support a user defined period type, which would require that users create their own start/enddates? I realize that this would create problems for the offline features of DHIS2, but this requirement, along with similar ones in countries which do not use the Gregorian calendar, point to the need for something more flexible than what we currently have. Regards, Jason On Mon, Mar 24, 2014 at 7:42 PM, Shantala Raman sra...@thoughtworks.comwrote: Sure. The requirement is to have data collection done weekly with the week being an Epi week http://www.cmmcp.org/epiweek.htm (epidemiology week), having week start date of Sunday and end date of Saturday. On Mon, Mar 24, 2014 at 12:48 PM, Knut Staring knu...@gmail.com wrote: Could you elaborate a bit on your specific requirements? Knut On Mon, Mar 24, 2014 at 8:14 AM, Shantala Raman sra...@thoughtworks.com wrote: Thank you. This helps. On Mon, Mar 24, 2014 at 11:58 AM, Knut Staring knu...@gmail.comwrote: We have actually accommodated other weeks (eg Wed to Tue) in Cambodia, but this code is not yet part of the core. On Mar 24, 2014 12:53 PM, Jason Pickering jason.p.picker...@gmail.com wrote: Hi Shantala, The weeks are calculated according to the ISO 8601 time and date standard. This generally means weeks start on Monday and end on Sunday. More info can be found here http://en.wikipedia.org/wiki/ISO_week_date Regards, Jason On Mon, Mar 24, 2014 at 4:16 PM, Shantala Raman sra...@thoughtworks.com wrote: Hi, For data that is reported/collected on a weekly basis, we have a requirement to use Epidemiology weeks. I wanted to know how the weeks are calculated in DHIS2. Please point me to any documentation around the logic for calculating the weeks. Thanks, Shantala ___ Mailing list: https://launchpad.net/~dhis2-users Post to : dhis2-us...@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-users More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~dhis2-users Post to : dhis2-us...@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-users More help : https://help.launchpad.net/ListHelp -- Knut Staring Dept. of Informatics, University of Oslo +4791880522 http://dhis2.org ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
[Dhis2-devs] [Bug 1297793] [NEW] Unable to load the data entry page for a user
Public bug reported: Environment details: Trunk build of DHIS 2. Steps to reproduce: 1. Create a category option, category and category combo called Number of cases. 2. Create a data element called Shock with category combination as Number of cases and of type aggregate and numeric. 3. Create a data set called Cause, assign the data element Shock and select Weekly as the frequency. 4. Create a role called Data entry person and assign access to the Cause dataset and authorities See data entry module, Delete data value, Add/Update data value, See dashboard integration module. 5. Create an org unit called District 1 6. Assign the Cause data set to the org unit District 1 7. Create a user called entry1 with role Data entry person and assign access to the org unit District 1 8. Login as entry1 and go to data entry screen. The following error is reported in the log - * INFO 2014-03-26 16:21:34,331 'entry1' read denied org.hisp.dhis.dataelement.DataElementCategoryCombo_$$_javassist_82, name: default, uid: hpgMJ5bmcBq (AuditLogUtil.java [1691071275@qtp-1792399744-20]) 9. Select the Cause data set and a week. Enter a number for the Shock data element and hit Complete. 10. Gives the message that data is saved offline although I am online. ** Affects: dhis2 Importance: Undecided Status: New -- You received this bug notification because you are a member of DHIS 2 developers, which is subscribed to DHIS. https://bugs.launchpad.net/bugs/1297793 Title: Unable to load the data entry page for a user Status in DHIS 2: New Bug description: Environment details: Trunk build of DHIS 2. Steps to reproduce: 1. Create a category option, category and category combo called Number of cases. 2. Create a data element called Shock with category combination as Number of cases and of type aggregate and numeric. 3. Create a data set called Cause, assign the data element Shock and select Weekly as the frequency. 4. Create a role called Data entry person and assign access to the Cause dataset and authorities See data entry module, Delete data value, Add/Update data value, See dashboard integration module. 5. Create an org unit called District 1 6. Assign the Cause data set to the org unit District 1 7. Create a user called entry1 with role Data entry person and assign access to the org unit District 1 8. Login as entry1 and go to data entry screen. The following error is reported in the log - * INFO 2014-03-26 16:21:34,331 'entry1' read denied org.hisp.dhis.dataelement.DataElementCategoryCombo_$$_javassist_82, name: default, uid: hpgMJ5bmcBq (AuditLogUtil.java [1691071275@qtp-1792399744-20]) 9. Select the Cause data set and a week. Enter a number for the Shock data element and hit Complete. 10. Gives the message that data is saved offline although I am online. To manage notifications about this bug go to: https://bugs.launchpad.net/dhis2/+bug/1297793/+subscriptions ___ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp
