Re: Group resizing isses (was: crash with my patch...)
On Tue, Sep 30, 2014 at 10:34 PM, George Georgalis geo...@galis.org wrote: On Fri, Sep 26, 2014 at 12:20 PM, Hans Breuer h...@breuer.org wrote: Am 23.09.2014 um 05:44 schrieb George Georgalis: I've been happy with my patch to increase size of object handles and connection points. However, I discovered if I group two objects then grab a resize handle, the grouping disappears. If I then select all and zoom to fit, crash. Probaly two issues: - the Group::move_hande() was seriously flawed (transformation is one of the new features after 0.97.x). I've just pushed a better implementation to master [1] transformation sounds like the key term. before objects would disappear, they would extend on side oppisit the handles being adjusted I had checked before/after my patch, so do think it brought out the issue, at least. Maybe from using different coordinate math for draw_pixel_line vs draw_pixel_rect? In any event, all seems resolved in the origin/master from today. Hi Hans, I've not had any additional group resize problems. The build from today seems just fine too, my patched build script is attached. I imagine variable re-size handles could be complex to integrate into preferences, but everyone I've shared my handles/connection point size increase patch with, has been very receptive. The size of these items does have a real useability impact. Bigger connection points can clutter, but I just un-enable them in the view menu when I'm not using them. Turns out, not much toggle is required for most drawings. (but a kbd-shortcut would be handy). So, maybe there is a solution? An easier way to integrate the feature into preferences for release versions might be through a toggle vs variable option. Would you be open to adding a small, medium, large handle size option in preferences? If so, I would be willing to write some pseudo code to add the option. Interested? -George Thanks! -George -- George Georgalis, (415) 894-2710, http://www.galis.org/ -- George Georgalis, (415) 894-2710, http://www.galis.org/ dia-inst.sh Description: Bourne shell script ___ dia-list mailing list dia-list@gnome.org https://mail.gnome.org/mailman/listinfo/dia-list FAQ at http://live.gnome.org/Dia/Faq Main page at http://live.gnome.org/Dia
Re: Group resizing isses (was: crash with my patch...)
On Fri, Sep 26, 2014 at 12:20 PM, Hans Breuer h...@breuer.org wrote: Am 23.09.2014 um 05:44 schrieb George Georgalis: I've been happy with my patch to increase size of object handles and connection points. However, I discovered if I group two objects then grab a resize handle, the grouping disappears. If I then select all and zoom to fit, crash. Probaly two issues: - the Group::move_hande() was seriously flawed (transformation is one of the new features after 0.97.x). I've just pushed a better implementation to master [1] transformation sounds like the key term. before objects would disappear, they would extend on side oppisit the handles being adjusted I had checked before/after my patch, so do think it brought out the issue, at least. Maybe from using different coordinate math for draw_pixel_line vs draw_pixel_rect? In any event, all seems resolved in the origin/master from today. Thanks! -George -- George Georgalis, (415) 894-2710, http://www.galis.org/ ___ dia-list mailing list dia-list@gnome.org https://mail.gnome.org/mailman/listinfo/dia-list FAQ at http://live.gnome.org/Dia/Faq Main page at http://live.gnome.org/Dia
Group resizing isses (was: crash with my patch...)
Am 23.09.2014 um 05:44 schrieb George Georgalis: Hi - I've been happy with my patch to increase size of object handles and connection points. However, I discovered if I group two objects then grab a resize handle, the grouping disappears. If I then select all and zoom to fit, crash. Probaly two issues: - the Group::move_hande() was seriously flawed (transformation is one of the new features after 0.97.x). I've just pushed a better implementation to master [1] - the transformed group was really small so select all had to work on a huge diagram. There was an issue with the GDK renderer trying to allocate huge internal pixmaps, which than failed [2]. There might be other issues like that. My patch (attached) changes: [...] I think the crash has something to do with float vs int values, but I cannot find what made me concerned about that before... is there any compile switches that will help me detect type mismatch? Dia is generally build with high warning level. But I seriously doubt the crash has anything to do with float vs. int. Could the issue be something else? Yes, certainly. I don't think it has anything to do with your patch. But you should try yourself by trying to reproduce the crash without it. Please build Dia with --enable-debug=yes so that you can provide stack traces of your crashes. Thanks, Hans [1] https://git.gnome.org/browse/dia/commit/?id=beb381aee1803b3864d7dcef75891655caaacc1d [2] https://git.gnome.org/browse/dia/commit/?id=c68d39779c91c036f304bd2791194cdb35e132ab Hans at Breuer dot Org --- Tell me what you need, and I'll tell you how to get along without it.-- Dilbert ___ dia-list mailing list dia-list@gnome.org https://mail.gnome.org/mailman/listinfo/dia-list FAQ at http://live.gnome.org/Dia/Faq Main page at http://live.gnome.org/Dia
crash with my patch...
Hi - I've been happy with my patch to increase size of object handles and connection points. However, I discovered if I group two objects then grab a resize handle, the grouping disappears. If I then select all and zoom to fit, crash. My patch (attached) changes: irenderer-draw_pixel_line (renderer, x-CP_SZ,y-CP_SZ, x+CP_SZ,y+CP_SZ, color); irenderer-draw_pixel_line (renderer, x+CP_SZ,y-CP_SZ, x-CP_SZ,y+CP_SZ, color); in ./app/connectionpoint_ops.c to irenderer-fill_pixel_rect(renderer, x - CONNECTIONPOINT_SIZE/2 + 1, y - CONNECTIONPOINT_SIZE/2 + 1, CONNECTIONPOINT_SIZE-2, CONNECTIONPOINT_SIZE-2, color); irenderer-draw_pixel_rect(renderer, x - CONNECTIONPOINT_SIZE/2, y - CONNECTIONPOINT_SIZE/2, CONNECTIONPOINT_SIZE-1, CONNECTIONPOINT_SIZE-1, color_white); Also HANDLE_SIZE and CONNECTIONPOINT_SIZE are changed to 9. I think the crash has something to do with float vs int values, but I cannot find what made me concerned about that before... is there any compile switches that will help me detect type mismatch? Could the issue be something else? -George -- George Georgalis, (415) 894-2710, http://www.galis.org/ ___ dia-list mailing list dia-list@gnome.org https://mail.gnome.org/mailman/listinfo/dia-list FAQ at http://live.gnome.org/Dia/Faq Main page at http://live.gnome.org/Dia
Re: crash with my patch...
Oops forgot patch, it is inside attached build script. -George On Mon, Sep 22, 2014 at 8:44 PM, George Georgalis geo...@galis.org wrote: My patch (attached) changes: dia-inst.sh Description: Bourne shell script ___ dia-list mailing list dia-list@gnome.org https://mail.gnome.org/mailman/listinfo/dia-list FAQ at http://live.gnome.org/Dia/Faq Main page at http://live.gnome.org/Dia
