[Issue 12609] Useless variable assignment in std.regex

2014-04-23 Thread via Digitalmars-d-bugs 
https://issues.dlang.org/show_bug.cgi?id=12609

Dmitry Olshansky dmitry.o...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||dmitry.o...@gmail.com
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Olshansky dmitry.o...@gmail.com ---
https://github.com/AndrejMitrovic/phobos/commit/70d965879a9b26bdef08c8db66ea34e4aceeb42d

--

[Issue 12609] Useless variable assignment in std.regex

2014-04-21 Thread via Digitalmars-d-bugs 
https://issues.dlang.org/show_bug.cgi?id=12609

Andrej Mitrovic andrej.mitrov...@gmail.com changed:

   What|Removed |Added

 CC||andrej.mitrov...@gmail.com

--- Comment #1 from Andrej Mitrovic andrej.mitrov...@gmail.com ---
This used to be:

-
static if(direction == OneShot.Fwd)
startPc = startPc;
else
startPc = cast(uint)re.ir.length-IRL!(IR.LookbehindEnd);
-

And changed to the current code in commit d9eaf22.

My guess is Dmitry probably used some Vim/regex(heh)-style searchreplace, and
the dead assignment was left in place.

--

[Issue 12609] Useless variable assignment in std.regex

2014-04-21 Thread via Digitalmars-d-bugs 
https://issues.dlang.org/show_bug.cgi?id=12609

Andrej Mitrovic andrej.mitrov...@gmail.com changed:

   What|Removed |Added

   Keywords||pull
URL||https://github.com/D-Progra
   ||mming-Language/phobos/pull/
   ||2097
   Assignee|nob...@puremagic.com|andrej.mitrov...@gmail.com

--