[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-25 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #9 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/6dd50d5c296dea9b565a5f2754c249d4f6db5141
fix Issue 12900 - Wrong code in IfStatement condition Expression

https://github.com/D-Programming-Language/dmd/commit/d664daebede34c6bf913af43f26c1d9673203414
Merge pull request #3685 from 9rnsr/fix12900

More conservative fix for issue 12900 - Wrong code in IfStatement condition
Expression

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-14 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Johannes Pfau johannesp...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Johannes Pfau johannesp...@gmail.com ---
https://github.com/D-Programming-Language/dmd/commit/ec3bfe03ae96712cbe0ce5dca86eb926bcb2e1e0
https://github.com/D-Programming-Language/dmd/pull/3662

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-13 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #4 from Iain Buclaw ibuc...@gdcproject.org ---
If there's a way to distinguish between different kinds of type in dmd's
backend, you could throw in some tree checking.

Such as:
Assignments, left and right types are compatible.
Comparisons, left and right types are compatible.
Returns, return value type and function return type are compatible.
Conditions, condition is a scalar type.

Of course, you don't need this sort of checking in dmd release builds. :)

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-13 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #7 from Iain Buclaw ibuc...@gdcproject.org ---
(In reply to yebblies from comment #3)
 If it doesn't have a test case or assert in dmd it's probably not going to
 stay fixed.

It's going in the gdc testsuite. :)

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-13 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #5 from Iain Buclaw ibuc...@gdcproject.org ---
https://github.com/D-Programming-Language/dmd/pull/3662

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-13 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #6 from Iain Buclaw ibuc...@gdcproject.org ---
This is also blocking the next binary release of gdc.

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-13 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Iain Buclaw ibuc...@gdcproject.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@puremagic.com|ibuc...@gdcproject.org

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Iain Buclaw ibuc...@gdcproject.org changed:

   What|Removed |Added

   Keywords||wrong-code
 CC||ibuc...@gdcproject.org

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Iain Buclaw ibuc...@gdcproject.org changed:

   What|Removed |Added

 Depends on||8913

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Iain Buclaw ibuc...@gdcproject.org changed:

   What|Removed |Added

 Blocks||7175

--- Comment #1 from Iain Buclaw ibuc...@gdcproject.org ---
PR that fixed 8913:
https://github.com/D-Programming-Language/dmd/pull/1382

PR that reverted changed and re-introduced this problem:
https://github.com/D-Programming-Language/dmd/pull/2888


Now it's interesting that 7175 was raised before 8913 and the fix that went
into 8913.  Oh well, I'll set this as a blocks anyhow.

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

--- Comment #2 from Iain Buclaw ibuc...@gdcproject.org ---
Infact, regardless of whether or not this blocks mingw builds, it is
reproducible on all targets.  This is a *serious* bug.

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Johannes Pfau johannesp...@gmail.com changed:

   What|Removed |Added

 CC||johannesp...@gmail.com

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

Vladimir Panteleev thecybersha...@gmail.com changed:

   What|Removed |Added

 CC||thecybersha...@gmail.com

--


[Issue 12900] REG 2.065: Wrong code in IfStatement condition Expression

2014-06-12 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=12900

yebblies yebbl...@gmail.com changed:

   What|Removed |Added

 CC||yebbl...@gmail.com

--- Comment #3 from yebblies yebbl...@gmail.com ---
If it doesn't have a test case or assert in dmd it's probably not going to stay
fixed.

--