[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

Dlang Bot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Dlang Bot  ---
dlang/phobos pull request #7205 "Fix Issue 15230 - Inconsistent
std.range.SortedRange predicate checks" was merged into master:

- 58c3a7573865f70f5c25b15af4a70257b3a8998e by Berni:
  Fix Issue 15230 - Inconsistent std.range.SortedRange predicate checks

https://github.com/dlang/phobos/pull/7205

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

Dlang Bot  changed:

   What|Removed |Added

   Keywords||pull

--- Comment #6 from Dlang Bot  ---
@crocopaw created dlang/phobos pull request #7205 "Fix Issue 15230 -
Inconsistent std.range.SortedRange predicate checks" fixing this issue:

- Fix Issue 15230 - Inconsistent std.range.SortedRange predicate checks

https://github.com/dlang/phobos/pull/7205

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

Berni  changed:

   What|Removed |Added

 CC||dl...@croco-puzzle.com

--- Comment #5 from Berni  ---
An other solution might be, to add an (optional) option parameter, like in
https://dlang.org/phobos/std_range.html#transposed. The parameter decides if
sortedness should be striktly checked (O(n)), roughly checked (O(log(n)) or
assumed.

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

Vladimir Panteleev  changed:

   What|Removed |Added

 CC||freeslav...@gmail.com

--- Comment #4 from Vladimir Panteleev  ---
*** Issue 15537 has been marked as a duplicate of this issue. ***

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

--- Comment #3 from Vladimir Panteleev  ---
Verifying the predicate statically regardless of -debug does sound like a good
idea.

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

--- Comment #2 from John Colvin  ---
(In reply to Jack Stouffer from comment #1)
> I would consider this as "working as intended", as the checks are only
> supposed to happen in debug mode. In a PR of mine, I asked @schveiguy if it
> made any sense to have any checks in a function that is supposed to be
> assuming something. He said it's strange, but it's nice to have something
> that double checks for you, in debug mode only.

It's fine to have extra runtime checks in debug mode that check data, but I
think the API should not change. The predicate should either always be verified
to be valid or be optional.

--

[Issue 15230] Inconsistent std.range.SortedRange predicate checks

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15230

Jack Stouffer  changed:

   What|Removed |Added

 CC||j...@jackstouffer.com

--- Comment #1 from Jack Stouffer  ---
I would consider this as "working as intended", as the checks are only supposed
to happen in debug mode. In a PR of mine, I asked @schveiguy if it made any
sense to have any checks in a function that is supposed to be assuming
something. He said it's strange, but it's nice to have something that double
checks for you, in debug mode only.

--