[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #9 from github-bugzi...@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/02074889d5984093b677a1c081c33fbf877360ec
Fix Issue 16564 - KRRegion.empty sometimes returns Ternary.no

https://github.com/dlang/phobos/commit/1649edd483519a5d60c7b38865e984b46d703cdf
Merge pull request #5862 from jercaianu/krr

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #8 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/02074889d5984093b677a1c081c33fbf877360ec
Fix Issue 16564 - KRRegion.empty sometimes returns Ternary.no

https://github.com/dlang/phobos/commit/1649edd483519a5d60c7b38865e984b46d703cdf
Merge pull request #5862 from jercaianu/krr

Fix Issue 16564 - KRRegion.empty sometimes returns Ternary.no
merged-on-behalf-of: Andrei Alexandrescu <andra...@users.noreply.github.com>

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

github-bugzi...@puremagic.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

alex.jercai...@gmail.com changed:

   What|Removed |Added

 CC||alex.jercai...@gmail.com
   Assignee|nob...@puremagic.com|alex.jercai...@gmail.com

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

Lucia Cojocaru  changed:

   What|Removed |Added

   Assignee|lucia.mcojoc...@gmail.com   |nob...@puremagic.com

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #7 from Temtaime  ---
Oh, sorry, my mistake

import
std.stdio,
std.range,
std.random,
std.typecons,
std.algorithm,

std.experimental.allocator.building_blocks,

core.memory;


void main()
{
ubyte[128 * 1024] b;
auto alloc = KRRegion!()(b);

//alloc.switchToFreeList;

auto k = alloc.allocate(128);
assert(alloc.deallocate(k));

assert(alloc.empty == Ternary.yes);
}

I don't know why but this simplest example asserts.
More complex tests are passed. Also it passes if the switch in uncommented

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #6 from Andrei Alexandrescu  ---
@Temtaime should this stay open?

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #5 from Vladimir Panteleev  ---
(In reply to Temtaime from comment #4)
>   ubyte[1024 * 1024] buf;


Are you sure that's not just because you have a 1MB static array on the stack?

This program, by itself, crashes on Windows (because of stack overflow):

void main()
{
ubyte[1024 * 1024] buf;
}

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

Temtaime  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #4 from Temtaime  ---
Increasing buffer size from 256 kb to 1 mb causes a crash or returns not empty
again

import
std.stdio,
std.random,
std.typecons,
std.algorithm,

std.experimental.allocator.building_blocks;


void main()
{
ubyte[1024 * 1024] buf;
auto a = KRRegion!()(buf);

while(true)
{
void[][] bufs;

foreach(_; 0..10_000)
{
bufs ~= a.allocate(uniform(1, buf.length));
}

foreach(b; bufs.randomCover)
{
a.deallocate(b);
}

if(a.empty == Ternary.no) break;
}

writeln(`all the elements are freed but allocator is not empty !`);
}

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #3 from github-bugzi...@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/8a69b104513d5f95e31be65b04a6502f559a95c0
fix issue 16564

https://github.com/dlang/phobos/commit/bb27aa7bd2b6863d50c3f19016ad8f4476709748
Merge pull request #5029 from somzzz/issue_16564

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #2 from github-bugzi...@puremagic.com ---
Commits pushed to newCTFE at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/8a69b104513d5f95e31be65b04a6502f559a95c0
fix issue 16564

https://github.com/dlang/phobos/commit/bb27aa7bd2b6863d50c3f19016ad8f4476709748
Merge pull request #5029 from somzzz/issue_16564

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

--- Comment #1 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/8a69b104513d5f95e31be65b04a6502f559a95c0
fix issue 16564

https://github.com/dlang/phobos/commit/bb27aa7bd2b6863d50c3f19016ad8f4476709748
Merge pull request #5029 from somzzz/issue_16564

fix issue 16564 - KRRegion.empty sometimes returns Ternary.no

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

Andrei Alexandrescu  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--

[Issue 16564] KRRegion.empty sometimes returns Ternary.no

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16564

Andrei Alexandrescu  changed:

   What|Removed |Added

 CC||and...@erdani.com
   Assignee|nob...@puremagic.com|lucia.mcojoc...@gmail.com

--