[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

github-bugzi...@puremagic.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

--- Comment #12 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/cef1c19991f39aa3dda07b08a79d164f6cb352df
Fix Issue 17961 - std.uni does not compile with -unittest -dip1000; rebased

https://github.com/dlang/phobos/commit/92877fddb5fff7b76e95fd35fd50036cb57b9ba4
Merge pull request #6041 from carblue/issue17961

Fix Issue 17961 - std.uni does not compile with -unittest -dip1000

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Carsten Blüggel  changed:

   What|Removed |Added

 Blocks||18585


Referenced Issues:

https://issues.dlang.org/show_bug.cgi?id=18585
[Issue 18585] Linker error if compiled with -dip1000
--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

--- Comment #11 from Carsten Blüggel  ---
(In reply to hsteoh from comment #10)
> Link: https://github.com/dlang/phobos/pull/6041

Due to lack of acceptance I closed PR
https://github.com/dlang/phobos/pull/6041.
Maybe https://github.com/dlang/phobos/pull/6212 will come to the rescue.

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Walter Bright  changed:

   What|Removed |Added

   Keywords||safe
 CC||bugzi...@digitalmars.com

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Carsten Blüggel  changed:

   What|Removed |Added

   Assignee|chi...@posteo.net   |nob...@puremagic.com

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

hst...@quickfur.ath.cx changed:

   What|Removed |Added

   Keywords||pull

--- Comment #10 from hst...@quickfur.ath.cx ---
Link: https://github.com/dlang/phobos/pull/6041

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Carsten Blüggel  changed:

   What|Removed |Added

   Assignee|nob...@puremagic.com|chi...@posteo.net

--- Comment #9 from Carsten Blüggel  ---
Fixing is under way, see PR #6041

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Martin Nowak  changed:

   What|Removed |Added

 CC||c...@dawg.eu

--- Comment #8 from Martin Nowak  ---
(In reply to Carsten Blüggel from comment #7)
> If there are no objections, I'll file a PR Fix issue 17961 - ...

Yes, those issues prevent trying out dip1000, and it's worthwhile to fix them,
even though support for all of phobos is out of reach for now.
And btw, you shouldn't ask for permission to fix an issue ;).

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Carsten Blüggel  changed:

   What|Removed |Added

 CC||chi...@posteo.net

--- Comment #7 from Carsten Blüggel  ---
Although -dip1000 is not ready, it's complaint seems to be justified in at
least 1 of 2 spots here:
The complaints originate in the function immediately preceding the reported
error line:  ref intersect()(dchar ch)
(1) There are 2 assignments to this: this = This.init...
that raise the error, IMO legitimately: reference to local variable __tmp...
assigned to non-scope parameter this.
This could be calmed down using instead: data.length(0); I hope it's an
equivalent for This.init in this case.
(2) The other one (same error msg) stems from this.byInterval in the foreach
loop and seems to be questionable.

In the end, this works with -dip1000 enabled:

ref intersect()(dchar ch)
{
scope arr = data;
foreach (i; Intervals!(typeof(data))(arr))
if (i.a <= ch && ch < i.b)
{
data.length(0);
return this.add(ch, ch+1);
}
data.length(0);
return this;
}

If there are no objections, I'll file a PR Fix issue 17961 - ...

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Jonathan M Davis  changed:

   What|Removed |Added

 CC||issues.dl...@jmdavisprog.co
   ||m

--- Comment #6 from Jonathan M Davis  ---
(In reply to hsteoh from comment #5)
> Yeah, I know Phobos is not -dip1000 ready yet.  That's probably how this PR
> got pulled in spite of the breakage. :-P
> 
> It would be nice to fix these breakages, though.  Less trouble for when we
> do want to start building Phobos with -dip1000.

I think that Walter has done a few PRs to fix DIP 1000 issues in Phobos, but as
long as -dip1000 isn't being used, we're going to continue to introduce code
that doesn't work with it and have to create new PRs to fix that breakage when
we catch it. I don't think that -dip1000 is really ready to be enabled though,
even if all of druntime and Phobos worked with it. So, we could be at this for
a while, depending on how long it takes for -dip1000 to be ready.

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

--- Comment #5 from hst...@quickfur.ath.cx ---
Yeah, I know Phobos is not -dip1000 ready yet.  That's probably how this PR got
pulled in spite of the breakage. :-P

It would be nice to fix these breakages, though.  Less trouble for when we do
want to start building Phobos with -dip1000.

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

Dmitry Olshansky  changed:

   What|Removed |Added

 CC||dmitry.o...@gmail.com

--- Comment #4 from Dmitry Olshansky  ---
(In reply to hsteoh from comment #0)
> Code:
> ---
> /* test.d */
> import std.uni;
> ---
> 
> Compile command:
> ---
> dmd -dip1000 -unittest -c test.d
> ---
> 
> Compiler output:
> ---
> /usr/src/d/phobos/std/uni.d(2554): Error: reference to local variable
> __tmpfordtor853 assigned to non-scope parameter this calling
> std.uni.InversionList!(GcPolicy).InversionList.byInterval
> /usr/src/d/phobos/std/uni.d(1976): Error: template instance
> std.uni.InversionList!(GcPolicy) error instantiating
> ---
> 
> This used to work fine until recently. Will post an update once I finish git
> bisecting.

Most curious. But AFAIK Phobos is not compiled with -dip1000 yet.

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

--- Comment #3 from hst...@quickfur.ath.cx ---
P.S., this bug pertains to Phobos git HEAD, not to any release (that I'm aware
of).

--

[Issue 17961] std.uni does not compile with -unittest -dip1000

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=17961

hst...@quickfur.ath.cx changed:

   What|Removed |Added

Summary|Git HEAD std.uni does not   |std.uni does not compile
   |compile with -unittest  |with -unittest -dip1000
   |-dip1000|

--