[Issue 6791] std.algorithm.splitter random indexes utf strings
https://d.puremagic.com/issues/show_bug.cgi?id=6791 monarchdo...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from monarchdo...@gmail.com 2014-02-27 04:15:52 PST --- This was fixed by https://github.com/D-Programming-Language/phobos/pull/1502 I think it was for the 2.065 release? Closing as Fixed. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 6791] std.algorithm.splitter random indexes utf strings
http://d.puremagic.com/issues/show_bug.cgi?id=6791 monarchdo...@gmail.com changed: What|Removed |Added CC||monarchdo...@gmail.com AssignedTo|nob...@puremagic.com|monarchdo...@gmail.com --- Comment #2 from monarchdo...@gmail.com 2013-08-18 23:25:05 PDT --- (In reply to comment #1) This is caused by struct SplitterResult in std.algorithm using array slicing and array indexing to pass char (not dchar!) to the lambda. SplitterResult appears to have multiple issues: it uses array slicing without a proper signature constraint on hasSlicing, and doesn't work properly for narrow strings because it uses indexing which for narrow strings doesn't handle multibyte UTF-8 sequences properly. It appears to be wanting a rewrite that uses only forward range primitives, or at least, an overload for narrow strings that properly take multibyte characters into account. I had submitted a correction for this about 1 year ago, but it ended up being too big in scope (*all* splitter flavors have bugs). It also ended up being messy due to (trying to avoid) code duplication. It might be better to just fix things little by little though, rather than not at all. I'll fix *just* splitter!pred: It's the easiest to fix. We'll see where we go from there. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 6791] std.algorithm.splitter random indexes utf strings
http://d.puremagic.com/issues/show_bug.cgi?id=6791 hst...@quickfur.ath.cx changed: What|Removed |Added CC||hst...@quickfur.ath.cx --- Comment #1 from hst...@quickfur.ath.cx 2013-08-18 22:22:41 PDT --- This is caused by struct SplitterResult in std.algorithm using array slicing and array indexing to pass char (not dchar!) to the lambda. SplitterResult appears to have multiple issues: it uses array slicing without a proper signature constraint on hasSlicing, and doesn't work properly for narrow strings because it uses indexing which for narrow strings doesn't handle multibyte UTF-8 sequences properly. It appears to be wanting a rewrite that uses only forward range primitives, or at least, an overload for narrow strings that properly take multibyte characters into account. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
