[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 Dmitry Olshansky changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #11 from Dmitry Olshansky 2013-09-22 01:12:35 PDT --- Flags are to be gone one day and "g" by default is not going to happen. This IMHO makes it won't fix. Anyhow the core issue should now be addressed by using new API that is more clear. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260
--- Comment #10 from Dmitry Olshansky 2013-08-17
05:33:49 PDT ---
The problem now should is addressed by this pull
https://github.com/D-Programming-Language/phobos/pull/1470
There is matchAll/matchFirst calls now that are the prefered way to go about
matching. Currently they simply override global flag if present.
Returning to the original example:
foreach (c; text.matchAll("1|2|3|4")) //this spins over captures of each match
write(c, " ");
writeln();
foreach (c; text.matchFirst("1|2|3|4")) //this spins submatches of 1st match
write(c, " ");
writeln();
To me there is little else to do aside from slooowly deprecating old flag-based
match/replace interface.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 --- Comment #9 from Dmitry Olshansky 2013-03-10 12:38:45 PDT --- (In reply to comment #8) > > Then once "g" is off we could either make .all a nop. > > Alternative is to make it opaque object that has 2 methods only .first/.all. > > The third alternative to add alias this to make .first implicit. I feel it > won't work reliably with range-based templates as it would make it "2 ranges > in > one". > > So only the first 2 are viable. I'd go with 1st that gets upgraded to the > second once people forget about "g" switch entierly. Typo - I've meant make it an opaque object then sometime later turn .all implicitly. It would still have potential to break code so it seems that just make .all implicit is better. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 --- Comment #8 from Dmitry Olshansky 2013-03-10 11:54:55 PDT --- (In reply to comment #7) > (In reply to comment #5) > > > match(someString, pattern).all //range of all matches > > match(someString, pattern).first //only the first one > > match(someString, pattern) // using the "g" flag to decide > > > (In reply to comment #6) > > > No overrides used would imply "use whatever the default mode is". > > > > How does it sound? > > > > Then we place nice bold warning that use of "g" option is discouraged and is > > provided only for compatibilty and is going be deprecated in future. > > > > A year later and depending on the mood of people it gets finally deprecated > > and > > slowly shifted towards oblivion. > > Once "g" is deprecated what is match(someString, pattern) (without all and > first) doing? Could go both ways. The other posibility I just thought about is: match(...).first - is the same as current match(...).front i.e. simplify interface for the case when 1 match is needed match(...).all - the same as current match(... with "g" overrided) i.e. a range Then once "g" is off we could either make .all a nop. Alternative is to make it opaque object that has 2 methods only .first/.all. The third alternative to add alias this to make .first implicit. I feel it won't work reliably with range-based templates as it would make it "2 ranges in one". So only the first 2 are viable. I'd go with 1st that gets upgraded to the second once people forget about "g" switch entierly. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 --- Comment #7 from bearophile_h...@eml.cc 2013-03-10 11:09:31 PDT --- (In reply to comment #5) > match(someString, pattern).all //range of all matches > match(someString, pattern).first //only the first one > match(someString, pattern) // using the "g" flag to decide (In reply to comment #6) > No overrides used would imply "use whatever the default mode is". > > How does it sound? > > Then we place nice bold warning that use of "g" option is discouraged and is > provided only for compatibilty and is going be deprecated in future. > > A year later and depending on the mood of people it gets finally deprecated > and > slowly shifted towards oblivion. Once "g" is deprecated what is match(someString, pattern) (without all and first) doing? -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260
--- Comment #6 from Dmitry Olshansky 2013-03-10
10:43:30 PDT ---
(In reply to comment #4)
> If changing std.regex.regex is not possible, then an alternative solution is
> to
> introduce the new little function "std.regex.re", that repeats on default,
> that
> is like:
>
> re(someString) === regex(someString, "g")
>
> re(someString, "d") === regex(someString, "dg")
Here is a plan based on one of my previous idea that I think is clean enough,
given the circumstances and the fact that e.g. this Perl-ism is fairly popular
in certain circles.
(Namely attaching mode of operation to the pattern itself as in
/`pattern`/`mode-suffix`).
What we do is at first specify that "g" serves only as the intended default
"mode" of this pattern.
Then introduce simple and elegant way to explicitly specify what mode of
matching to use: first, all or the default for this pattern.
The your code looks like this (I'm still pondering better names/ways for
overriding default):
void main() {
string text = "abc312de";
foreach (c; text.match("1|2|3|4").first)
write(c, " ");
writeln();
foreach (c; text.match(regex("1|2|3|4")).all) //could use string pattern as
above
write(c, " ");
writeln();
}
Then I'd try to do the same with replace.
No overrides used would imply "use whatever the default mode is".
How does it sound?
Then we place nice bold warning that use of "g" option is discouraged and is
provided only for compatibilty and is going be deprecated in future.
A year later and depending on the mood of people it gets finally deprecated and
slowly shifted towards oblivion.
I'll probably cross-post this to NG to collect opinions since this is the
largest pain point of the otherwise fine interface.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 --- Comment #5 from Dmitry Olshansky 2013-01-25 12:22:46 PST --- (In reply to comment #4) > If changing std.regex.regex is not possible, then an alternative solution is > to > introduce the new little function "std.regex.re", that repeats on default, > that > is like: > > re(someString) === regex(someString, "g") > > re(someString, "d") === regex(someString, "dg") Frankly this is stupid (sorry). Obviously the wrong turn is that people (rightfully so) associate "find all" vs "find first" with operation that is "match"/"replace" not the "regex" as in the pattern itself. Personally I think that we better go with explicit overrides on "match"/"replace"/etc. and very slowly deprecate the "g" switch. Then how the override will look like is up for debate. match(someString, pattern).all //range of all matches match(someString, pattern).first //only the first one match(someString, pattern) // using the "g" flag to decide Or pass the override as optional parameter to match: match(someString, pattern, Regex.all); match(someString, pattern, Regex.first); match(someString, pattern); //use the flag I'll probably open a poll to pick the better one. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
[Issue 7260] "g" on default in std.regex
http://d.puremagic.com/issues/show_bug.cgi?id=7260 bearophile_h...@eml.cc changed: What|Removed |Added Summary|"g" on default in |"g" on default in std.regex |std.regex.match | --- Comment #4 from bearophile_h...@eml.cc 2013-01-24 19:21:14 PST --- If changing std.regex.regex is not possible, then an alternative solution is to introduce the new little function "std.regex.re", that repeats on default, that is like: re(someString) === regex(someString, "g") re(someString, "d") === regex(someString, "dg") -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email --- You are receiving this mail because: ---
