Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues
On Fri, Jul 9, 2021 at 10:11 AM Daniel Vetter wrote: > > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. > > Cc: Christian König > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Signed-off-by: Daniel Vetter Pushed, thanks for all the r-b/acks. -Daniel > --- > committer-drm-misc.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst > index 9497a5d26a9d..110ca8b0525e 100644 > --- a/committer-drm-misc.rst > +++ b/committer-drm-misc.rst > @@ -21,6 +21,9 @@ Merge Criteria > > Right now the only hard merge criteria are: > > +* There must not be open issues or unresolved or conflicting feedback from > + anyone. Clear them up first. Defer to maintainers as needed. > + > * Patch is properly reviewed or at least Ack, i.e. don't just push your own >stuff directly. This rule holds even more for bugfix patches - it would be >embarrassing if the bugfix contains a small gotcha that review would have > -- > 2.32.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-misc-fixes
On Tue, Jul 13, 2021 at 10:44:05AM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > these two fixes in drm-misc-fixes got lost during last cycle. Sending them > now. Applied to drm-fixes, thanks. -Daniel > > Best regards > Thomas > > drm-misc-fixes-2021-07-13: > Short summary of fixes pull: > > * dma-buf: Fix fence leak in sync_file_merge() error code > * drm/panel: nt35510: Don't fail on DSI reads > The following changes since commit d330099115597bbc238d6758a4930e72b49ea9ba: > > drm/nouveau: fix dma_address check for CPU/GPU sync (2021-06-24 15:40:44 > +0200) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-07-13 > > for you to fetch changes up to ffe000217c5068c5da07ccb1c0f8cce7ad767435: > > dma-buf/sync_file: Don't leak fences on merge failure (2021-07-12 13:34:49 > +0200) > > > Short summary of fixes pull: > > * dma-buf: Fix fence leak in sync_file_merge() error code > * drm/panel: nt35510: Don't fail on DSI reads > > > Jason Ekstrand (1): > dma-buf/sync_file: Don't leak fences on merge failure > > Linus Walleij (1): > drm/panel: nt35510: Do not fail if DSI read fails > > drivers/dma-buf/sync_file.c | 13 +++-- > drivers/gpu/drm/panel/panel-novatek-nt35510.c | 4 +--- > 2 files changed, 8 insertions(+), 9 deletions(-) > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues
Am 09.07.21 um 10:11 schrieb Daniel Vetter: We kinda left this out, and I like the wording from the drm-intel side, so add that. Motivated by a discussion with Christian. I always thought this goes without saying. Cc: Christian König Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Signed-off-by: Daniel Vetter Acked-by: Thomas Zimmermann --- committer-drm-misc.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst index 9497a5d26a9d..110ca8b0525e 100644 --- a/committer-drm-misc.rst +++ b/committer-drm-misc.rst @@ -21,6 +21,9 @@ Merge Criteria Right now the only hard merge criteria are: +* There must not be open issues or unresolved or conflicting feedback from + anyone. Clear them up first. Defer to maintainers as needed. + * Patch is properly reviewed or at least Ack, i.e. don't just push your own stuff directly. This rule holds even more for bugfix patches - it would be embarrassing if the bugfix contains a small gotcha that review would have -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_signature Description: OpenPGP digital signature ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
[PULL] drm-misc-fixes
Hi Dave and Daniel, these two fixes in drm-misc-fixes got lost during last cycle. Sending them now. Best regards Thomas drm-misc-fixes-2021-07-13: Short summary of fixes pull: * dma-buf: Fix fence leak in sync_file_merge() error code * drm/panel: nt35510: Don't fail on DSI reads The following changes since commit d330099115597bbc238d6758a4930e72b49ea9ba: drm/nouveau: fix dma_address check for CPU/GPU sync (2021-06-24 15:40:44 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-07-13 for you to fetch changes up to ffe000217c5068c5da07ccb1c0f8cce7ad767435: dma-buf/sync_file: Don't leak fences on merge failure (2021-07-12 13:34:49 +0200) Short summary of fixes pull: * dma-buf: Fix fence leak in sync_file_merge() error code * drm/panel: nt35510: Don't fail on DSI reads Jason Ekstrand (1): dma-buf/sync_file: Don't leak fences on merge failure Linus Walleij (1): drm/panel: nt35510: Do not fail if DSI read fails drivers/dma-buf/sync_file.c | 13 +++-- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 4 +--- 2 files changed, 8 insertions(+), 9 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools