[PULL] drm-misc-fixes
Hi Here's this week drm-misc-fixes PR. Somehow the email wasn't sent yesterday when I first did it, so let's try again. Maxime drm-misc-fixes-2022-07-07-1: Three mode setting fixes for fsl-ldb, a fbdev removal use-after-free fix, a dma-buf fence use-after-free fix, a DMA setup fix for rockchip, an error path fix and memory corruption fix for panfrost and one more orientation quirk The following changes since commit ee7a69aa38d87a3bbced7b8245c732c05ed0c6ec: fbdev: Disable sysfb device registration when removing conflicting FBs (2022-06-29 09:51:50 +0200) are available in the Git repository at: ssh://git.freedesktop.org/git/drm/drm-misc tags/drm-misc-fixes-2022-07-07-1 for you to fetch changes up to b68277f19e31a25312c4acccadb5cf1502e52e84: drm/ssd130x: Fix pre-charge period setting (2022-07-07 10:52:03 +0200) Three mode setting fixes for fsl-ldb, a fbdev removal use-after-free fix, a dma-buf fence use-after-free fix, a DMA setup fix for rockchip, an error path fix and memory corruption fix for panfrost and one more orientation quirk Dmitry Osipenko (2): drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error drm/panfrost: Fix shrinker list corruption by madvise IOCTL Ezequiel Garcia (1): drm/ssd130x: Fix pre-charge period setting Hans de Goede (1): drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830 Liu Ying (3): drm/bridge: fsl-ldb: Fix mode clock rate validation drm/bridge: fsl-ldb: Enable split mode for LVDS dual link drm/bridge: fsl-ldb: Drop DE signal polarity inversion Steven Price (1): drm/rockchip: Detach from ARM DMA domain in attach_device Thomas Zimmermann (1): drm/aperture: Run fbdev removal before internal helpers xinhui pan (1): dma-buf: Fix one use-after-free of fence drivers/dma-buf/dma-resv.c | 2 +- drivers/gpu/drm/bridge/fsl-ldb.c | 21 ++--- drivers/gpu/drm/drm_aperture.c | 26 +++--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 15 +++ drivers/gpu/drm/panfrost/panfrost_drv.c| 4 ++-- drivers/gpu/drm/panfrost/panfrost_mmu.c| 2 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c| 17 + drivers/gpu/drm/solomon/ssd130x.c | 2 +- 8 files changed, 54 insertions(+), 35 deletions(-) signature.asc Description: PGP signature
Re: [PATCH] doc: Mention dim cherry-pick command in getting started page
On 7/7/22 23:08, Rodrigo Vivi wrote: > On Thu, Jul 07, 2022 at 10:07:12PM +0200, Javier Martinez Canillas wrote: [snip] >> I see the content of that page as a dim workflow summary and that's why I >> think that cherry-pick should be part of it (just like you have checkout, >> apply, push, etc). After all, applying from the list and cherry-picking >> are the two operations that most developers are going to do with dim. >> >> But if the agreement is that this shouldn't be in that page, I can move it >> somewhere else. > > I actually don't have strong preferences on the place... With Daniel and Jani > on vacation I will merge this right now and we can always move things later. > Sounds good to me. Thanks! > Better to have this info there than nowhere. Thanks for the patch! > Sure, I'll be happy to post a follow-up patch if they prefer to have it in another page. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Re: [PATCH] doc: Mention dim cherry-pick command in getting started page
On Thu, Jul 07, 2022 at 10:07:12PM +0200, Javier Martinez Canillas wrote: > Hello Rodrigo, > > Thanks for your feedback. > > On 7/7/22 20:50, Rodrigo Vivi wrote: > > On Thu, Jul 07, 2022 at 12:06:44PM +0200, Thomas Zimmermann wrote: > > [snip] > > >>> diff --git a/getting-started.rst b/getting-started.rst > >>> index ea672497982d..44043fb2e5b3 100644 > >>> --- a/getting-started.rst > >>> +++ b/getting-started.rst > > > > The addition is good, but should we really put this in this getting start > > section? > > or improve the dim doc itself: > > https://drm.pages.freedesktop.org/maintainer-tools/dim.html > > > > or maybe because this is really useful for the drm-misc committers > > add it to the drm-misc pages like: > > https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html > > > > This patch was driven by the fact that I made this mistake even when have > been using dim for some time. A patch landed in -rc5 via drm-misc-fixes, > and I missed that a follow-up patch was also needed to have a complete fix. > > So I thought that this information should be in a very prominent place and > probably many developers won't look at the other documentation pages if is > enough the information that they find in the getting started page. > > I see the content of that page as a dim workflow summary and that's why I > think that cherry-pick should be part of it (just like you have checkout, > apply, push, etc). After all, applying from the list and cherry-picking > are the two operations that most developers are going to do with dim. > > But if the agreement is that this shouldn't be in that page, I can move it > somewhere else. I actually don't have strong preferences on the place... With Daniel and Jani on vacation I will merge this right now and we can always move things later. Better to have this info there than nowhere. Thanks for the patch! > > -- > Best regards, > > Javier Martinez Canillas > Linux Engineering > Red Hat >
Re: [PATCH] doc: Mention dim cherry-pick command in getting started page
Hello Rodrigo, Thanks for your feedback. On 7/7/22 20:50, Rodrigo Vivi wrote: > On Thu, Jul 07, 2022 at 12:06:44PM +0200, Thomas Zimmermann wrote: [snip] >>> diff --git a/getting-started.rst b/getting-started.rst >>> index ea672497982d..44043fb2e5b3 100644 >>> --- a/getting-started.rst >>> +++ b/getting-started.rst > > The addition is good, but should we really put this in this getting start > section? > or improve the dim doc itself: > https://drm.pages.freedesktop.org/maintainer-tools/dim.html > > or maybe because this is really useful for the drm-misc committers > add it to the drm-misc pages like: > https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html > This patch was driven by the fact that I made this mistake even when have been using dim for some time. A patch landed in -rc5 via drm-misc-fixes, and I missed that a follow-up patch was also needed to have a complete fix. So I thought that this information should be in a very prominent place and probably many developers won't look at the other documentation pages if is enough the information that they find in the getting started page. I see the content of that page as a dim workflow summary and that's why I think that cherry-pick should be part of it (just like you have checkout, apply, push, etc). After all, applying from the list and cherry-picking are the two operations that most developers are going to do with dim. But if the agreement is that this shouldn't be in that page, I can move it somewhere else. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Re: [PATCH] doc: Mention dim cherry-pick command in getting started page
On Thu, Jul 07, 2022 at 12:06:44PM +0200, Thomas Zimmermann wrote: > > > Am 07.07.22 um 11:51 schrieb Javier Martinez Canillas: > > The dim tool supports a cherry-pick that is a glorified version of the git > > command but adds additional metadata and checks if there are any follow-up > > commits referencing the one being cherry-picked. > > > > Let's document in the getting started page that the dim command should be > > used instead of just git cherry-pick. That way people will be aware of it. > > > > This is useful to avoid cherry-picking commits but miss existing fixes for > > them, which would introduce unnecessary regressions in the target branch. > > > > Signed-off-by: Javier Martinez Canillas > > Acked-by: Thomas Zimmermann > > > --- > > > > getting-started.rst | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/getting-started.rst b/getting-started.rst > > index ea672497982d..44043fb2e5b3 100644 > > --- a/getting-started.rst > > +++ b/getting-started.rst The addition is good, but should we really put this in this getting start section? or improve the dim doc itself: https://drm.pages.freedesktop.org/maintainer-tools/dim.html or maybe because this is really useful for the drm-misc committers add it to the drm-misc pages like: https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html > > @@ -71,6 +71,17 @@ rebasing) push out the new tree with:: > > This will also rebuild a new drm-tip integration tree. For historical > > reasons > > there's shortcut for the drm-intel specific branches for most of these > > commands. > > +If a commit that is already present in a branch has to be cherry-picked > > (e.g: a > > +fix for drm-misc-fixes that is already in drm-misc-next), the dim tool > > must used > > +as well instead of the git cherry-pick command. This can be done with: > > + > > +$ dim cherry-pick > > + > > +This will not only cherry-pick the commit but also add some metadata such > > as the > > +cherry-picked commit SHA-1 hash. Also checks if there were any following > > commits > > +in that branch that referenced the cherry-picked commit. This is useful to > > avoid > > +missing any follow-up fixes for the commit being cherry-picked. > > + > > Please note that if there is no specific command available from dim then > > you > > can always use your every day tooling to get things done. > > For example, if a wrong patch was applied or you need to update commit > > message > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Ivo Totev
[PULL] drm-intel-fixes
Hi Dave and Daniel, Here goes our fixes targeting 5.19-rc6. There will probably be a couple more important fixes coming next week for the -rc7 drm-intel-fixes-2022-07-07: - Fix a possible refcount leak in DP MST connector (Hangyu) - Fix on loading guc on ADL-N (Daniele) - Fix vm use-after-free in vma destruction (Thomas) Thanks, Rodrigo. The following changes since commit 79538490fd7ade244dba400923e792519a2bdfea: drm/i915: tweak the ordering in cpu_write_needs_clflush (2022-06-27 18:12:10 +0300) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2022-07-07 for you to fetch changes up to 12058077b2e963d16d2d673d46233a7f46add7c9: drm/i915: Fix vm use-after-free in vma destruction (2022-07-06 23:04:55 -0400) - Fix a possible refcount leak in DP MST connector (Hangyu) - Fix on loading guc on ADL-N (Daniele) - Fix vm use-after-free in vma destruction (Thomas) Daniele Ceraolo Spurio (1): drm/i915/guc: ADL-N should use the same GuC FW as ADL-S Hangyu Hua (1): drm/i915: fix a possible refcount leak in intel_dp_add_mst_connector() Thomas Hellström (1): drm/i915: Fix vm use-after-free in vma destruction drivers/gpu/drm/i915/display/intel_dp_mst.c | 1 + drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c| 9 + drivers/gpu/drm/i915/i915_vma.c | 12 3 files changed, 18 insertions(+), 4 deletions(-)
Re: [PATCH] doc: Mention dim cherry-pick command in getting started page
Am 07.07.22 um 11:51 schrieb Javier Martinez Canillas: The dim tool supports a cherry-pick that is a glorified version of the git command but adds additional metadata and checks if there are any follow-up commits referencing the one being cherry-picked. Let's document in the getting started page that the dim command should be used instead of just git cherry-pick. That way people will be aware of it. This is useful to avoid cherry-picking commits but miss existing fixes for them, which would introduce unnecessary regressions in the target branch. Signed-off-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann --- getting-started.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/getting-started.rst b/getting-started.rst index ea672497982d..44043fb2e5b3 100644 --- a/getting-started.rst +++ b/getting-started.rst @@ -71,6 +71,17 @@ rebasing) push out the new tree with:: This will also rebuild a new drm-tip integration tree. For historical reasons there's shortcut for the drm-intel specific branches for most of these commands. +If a commit that is already present in a branch has to be cherry-picked (e.g: a +fix for drm-misc-fixes that is already in drm-misc-next), the dim tool must used +as well instead of the git cherry-pick command. This can be done with: + +$ dim cherry-pick + +This will not only cherry-pick the commit but also add some metadata such as the +cherry-picked commit SHA-1 hash. Also checks if there were any following commits +in that branch that referenced the cherry-picked commit. This is useful to avoid +missing any follow-up fixes for the commit being cherry-picked. + Please note that if there is no specific command available from dim then you can always use your every day tooling to get things done. For example, if a wrong patch was applied or you need to update commit message -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev OpenPGP_signature Description: OpenPGP digital signature
[PATCH] doc: Mention dim cherry-pick command in getting started page
The dim tool supports a cherry-pick that is a glorified version of the git command but adds additional metadata and checks if there are any follow-up commits referencing the one being cherry-picked. Let's document in the getting started page that the dim command should be used instead of just git cherry-pick. That way people will be aware of it. This is useful to avoid cherry-picking commits but miss existing fixes for them, which would introduce unnecessary regressions in the target branch. Signed-off-by: Javier Martinez Canillas --- getting-started.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/getting-started.rst b/getting-started.rst index ea672497982d..44043fb2e5b3 100644 --- a/getting-started.rst +++ b/getting-started.rst @@ -71,6 +71,17 @@ rebasing) push out the new tree with:: This will also rebuild a new drm-tip integration tree. For historical reasons there's shortcut for the drm-intel specific branches for most of these commands. +If a commit that is already present in a branch has to be cherry-picked (e.g: a +fix for drm-misc-fixes that is already in drm-misc-next), the dim tool must used +as well instead of the git cherry-pick command. This can be done with: + +$ dim cherry-pick + +This will not only cherry-pick the commit but also add some metadata such as the +cherry-picked commit SHA-1 hash. Also checks if there were any following commits +in that branch that referenced the cherry-picked commit. This is useful to avoid +missing any follow-up fixes for the commit being cherry-picked. + Please note that if there is no specific command available from dim then you can always use your every day tooling to get things done. For example, if a wrong patch was applied or you need to update commit message -- 2.36.1
[PULL] drm-misc-next
Hi Dave and Daniel, here's the PR for drm-misc-next. Best regards Thomas drm-misc-next-2022-07-07: drm-misc-next for v5.20: UAPI Changes: Cross-subsystem Changes: Core Changes: * crtc: Remove unnessary include statements from drm_crtc.h, plus fallout in drivers * edid: More use of struct drm_edid; implement HF-EEODB extension Driver Changes: * bridge: * anx7625: Implement HDP timeout via callback; Cleanups * fsl-ldb: Drop DE flip; Modesetting fixes * imx: Depend on ARCH_MXC * sil8620: Fix off-by-one * ti-sn65dsi86: Convert to atomic modesetting * ingenic: Fix display at maximum resolution * panel: * simple: Add support for HannStar HSD101PWW2, plus DT bindings; Add support for ETML0700Y5DHA, plus DT bindings * rockchip: Fixes * vc4: Cleanups * vmwgfx: Cleanups The following changes since commit 6fb5ee7cec06266a29f25ecc01a23b9d107f64e1: iosys-map: Add per-word write (2022-06-29 17:42:28 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2022-07-07 for you to fetch changes up to 3915f8bddefda1c914d5c3149d329819a988761f: drm: xlnx: add for readl/writel (2022-07-06 22:54:51 +0300) drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: Core Changes: * crtc: Remove unnessary include statements from drm_crtc.h, plus fallout in drivers * edid: More use of struct drm_edid; implement HF-EEODB extension Driver Changes: * bridge: * anx7625: Implement HDP timeout via callback; Cleanups * fsl-ldb: Drop DE flip; Modesetting fixes * imx: Depend on ARCH_MXC * sil8620: Fix off-by-one * ti-sn65dsi86: Convert to atomic modesetting * ingenic: Fix display at maximum resolution * panel: * simple: Add support for HannStar HSD101PWW2, plus DT bindings; Add support for ETML0700Y5DHA, plus DT bindings * rockchip: Fixes * vc4: Cleanups * vmwgfx: Cleanups Anton Bambura (1): dt-bindings: sharp,lq101r1sx01: Add compatible for LQ101R1SX03 Brian Norris (1): drm/rockchip: vop: Don't crash for invalid duplicate_state() Christophe JAILLET (1): drm/rockchip: Fix an error handling path rockchip_dp_probe() Geert Uytterhoeven (1): drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC Hangyu Hua (1): drm: bridge: sii8620: fix possible off-by-one Hsin-Yi Wang (4): drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device() drm/bridge: anx7625: use pm_runtime_force_suspend(resume) drm/bridge: anx7625: Fix NULL pointer crash when using edp-panel drm/bridge: anx7625: Add wait_hpd_asserted() callback Jani Nikula (10): drm/edid: move drm_connector_update_edid_property() to drm_edid.c drm/edid: convert drm_connector_update_edid_property() to struct drm_edid drm/edid: clean up connector update error handling and debug logging drm/edid: abstract debugfs override EDID set/reset drm/edid: add drm_edid_connector_update() drm/probe-helper: add drm_connector_helper_get_modes() drm/edid: add drm_edid_raw() to access the raw EDID data drm/edid: do invalid block filtering in-place drm/edid: add HF-EEODB support to EDID read and allocation drm/edid: take HF-EEODB extension count into account Liu Ying (2): drm/bridge: fsl-ldb: Fix mode clock rate validation drm/bridge: fsl-ldb: Enable split mode for LVDS dual link Marco Felsch (2): dt-bindings: display: simple: add EDT ETML0700Y5DHA panel drm/panel: simple: add ETML0700Y5DHA panel Marek Vasut (1): drm: bridge: ldb: Drop DE flip from Freescale i.MX8MP LDB bridge Paul Cercueil (1): drm/ingenic: Use the highest possible DMA burst size Randy Dunlap (1): drm: xlnx: add for readl/writel Sam Ravnborg (1): drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs Svyatoslav Ryhel (2): dt-bindings: display: simple: Add HannStar HSD101PWW2 drm/panel: simple: Add support for HannStar HSD101PWW2 panel Tom Rix (1): drm/vc4: change vc4_dma_range_matches from a global to static Ville Syrjälä (5): drm: Remove unnecessary junk from drm_crtc.h drm/vmwgfx: Stop using 'TRUE' drm: Remove linux/fb.h from drm_crtc.h drm: Remove linux/media-bus-format.h from drm_crtc.h drm: Remove linux/i2c.h from drm_crtc.h .../bindings/display/panel/panel-simple.yaml | 4 + .../bindings/display/panel/sharp,lq101r1sx01.yaml | 7 +- .../gpu/drm/arm/display/komeda/komeda_pipeline.c | 2 + drivers/gpu/drm/armada/armada_510.c| 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 179 -- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c| 1
