Re: [PULL] drm-misc-fixes
On Thu, Mar 30, 2023 at 04:10:06PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's the weekly PR for drm-misc-fixes. > > Best regards > Thomas > > drm-misc-fixes-2023-03-30: > Short summary of fixes pull: > > * various ivpu fixes > * fix nouveau backlight registration > * fix buddy allocator in 32-bit systems > The following changes since commit 1a70ca89d59c7c8af006d29b965a95ede0abb0da: > > drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found (2023-03-22 > 18:01:57 +0100) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2023-03-30 Pulled, thanks > > for you to fetch changes up to 25bbe844ef5c4fb4d7d8dcaa0080f922b7cd3a16: > > drm: test: Fix 32-bit issue in drm_buddy_test (2023-03-29 17:14:15 +0200) > > > Short summary of fixes pull: > > * various ivpu fixes > * fix nouveau backlight registration > * fix buddy allocator in 32-bit systems > > > Andrzej Kacprowski (1): > accel/ivpu: Fix IPC buffer header status field value > > David Gow (2): > drm: buddy_allocator: Fix buddy allocator init on 32-bit systems > drm: test: Fix 32-bit issue in drm_buddy_test > > Hans de Goede (1): > drm/nouveau/kms: Fix backlight registration > > Stanislaw Gruszka (7): > accel/ivpu: Do not access HW registers after unbind > accel/ivpu: Cancel recovery work > accel/ivpu: Do not use SSID 1 > accel/ivpu: Fix power down sequence > accel/ivpu: Disable buttress on device removal > accel/ivpu: Remove support for 1 tile SKUs > accel/ivpu: Fix VPU clock calculation > > drivers/accel/ivpu/ivpu_drv.c | 18 - > drivers/accel/ivpu/ivpu_drv.h | 7 +- > drivers/accel/ivpu/ivpu_hw_mtl.c| 113 > +--- > drivers/accel/ivpu/ivpu_ipc.h | 2 +- > drivers/accel/ivpu/ivpu_job.c | 11 ++- > drivers/accel/ivpu/ivpu_pm.c| 17 - > drivers/accel/ivpu/ivpu_pm.h| 1 + > drivers/gpu/drm/drm_buddy.c | 4 +- > drivers/gpu/drm/nouveau/nouveau_backlight.c | 7 +- > drivers/gpu/drm/tests/drm_buddy_test.c | 3 +- > 10 files changed, 90 insertions(+), 93 deletions(-) > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Thu, Mar 30, 2023 at 02:30:29PM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2023-03-30: > drm/i915 fixes for v6.3-rc5: > - Fix PMU support by reusing functions with sysfs > - Fix a number of issues related to color, PSR and arm/noarm > - Fix state check related to ICL PHY ownership check in TC-cold state > - Flush lmem contents after construction > - Fix hibernate oops related to DPT BO > - Fix perf stream error path wakeref balance > > BR, > Jani. > > The following changes since commit 197b6b60ae7bc51dd0814953c562833143b292aa: > > Linux 6.3-rc4 (2023-03-26 14:40:20 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-03-30 Pulled, thanks. > > for you to fetch changes up to 5c95b2d5d44fa250ce8aeee27bdb39b381d03857: > > drm/i915/perf: Drop wakeref on GuC RC error (2023-03-27 13:22:24 +0300) > > > drm/i915 fixes for v6.3-rc5: > - Fix PMU support by reusing functions with sysfs > - Fix a number of issues related to color, PSR and arm/noarm > - Fix state check related to ICL PHY ownership check in TC-cold state > - Flush lmem contents after construction > - Fix hibernate oops related to DPT BO > - Fix perf stream error path wakeref balance > > > Ashutosh Dixit (1): > drm/i915/pmu: Use functions common with sysfs to read actual freq > > Chris Wilson (2): > drm/i915/gem: Flush lmem contents after construction > drm/i915/perf: Drop wakeref on GuC RC error > > Imre Deak (1): > drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state > > Ville Syrjälä (6): > drm/i915: Split icl_color_commit_noarm() from skl_color_commit_noarm() > drm/i915: Move CSC load back into .color_commit_arm() when PSR is > enabled on skl/glk > drm/i915: Add a .color_post_update() hook > drm/i915: Workaround ICL CSC_MODE sticky arming > drm/i915: Disable DC states for all commits > drm/i915/dpt: Treat the DPT BO as a framebuffer > > drivers/gpu/drm/i915/display/intel_color.c | 101 > ++- > drivers/gpu/drm/i915/display/intel_color.h | 1 + > drivers/gpu/drm/i915/display/intel_display.c | 31 ++- > drivers/gpu/drm/i915/display/intel_dpt.c | 2 + > drivers/gpu/drm/i915/display/intel_tc.c | 4 +- > drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 3 +- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 3 + > drivers/gpu/drm/i915/gt/intel_rps.c | 38 + > drivers/gpu/drm/i915/gt/intel_rps.h | 4 +- > drivers/gpu/drm/i915/i915_perf.c | 14 ++-- > drivers/gpu/drm/i915/i915_perf_types.h | 6 ++ > drivers/gpu/drm/i915/i915_pmu.c | 10 +-- > 13 files changed, 177 insertions(+), 42 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH] dim: Don't escape forward slash for grep
On Thu, Mar 30, 2023 at 11:49:50AM -0400, Rodrigo Vivi wrote: > On Thu, Mar 30, 2023 at 06:42:53PM +0300, Jani Nikula wrote: > > On Thu, 30 Mar 2023, Rodrigo Vivi wrote: > > > On Wed, Mar 29, 2023 at 10:53:53PM +0300, Ville Syrjälä wrote: > > >> On Wed, Feb 08, 2023 at 08:21:51AM -0500, Rodrigo Vivi wrote: > > >> > On Wed, Feb 08, 2023 at 03:32:43AM +0200, Ville Syrjala wrote: > > >> > > From: Ville Syrjälä > > >> > > > > >> > > GNU grep 3.8 started to complain about backslashes where > > >> > > they're not needed: > > >> > > grep: warning: stray \ before / > > >> > > Get rid of them. > > >> > > > > >> > > Signed-off-by: Ville Syrjälä > > >> > > --- > > >> > > dim | 6 +++--- > > >> > > 1 file changed, 3 insertions(+), 3 deletions(-) > > >> > > > > >> > > diff --git a/dim b/dim > > >> > > index b87b54259f8b..296feb9dd314 100755 > > >> > > --- a/dim > > >> > > +++ b/dim > > >> > > @@ -503,7 +503,7 @@ function dim_retip > > >> > > if repo_to_remote drm-tip &> /dev/null ; then > > >> > > new_upstream=$(repo_to_remote drm-tip)/drm-tip > > >> > > else > > >> > > -new_upstream=$(git branch -r | grep '\/drm-tip$') > > >> > > +new_upstream=$(git branch -r | grep '/drm-tip$') > > >> > > > >> > this I knew it would work... because of ' ' > > >> > > > >> > > fi > > >> > > upstream=$(git_find_tip "$branch") > > >> > > > > >> > > @@ -1124,12 +1124,12 @@ function check_diff_prefix > > >> > > local rv patch msg patch_recoded > > >> > > patch="$1" > > >> > > > > >> > > -rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" $patch) > > >> > > +rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch) > > >> > > > >> > but here with " " > > >> > I had my doubts... but confirmed that it does work with previous > > >> > grep 3.7. > > >> > > > >> > I hope it doesn't go badly with older grep versions... > > >> > > > >> > with this hope > > >> > > > >> > Reviewed-by: Rodrigo Vivi > > >> > > >> I can't push this btw. -EPERM or something. > > > > > > per rules we need Jani's or Daniel's ack, then I can help on > > > pushing it... > > > > Acked-by: Jani Nikula > > thanks, pushed. Hm I thought that we've switched to "people with push rights can push"? Probably should. > > Daniel, is it time we switched the whole thing to merge request process > > btw? > > +1! Yeah can do. I think atm it's a bit max awkward since some is here and some is on gitlab ... Documentation patch I guess? -Daniel > > > > > BR, > > Jani. > > > > > > > > > > > >> > > >> > > > >> > > > >> > > if [ -z "$rv" ]; then > > >> > > msg=$(mktemp --tmpdir dim-msg.XX) > > >> > > patch_recoded=$(mktemp --tmpdir dim-patch.XX) > > >> > > git mailinfo "$msg" "$patch_recoded" < $patch >/dev/null > > >> > > -rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" > > >> > > $patch_recoded) > > >> > > +rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch_recoded) > > >> > > rm "$msg" "$patch_recoded" > > >> > > fi > > >> > > > > >> > > -- > > >> > > 2.39.1 > > >> > > > > >> > > >> -- > > >> Ville Syrjälä > > >> Intel > > > > -- > > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH] dim: Don't escape forward slash for grep
On Thu, Mar 30, 2023 at 06:42:53PM +0300, Jani Nikula wrote: > On Thu, 30 Mar 2023, Rodrigo Vivi wrote: > > On Wed, Mar 29, 2023 at 10:53:53PM +0300, Ville Syrjälä wrote: > >> On Wed, Feb 08, 2023 at 08:21:51AM -0500, Rodrigo Vivi wrote: > >> > On Wed, Feb 08, 2023 at 03:32:43AM +0200, Ville Syrjala wrote: > >> > > From: Ville Syrjälä > >> > > > >> > > GNU grep 3.8 started to complain about backslashes where > >> > > they're not needed: > >> > > grep: warning: stray \ before / > >> > > Get rid of them. > >> > > > >> > > Signed-off-by: Ville Syrjälä > >> > > --- > >> > > dim | 6 +++--- > >> > > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > > >> > > diff --git a/dim b/dim > >> > > index b87b54259f8b..296feb9dd314 100755 > >> > > --- a/dim > >> > > +++ b/dim > >> > > @@ -503,7 +503,7 @@ function dim_retip > >> > >if repo_to_remote drm-tip &> /dev/null ; then > >> > >new_upstream=$(repo_to_remote drm-tip)/drm-tip > >> > >else > >> > > - new_upstream=$(git branch -r | grep '\/drm-tip$') > >> > > + new_upstream=$(git branch -r | grep '/drm-tip$') > >> > > >> > this I knew it would work... because of ' ' > >> > > >> > >fi > >> > >upstream=$(git_find_tip "$branch") > >> > > > >> > > @@ -1124,12 +1124,12 @@ function check_diff_prefix > >> > >local rv patch msg patch_recoded > >> > >patch="$1" > >> > > > >> > > - rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" $patch) > >> > > + rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch) > >> > > >> > but here with " " > >> > I had my doubts... but confirmed that it does work with previous > >> > grep 3.7. > >> > > >> > I hope it doesn't go badly with older grep versions... > >> > > >> > with this hope > >> > > >> > Reviewed-by: Rodrigo Vivi > >> > >> I can't push this btw. -EPERM or something. > > > > per rules we need Jani's or Daniel's ack, then I can help on > > pushing it... > > Acked-by: Jani Nikula thanks, pushed. > > Daniel, is it time we switched the whole thing to merge request process > btw? +1! > > BR, > Jani. > > > > > > >> > >> > > >> > > >> > >if [ -z "$rv" ]; then > >> > >msg=$(mktemp --tmpdir dim-msg.XX) > >> > >patch_recoded=$(mktemp --tmpdir dim-patch.XX) > >> > >git mailinfo "$msg" "$patch_recoded" < $patch >/dev/null > >> > > - rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" > >> > > $patch_recoded) > >> > > + rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch_recoded) > >> > >rm "$msg" "$patch_recoded" > >> > >fi > >> > > > >> > > -- > >> > > 2.39.1 > >> > > > >> > >> -- > >> Ville Syrjälä > >> Intel > > -- > Jani Nikula, Intel Open Source Graphics Center
Re: [PATCH] dim: Don't escape forward slash for grep
On Thu, 30 Mar 2023, Rodrigo Vivi wrote: > On Wed, Mar 29, 2023 at 10:53:53PM +0300, Ville Syrjälä wrote: >> On Wed, Feb 08, 2023 at 08:21:51AM -0500, Rodrigo Vivi wrote: >> > On Wed, Feb 08, 2023 at 03:32:43AM +0200, Ville Syrjala wrote: >> > > From: Ville Syrjälä >> > > >> > > GNU grep 3.8 started to complain about backslashes where >> > > they're not needed: >> > > grep: warning: stray \ before / >> > > Get rid of them. >> > > >> > > Signed-off-by: Ville Syrjälä >> > > --- >> > > dim | 6 +++--- >> > > 1 file changed, 3 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/dim b/dim >> > > index b87b54259f8b..296feb9dd314 100755 >> > > --- a/dim >> > > +++ b/dim >> > > @@ -503,7 +503,7 @@ function dim_retip >> > > if repo_to_remote drm-tip &> /dev/null ; then >> > > new_upstream=$(repo_to_remote drm-tip)/drm-tip >> > > else >> > > -new_upstream=$(git branch -r | grep '\/drm-tip$') >> > > +new_upstream=$(git branch -r | grep '/drm-tip$') >> > >> > this I knew it would work... because of ' ' >> > >> > > fi >> > > upstream=$(git_find_tip "$branch") >> > > >> > > @@ -1124,12 +1124,12 @@ function check_diff_prefix >> > > local rv patch msg patch_recoded >> > > patch="$1" >> > > >> > > -rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" $patch) >> > > +rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch) >> > >> > but here with " " >> > I had my doubts... but confirmed that it does work with previous >> > grep 3.7. >> > >> > I hope it doesn't go badly with older grep versions... >> > >> > with this hope >> > >> > Reviewed-by: Rodrigo Vivi >> >> I can't push this btw. -EPERM or something. > > per rules we need Jani's or Daniel's ack, then I can help on > pushing it... Acked-by: Jani Nikula Daniel, is it time we switched the whole thing to merge request process btw? BR, Jani. > >> >> > >> > >> > > if [ -z "$rv" ]; then >> > > msg=$(mktemp --tmpdir dim-msg.XX) >> > > patch_recoded=$(mktemp --tmpdir dim-patch.XX) >> > > git mailinfo "$msg" "$patch_recoded" < $patch >/dev/null >> > > -rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" >> > > $patch_recoded) >> > > +rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch_recoded) >> > > rm "$msg" "$patch_recoded" >> > > fi >> > > >> > > -- >> > > 2.39.1 >> > > >> >> -- >> Ville Syrjälä >> Intel -- Jani Nikula, Intel Open Source Graphics Center
Re: [PATCH] dim: Don't escape forward slash for grep
On Wed, Mar 29, 2023 at 10:53:53PM +0300, Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 08:21:51AM -0500, Rodrigo Vivi wrote: > > On Wed, Feb 08, 2023 at 03:32:43AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > GNU grep 3.8 started to complain about backslashes where > > > they're not needed: > > > grep: warning: stray \ before / > > > Get rid of them. > > > > > > Signed-off-by: Ville Syrjälä > > > --- > > > dim | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/dim b/dim > > > index b87b54259f8b..296feb9dd314 100755 > > > --- a/dim > > > +++ b/dim > > > @@ -503,7 +503,7 @@ function dim_retip > > > if repo_to_remote drm-tip &> /dev/null ; then > > > new_upstream=$(repo_to_remote drm-tip)/drm-tip > > > else > > > - new_upstream=$(git branch -r | grep '\/drm-tip$') > > > + new_upstream=$(git branch -r | grep '/drm-tip$') > > > > this I knew it would work... because of ' ' > > > > > fi > > > upstream=$(git_find_tip "$branch") > > > > > > @@ -1124,12 +1124,12 @@ function check_diff_prefix > > > local rv patch msg patch_recoded > > > patch="$1" > > > > > > - rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" $patch) > > > + rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch) > > > > but here with " " > > I had my doubts... but confirmed that it does work with previous > > grep 3.7. > > > > I hope it doesn't go badly with older grep versions... > > > > with this hope > > > > Reviewed-by: Rodrigo Vivi > > I can't push this btw. -EPERM or something. per rules we need Jani's or Daniel's ack, then I can help on pushing it... > > > > > > > > if [ -z "$rv" ]; then > > > msg=$(mktemp --tmpdir dim-msg.XX) > > > patch_recoded=$(mktemp --tmpdir dim-patch.XX) > > > git mailinfo "$msg" "$patch_recoded" < $patch >/dev/null > > > - rv=$(grep -q -E "^diff --git a\/.+ b\/.+$" $patch_recoded) > > > + rv=$(grep -q -E "^diff --git a/.+ b/.+$" $patch_recoded) > > > rm "$msg" "$patch_recoded" > > > fi > > > > > > -- > > > 2.39.1 > > > > > -- > Ville Syrjälä > Intel
[PULL] drm-misc-fixes
Hi Dave and Daniel, here's the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-03-30: Short summary of fixes pull: * various ivpu fixes * fix nouveau backlight registration * fix buddy allocator in 32-bit systems The following changes since commit 1a70ca89d59c7c8af006d29b965a95ede0abb0da: drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found (2023-03-22 18:01:57 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2023-03-30 for you to fetch changes up to 25bbe844ef5c4fb4d7d8dcaa0080f922b7cd3a16: drm: test: Fix 32-bit issue in drm_buddy_test (2023-03-29 17:14:15 +0200) Short summary of fixes pull: * various ivpu fixes * fix nouveau backlight registration * fix buddy allocator in 32-bit systems Andrzej Kacprowski (1): accel/ivpu: Fix IPC buffer header status field value David Gow (2): drm: buddy_allocator: Fix buddy allocator init on 32-bit systems drm: test: Fix 32-bit issue in drm_buddy_test Hans de Goede (1): drm/nouveau/kms: Fix backlight registration Stanislaw Gruszka (7): accel/ivpu: Do not access HW registers after unbind accel/ivpu: Cancel recovery work accel/ivpu: Do not use SSID 1 accel/ivpu: Fix power down sequence accel/ivpu: Disable buttress on device removal accel/ivpu: Remove support for 1 tile SKUs accel/ivpu: Fix VPU clock calculation drivers/accel/ivpu/ivpu_drv.c | 18 - drivers/accel/ivpu/ivpu_drv.h | 7 +- drivers/accel/ivpu/ivpu_hw_mtl.c| 113 +--- drivers/accel/ivpu/ivpu_ipc.h | 2 +- drivers/accel/ivpu/ivpu_job.c | 11 ++- drivers/accel/ivpu/ivpu_pm.c| 17 - drivers/accel/ivpu/ivpu_pm.h| 1 + drivers/gpu/drm/drm_buddy.c | 4 +- drivers/gpu/drm/nouveau/nouveau_backlight.c | 7 +- drivers/gpu/drm/tests/drm_buddy_test.c | 3 +- 10 files changed, 90 insertions(+), 93 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
[PULL] drm-intel-fixes
Hi Dave & Daniel - drm-intel-fixes-2023-03-30: drm/i915 fixes for v6.3-rc5: - Fix PMU support by reusing functions with sysfs - Fix a number of issues related to color, PSR and arm/noarm - Fix state check related to ICL PHY ownership check in TC-cold state - Flush lmem contents after construction - Fix hibernate oops related to DPT BO - Fix perf stream error path wakeref balance BR, Jani. The following changes since commit 197b6b60ae7bc51dd0814953c562833143b292aa: Linux 6.3-rc4 (2023-03-26 14:40:20 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-03-30 for you to fetch changes up to 5c95b2d5d44fa250ce8aeee27bdb39b381d03857: drm/i915/perf: Drop wakeref on GuC RC error (2023-03-27 13:22:24 +0300) drm/i915 fixes for v6.3-rc5: - Fix PMU support by reusing functions with sysfs - Fix a number of issues related to color, PSR and arm/noarm - Fix state check related to ICL PHY ownership check in TC-cold state - Flush lmem contents after construction - Fix hibernate oops related to DPT BO - Fix perf stream error path wakeref balance Ashutosh Dixit (1): drm/i915/pmu: Use functions common with sysfs to read actual freq Chris Wilson (2): drm/i915/gem: Flush lmem contents after construction drm/i915/perf: Drop wakeref on GuC RC error Imre Deak (1): drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state Ville Syrjälä (6): drm/i915: Split icl_color_commit_noarm() from skl_color_commit_noarm() drm/i915: Move CSC load back into .color_commit_arm() when PSR is enabled on skl/glk drm/i915: Add a .color_post_update() hook drm/i915: Workaround ICL CSC_MODE sticky arming drm/i915: Disable DC states for all commits drm/i915/dpt: Treat the DPT BO as a framebuffer drivers/gpu/drm/i915/display/intel_color.c | 101 ++- drivers/gpu/drm/i915/display/intel_color.h | 1 + drivers/gpu/drm/i915/display/intel_display.c | 31 ++- drivers/gpu/drm/i915/display/intel_dpt.c | 2 + drivers/gpu/drm/i915/display/intel_tc.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 3 + drivers/gpu/drm/i915/gt/intel_rps.c | 38 + drivers/gpu/drm/i915/gt/intel_rps.h | 4 +- drivers/gpu/drm/i915/i915_perf.c | 14 ++-- drivers/gpu/drm/i915/i915_perf_types.h | 6 ++ drivers/gpu/drm/i915/i915_pmu.c | 10 +-- 13 files changed, 177 insertions(+), 42 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center
