Re: [jQuery] ajax bug or I am really confused?

[Ian Struble]

Hi Jake.

I read over your bug ticket and believe that we are really talking
about two seperate things that just happen to find themselves at the
same spot in the code; one, can we remove or update the Connection:
close hack and two, can we add  a i-really-really-really-want-xml
update.

If we want to leave it together as a single ticket, we should add a
little something about why it is ok to remove the existing hack to the
ticket.  I am more inclined to just add another ticket since it it
probably easier to work two items.  I'll update your ticket with
background information about why it is ok to remove the hack if people
prefer a single ticket for this type of request.

Ian

On 10/10/06, Ⓙⓐⓚⓔ [EMAIL PROTECTED] wrote:
 oops not bugzilla, but very easy to use! my patch is in as

 http://jquery.com/dev/bugs/bug/266/

 ___
 jQuery mailing list
 discuss@jquery.com
 http://jquery.com/discuss/

___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/

Re: [jQuery] ajax bug or I am really confused?

[Ian Struble]

This fix is no longer needed.  I tracked down the reason for why we
have this work around and you are correct that it is because there is
a work around for a firefox bug in Prototype.  We lost the comment
referencing it in the 89 - 93 checkin of src\ajax.js.

Here is the FF bug that this code is working around:
  https://bugzilla.mozilla.org/show_bug.cgi?id=246651

The workarounds in both Prototype and jQuery have spawned quite a few
FF bugs that have been marked as duplicate.  This FF bug even mentions
the bug filed with Prototype to fix or update the work around to only
fire for pre-1.5 FF browsers:
  https://bugzilla.mozilla.org/show_bug.cgi?id=331210

Here is the Prototype bug to remove or update the work around to only
target pre-1.5 FF browsers:
  http://dev.rubyonrails.org/ticket/5809

Should I file a jQuery bug to fix it?  Here is a patch for my current
work around.  Not very pretty but it works for me.

Ian

Index: ajax.js
===
--- ajax.js (revision 413)
+++ ajax.js (working copy)
@@ -652,8 +652,12 @@
xml.setRequestHeader(X-Requested-With, XMLHttpRequest);

// Make sure the browser sends the right content length
-   if ( xml.overrideMimeType )
+   if ( xml.overrideMimeType  jQuery.browser.mozilla ) {
+   // bug fixed in rev 1.5 - bug #246651
+   var rev = navigator.userAgent.match(/rv:(\d+(?:\.\d+)+)/);
+   if ( rev  rev  1.5 )
xml.setRequestHeader(Connection, close);
+   }

// Wait for a response to come back
var onreadystatechange = function(istimeout){



On 9/28/06, Klaus Hartl [EMAIL PROTECTED] wrote:


 Ⓙⓐⓚⓔ schrieb:
  line 1691 of latest jquery   * $Rev: 249 $
 
 
// Make sure the browser sends the right content length
if ( xml.overrideMimeType )
  xml.setRequestHeader(Connection, close);
 
 
  should probably read:
 
xml.overrideMimeType('text/xml');
 
  At least that is how I want it. Overriding html mime type lets files
  served as 'html' to be used in $('body',xml) type expressions.
 
 


 These lines seem to be ok, they are supposed to fix this bug:

 https://bugzilla.mozilla.org/show_bug.cgi?query_format=specificorder=relevance+descbug_status=__open__id=246651


 Prototype has this fix as well:
 http://dev.rubyonrails.org/ticket/3564


 -- Klaus

 ___
 jQuery mailing list
 discuss@jquery.com
 http://jquery.com/discuss/

___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/