Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Tom Rondeau]

On Wed, Dec 30, 2015 at 6:14 AM, Marcus Müller 
wrote:

> That was the general idea, but long impossible at the start, because one
> didn't want modules that were "C++ compatible" to older versions of GNU
> Radio to fail because these older versions were missing cmake modules.
> That's why it might be a good time to revisit that problem, and throw
> away stuff that's guaranteed to be there in central GNU Radio of any
> sufficiently recent version.
>
> Best regards,
> Marcus



Thanks, Marcus. I was going to step in and explain this. We spent quite a
bit of time debating the proper use and installation policies of the cmake
modules when we switched to using cmake. Another issue is that of discovery
of the cmake modules. We install ours into $prefix/lib/cmake/gnuradio as
per the Cmake guidelines. However, putting them there meant they were not
necessarily in a place that cmake would discover their existence and you
might have to set some environmental variables to point there. I had tried
a number of different things, but each one seemed to lead us into some
problem or another without a clear and clean solution. We ended up with the
current model because it put the onus on the developers (of GR and the
OOTs) and made it easier for the users.

If we change this behavior, it might be a good target for 3.8. I'm saying
this because we will be updating our dependency versions for 3.8, so we
will need to revisit the cmake modules to make sure they set to look for
the right versions of everything, but it also means a newer version of
CMake, which given all of the work on that project since their 2.6 days
might make this problem a lot easier for us.

Tom




> On 12/30/2015 11:30 AM, Volker Schroer wrote:
> > Why not to use the cmake modules of gnuradio directly if building OOT's ?
> > If I'm right they are in ${INSTALL_PREFIX}/lib/cmake/gnuradio.
> >
> > And put cmake files only nedded by the oot module into the local oot
> > cmake directory.
> >
> > -- Volker
> >
> > Am 29.12.2015 um 22:43 schrieb Philip Balister:
> >> Per this commit in gnuradio:
> >>
> >>
> https://github.com/gnuradio/gnuradio/commit/dec480ab3f0809677ba3ef2a3a64d402d742b5ec
> >>
> >>
> >> This commit fixes the cmake in new OOT's, but existing ones need to do
> >> this by hand.
> >>
> >> Thanks,
> >>
> >> Philip
> >>
> >> ___
> >> Discuss-gnuradio mailing list
> >> Discuss-gnuradio@gnu.org
> >> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
> >>
> >
> >
> > ___
> > Discuss-gnuradio mailing list
> > Discuss-gnuradio@gnu.org
> > https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>
>
> ___
> Discuss-gnuradio mailing list
> Discuss-gnuradio@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Marcus Müller]

That was the general idea, but long impossible at the start, because one
didn't want modules that were "C++ compatible" to older versions of GNU
Radio to fail because these older versions were missing cmake modules.
That's why it might be a good time to revisit that problem, and throw
away stuff that's guaranteed to be there in central GNU Radio of any
sufficiently recent version.

Best regards,
Marcus

On 12/30/2015 11:30 AM, Volker Schroer wrote:
> Why not to use the cmake modules of gnuradio directly if building OOT's ?
> If I'm right they are in ${INSTALL_PREFIX}/lib/cmake/gnuradio.
>
> And put cmake files only nedded by the oot module into the local oot
> cmake directory.
>
> -- Volker
>
> Am 29.12.2015 um 22:43 schrieb Philip Balister:
>> Per this commit in gnuradio:
>>
>> https://github.com/gnuradio/gnuradio/commit/dec480ab3f0809677ba3ef2a3a64d402d742b5ec
>>
>>
>> This commit fixes the cmake in new OOT's, but existing ones need to do
>> this by hand.
>>
>> Thanks,
>>
>> Philip
>>
>> ___
>> Discuss-gnuradio mailing list
>> Discuss-gnuradio@gnu.org
>> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>>
>
>
> ___
> Discuss-gnuradio mailing list
> Discuss-gnuradio@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio


___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Volker Schroer]

Why not to use the cmake modules of gnuradio directly if building OOT's ?
If I'm right they are in ${INSTALL_PREFIX}/lib/cmake/gnuradio.

And put cmake files only nedded by the oot module into the local oot 
cmake directory.


-- Volker

Am 29.12.2015 um 22:43 schrieb Philip Balister:

Per this commit in gnuradio:

https://github.com/gnuradio/gnuradio/commit/dec480ab3f0809677ba3ef2a3a64d402d742b5ec

This commit fixes the cmake in new OOT's, but existing ones need to do
this by hand.

Thanks,

Philip

___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio




___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Johnathan Corgan]

On Tue, Dec 29, 2015 at 4:42 PM, Michael Dickens 
wrote:


> No way to force things here, I don't think.
>

To be clear, I was referring to new OOT modules created by gr_modtool.  Why
would they need to have local copies of those files if they are already
available via the installed GNU Radio?

-- 
Johnathan Corgan
Corgan Labs - SDR Training and Development Services
http://corganlabs.com
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Michael Dickens]

On Tue, Dec 29, 2015, at 07:31 PM, Johnathan Corgan wrote:
> On Tue, Dec 29, 2015 at 4:10 PM, Michael Dickens  
> wrote:
>
>> My advice is to just update the whole cmake directory. There
>> have been
>>
other changes in that directory that should be included in OOT modules
>>
too. I know not all OOT modules use the latest, because I patch them in
>>
MacPorts for the parts I need. - MLD
>
> This makes me wonder how many of these should be installed as part of
> GNU Radio, then used by OOT CMake.

I think that GNU Radio installs all of the files needed, but then each
OOT overrides them with a local copy -- some up to date & some older. We
can recommend that folks use the cmake scripts we provide with GNU
Radio, but we can't force them to do so. We could rewrite the OOT top-
level CMakeLists.txt to not use local cmake scripts, but that requires
people to adopt them. No way to force things here, I don't think. - MLD
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Michael Dickens]

On Tue, Dec 29, 2015, at 08:30 PM, Johnathan Corgan wrote:
> On Tue, Dec 29, 2015 at 5:08 PM, Philip Balister  wrote:
>> Dunno, but gr-newmod (or whatever it is called) in gnuradio
>> has a copy
>>
of the files. I had to fix the issue twice.
>
> This is good opportunity then to see what we can now remove from
> gr-newmod.

Yes! Or, whatever the name ends up being. +1 from me!
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Michael Dickens]

My advice is to just update the whole cmake directory. There have been
other changes in that directory that should be included in OOT modules
too. I know not all OOT modules use the latest, because I patch them in
MacPorts for the parts I need. - MLD

On Tue, Dec 29, 2015, at 04:43 PM, Philip Balister wrote:
> Per this commit in gnuradio:
> 
> https://github.com/gnuradio/gnuradio/commit/dec480ab3f0809677ba3ef2a3a64d402d742b5ec
> 
> This commit fixes the cmake in new OOT's, but existing ones need to do this 
> by hand.

___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Johnathan Corgan]

On Tue, Dec 29, 2015 at 4:10 PM, Michael Dickens 
wrote:


> My advice is to just update the whole cmake directory. There have been
> other changes in that directory that should be included in OOT modules
> too. I know not all OOT modules use the latest, because I patch them in
> MacPorts for the parts I need. - MLD
>

​This makes me wonder how many of these should be installed as part of GNU
Radio, then used by OOT CMake.​

-- 
Johnathan Corgan
Corgan Labs - SDR Training and Development Services
http://corganlabs.com
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Michael Dickens]

I believe that GR did not provide these files a while back, so we
included them in the OOT via gr-modtool. They've been there ever since.
That's my memory. - MLD

On Tue, Dec 29, 2015, at 07:47 PM, Johnathan Corgan wrote:
> On Tue, Dec 29, 2015 at 4:42 PM, Michael Dickens
>  wrote:
>
>>
>> No way to force things here, I don't think.
>>
>
> To be clear, I was referring to new OOT modules created by gr_modtool.
> Why would they need to have local copies of those files if they are
> already available via the installed GNU Radio?
>
> --
> Johnathan Corgan Corgan Labs - SDR Training and Development Services
> http://corganlabs.com
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Johnathan Corgan]

On Tue, Dec 29, 2015 at 5:08 PM, Philip Balister 
wrote:

> On 12/29/2015 07:47 PM, Johnathan Corgan wrote:
> > On Tue, Dec 29, 2015 at 4:42 PM, Michael Dickens <
> michael.dick...@ettus.com>
> > wrote:
> >
> >
> >> No way to force things here, I don't think.
> >>
> >
> > To be clear, I was referring to new OOT modules created by gr_modtool.
> Why
> > would they need to have local copies of those files if they are already
> > available via the installed GNU Radio?
>
> Dunno, but gr-newmod (or whatever it is called) in gnuradio has a copy
> of the files. I had to fix the issue twice.
>

​This is good opportunity then to see what we can now remove from
gr-newmod.​


-- 
Johnathan Corgan
Corgan Labs - SDR Training and Development Services
http://corganlabs.com
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Philip Balister]

On 12/29/2015 07:47 PM, Johnathan Corgan wrote:
> On Tue, Dec 29, 2015 at 4:42 PM, Michael Dickens 
> wrote:
> 
> 
>> No way to force things here, I don't think.
>>
> 
> To be clear, I was referring to new OOT modules created by gr_modtool.  Why
> would they need to have local copies of those files if they are already
> available via the installed GNU Radio?

Dunno, but gr-newmod (or whatever it is called) in gnuradio has a copy
of the files. I had to fix the issue twice.

Philip

> 
> 
> 
> ___
> Discuss-gnuradio mailing list
> Discuss-gnuradio@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
> 

___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

[Discuss-gnuradio] OOT module authors, please update your cmake

[Philip Balister]

Per this commit in gnuradio:

https://github.com/gnuradio/gnuradio/commit/dec480ab3f0809677ba3ef2a3a64d402d742b5ec

This commit fixes the cmake in new OOT's, but existing ones need to do
this by hand.

Thanks,

Philip

___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

Re: [Discuss-gnuradio] OOT module authors, please update your cmake

[Tim K]

Could there be perhaps a `gr_modtool update_cfiles`?

On Tue, Dec 29, 2015 at 8:55 PM, Michael Dickens 
wrote:

> On Tue, Dec 29, 2015, at 08:30 PM, Johnathan Corgan wrote:
>
> On Tue, Dec 29, 2015 at 5:08 PM, Philip Balister 
> wrote:
>
> Dunno, but gr-newmod (or whatever it is called) in gnuradio has a copy
> of the files. I had to fix the issue twice.
>
>
> This is good opportunity then to see what we can now remove from gr-newmod.
>
>
> Yes! Or, whatever the name ends up being. +1 from me!
>
> ___
> Discuss-gnuradio mailing list
> Discuss-gnuradio@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>
>
___
Discuss-gnuradio mailing list
Discuss-gnuradio@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio