[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title
Michael Osipov commented on an issue
Re: CSV export fixes (patch included)
Here is the Excel-compatible version: {code:java} /** * Excelkompatibler CSV-Export: * ol * liFeldtrenner muss ein Semikolon sein./li * liBei UTF-8 Kodierung stronga * href="" href="http://wiki.sdn.sap.com/wiki/display/ABAP/Excel+files+-+CSV+format" style="color: #3b73af; text-decoration: none">http://wiki.sdn.sap.com/wiki/display/ABAP/Excel+files+-+CSV+format * muss/a/strong der BOM vorhanden sein, sonst ist die Datei fr Excel * nicht sauber lesbar. Obwohl der BOM a * href="" href="http://unicode.org/faq/utf_bom.html#bom5" style="color: #3b73af; text-decoration: none">http://unicode.org/faq/utf_bom.html#bom5nicht empfohlen/a wird bei * UTF-8/li. * /ol */ public class ExcelCompatibleCsvView extends CsvView { @Override protected String getDocumentStart() { // Write Byte Order Mark return \ufeff; } @Override protected String getCellEnd() { return ;; } @Override protected String escapeColumnValue(Object value) { String stringValue = StringUtils.trim(value.toString()); if (!StringUtils.containsNone(stringValue, new char[] { '\n', ';' })) { return \ + //$NON-NLS-1$ StringUtils.replace(stringValue, \, \\\) + \; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ } return stringValue; } } {code}
Add Comment
DisplayTag / DISPL-688
CSV export fixes (patch included)
* UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as.
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title
Michael Osipov edited a comment on an issue
Re: CSV export fixes (patch included)
Notreally,becauseyoudonotknowwhoaregoingtobetheconsumersofthosefiles.TheycodechokeontheBOM.Noadditinalpropertynecessary.Itisenoughtoprovidean{ { ExcelCompatibleCsvView} } andleavingtheoriginalonealone.ThisiswhatIdidanditworksflawlessly.Asmentionedbefore,Icansharethatcode.
Add Comment
DisplayTag / DISPL-688
CSV export fixes (patch included)
* UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as.
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
--
___
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title
Michael Osipov edited a comment on an issue
Re: CSV export fixes (patch included)
Notreally,becauseyoudonotknowwhoaregoingtobetheconsumersofthosefiles.TheycodechokeontheBOM. JustbecauseMicrosoftistoostupidtowritedecentsoftware,weshouldn'tfollow. Noadditinalpropertynecessary.Itisenoughtoprovidean{ExcelCompatibleCsvView}andleavingtheoriginalonealone.ThisiswhatIdidanditworksflawlessly.Asmentionedbefore,Icansharethatcode.
Add Comment
DisplayTag / DISPL-688
CSV export fixes (patch included)
* UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as.
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
--
___
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title Michael Osipov commented on an issue Re: CSV export fixes (patch included) Not a good idea to add a BOM for two reasons: 1. If you read Unicode specs, it clearly says that a BOM is redundant 2. This is solely a Excel problem The give CSV exporter should a neutral, though you can provide a subclass for Excel. I have a valid one for our projects. Excel is then able to ready any Unicode char. Add Comment DisplayTag / DISPL-688 CSV export fixes (patch included) * UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) -- ___ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title Johno Crawford commented on an issue Re: CSV export fixes (patch included) I disagree with those points being good reasons Michael. Even if spec states BOM is redundant it vastly improves usage in Excel which is still very popular. I have also not seen any issues in OpenOffice, LibreOffice or plain text editors with parsing the BOM. Regardless, we could make this configurable via display.properties defaulting off for backwards compatibility to keep everyone happy. Add Comment DisplayTag / DISPL-688 CSV export fixes (patch included) * UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) -- ___ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title fabrizio giustina resolved an issue as Fixed added for 2.0, thanks DisplayTag / DISPL-688 CSV export fixes (patch included) Change By: fabrizio giustina Resolution: Fixed Status: Open Resolved Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) -- ___ displaytag-devel mailing list displaytag-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/displaytag-devel
[displaytag-devel] [jira] (DISPL-688) CSV export fixes (patch included)
Title: Message Title Johno Crawford created an issue DisplayTag / DISPL-688 CSV export fixes (patch included) Issue Type: Bug Affects Versions: 1.2 Assignee: Unassigned Attachments: csv_export_fixes.patch Components: Export Created: 30/Jul/14 2:55 AM Fix Versions: 1.3 Priority: Major Reporter: Johno Crawford * UTF8 header needs to be captured before we reset the headers. * Line feeds caused spreadsheet applications to render columns incorrectly. * Added BOM to csv export file so spreadsheet applications know what to display text as.
