Re: Django Rest Framework Validation Order Issue

[Brent O'Connor]

I guess my point is that I don't feel like I should have to override
anything and this should be DRF's default behavior. 🙂 Thank you for
pointing out that `validation` should be the method that should be used.

On Tue, Jun 30, 2020, 5:42 PM Carl Nobile  wrote:

> Brent, overriding the 'to_internal_value' method is normal and encouraged,
> however, the 'run_validation' shouldn't generally be overridden, what you
> can override is the 'validate' method which is called by 'run_validation'.
> ~Carl
>
> On Tue, Jun 30, 2020 at 5:51 PM Brent O'Connor 
> wrote:
>
>> For anyone that might come across this thread, I went ahead and created an
>> issue  for
>> this on Github.
>>
>> On Friday, June 26, 2020 at 5:08:03 PM UTC-5, Brent O'Connor wrote:
>>>
>>> I created an example project
>>>  to illustrate this
>>> issue, but basically if you have custom validation logic on a serializer
>>> and the data has a field that isn't valid, then the errors raised are only
>>> the field level errors and not the custom validation logic errors. This
>>> ends up being a bad user experience because the user can fix the field
>>> error and then when post another request they can end up getting errors
>>> thrown in the custom validation. I'm thinking this might need to be an
>>> issue added the DRF project on Github, but thought I would check here
>>> first. Please see the project example for more details.
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django REST framework" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-rest-framework+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-rest-framework/ea8a9b5d-a671-42b4-9cee-043f28f8efa3o%40googlegroups.com
>> 
>> .
>>
>
>
> --
>
> ---
> Carl J. Nobile (Software Engineer)
> carl.nob...@gmail.com
>
> ---
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django REST framework" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-rest-framework+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-rest-framework/CAGQqDQL2UvWyjr6UgK%2BpCDexAc%2BC%2BeBUGxAwZYyaxC3dJYwGsQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-rest-framework+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-rest-framework/CA%2Bx7ZMp9HOprA-aUjP93s02BVLmMyz8%3DwKrGZjgA2gPAh2ExJg%40mail.gmail.com.

Re: Django Rest Framework Validation Order Issue

[Carl Nobile]

Brent, overriding the 'to_internal_value' method is normal and encouraged,
however, the 'run_validation' shouldn't generally be overridden, what you
can override is the 'validate' method which is called by 'run_validation'.
~Carl

On Tue, Jun 30, 2020 at 5:51 PM Brent O'Connor  wrote:

> For anyone that might come across this thread, I went ahead and created an
> issue  for
> this on Github.
>
> On Friday, June 26, 2020 at 5:08:03 PM UTC-5, Brent O'Connor wrote:
>>
>> I created an example project
>>  to illustrate this
>> issue, but basically if you have custom validation logic on a serializer
>> and the data has a field that isn't valid, then the errors raised are only
>> the field level errors and not the custom validation logic errors. This
>> ends up being a bad user experience because the user can fix the field
>> error and then when post another request they can end up getting errors
>> thrown in the custom validation. I'm thinking this might need to be an
>> issue added the DRF project on Github, but thought I would check here
>> first. Please see the project example for more details.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django REST framework" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-rest-framework+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-rest-framework/ea8a9b5d-a671-42b4-9cee-043f28f8efa3o%40googlegroups.com
> 
> .
>


-- 
---
Carl J. Nobile (Software Engineer)
carl.nob...@gmail.com
---

-- 
You received this message because you are subscribed to the Google Groups 
"Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-rest-framework+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-rest-framework/CAGQqDQL2UvWyjr6UgK%2BpCDexAc%2BC%2BeBUGxAwZYyaxC3dJYwGsQ%40mail.gmail.com.

Re: Django Rest Framework Validation Order Issue

[Brent O'Connor]

For anyone that might come across this thread, I went ahead and created an 
issue  for 
this on Github.

On Friday, June 26, 2020 at 5:08:03 PM UTC-5, Brent O'Connor wrote:
>
> I created an example project 
>  to illustrate this 
> issue, but basically if you have custom validation logic on a serializer 
> and the data has a field that isn't valid, then the errors raised are only 
> the field level errors and not the custom validation logic errors. This 
> ends up being a bad user experience because the user can fix the field 
> error and then when post another request they can end up getting errors 
> thrown in the custom validation. I'm thinking this might need to be an 
> issue added the DRF project on Github, but thought I would check here 
> first. Please see the project example for more details.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-rest-framework+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-rest-framework/ea8a9b5d-a671-42b4-9cee-043f28f8efa3o%40googlegroups.com.

pagination.CursorPagination - aws aurora postgres

[Ross C]

Hi there,

   Long time DRF user of many years and i seem to have found a strange 
behaviour in AWS rds aurora psotgres.

I have it working correctly locally, returns data as expected however on 
deploy to an aws environment the cursor returns None

If i disable pagination entirely, data is returned
I've snapshotted the databsae brought down it local and installed it and am 
able to use the CursorPagination on it with no problem

I wonder if this is a known issue ?

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-rest-framework+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-rest-framework/b2bf02cd-c6aa-4e85-a766-9879caa13fb6o%40googlegroups.com.

Re: Django Rest Framework Validation Order Issue

[Brent O'Connor]

Carl, I created another branch 

 
on my example project that solves this issue by overriding two DRF methods 
(to_internal_value and run_validation). I'm probably going to create an 
issue in DRF that suggests that a solution like this gets added.

On Saturday, June 27, 2020 at 3:34:05 PM UTC-5, Carl Nobile wrote:
>
> Then write your custom validation as a field validator and put them all in 
> the list in the order you want them to fire off in or you could include the 
> field validator checks into your custom validation method.
> The problem is that DRF can only implement what the common cases are, not 
> all the edge cases people may need, but the hooks are there in the code to 
> customize it the way you want.
>
>
> On Sat, Jun 27, 2020 at 4:05 PM Brent O'Connor  > wrote:
>
>> Unfortunately, that doesn't really solve the issue because you want 
>> field-level validation to run because you want to make sure that valid 
>> numbers, etc. are being sent to the API.
>>
>> On Sat, Jun 27, 2020 at 12:25 PM Carl Nobile > > wrote:
>>
>>> It is possible to turn off the built infield errors. The empty list 
>>> essentially turns off al field validation. If there are multiple and you 
>>> don't want all turned off you would need to specify them yourself.
>>>
>>> Class SomeSeializer(...):
>>>
>>> class Meta:
>>> extra_kwargs = { 
>>>'field_name': {'validators': []}, 
>>>}
>>>
>>> On Fri, Jun 26, 2020 at 6:08 PM Brent O'Connor >> > wrote:
>>>
 I created an example project 
  to illustrate this 
 issue, but basically if you have custom validation logic on a serializer 
 and the data has a field that isn't valid, then the errors raised are only 
 the field level errors and not the custom validation logic errors. This 
 ends up being a bad user experience because the user can fix the field 
 error and then when post another request they can end up getting errors 
 thrown in the custom validation. I'm thinking this might need to be an 
 issue added the DRF project on Github, but thought I would check here 
 first. Please see the project example for more details.

 -- 
 You received this message because you are subscribed to the Google 
 Groups "Django REST framework" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to django-rest-framework+unsubscr...@googlegroups.com 
 .
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/django-rest-framework/121a7ebe-4b34-4197-be60-1178730361f7o%40googlegroups.com
  
 
 .

>>>
>>>
>>> -- 
>>>
>>> ---
>>> Carl J. Nobile (Software Engineer)
>>> carl@gmail.com 
>>>
>>> ---
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Django REST framework" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to django-rest-framework+unsubscr...@googlegroups.com 
>>> .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/django-rest-framework/CAGQqDQ%2BOzPQ-Xuad4OboE-%2BgXF_-uAkuxF%2B9XT5jLPiAnFJfog%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django REST framework" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-rest-framework+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-rest-framework/CA%2Bx7ZMq7iMmi4PaQ9aBjGaEybKWH0piWumZTOOfR5-wJOBwwZw%40mail.gmail.com
>>  
>> 
>> .
>>
>
>
> -- 
>
> ---
> Carl J. Nobile (Software Engineer)
> carl@gmail.com 
>
> ---
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-rest-framework+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.