date:20120723

Re: [Django] #18660: View on Site links get localized and break urls

2012-07-23 Thread Django

#18660: View on Site links get localized and break urls
---+--
 Reporter:  eduardocereto  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  localization   | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by eduardocereto):

 * has_patch:  0 => 1


Comment:

 Pull Request with possible Fix

 https://github.com/django/django/pull/226

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18660: View on Site links get localized and break urls

2012-07-23 Thread Django

#18660: View on Site links get localized and break urls
---+--
 Reporter:  eduardocereto  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords:  localization   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by eduardocereto):

 * cc: eduardocereto@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18660: View on Site links get localized and break urls

2012-07-23 Thread Django

#18660: View on Site links get localized and break urls
---+--
 Reporter:  eduardocereto  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  1.4
 Severity:  Normal |   Keywords:  localization
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+--
 When object ids are larger than 1000 and you have localization turned on
 the "View on Site" links on the admin break because the ids get a thousand
 separator and that render invalid shortcut urls.

 This is a very old bug and I'm sure I reported it before. Just can't seem
 to find it anymore. But I just confirmed it still happens on 1.4.

 I know the fix should be simple. It's just a matter of using the template
 filter unlocalize or maybe {% localize off %} around the problematic code.
 But I fid this solution somehow not very elegant.

 Possibly affected files:

 admin/templates/admin/change_form.html
 admin/templates/admin/edit_inline/stacked.html
 admin/templates/admin/edit_inline/tabular.html

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15760: Feature: JS Hooks for Dynamic Inlines

2012-07-23 Thread Django

#15760: Feature: JS Hooks for Dynamic Inlines
-+-
 Reporter:  mlavin   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  inlines jquery   | Triage Stage:  Accepted
  callback   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by mpasternak):

 I like the inlines.diff patch, because it is more explicit this way. I
 don't think there's anything wrong with having clearly named events on the
 javascript side, is there?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18659: Remove `request.REQUEST`

2012-07-23 Thread Django

#18659: Remove `request.REQUEST`
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by mjtamlyn):

 * cc: marc.tamlyn@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18659: Remove `request.REQUEST`

2012-07-23 Thread Django

#18659: Remove `request.REQUEST`
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 This may break a lot of code, so this isn't a decision to make lightly.

 Django itself uses `request.REQUEST` in i18n views, auth, and admin.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18659: Remove `request.REQUEST`

2012-07-23 Thread Django

#18659: Remove `request.REQUEST`
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Alex):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18659: Remove `request.REQUEST`

2012-07-23 Thread Django

#18659: Remove `request.REQUEST`
+
   Reporter:  aaugustin |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (Other)  |Version:  1.4
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 `request.REQUEST` provides indifferent access to `request.GET` or
 `request.POST` (PHP style).

 This attribute is a legacy from the pre-1.0 days, when you could access
 the `GET` or `POST` data using dict syntax on the request object.
 `request.REQUEST` was introduced in 1.0 to make this operation more
 explicit, with an easy upgrade path.

 It's hardly ever a good design pattern to handle `GET` and `POST`
 identically, and it's our responsibility not to provide tools who are more
 likely to result in bad code than anything else. So I think it's time to
 deprecate this attribute.

 We could deprecate `django.utils.datastructures.MergeDict` at the same
 time — it's a 100-lines long class whose sole purpose is to support
 `request.REQUEST`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18658: Better support for exceptions / error messages in custom admin actions

2012-07-23 Thread Django

#18658: Better support for exceptions / error messages in custom admin actions
-+-
 Reporter:  dbrgn|  Owner:  nobody
 Type:   | Status:  new
  Uncategorized  |Version:  1.4
Component:   |   Keywords:  admin, exception handling, ui/ux,
  contrib.admin  |  docs
 Severity:  Normal   |  Has patch:  0
 Triage Stage:   |  UI/UX:  0
  Unreviewed |
Easy pickings:  1|
-+-
 The docs don't mention any way to create error messages in custom admin
 actions. According to [http://stackoverflow.com/questions/3241659/custom-
 error-message-in-django-admin-actions/5622515 an answer on Stackoverflow],
 this can be achieved with:

 {{{
 from django.contrib import messages

 # Then, when you need to error the user:
 messages.error(request, "The message")
 }}}

 There are three issues with this:
 - There's a `message_user` method on a ModelAdmin, but no similar thing
 for errors. This seems inconsistent.
 - It's not mentioned in the docs. Errors in actions need to be handled.
 - The error message isn't rendered with red background color, as it should
 be. A possible fix is described [http://stackoverflow.com/a/5622515/284318
 here].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12090: Show admin actions on the edit pages too

2012-07-23 Thread Django

#12090: Show admin actions on the edit pages too
---+
 Reporter:  apollo13   |Owner:
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by dbrgn):

 * cc: dbrgn (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11495: Improvements to django.views.static.serve directory indexes

2012-07-23 Thread Django

#11495: Improvements to django.views.static.serve directory indexes
-+-
 Reporter:  SmileyChris  |Owner:
 Type:   |  SmileyChris
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  1.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  1
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-
Changes (by jezdez):

 * needs_better_patch:  0 => 1


Comment:

 The branch isn't there anymore, any chance to update the patch here?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17208: Dogfood class-based views in contrib.admin

2012-07-23 Thread Django

#17208: Dogfood class-based views in contrib.admin
-+-
 Reporter:  melinath |Owner:  julien
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  class-based views|  Needs documentation:  1
  admin  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by vzima):

 * cc: vlastimil.zima@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17209: Dogfood class-based views in contrib.auth

2012-07-23 Thread Django

#17209: Dogfood class-based views in contrib.auth
-+-
 Reporter:  melinath |Owner:  andrews
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.auth |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  class-based views|  Needs documentation:  0
  admin auth |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by vzima):

 * cc: vlastimil.zima@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18482: Cache backend API should close()

2012-07-23 Thread Django

#18482: Cache backend API should close()
-+-
 Reporter:  russellm |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by russellm):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Nope - the patch looks good to commit. Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18482: Cache backend API should close()

2012-07-23 Thread Django

#18482: Cache backend API should close()
--+
 Reporter:  russellm  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Cache system)   |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+

Comment (by mgrouchy):

 Hey, is there anything that I should do to get this ticket closed/pull
 request merged?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18363: Add a compatibility layer for Python 3

2012-07-23 Thread Django

#18363: Add a compatibility layer for Python 3
-+
 Reporter:  claudep  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by aaugustin):

 It's actually possible to use `six.with_metaclass()` for `ModelBase`, see
 [ae4125ffce6c0a82e9016f67d60d31bc7595887c].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] ae4125: Removed a Python 3-compatibility hack.

2012-07-23 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: ae4125ffce6c0a82e9016f67d60d31bc7595887c
  
https://github.com/django/django/commit/ae4125ffce6c0a82e9016f67d60d31bc7595887c
  Author: Aymeric Augustin 
  Date:   2012-07-23 (Mon, 23 Jul 2012)

  Changed paths:
M django/db/models/base.py

  Log Message:
  ---
  Removed a Python 3-compatibility hack.

Thanks Preston Holmes for the patch.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18657: Inconsistent db names in example

2012-07-23 Thread Django

#18657: Inconsistent db names in example
---+
 Reporter:  msb@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by msb):

 * cc: msb (added)


Comment:

 Thanks russellm for looking so quickly.  I agree that there is a case for
 making the whole page use the same examples, but I don't think that is
 essential.  The first, simple example uses 'default' and 'users'.  Then
 the more complex example at
 https://docs.djangoproject.com/en/1.4/topics/db/multi-db/#an-example uses
 'other', 'master', 'slave1' and 'slave2', plus the stray 'credentials'.
 Simply fixing that would be a good start and enough to remove the
 inconsistency.  HTH.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18660: View on Site links get localized and break urls

Re: [Django] #18660: View on Site links get localized and break urls

[Django] #18660: View on Site links get localized and break urls

Re: [Django] #15760: Feature: JS Hooks for Dynamic Inlines

Re: [Django] #18659: Remove `request.REQUEST`

Re: [Django] #18659: Remove `request.REQUEST`

Re: [Django] #18659: Remove `request.REQUEST`

[Django] #18659: Remove `request.REQUEST`

[Django] #18658: Better support for exceptions / error messages in custom admin actions

Re: [Django] #12090: Show admin actions on the edit pages too

Re: [Django] #11495: Improvements to django.views.static.serve directory indexes

Re: [Django] #17208: Dogfood class-based views in contrib.admin

Re: [Django] #17209: Dogfood class-based views in contrib.auth

Re: [Django] #18482: Cache backend API should close()

Re: [Django] #18482: Cache backend API should close()

Re: [Django] #18363: Add a compatibility layer for Python 3

[django/django] ae4125: Removed a Python 3-compatibility hack.

Re: [Django] #18657: Inconsistent db names in example

18 matches

Site Navigation

Mail list logo

Footer information