Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Berker Peksag):

 > [...] I see different csrfmiddlewaretoken values after each refresh but
 the value of csrfmiddlewaretoken doesn't match with the csrftoken cookie
 [...]

 Turns out I was reading an older version of the document and this behavior
 is expected in Django 1.11.

 Also, I get 403 even if there was no 404 request in the middle so I'm
 beginning to think that my problem is different than this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.38ef8f703b4c0a70fb09f7cab9d4100b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Berker Peksag):

 I just tried Nicola's sample project and I was able to reproduce it
 locally.

 For some strange reason, I can't reproduce it locally on my own project
 even if I made the same request:

 {{{
 [19/Sep/2017 02:00:34] "GET / HTTP/1.1" 200 42428
 [19/Sep/2017 02:00:36] "GET /static/js/main-min.js HTTP/1.1" 404 31942
 [19/Sep/2017 02:00:50] "GET /admin/login/?next=/admin/ HTTP/1.1" 200 1625
 [19/Sep/2017 02:00:50] "GET /static/admin/css/base.css HTTP/1.1" 404 31950
 [19/Sep/2017 02:00:50] "GET /static/admin/css/login.css HTTP/1.1" 404
 31952
 }}}

 I removed all custom middlewares and copied the `MIDDLEWARE` setting from
 Nicola's project and I was still able to login successfully.

 On both local and production environment, I see different
 `csrfmiddlewaretoken` values after each refresh but the value of
 `csrfmiddlewaretoken` doesn't match with the `csrftoken` cookie (it also
 stays same after I refreshed the page) However, the `csrftoken` cookie
 changes each request in Nicola's project.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9be3045110ae74e783f24abc816a071e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28576: Add GetColorInterpretation for GDALBand

2017-09-18 Thread Django 
#28576: Add GetColorInterpretation for GDALBand
--+
 Reporter:  winsent   |Owner:  Niall Dalton
 Type:  New feature   |   Status:  assigned
Component:  GIS   |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:  raster, band  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Niall Dalton):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/9064]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.856be7e2d37f417bfb736e0a00c4a5a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Berker Peksag):

 > Does my PR fix it for you?

 I can't reproduce the problem in development environment even if I set
 `settings.DEBUG` to `False`. I applied your patch manually on the server
 and unfortunately I still get 403 when I try to submit a form.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8dbcd7548bd8be809e80e038020eea01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28542: migration that introduces uuid field is not reversible with unique=True

2017-09-18 Thread Django 
#28542: migration that introduces uuid field is not reversible with unique=True
+--
 Reporter:  karyon  |Owner:  Tim Martin
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.11
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Tim Martin):

 I've got a theory about this now. When a primary key constraint is removed
 and the target field state is unique, then the primary key constraint is
 deleted along with all other unique constraints on the field. This happens
 in `BaseDatabaseSchemaEditor._alterField`, in the second conditional
 block. But I think this masks the fact that the primary key isn't
 explicitly removed. If the removal isn't triggered by the removal of
 uniqueness, then it doesn't happen.

 I've created a branch with a UT that reproduces this case
 [https://github.com/timmartin/django/tree/ticket_28542 here]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.497b277694195e3a0830e8bce6a187f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28576: Add GetColorInterpretation for GDALBand

2017-09-18 Thread Django 
#28576: Add GetColorInterpretation for GDALBand
--+
 Reporter:  winsent   |Owner:  Niall Dalton
 Type:  New feature   |   Status:  assigned
Component:  GIS   |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:  raster, band  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Niall Dalton):

 Just about done, waiting for confirmation from GDAL devs about a possible
 issue in their documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7fcbe0e5a71c92c38113383df9983f0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28597: Class-based model indexes containing default primary key doesn't work.

2017-09-18 Thread Django 
#28597: Class-based model indexes containing default primary key doesn't work.
-+-
 Reporter:  Дилян Палаузов   |Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  Model.Meta.indexes   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fb02ebe889eee292144f9157ed4ddcdcc139eba9" fb02ebe]:
 {{{
 #!CommitTicketReference repository=""
 revision="fb02ebe889eee292144f9157ed4ddcdcc139eba9"
 Fixed #28597 -- Fixed crash with the name of a model's autogenerated
 primary key in an Index's fields.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7b3fe65f6f075c26cef4d55634e34a01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28612: inspectdb sets max_length to -1 if no field length specified in the DB schema

2017-09-18 Thread Django 
#28612: inspectdb sets max_length to -1 if no field length specified in the DB
schema
-+-
   Reporter:  rvernica   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.11
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Postgres schema:

 {{{
 # \d instance
Table "public.instance"
Column   |Type | Modifiers
 +-+---
  instance_id| bigint  | not null
  membership_id  | bigint  | default 0
  host   | character varying   |
  port   | integer |
  online_since   | timestamp without time zone |
  base_path  | character varying   |
  server_id  | integer |
  server_instance_id | integer |
 Indexes:
 "instance_pkey" PRIMARY KEY, btree (instance_id)
 "instance_host_port_key" UNIQUE CONSTRAINT, btree (host, port)
 "instance_host_server_id_server_instance_id_key" UNIQUE CONSTRAINT,
 btree (host, server_id, server_instance_id)
 "instance_server_id_server_instance_id_key" UNIQUE CONSTRAINT, btree
 (server_id, server_instance_id)
 Check constraints:
 "instance_base_path_non_unique" CHECK (check_base_path(base_path) = 0)
 }}}

 Notice the type for `host` and `base_path` attributes.

 `inspectdb` output:

 {{{
 #!python
 # python3 manage.py inspectdb instance
 # This is an auto-generated Django model module.
 # You'll have to do the following manually to clean this up:
 #   * Rearrange models' order
 #   * Make sure each model has one field with primary_key=True
 #   * Make sure each ForeignKey has `on_delete` set to the desired
 behavior.
 #   * Remove `managed = False` lines if you wish to allow Django to
 create, modify, and delete the table
 # Feel free to rename the models, but don't rename db_table values or
 field names.
 from __future__ import unicode_literals

 from django.db import models


 class Instance(models.Model):
 instance_id = models.BigIntegerField(primary_key=True)
 membership_id = models.BigIntegerField(blank=True, null=True)
 host = models.CharField(max_length=-1, blank=True, null=True)
 port = models.IntegerField(blank=True, null=True)
 online_since = models.DateTimeField(blank=True, null=True)
 base_path = models.CharField(max_length=-1, blank=True, null=True)
 server_id = models.IntegerField(blank=True, null=True)
 server_instance_id = models.IntegerField(blank=True, null=True)

 class Meta:
 managed = False
 db_table = 'instance'
 unique_together = (('host', 'port'), ('server_id',
 'server_instance_id'), ('host', 'server_id', 'server_instance_id'),)
 }}}

 Notice the `max_length=-1` for `host` and `base_path` attributes.

 The `django.contrib.postgres` app is listed in `INSTALLED_APPS`

 PostgreSQL `9.6.5`
 Python `3.6.1`
 Django `1.11.5`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.400856a2e26adb67be6cd6b752bed26b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2017-09-18 Thread Django 
#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"94cd8efc50c717cd00244f4b2233f971a53b205e" 94cd8ef]:
 {{{
 #!CommitTicketReference repository=""
 revision="94cd8efc50c717cd00244f4b2233f971a53b205e"
 Fixed #14370 -- Allowed using a Select2 widget for ForeignKey and
 ManyToManyField in the admin.

 Thanks Florian Apolloner and Tim Graham for review and
 contributing to the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.88196bef5485aeda56e3721ca8dee666%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14370: Adding support for Autocomplete in contrib.admin

2017-09-18 Thread Django 
#14370: Adding support for Autocomplete in contrib.admin
-+-
 Reporter:  Germano Gabbianelli  |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autocomplete,| Triage Stage:  Accepted
  jquery, javascript, widgets,   |
  admin  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Tim Graham ):

 In [changeset:"01a294f8f014a32e288958701540ea47dcb9fc14" 01a294f8]:
 {{{
 #!CommitTicketReference repository=""
 revision="01a294f8f014a32e288958701540ea47dcb9fc14"
 Refs #14370 -- Vendored Select2 4.0.3 for use by the admin.

 From https://github.com/select2/select2/releases/tag/4.0.3
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.41fca2a7ee4b805f638cc464c3786e06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28610: register_tests() for serializers test doesn't show skipped formats

2017-09-18 Thread Django 
#28610: register_tests() for serializers test doesn't show skipped formats
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core |  Version:  master
  (Serialization)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"774f5548bdf976fc6f0f5ec3603723850a698f74" 774f5548]:
 {{{
 #!CommitTicketReference repository=""
 revision="774f5548bdf976fc6f0f5ec3603723850a698f74"
 Fixed #28610 -- Skipped test when serializer is not available

 Thanks Tim Graham for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.762587386752be0db9e4f561206805e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28608: UserCreationForm and UserChangeForm model using get_user_model

2017-09-18 Thread Django 
#28608: UserCreationForm and UserChangeForm model using get_user_model
-+-
 Reporter:  Rômulo Collopy   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  user, custom user,   | Triage Stage:
  auth   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Rômulo Collopy):

 * Attachment "patch.diff" added.

 patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8f5470191a5506d8146b8bbba99d3c62%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28606: Deprecate CachedStaticFilesStorage (was: Mark CachedStaticFilesStorage as deprecated in Django 2.1)

2017-09-18 Thread Django 
#28606: Deprecate CachedStaticFilesStorage
--+
 Reporter:  Ed Morley |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.staticfiles   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c7a234a7a6e7396315f8f7e9c74deeb4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26608: Add a window function expression

2017-09-18 Thread Django 
#26608: Add a window function expression
-+-
 Reporter:  Jamie Cockburn   |Owner:  Mads
 |  Jensen
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d549b8805053d4b064bf492ba90e90db5d7e2a6b" d549b880]:
 {{{
 #!CommitTicketReference repository=""
 revision="d549b8805053d4b064bf492ba90e90db5d7e2a6b"
 Fixed #26608 -- Added support for window expressions (OVER clause).

 Thanks Josh Smeaton, Mariusz Felisiak, Sergey Fedoseev, Simon Charettes,
 Adam Chainz/Johnson and Tim Graham for comments and reviews and Jamie
 Cockburn for initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c4cf080f12bab90c8255e2ac36ef5888%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28610: register_tests() for serializers test doesn't show skipped formats (was: register_tests() for serializers test does not exhibit skipped formats)

2017-09-18 Thread Django 
#28610: register_tests() for serializers test doesn't show skipped formats
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core |  Version:  master
  (Serialization)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin
 * component:  Testing framework => Core (Serialization)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8ef4c662f9adeda228d0edce2615cff4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28611: Redirects contrib app - CharField(max_length=200) is too little

2017-09-18 Thread Django 
#28611: Redirects contrib app - CharField(max_length=200) is too little
-+-
 Reporter:  Artur Barseghyan |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.redirects|  Version:  1.11
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  redirects| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * resolution:   => duplicate


Comment:

 Duplicate of #19515.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.d746226b602f30584e93b72c8ca1136b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27391: Support unittest.TestCase.debug() method

2017-09-18 Thread Django 
#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.117f139abb610a010110df9d14602bc9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28611: Redirects contrib app - CharField(max_length=200) is too little

2017-09-18 Thread Django 
#28611: Redirects contrib app - CharField(max_length=200) is too little
-+---
   Reporter:  Artur Barseghyan   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  contrib.redirects  |Version:  1.11
   Severity:  Normal |   Keywords:  redirects
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
 Nowadays, paths are long. It would make sense either:

 (Option 1): Change the `old_path` and `new_path` from `CharField` to
 `TextField`.
 (Option 2): Let the `RedirectFallbackMiddleware` middleware use customized
 `Redirect` model.

 If any of the solutions is found acceptable, I could come up with a pull
 request.

 Best regards,

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/058.37d76a095e6a848acfa7c3925b311c65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28594: Value error on related user name during save of user model

2017-09-18 Thread Django 
#28594: Value error on related user name during save of user model
-+-
 Reporter:  Axel Rau |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  Value error, user| Triage Stage:  Accepted
  model, normalize_username  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Axel Rau):

 I agree, that this is a corner case and can be prevented by a hint in the
 documentaion.
 My proposal of the doc enhancement is attached. It replaces my original
 code patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.96df6179b48984f03cd5ac8515f93ad1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28594: Value error on related user name during save of user model

2017-09-18 Thread Django 
#28594: Value error on related user name during save of user model
-+-
 Reporter:  Axel Rau |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  Value error, user| Triage Stage:  Accepted
  model, normalize_username  |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Axel Rau):

 * Attachment "28594.diff" added.

 git diff of documentation patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.253a2aadd62d9f971f0b56e04e5653fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florian Apolloner):

 Does my PR fix it for you?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.cbc10274fcdcb04977922a4da2d4af70%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Berker Peksag):

 I have the same problem, but disabling the custom 404 handler didn't work
 for me as described in #28143 (closed as a duplicate of this issue)

 > Removing the custom 404 view from urls.py, or setting DEBUG to True
 (obviously), fixes the Django admin failed csrf error.

 Test URL: https://staging.python.org/admin/
 Source code: https://github.com/python/pythondotorg
 Installation document: https://pythondotorg.readthedocs.io/install.html

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2ca5005f1e83e8cdbbaa600caa055f42%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False and an intermediate 404 page is requested

2017-09-18 Thread Django 
#28488: Django 1.11+ raises CSRF verification failed if settings.DEBUG is False 
and
an intermediate 404 page is requested
-+-
 Reporter:  Ruben Alves  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  csrf failed  | Triage Stage:  Accepted
  settings debug false production|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Berker Peksag):

 * cc: Berker Peksag (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.39dc65cc04d690bdc60edd259a7423a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers.test_data

2017-09-18 Thread Django 
#21286: Fix commented out tests in serializers.test_data
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz):

 Missing skip issue in #28610.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1d3558c844d08ae959b4db274b99%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28610: register_tests() for serializers test does not exhibit skipped formats

2017-09-18 Thread Django 
#28610: register_tests() for serializers test does not exhibit skipped formats
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/9102 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3d02bcf9bad4750ecafe58a74da407fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28610: register_tests() for serializers test does not exhibit skipped formats

2017-09-18 Thread Django 
#28610: register_tests() for serializers test does not exhibit skipped formats
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Testing framework |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 When running the serializers tests dynamically created by
 `register_tests()`, and when a serializer is not available (for example
 missing pyyaml), the test suite doesn't show any skipped test. It simply
 ignores the missing tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.63ce5f3be39b7bb3d84ec70c7fe88340%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers.test_data

2017-09-18 Thread Django 
#21286: Fix commented out tests in serializers.test_data
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"256182c43d2ff029a4c55c74e43041c79d819cf6" 256182c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="256182c43d2ff029a4c55c74e43041c79d819cf6"
 Revert "Refs #21286 -- Enabled serializer tests with time pk model"

 This reverts commit 01c6a3e227b645e8dea97e9befecd23d1d3b8581.
 Unfortunately, the YAML serializer is not yet able to cope with time
 values.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7799c8f66b4fe555c8d71b9097723d60%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21286: Fix commented out tests in serializers.test_data

2017-09-18 Thread Django 
#21286: Fix commented out tests in serializers.test_data
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Serialization)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz):

 Argh, sorry! I was fooled by the fact the missing YAML lib in my test
 virtualenv wasn't showing by a skipped ('s') test. I will revert ASAP and
 try to work on that skip issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.fc019b828b360245794c595916f6137c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28609: Original request URI is not available to development server

2017-09-18 Thread Django 
#28609: Original request URI is not available to development server
-+-
   Reporter:  Jay Lynch  |  Owner:  nobody
   Type: | Status:  new
  Uncategorized  |
  Component:  Core   |Version:  1.11
  (Management commands)  |   Keywords:  server http-server
   Severity:  Normal |  runserver
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When using the default development server using `manage.py runserver` the
 value `settings.WSGI_APPLICATION` may be used to configure the WSGI
 application which is executed.

 If trying to use this feature to apply WSGI middleware, however, there is
 no way to access the original URI of the request, leaving the user unable
 to detect certain specific URLs they may wish to respond to, eg:

 `https://localhost:8000/search/test+search` and
 `https://localhost:8000/search/test%2Bsearch` appear identical to the WSGI
 application.

 In production this is typically addressed with a uWSGI parameter passing
 the original request URI as `REQUEST_URI`, the WSGIRequestHandler has the
 information and can perform the same function.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.06b0e1271e24bed66cbd3fde3593e803%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.