date:20180403

Re: [Django] #29278: FileResponse documentation should warn against using context managers

2018-04-03 Thread Django

Comment (by andrei kulakov):

Replying to [comment:5 Mike DePalatis]:

>
> I don't think all Python features need to be documented. However, this
is a special case where the required way of opening a file goes against
the usual best practices and thus it makes sense that this should be
explicitly noted.

In theory, perhaps, but in this case someone using this best practice
needs to understand the reason for 'with' construct. It's a fairly common
construct and its
use is much more general than just file objects. Also the way it works is
neither very obscure nor complex to understand.

You could also argue that the best practice is "use with construct and
complete all work on file within the `with` block", and so this best
practice does not apply
here because obviously no work is completed in the example.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.42ec96952d2f1300ff7f1285fa61aee9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29260: Remove UPDATE query when saving a new model instance with a primary key that has a default

2018-04-03 Thread Django

#29260: Remove UPDATE query when saving a new model instance with a primary key
that has a default
-+-
 Reporter:  user0007 |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Windson yang):

 @Tim Graham, should we still work on it?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4de9518dc56533f3f203297f4abb17d3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24791: Cannot run tests without access to postgres database

2018-04-03 Thread Django

#24791: Cannot run tests without access to postgres database
-+-
 Reporter:  Daniel Hahler|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"816b386d41e58c6ae750f2e57b6614310886a61a" 816b386d]:
 {{{
 #!CommitTicketReference repository=""
 revision="816b386d41e58c6ae750f2e57b6614310886a61a"
 Refs #24791 -- Made PostgreSQL's nodb connection use first PostgresSQL db
 when 'postgres' db isn't available.

 Thanks Tim Graham and Claude Paroz for reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.06a23190350542c5d66c79e0b9dbdd5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29280: Fix for a class of SQLite "database is locked" problems

2018-04-03 Thread Django

Comment (by Aymeric Augustin):

So the proposal here is to always use immediate rather than deferred
transactions.

Per https://www.sqlite.org/lang_transaction.html:
> After a BEGIN IMMEDIATE, no other database connection will be able to
write to the database or do a BEGIN IMMEDIATE or BEGIN EXCLUSIVE.

This means all `atomic` blocks will be serialized. Combined with
`ATOMIC_REQUESTS = True`, HTTP requests will be serialized. I don't think
that's an acceptable behavior.

In general the performance hit of removing the possibility of concurrent
database reads — and web workflows tend to be read-heavy — seems too high
to implement this in Django.

Also I'm not sure it fits well with the premise of allowing concurrency.
It brings us back to "Don't use SQLite, or don't do concurrency."

FWIW you can trivially subclass (or monkey-patch) the SQLite database
adapter to make this change in your project.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.b2f4b0fce5f7d9b65e89130c4a70d99e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

2018-04-03 Thread Django

#29287: Time to Remove: django.utils.deprecation.MiddlewareMixin
-+-
 Reporter:  Robert Roskam|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Robert Roskam):

 Apologies! I though it just a holdout from the switch in 1.10.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.efd1164fd732fc6cac0ff062b023c296%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

2018-04-03 Thread Django

#29287: Time to Remove: django.utils.deprecation.MiddlewareMixin
-+-
 Reporter:  Robert Roskam|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => wontfix
 * component:  Uncategorized => Core (Other)


Comment:

 It hasn't been deprecated (and therefore could not be removed immediately)
 and I see no advantage to removing it as it remains a useful class to
 avoid rewriting older middleware.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.785c599be521e5800274ae848ffd4557%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

2018-04-03 Thread Django

#29287: Time to Remove: django.utils.deprecation.MiddlewareMixin
+
   Reporter:  Robert Roskam |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Uncategorized |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 It was deprecated in 1.10:
 
https://github.com/django/django/blame/104ee2fdae7fcd402396c709c91f5c84de6e4165/django/utils/deprecation.py

 We've now had 1.11 and 2.0. Per our deprecation policy, it's actually
 overdue: https://docs.djangoproject.com/en/dev/internals/release-process
 /#deprecation-policy

 Lets remove it for 2.1!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.9ac97a7ca8c7c2b43b20cd7e2166f1f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21080: collectstatic post-processing fails for references inside comments

2018-04-03 Thread Django

#21080: collectstatic post-processing fails for references inside comments
-+
 Reporter:  shreyas@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Joshua Smith):

 * version:  2.0 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.2d7c67a0aa1b2d65694057e00259b348%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21080: collectstatic post-processing fails for references inside comments

2018-04-03 Thread Django

#21080: collectstatic post-processing fails for references inside comments
-+
 Reporter:  shreyas@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Joshua Smith):

 * cc: Joshua Smith (added)
 * version:  1.11 => 2.0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.d9a92fb79e31e194df24687aea76297c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28643: Complete the ORM Function Library

2018-04-03 Thread Django

#28643: Complete the ORM Function Library
-+-
 Reporter:  Matthew Pava |Owner:  JunyiJ
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by felixxm:

Old description:

> I was surprised to learn that we didn't have a StrIndex function until
> version 2, and yet we had Substr since at least version 1.8.  I wonder
> how users were using Substr without also finding a use for StrIndex this
> whole time.  Anyway, since we seem to be adding these functions one at a
> time, why don't we work on trying to get the built-ins implemented in one
> sweep instead?
>
> We may even want to split the documentation page
> (https://docs.djangoproject.com/en/dev/ref/models/database-functions/)
> into further categories with String functions and Numeric functions.
>
> This is just a sample checklist, with corresponding attributes to which
> backend has them available.
>
> = **Comparison** =||
> ||**Django**||**SQL**||**Description**||**PostgreSQL**||**Oracle**||**MySQL**||**SQLite**||**PR**||
> ||{{{NullIf}}}||{{{NULLIF}}}||Returns {{{NULL}}} if the first argument
> equals the
> second.||‎✔||‎✔||‎✔||‎✔||[https://github.com/django/django/pull/9543
> 9543]||
> = **Math** =||
> ||**Django**||**SQL**||**Description**||**PostgreSQL**||**Oracle**||**MySQL**||**SQLite**||**PR**||
> ||{{{Abs}}}||{{{ABS}}}||Returns the absolute
> value.||‎✔||‎✔||‎✔||‎✔||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{ACos}}}||{{{ACOS}}}||Returns the
> arccosine.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{ASin}}}||{{{ASIN}}}||Returns the
> arcsine.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{ATan}}}||{{{ATAN}}}||Returns the
> arctangent.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{ATan2}}}||{{{ATAN2}}}||Returns the arctangent of the two variables
> passed to
> it.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Ceil}}}||{{{CEILING}}}||Returns the smallest integer value that is
> not less than a numeric
> expression||‎✔||{{{CEIL}}}||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Cos}}}||{{{COS}}}||Returns the cosine expressed in
> radians.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Cot}}}||{{{COT}}}||Returns the
> cotangent.||‎✔||‎✔**^5^**||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Degrees}}}||{{{DEGREES}}}||Returns a numeric expression converted
> from radians to
> degrees.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Exp}}}||{{{EXP}}}||Returns the base of the natural logarithm (e)
> raised to the power of a numeric
> expression.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Floor}}}||{{{FLOOR}}}||Returns the largest integer value that is not
> greater than a numeric
> expression.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Ln}}}||{{{LN}}}||Returns the natural logarithm of a numeric
> expression.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Log}}}||{{{LOG(B, X)}}}||Returns the logarithm of a numeric
> expression.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Mod}}}||{{{MOD}}}||Returns the remainder of one expression by diving
> by another
> expression.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Pi}}}||{{{PI}}}||Returns the value of
> π||‎✔||✔**^4^**||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Power}}}||{{{POWER}}}||Returns the value of one expression raised to
> the power of another
> expression||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Radians}}}||{{{RADIANS}}}||Returns the value of an expression
> converted from degrees to
> radians.||‎✔||‎✔||‎✔||✔**^1^**||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Round}}}||{{{ROUND}}}||Returns a numeric expression rounded to an
> integer.\\Can be used to round an expression to a number of decimal
> points||‎✔||‎✔||‎✔||‎✔||[https://github.com/django/django/pull/9622
> 9622]||
> ||{{{Sin}}}||{{{SIN}}}||Returns the sine given in
>

Re: [Django] #28643: Complete the ORM Function Library

2018-04-03 Thread Django

#28643: Complete the ORM Function Library
-+-
 Reporter:  Matthew Pava |Owner:  JunyiJ
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"55cc26941a1eb6093bf9602e67a2b5fdf7e68683" 55cc269]:
 {{{
 #!CommitTicketReference repository=""
 revision="55cc26941a1eb6093bf9602e67a2b5fdf7e68683"
 Refs #28643 -- Added Repeat database function.

 Thanks Tim Graham and Nick Pope for reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a0164ea7b557e08009f538307caecbec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29281: In some cases i18n set_language does not change url language

2018-04-03 Thread Django

#29281: In some cases i18n set_language does not change url language
-+-
 Reporter:  Nikita Delyukov  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  1.11
  Internationalization   |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 If you have a sample project that reproduces the problem intermittently,
 that also might be enough to investigate the issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.75a1d65bd20cea6c7d563cfb06d6e17f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29274: Update the password list used by CommonPasswordValidator to a more recent list

2018-04-03 Thread Django

#29274: Update the password list used by CommonPasswordValidator to a more 
recent
list
-+-
 Reporter:  Brenton Cleeland |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  CommonPasswordValidator|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  New feature => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 [https://groups.google.com/d/topic/django-
 developers/oMWLVK5kTpI/discussion django-developers discussion]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.de7d9712ec8996abbdd63084ce3d62c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29276: Compatibility of charset works not well when there are non-ascii characters in HTTPResponse headers

2018-04-03 Thread Django

#29276: Compatibility of charset works not  well when there are non-ascii
characters in HTTPResponse headers
-+-
 Reporter:  sanjiely |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  2.0
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  HTTPResponse header  | Triage Stage:
  str bytes  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.44c0729ab1e49dea9a30cf9867d9d29f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11964: Add the ability to use database-level CHECK CONSTRAINTS

2018-04-03 Thread Django

#11964: Add the ability to use database-level CHECK CONSTRAINTS
-+-
 Reporter:  Matthew Schinckel|Owner:  Ian Foote
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  check contsraint | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


Comment:

 Please don't check "Patch needs improvement" only because there's a small
 merge conflict (as far as I can see, there's no outstanding review
 comments on the patch).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.359d5d19809c3b31fd36ef8ab7dbeb57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29251: MySQL backend returns bytes instead of strings in some queries involving database functions

2018-04-03 Thread Django

#29251: MySQL backend returns bytes instead of strings in some queries involving
database functions
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  mysql bytes  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6141c752fe7091d2197f5ac061300a9e0a36b09b" 6141c752]:
 {{{
 #!CommitTicketReference repository=""
 revision="6141c752fe7091d2197f5ac061300a9e0a36b09b"
 Fixed #29251 -- Added bytes to str conversion in LPad/RPad database
 functions on MySQL.

 Thanks Tim Graham for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c8483ebec4c621e043ec67838892ab06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11964: Add the ability to use database-level CHECK CONSTRAINTS

2018-04-03 Thread Django

#11964: Add the ability to use database-level CHECK CONSTRAINTS
-+-
 Reporter:  Matthew Schinckel|Owner:  Ian Foote
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  check contsraint | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Asif Saifuddin Auvi):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3fb0d4bb064e7e1a2035f6f54aa9aeda%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28577: Create system checks for mutable defaults on ArrayField and JSONField

2018-04-03 Thread Django

#28577: Create system checks for mutable defaults on ArrayField and JSONField
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  New feature  |   Status:  closed
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  check| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"4f7467b6905482a5d826c2815dcf8c6dd332340d" 4f7467b6]:
 {{{
 #!CommitTicketReference repository=""
 revision="4f7467b6905482a5d826c2815dcf8c6dd332340d"
 Refs #28577 -- Added check for HStoreField to prevent mutable default.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3fd72d4a3642d38f637b74017cebec6f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27728: Allowed overriding admin templatetag's templates.

2018-04-03 Thread Django

#27728: Allowed overriding admin templatetag's templates.
-+-
 Reporter:  Raffaele Salmaso |Owner:  Raffaele
 |  Salmaso
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"167d98528a2f38e370507ffe4f352b3406f5c5e1" 167d9852]:
 {{{
 #!CommitTicketReference repository=""
 revision="167d98528a2f38e370507ffe4f352b3406f5c5e1"
 Refs #27728 -- Fixed BytesWarning in admin_views tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2c8a4ba91f12f1d366e4ae7d9ea39dde%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28577: Create system checks for mutable defaults on ArrayField and JSONField

2018-04-03 Thread Django

#28577: Create system checks for mutable defaults on ArrayField and JSONField
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  New feature  |   Status:  closed
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  check| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 [https://github.com/django/django/pull/9852 PR] for `HStoreField` (as
 suggested in #28406).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.bcd97a3d5bde8a297ee6e517dff05e96%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28406: bug with HStore that has a default value of empty dict - {}

2018-04-03 Thread Django

#28406: bug with HStore that has a default value of empty dict - {}
-+-
 Reporter:  Eyal Elkevity|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  hstore   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 #28577 added checks for `JSONField` and `ArrayField` `default`. I added a
 [https://github.com/django/django/pull/9852 PR] to do to the same for
 `HStoreField`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fb11b6ec32441dc3c19e5f601f23e3a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24218: Use sub-query in ORM when distinct and order_by columns do not match

2018-04-03 Thread Django

#24218: Use sub-query in ORM when distinct and order_by columns do not match
-+-
 Reporter:  Miroslav |Owner:  nobody
  Shubernetskiy  |
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  subquery distinct| Triage Stage:  Accepted
  order_by   |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Harro):

 * cc: Harro (added)


Comment:

 This is exactly what I need right now.

 My proposal would be to add the distinct ordering to the distinct itself
 as a kwarg.

 {{{#!python
 Model.objects.all().distinct('foo', order_by=('-baz',)).order_by('bar')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.833bfd06fedb92f5a9959d66a299%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23577: Rename operations should rename indexes, constraints, sequences and triggers named after their former value

2018-04-03 Thread Django

#23577: Rename operations should rename indexes, constraints, sequences and
triggers named after their former value
-+
 Reporter:  Chris Woytowitz  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jonathan-golorry):

 I just ran into this issue with `RenameField` on `ManyToMany` relations.
 The (automatically generated) through table changes name, but the id_seq
 for it doesn't.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8e5091d6abba3267020ec72fa5989320%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  nobody => felixxm
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0c6f3ce96bf3b30c46c69385a1c5433f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9867ed6043066f8f7c770c7f3c117637%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29282: Admin checks raise TypeError if issubclass() receives a non-class (was: Admin checks raise TypeError if isinstance() receives a non-class)

2018-04-03 Thread Django

#29282: Admin checks raise TypeError if issubclass() receives a non-class
---+
 Reporter:  David Sanders  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.33d543c1251f221907ea9cfce90359d4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * Attachment "29286.diff" added.

 Regression test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9557d803d195ce1fe510b323b3f1c356%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * Attachment "29286.diff" added.

 Regression test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.260bceef0ea032d8c93a7fbab2a24398%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * Attachment "29286.diff" added.

 Regression test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e81c569fe8e61542c302961f1ca8b8fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

2018-04-03 Thread Django

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
   Reporter:  felixxm|  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.0
  layer (models, ORM)|
   Severity:  Release|   Keywords:
  blocker|
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 `QuerySet.values_list()` crashes when combining annotated and not-
 annotated querysets with union().

 Regression in
 
https://github.com/django/django/commit/a0c03c62a8ac586e5be5b21393c925afa581efaf.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.ade256986c975547c95e9a956ab9f37f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

2018-04-03 Thread Django

#29285: forms.DecimalField doesn't recognise max_decimal_places kwarg
-+-
 Reporter:  Paul Korir   |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Documentation|  Version:  2.0
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  fields,  | Triage Stage:
  max_decimal_places |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Please read the documentation once more, `max_decimal_places` is a key of
 the error messages dict, the kwarg is documented as being
 `decimal_places`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4f8fc01edf05cf829b14d02d3b8d0027%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

2018-04-03 Thread Django

#29285: forms.DecimalField doesn't recognise max_decimal_places kwarg
-+-
 Reporter:  Paul Korir   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Documentation|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  fields,  | Triage Stage:
  max_decimal_places |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by Claude Paroz:

Old description:

> Documentation
> (https://docs.djangoproject.com/en/2.0/ref/forms/fields/#decimalfield)
> states that max_decimal_places is a kwarg
>
> File "/Users/paulkorir/Documents/Code/Python/Django/project-
> classified/project_classified/listings/forms.py", line 48, in
> AdvancedSearch
> price_minimum = forms.DecimalField(required=False, min_value=0,
> max_value=2, max_decimal_places=2)
>   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
> /site-packages/django/forms/fields.py", line 330, in __init__
> super().__init__(max_value=max_value, min_value=min_value, **kwargs)
>   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
> /site-packages/django/forms/fields.py", line 254, in __init__
> super().__init__(**kwargs)
> TypeError: __init__() got an unexpected keyword argument
> 'max_decimal_places'
>
> However, works with decimal_places instead of max_decimal_places

New description:

 Documentation
 (https://docs.djangoproject.com/en/2.0/ref/forms/fields/#decimalfield)
 states that max_decimal_places is a kwarg

 {{{
 File "/Users/paulkorir/Documents/Code/Python/Django/project-
 classified/project_classified/listings/forms.py", line 48, in
 AdvancedSearch
 price_minimum = forms.DecimalField(required=False, min_value=0,
 max_value=2, max_decimal_places=2)
   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
 /site-packages/django/forms/fields.py", line 330, in __init__
 super().__init__(max_value=max_value, min_value=min_value, **kwargs)
   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
 /site-packages/django/forms/fields.py", line 254, in __init__
 super().__init__(**kwargs)
 TypeError: __init__() got an unexpected keyword argument
 'max_decimal_places'
 }}}

 However, works with decimal_places instead of max_decimal_places

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.85135121fc113661d27bab338f06e404%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29284: ImageField widget need 'accept' attribute

2018-04-03 Thread Django

#29284: ImageField widget need 'accept' attribute
--+
 Reporter:  safu9 |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+
Changes (by Claude Paroz):

 * needs_docs:  0 => 1
 * type:  Bug => Cleanup/optimization
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.38f662a608b5fe2f0533156375c1e4aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

2018-04-03 Thread Django

#29285: forms.DecimalField doesn't recognise max_decimal_places kwarg
-+-
   Reporter:  Paul   |  Owner:  nobody
  Korir  |
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  2.0
  Documentation  |   Keywords:  fields,
   Severity:  Normal |  max_decimal_places
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 Documentation
 (https://docs.djangoproject.com/en/2.0/ref/forms/fields/#decimalfield)
 states that max_decimal_places is a kwarg

 File "/Users/paulkorir/Documents/Code/Python/Django/project-
 classified/project_classified/listings/forms.py", line 48, in
 AdvancedSearch
 price_minimum = forms.DecimalField(required=False, min_value=0,
 max_value=2, max_decimal_places=2)
   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
 /site-packages/django/forms/fields.py", line 330, in __init__
 super().__init__(max_value=max_value, min_value=min_value, **kwargs)
   File "/Users/paulkorir/miniconda3/envs/project_classified/lib/python3.6
 /site-packages/django/forms/fields.py", line 254, in __init__
 super().__init__(**kwargs)
 TypeError: __init__() got an unexpected keyword argument
 'max_decimal_places'

 However, works with decimal_places instead of max_decimal_places

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.82d007f4e73351843f9a40a081236205%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29278: FileResponse documentation should warn against using context managers

Re: [Django] #29260: Remove UPDATE query when saving a new model instance with a primary key that has a default

Re: [Django] #24791: Cannot run tests without access to postgres database

Re: [Django] #29280: Fix for a class of SQLite "database is locked" problems

Re: [Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

Re: [Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

[Django] #29287: Time to Remove: django.utils.deprecation.MiddlewareMixin

Re: [Django] #21080: collectstatic post-processing fails for references inside comments

Re: [Django] #21080: collectstatic post-processing fails for references inside comments

Re: [Django] #28643: Complete the ORM Function Library

Re: [Django] #28643: Complete the ORM Function Library

Re: [Django] #29281: In some cases i18n set_language does not change url language

Re: [Django] #29274: Update the password list used by CommonPasswordValidator to a more recent list

Re: [Django] #29276: Compatibility of charset works not well when there are non-ascii characters in HTTPResponse headers

Re: [Django] #11964: Add the ability to use database-level CHECK CONSTRAINTS

Re: [Django] #29251: MySQL backend returns bytes instead of strings in some queries involving database functions

Re: [Django] #11964: Add the ability to use database-level CHECK CONSTRAINTS

Re: [Django] #28577: Create system checks for mutable defaults on ArrayField and JSONField

Re: [Django] #27728: Allowed overriding admin templatetag's templates.

Re: [Django] #28577: Create system checks for mutable defaults on ArrayField and JSONField

Re: [Django] #28406: bug with HStore that has a default value of empty dict - {}

Re: [Django] #24218: Use sub-query in ORM when distinct and order_by columns do not match

Re: [Django] #23577: Rename operations should rename indexes, constraints, sequences and triggers named after their former value

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Re: [Django] #29282: Admin checks raise TypeError if issubclass() receives a non-class (was: Admin checks raise TypeError if isinstance() receives a non-class)

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

[Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Re: [Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

Re: [Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

Re: [Django] #29284: ImageField widget need 'accept' attribute

[Django] #29285: forms.DecimalField doesn't recognise max_decimal_places kwarg

34 matches

Site Navigation

Mail list logo

Footer information