Re: [Django] #30501: Queryset ordering and Meta.ordering are mutable on expressions with reverse().

[Django]

#30501: Queryset ordering and Meta.ordering are mutable on expressions with
reverse().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * Attachment "30501.diff" added.

 Tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ce96fe3c944049d74783ff29d6727e15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30501: Queryset ordering and Meta.ordering are mutable on expressions with reverse().

[Django]

#30501: Queryset ordering and Meta.ordering are mutable on expressions with
reverse().
-+-
   Reporter:  felixxm|  Owner:  felixxm
   Type:  Bug| Status:  assigned
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Queryset order and `Meta.ordering` are mutable with `reverse()`.

 Bug revealed by running `./runtests.py ordering.test --reverse`
 (reproduced at a2c31e12da272acc76f3a3a0157fae9a7f6477ac).

 It seems that test added in f218a2ff455b5f7391dd38038994f2c5f8b0eca1
 wasn't correct because order mutates on queryset execution in
 
[https://github.com/django/django/blob/a2c31e12da272acc76f3a3a0157fae9a7f6477ac/django/db/models/sql/compiler.py#L253
 SQLCompiler.get_order_by()].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.9f83b356bc42c5ec9fdc9944bea98928%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30498: lazy() class preparation is not being cached correctly.

[Django]

#30498: lazy() class preparation is not being cached correctly.
-+-
 Reporter:  Ran Benita   |Owner:  Ran
 Type:   |  Benita
  Cleanup/optimization   |   Status:  closed
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a2c31e12da272acc76f3a3a0157fae9a7f6477ac" a2c31e12]:
 {{{
 #!CommitTicketReference repository=""
 revision="a2c31e12da272acc76f3a3a0157fae9a7f6477ac"
 Fixed #30498 -- Fixed proxy class caching in lazy().

 lazy() should prepare the proxy class only once (the first time it's
 used) not on every call.

 Regression in b4e76f30d12bfa8a53cc297c60055c6f4629cc4c.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1370d68145c07ae8384aee9958f2ef5d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30256: autocomplete_fields cause one or two extra queries for each field wth foreign key or many to many relation

[Django]

#30256: autocomplete_fields cause one or two extra queries for each field wth
foreign key or many to many relation
--+
 Reporter:  George Tantiras   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  autocomplete  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by George Tantiras):

 Carlton, thank you for the feedback!

 I would like to try for a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6d8523c0fb7a495e32317ec06f4899c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30500: Error reporting returns a circular import error on a python formatting error, and does not restart the development server

[Django]

#30500: Error reporting returns a circular import error on a python formatting
error, and does not restart the development server
-+-
 Reporter:  Runner15 |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Error reporting  |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:  error reporting, | Triage Stage:
  error, circular import |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Runner15):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9b8815540fcbaebe90b082ec88d8e3e9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30500: Error reporting returns a circular import error on a python formatting error, and does not restart the development server

[Django]

#30500: Error reporting returns a circular import error on a python formatting
error, and does not restart the development server
-+-
   Reporter:  Runner15   |  Owner:  (none)
   Type: | Status:  new
  Uncategorized  |
  Component:  Error  |Version:  2.2
  reporting  |   Keywords:  error reporting,
   Severity:  Normal |  error, circular import
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 In Django 2.2.1, a python formatting error, such as a NameError or
 IndentationError will give the error shown below:
 {{{
 Exception in thread django-main-thread:
 Traceback (most recent call last):
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/urls/resolvers.py", line 581, in url_patterns
 iter(patterns)
 TypeError: 'module' object is not iterable

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
 self.run()
   File "/usr/lib/python3.5/threading.py", line 862, in run
 self._target(*self._args, **self._kwargs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/utils/autoreload.py", line 54, in wrapper
 fn(*args, **kwargs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/commands/runserver.py", line 117, in
 inner_run
 self.check(display_num_errors=True)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/base.py", line 390, in check
 include_deployment_checks=include_deployment_checks,
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/base.py", line 377, in _run_checks
 return checks.run_checks(**kwargs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/checks/registry.py", line 72, in run_checks
 new_errors = check(app_configs=app_configs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/checks/urls.py", line 13, in check_url_config
 return check_resolver(resolver)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/checks/urls.py", line 23, in check_resolver
 return check_method()
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/urls/resolvers.py", line 398, in check
 for pattern in self.url_patterns:
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/utils/functional.py", line 80, in __get__
 res = instance.__dict__[self.name] = self.func(instance)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/urls/resolvers.py", line 588, in url_patterns
 raise ImproperlyConfigured(msg.format(name=self.urlconf_name))
 django.core.exceptions.ImproperlyConfigured: The included URLconf
 'runnertest.urls' does not appear to have any patterns in it. If you see
 valid patterns in the file then the issue is probably caused by a circular
 import.
 }}}
 This throws django.core.exceptions.ImproperlyConfigured error, with the
 message that the main urls file does not appear to have any patters in it,
 and if there are patterns then the issue is probably a circular import.
 Neither of these are the problem, as it is just a simple line in the code
 that is indented improperly, or a variable that is not assigned.  When
 this issue is fixed, the development server does not restart itself to
 reflect this fix.  It manually has to be quit and then restarted.

 The code below is the same python formatting error in Django 2.1.  It
 shows the error at the end of the error reporting, and when the error is
 fixed in the code, the development server restarts itself.
 {{{
 Unhandled exception in thread started by .wrapper at 0x7f03cb1029d8>
 Traceback (most recent call last):
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/utils/autoreload.py", line 225, in wrapper
 fn(*args, **kwargs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/commands/runserver.py", line 117, in
 inner_run
 self.check(display_num_errors=True)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/base.py", line 379, in check
 include_deployment_checks=include_deployment_checks,
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/management/base.py", line 366, in _run_checks
 return checks.run_checks(**kwargs)
   File "/home/runner/.local/lib/python3.5/site-
 packages/django/core/checks/registry.py", line 71, in run_checks
 new_errors = check(app_configs=app_c

Re: [Django] #30116: Drop support for Python 3.5

[Django]

#30116: Drop support for Python 3.5
-+-
 Reporter:  Tim Graham   |Owner:  Tim
 Type:   |  Graham
  Cleanup/optimization   |   Status:  closed
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"b711eafd2aabdf22e1d529bfb76dd8d3356d7000" b711eafd]:
 {{{
 #!CommitTicketReference repository=""
 revision="b711eafd2aabdf22e1d529bfb76dd8d3356d7000"
 Refs #30116 -- Removed unnecessary str() calls in CommonPasswordValidator.

 open() and gzip.open() supports path-like objects since Python 3.6.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3669b8cea400d0785199d82720f1392c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29548: Add official support for MariaDB.

[Django]

#29548: Add official support for MariaDB.
-+-
 Reporter:  Tim Graham   |Owner:  felixxm
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Good point thanks, fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.caea4d405e258b8b5e77bb8574ff17e0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29548: Add official support for MariaDB.

[Django]

#29548: Add official support for MariaDB.
-+-
 Reporter:  Tim Graham   |Owner:  felixxm
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 @felixxm your PR link is self-referencing the ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.17260b8cdd95bbd6d4cb873a490d4d35%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9982: Inconsistent behavior on model save depending on whether OneToOneField is a primary key

[Django]

#9982: Inconsistent behavior on model save depending on whether OneToOneField 
is a
primary key
-+-
 Reporter:  sean@…   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  OneToOneField| Triage Stage:  Accepted
  primary_key IntegrityError |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * cc: Can Sarıgöl (added)


Comment:

 Hi, I think this bug is fixed by that
 
[https://github.com/django/django/commit/519016e5f25d7c0a040015724f9920581551cab0
 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.c4433695796d7d54edb2b7edd1c38116%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30497: assertXMLEqual fails on document type declaration.

[Django]

#30497: assertXMLEqual fails on document type declaration.
---+---
 Reporter:  Yuri Kanivetsky|Owner:  Caio Ariede
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by felixxm):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f347d5c39415ac6f2c354c4388d335d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28553: Querysets: annotate() columns are forced into a certain position which may disrupt union()

[Django]

#28553: Querysets: annotate() columns are forced into a certain position which 
may
disrupt union()
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Kal Sze):

 Actually there could be a different problem as well. We were lucky in that
 the ORM generated SQL where the column types do not match. But what
 happens when the column types match? I'm afraid you would get a query that
 doesn't throw an exception but is in fact subtly broken, especially if the
 values of the differnet columns happen to be similar, in which case it
 might take a long time for app developers to realize that the query is
 broken.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0210d2d5e226fab653d31c0ceebd6c15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30499: PasswordResetView should be allowed to set `domain_override`

[Django]

#30499: PasswordResetView should be allowed to set `domain_override`
-+-
 Reporter:  Mattia Procopio  |Owner:  Mattia
 |  Procopio
 Type:  New feature  |   Status:  assigned
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, yes, it seems a reasonable addition.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6ad36084156d283597ace5b3eb28eebe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24342: Add EnumField model/form fields

[Django]

#24342: Add EnumField model/form fields
-+-
 Reporter:  Thomas Stephenson|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Cesar Canassa):

 * cc: Cesar Canassa (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8533bc8fa23f4480d590051b5e0e30a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30256: autocomplete_fields cause one or two extra queries for each field wth foreign key or many to many relation

[Django]

#30256: autocomplete_fields cause one or two extra queries for each field wth
foreign key or many to many relation
--+
 Reporter:  George Tantiras   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  autocomplete  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * keywords:   => autocomplete
 * version:  2.1 => master
 * stage:  Unreviewed => Accepted


Comment:

 OK, this is a gnarly one but I'm going to Accept it as a possible
 optimization.

 The **extra** queries are generated when rendering the `optgroups` for the
 widgets.

 django-autocomplete-light (DAL) [https://github.com/yourlabs/django-
 autocomplete-
 light/blob/230c9a119d24ef969a39c4fbd28207714f26ca58/src/dal/widgets.py#L132
 excludes unselected self.choices before determining the options to
 render], i.e. it only initially renders the selected option.

 Where the selected option is **just** the foreign key value that we
 already selected for the admin this query can be eliminated.

 {{{
 SELECT "inl_child2"."id", "inl_child2"."key_id", "inl_child2"."boolean",
 "inl_child2"."child_key_id"
 FROM "inl_child2" INNER JOIN "inl_child3_child_keys" ON ("inl_child2"."id"
 = "inl_child3_child_keys"."child2_id")
 WHERE "inl_child3_child_keys"."child3_id" = 1
 }}}

 Looks to already cover in this case:

 {{{
 SELECT "inl_child2"."id", "inl_child2"."key_id", "inl_child2"."boolean",
 "inl_child2"."child_key_id"
 FROM "inl_child2"
 WHERE "inl_child2"."id" IN (2)
 }}}

 (Since the FK points to child2.id = 2 in this case.)

 Forcing evaluation of the [https://github.com/yourlabs/django-
 autocomplete-
 light/blob/230c9a119d24ef969a39c4fbd28207714f26ca58/src/dal/widgets.py#L186
 temporarily reduced queryset (here)] causes the query count to match that
 observed in Django's own autocomplete, since we apply no such
 optimization. (i.e All choices are required in `optgroups()` in Django's
 version.)

 Thus in theory there's a gain to be had here.

 Thanks for the report George. Fancy working on a patch? 🙂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2671a17560c0e27e3b95894e0610d799%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30499: PasswordResetView should be allowed to set `domain_override`

[Django]

#30499: PasswordResetView should be allowed to set `domain_override`
-+-
 Reporter:  Mattia Procopio  |Owner:  Mattia
 |  Procopio
 Type:  New feature  |   Status:  assigned
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mattia Procopio):

 * status:  new => assigned
 * owner:  nobody => Mattia Procopio


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6ab0929e916e254f77b6e414c8dfbb00%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30499: PasswordResetView should be allowed to set `domain_override`

[Django]

#30499: PasswordResetView should be allowed to set `domain_override`
---+
   Reporter:  Mattia Procopio  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  Uncategorized|Version:  master
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Actually if the domain of the link sent within the mail needs to be
 overridden, the view `form_valid` method should be replaced or the view
 should subclass an own instance of PasswordContextMixin.
 I think allowing to inject a custom domain from `urls.py` would help with
 DRY in this case as the new domain can be passed when declaring
 `PasswordResetView.as_view(domain_override="mynew.domain.com"`)

 I am thinking of adding simply domain_override = None as new class
 attribute and adding it to opts:


 {{{
 class PasswordResetView(PasswordContextMixin, FormView):
 ...
 domain_override = None

 def form_valid(self, form):
 opts = {
 'use_https': self.request.is_secure(),
 'token_generator': self.token_generator,
 'from_email': self.from_email,
 'email_template_name': self.email_template_name,
 'subject_template_name': self.subject_template_name,
 'request': self.request,
 'html_email_template_name': self.html_email_template_name,
 'extra_email_context': self.extra_email_context,
 'domain_override': self.domain_override,
 }
 form.save(**opts)
 return super().form_valid(form)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.3cf108063bb8422deb82bc2777ad8ecb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30497: assertXMLEqual fails on document type declaration.

[Django]

#30497: assertXMLEqual fails on document type declaration.
---+---
 Reporter:  Yuri Kanivetsky|Owner:  Caio Ariede
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by Caio Ariede):

 PR: https://github.com/django/django/pull/11402

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b10e551c27c6bc096ac4bf82cbed98f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30497: assertXMLEqual fails on document type declaration.

[Django]

#30497: assertXMLEqual fails on document type declaration.
---+---
 Reporter:  Yuri Kanivetsky|Owner:  Caio Ariede
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by Caio Ariede):

 * owner:  nobody => Caio Ariede
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9cd55e5e49928482fa245cdcb38cfe3b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29548: Add official support for MariaDB.

[Django]

#29548: Add official support for MariaDB.
-+-
 Reporter:  Tim Graham   |Owner:  felixxm
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://code.djangoproject.com/ticket/29548 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.81acdbffb180ef81c78b7cbd84d61a5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30498: lazy() class preparation is not being cached correctly. (was: lazy() class preparation is not being cached correctly)

[Django]

#30498: lazy() class preparation is not being cached correctly.
-+-
 Reporter:  Ran Benita   |Owner:  Ran
 Type:   |  Benita
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  nobody => Ran Benita
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report! Reproduced at
 888fdf182e164fa4b24aa82fa833c90a2b9bee7a.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a9599c9d05dde9d7c3ec6ffa1f23753e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28780: Allow customizing PasswordResetConfirmView's INTERNAL_RESET_URL_TOKEN

[Django]

#28780: Allow customizing PasswordResetConfirmView's INTERNAL_RESET_URL_TOKEN
--+-
 Reporter:  Meiyer|Owner:  robinh00d
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+-
Changes (by felixxm):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.de76df3c637fd0d7023bce0fe9057cd7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30476: Add introspection of "json" (like "jsonb") data type as JSONField on PostgreSQL.

[Django]

#30476: Add introspection of "json" (like "jsonb") data type as JSONField on
PostgreSQL.
-+-
 Reporter:  Héctor Pablos|Owner:  (none)
 Type:  New feature  |   Status:  closed
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  inspectdb,   | Triage Stage:
  JSONField, json, jsonb |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Adam (Chainz) Johnson):

 Also worth bearing in mind is that there's a GSoC project underway to
 create a cross-DB JSONField, which ultimately inspectdb should probably
 point to
 https://summerofcode.withgoogle.com/organizations/5465143218012160/#projects

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1dc806282338c2e9ed7b0cc5c2945f50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30485: Unexpected behavior for django.utils.http.urlencode

[Django]

#30485: Unexpected behavior for django.utils.http.urlencode
-+-
 Reporter:  Johan Lübcke |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6a67871017efbd3fa4ce752680737b33%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30498: lazy() class preparation is not being cached correctly

[Django]

#30498: lazy() class preparation is not being cached correctly
-+-
 Reporter:  Ran Benita   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ran Benita):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/11399

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4237a68be2fe468a29d772bc530d57a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30485: Unexpected behavior for django.utils.http.urlencode

[Django]

#30485: Unexpected behavior for django.utils.http.urlencode
--+
 Reporter:  Johan Lübcke  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, having conferred with Mariusz, I'm going to Accept this as a bug on
 2.2, to be fixed in master, rather than backported to 2.2. (We'll look at
 the final patch before deciding finally there.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.538fc045009712d705c68d9a92fb8fb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30498: lazy() class preparation is not being cached correctly

[Django]

#30498: lazy() class preparation is not being cached correctly
+
   Reporter:  Ran Benita|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Utilities |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Doing `self.__prepared = True` changes the instance, but the intention is
 to change the class variable:
 
https://github.com/django/django/blob/888fdf182e164fa4b24aa82fa833c90a2b9bee7a/django/utils/functional.py#L82

 This makes functions like gettext_lazy, format_lazy and reverse_lazy a lot
 slower than they ought to be.

 Regressed in Django 1.8 (b4e76f30d12bfa8a53cc297c60055c6f4629cc4c).

 Using this micro-benchmark on Python 3.7:

 {{{#!python
 import cProfile
 from django.utils.functional import lazy

 def identity(x): return x
 lazy_identity = lazy(identity, int)
 cProfile.run("for i in range(1): str(lazy_identity(1))")
 }}}


 Before:

 {{{
   910049 function calls in 0.208 seconds

 Ordered by: standard name

 ncalls  tottime  percall  cumtime  percall filename:lineno(function)
  10.0100.0100.2080.208 :1()
  10.0010.0000.0010.000 bench.py:4(identity)
  10.0050.0000.0100.000 functional.py:105(__str__)
  10.0040.0000.1880.000
 functional.py:159(__wrapper__)
  10.0070.0000.1850.000 functional.py:76(__init__)
  10.0890.0000.1780.000
 functional.py:83(__prepare_class__)
  10.0040.0000.0050.000 functional.py:99(__cast)
  10.0000.0000.2080.208 {built-in method
 builtins.exec}
 840.0870.0000.0870.000 {built-in method
 builtins.hasattr}
 460.0000.0000.0000.000 {built-in method
 builtins.setattr}
  10.0000.0000.0000.000 {method 'disable' of
 '_lsprof.Profiler' objects}
  10.0020.0000.0020.000 {method 'mro' of 'type'
 objects}
 }}}

 After:

 {{{
   50135 function calls in 0.025 seconds

 Ordered by: standard name

 ncalls  tottime  percall  cumtime  percall filename:lineno(function)
  10.0080.0080.0250.025 :1()
  10.0010.0000.0010.000 bench.py:4(identity)
  10.0050.0000.0090.000 functional.py:105(__str__)
  10.0030.0000.0080.000
 functional.py:159(__wrapper__)
  10.0050.0000.0050.000 functional.py:76(__init__)
  10.0000.0000.0000.000
 functional.py:83(__prepare_class__)
  10.0040.0000.0050.000 functional.py:99(__cast)
  10.0000.0000.0250.025 {built-in method
 builtins.exec}
 840.0000.0000.0000.000 {built-in method
 builtins.hasattr}
 460.0000.0000.0000.000 {built-in method
 builtins.setattr}
  10.0000.0000.0000.000 {method 'disable' of
 '_lsprof.Profiler' objects}
  10.0000.0000.0000.000 {method 'mro' of 'type'
 objects}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.368e1524f97fe0a4028c8d3f3d70be7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30497: assertXMLEqual fails on document type declaration. (was: assertXMLEqual chokes on document type declaration)

[Django]

#30497: assertXMLEqual fails on document type declaration.
---+
 Reporter:  Yuri Kanivetsky|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by felixxm):

 * version:  2.2 => master
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for this report. We should probably omit `Node.DOCUMENT_TYPE_NODE`
 when looking for a `root` element and compare document types separately.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fd556b5a0d357803767f35aa8afb16ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.