Re: [Django] #31013: Remove jQuery dependency from SelectBox.js

2019-11-20 Thread Django
#31013: Remove jQuery dependency from SelectBox.js
-+-
 Reporter:  Johannes Hoppe   |Owner:  Johannes
 Type:   |  Hoppe
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.69dd91d9fedb252170b8cef7d245f7ec%40djangoproject.com.


Re: [Django] #30996: add AsBinary and AsText GIS functions

2019-11-20 Thread Django
#30996: add AsBinary and AsText GIS functions
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.acc6072ae1323c495b9889138b357f39%40djangoproject.com.


Re: [Django] #25388: Allow disabling of all migrations during tests

2019-11-20 Thread Django
#25388: Allow disabling of all migrations during tests
-+-
 Reporter:  Markus Holtermann|Owner:  Mariusz
 |  Felisiak 
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  new => closed
 * owner:  (none) => Mariusz Felisiak 
 * resolution:   => fixed


Comment:

 In [changeset:"f5ebdfce5c417f9844e86bccc2f12577064d4bad" f5ebdfce]:
 {{{
 #!CommitTicketReference repository=""
 revision="f5ebdfce5c417f9844e86bccc2f12577064d4bad"
 Fixed #25388 -- Added an option to allow disabling of migrations during
 test database creation.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f786b67abf74aacab61afcbf054b%40djangoproject.com.


Re: [Django] #31011: A new template tag for ternary operations?

2019-11-20 Thread Django
#31011: A new template tag for ternary operations?
-+--
 Reporter:  Remy |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by felixxm):

 * version:  2.2 => master
 * component:  Uncategorized => Template system


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0af510024ad0c9c1902c00a77618119a%40djangoproject.com.


Re: [Django] #31011: A new template tag for ternary operations?

2019-11-20 Thread Django
#31011: A new template tag for ternary operations?
---+--
 Reporter:  Remy   |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Please [https://docs.djangoproject.com/en/stable/internals/contributing
 /triaging-tickets/#closing-tickets follow triaging guidelines with regards
 to wontfix tickets] and don't open duplicates.

 Duplicate of #14333.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bce206945435399c5783c9e5d6c84a67%40djangoproject.com.


Re: [Django] #31009: Test database named just "test_". (was: Test database named just "test_")

2019-11-20 Thread Django
#31009: Test database named just "test_".
-+-
 Reporter:  rvernica |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * version:  2.1 => master
 * resolution:   => wontfix


Comment:

 I agree with Simon, we don't want to parse `cnf` files and we provide an
 option to specify the test database name.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.13e54329a716b11485523da7cff0552c%40djangoproject.com.


Re: [Django] #30975: Replace get_select_option with Selenium's native select_by_value

2019-11-20 Thread Django
#30975: Replace get_select_option with Selenium's native select_by_value
--+
 Reporter:  Johannes Hoppe|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  Selenium  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Johannes Hoppe):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e408f044ce50bb55d669fac9707d3592%40djangoproject.com.


Re: [Django] #31013: Remove jQuery dependency from SelectBox.js

2019-11-20 Thread Django
#31013: Remove jQuery dependency from SelectBox.js
-+-
 Reporter:  Johannes Hoppe   |Owner:  Johannes
 Type:   |  Hoppe
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Johannes Hoppe):

 * owner:  nobody => Johannes Hoppe
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6da33b8f44452e67be99a5a9be815122%40djangoproject.com.


[Django] #31013: Remove jQuery dependency from SelectBox.js

2019-11-20 Thread Django
#31013: Remove jQuery dependency from SelectBox.js
+
   Reporter:  Johannes Hoppe|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  1 |
+
 Currently, `django/contrib/admin/static/admin/js/SelectBox.js` uses jQuery
 only to execute `$(box).empty();` which can easily replaced with

 {{{
 while (box.options.length)
 box.options.remove(0);
 }}}

 I'd suggest making that tiny change and drop the jQuery dependency.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.f0623570b82de29b62ffa75ab93fb665%40djangoproject.com.


Re: [Django] #30803: Dateparse function should support comma separators for milliseconds according to ISO-8601

2019-11-20 Thread Django
#30803: Dateparse function should support comma separators for milliseconds
according to ISO-8601
-+--
 Reporter:  Ben Wilber   |Owner:  Ben Wilber
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Farhaan Bukhsh):

 Hey, I would love to complete this PR, what can be the next steps? I see
 writing tests as one of them. Thanks a ton in advance. :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.27853fcdbca6cbb4b1ca8be3c247044c%40djangoproject.com.


[Django] #31012: Required SelectDateWidget renders invalid HTML

2019-11-20 Thread Django
#31012: Required SelectDateWidget renders invalid HTML
-+
   Reporter:  Kevin Brown|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Forms  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 When you render a `SelectDateWidget` for a field marked as required, I
 noticed it produced output that does not meet the HTML standard per
 https://www.w3.org/TR/html5/sec-forms.html#placeholder-label-option. This
 was called out in the 3.0 release notes so I checked out #29056 and
 determined that was likely the cause.

 

 The specific issue is that a `SelectDateWidget`, when specified as a
 required field, will generate a `placeholder` attribute on each of the
 `` boxes which it generates. The `placeholder` attribute is not
 valid for a `` box and instead a "placeholder" option must be
 specified as an `` with an empty value (`value=""`) with the text
 containing the placeholder to display.

 From a Django forms perspective, this would be equivalent to setting the
 `empty_label` for the `SelectDateWidget` to `(_('Year'), _('Month'),
 _('Day'))`, which would generate each of the placeholder label options for
 each of the corresponding `` boxes used by the widget.

 It's also important to note that the HTML generated for the
 `SelectDateWidget` in previous versions of Django was valid per the HTML
 standard. They did not contain a placeholder label option, but because
 they were not a `` they always contained an option with a
 selectedness set to true (usually the first option). This meant that the
 `required` attribute generated for them was useless, since it would never
 not have a value or be empty, but it did mean it was still valid HTML.

 

 Here's some relevant parts of the standard when it comes to required
 select boxes.

 > If a select element has a required attribute specified, does not have a
 multiple attribute specified, and has a display size of 1; and if the
 value of the first option element in the select element's list of options
 (if any) is the empty string, and that option element's parent node is the
 select element (and not an optgroup element), then that option is the
 select element's placeholder label option.
 >
 > If a select element has a required attribute specified, does not have a
 multiple attribute specified, and has a display size of 1, then the select
 element must have a placeholder label option.
 >
 > Constraint validation: If the element has its required attribute
 specified, and either none of the option elements in the select element's
 list of options have their selectedness set to true, or the only option
 element in the select element's list of options with its selectedness set
 to true is the placeholder label option, then the element is suffering
 from being missing.

 You can also find the list of accepted attributes for a `` at
 https://html.spec.whatwg.org/multipage/form-elements.html#the-select-
 element and https://developer.mozilla.org/en-
 US/docs/Web/HTML/Element/select#Attributes. Note that neither of those
 pages specify that a `` element may have a `placeholder`
 attribute.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.a3c7399e4f21ce76608a90a9a886752b%40djangoproject.com.


[Django] #31011: A new template tag for ternary operations?

2019-11-20 Thread Django
#31011: A new template tag for ternary operations?
-+
   Reporter:  lapinvert  |  Owner:  nobody
   Type:  New feature| Status:  new
  Component:  Uncategorized  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I am aware that this issue was already pointed out
 [https://code.djangoproject.com/ticket/14333 here], but it was 9 years
 ago, so I allowed myself to bring it back again.

 HTML easily gets complex and nested, and in many case you don't want to
 add to this complexity and you need to add inline logic but you can't do
 that in Django without a lot of verbosity.

 Django's PHP competitor `Laravel` manages template with something called
 `Blade`, in which inserting a one-line condition looks like:
 `{{ condition ? var1 : var2 }}`
 ... which is the exact same syntaxe as many major JavaScript-based
 frontend frameworks (Vue / React...).

 Rails's templating engine `ERB` also provides a similar syntaxe:
 `<%= condition? ? var1 : var2 %>`

 I also remember one of my projects in Angular 1, where I was even able to
 use a filter on the output of it:
 `{{ condition ? date1 : date2 | dateFilter }}`
 (and also have space around the filter for better readability, but that's
 another topic... `Sparse is better than dense`)

 In Django that would translate in:

 `{% if condition %}{{ date1|date:'c' }}{% else %}{{ date2|date:'c' }}{%
 endif %}`

 That is... pretty verbose. Especially if you replace those placeholder
 vars with actual (often longer) ones. In an actual project you often find
 yourself violating in many ways the Zen of Python (flat vs nested,
 readability, etc).

 The other tools we have at our disposal is :
 - The filter `|default:''` works fine in a lot of cases, but sometimes you
 just need to check for a third parameter.
 - The filter `|yesno:"yes,no"` however this works only for displaying
 strings.

 **Possible solution**

 Well, the point is not to say that Django should allow the exact same
 syntaxe as other languages, but at least I think it should allow some sort
 of natively supported ternary operation.

 I suggest to keep the pythonic way of writing a ternary operation and
 implement it within Django template. Example:
 `{% ternary var1 if condition else var2 %}`
 Currently:
 `{% if condition %}{{ var1 }}{% else %}{{ var2 }}{% endif %}`

 Given the arbitrary "ternary" wording, this is `{% ternary  if  else  %}`
 vs `{% if  %}{{  }}{% else %}{{  }}{% endif %}`. 43 chars -> 25 chars
 (about 43% reduction).

 **Final thoughts**

 If this is to be resolved as `wontfix` again, would it be possible to at
 least explain a clear and practical reason as for why we don't want to
 include a native ternary operation in Django templates, where virtually
 every other languages and frameworks do include one? (`python`,
 `JavaScript`, `Rails`, `Laravel` ...)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.ca708fd8d150e66303c6c3ccee08ae1a%40djangoproject.com.


Re: [Django] #31009: Test database named just "test_"

2019-11-20 Thread Django
#31009: Test database named just "test_"
-+-
 Reporter:  rvernica |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Not sure what to do here. It looks like #30636 added tested support for
 using `read_default_file` with `manage.py` test but it assumed `NAME` was
 provided.

 Given [https://docs.djangoproject.com/en/2.2/ref/settings/#test we already
 provide an option] to specify the test database name I'm not convinced
 teaching the test database name generation logic to parse CNF files if
 `NAME` is not provided is worth the complexity it incurs. I'm inclined to
 close this as ''wontfix''.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f0013ac090933ae36411b0e5c6010290%40djangoproject.com.


[Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

2019-11-20 Thread Django
#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
-+
   Reporter:  thenewguy  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 It would minimize configuration for new projects if ALLOWED_HOSTS +=
 ['.localhost'] when DEBUG=True

 Chrome resolves *.localhost to localhost without modifying any host files
 or DNS

 Referencing the project this way makes it easy to test subdomains ->
 static.localhost, uploads.localhost, www.localhost, etc

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.9d5c962682ed8d3dcc4183ea959b5e11%40djangoproject.com.


Re: [Django] #28357: Prepopulated_fields doesn't work for admin.StackedInline.

2019-11-20 Thread Django
#28357: Prepopulated_fields doesn't work for admin.StackedInline.
-+-
 Reporter:  ChristosKon  |Owner:  Jakob
 |  Köhler
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin,   | Triage Stage:  Accepted
  stackedinline, |
  prepopulated_fields|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Jakob Köhler):

 * needs_tests:  1 => 0


Comment:

 I added a test for the scenario defined by Ryan ✅

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.66771066b6809f9d49ee49ee8e50368f%40djangoproject.com.


[Django] #31009: Test database named just "test_"

2019-11-20 Thread Django
#31009: Test database named just "test_"
-+-
   Reporter:  rvernica   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.1
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When I do `manage.py test` the database that is created is named only
 `test_`

 In `settings.py` I have:
 {{{
 DATABASES = {
 'default': {
 'ENGINE': 'django.db.backends.mysql',
 'OPTIONS': {
 'read_default_file': 'app/my.cnf',
 },
 }
 }
 }}}

 while in `my.cfg` I have:
 {{{
 [client]
 host = db
 database = foo
 user = bar
 password = taz
 default-character-set = utf8
 }}}

 I expect that the test database be called `test_foo`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.ee5ebeec9b7e9c1d416a4f637c866500%40djangoproject.com.


Re: [Django] #31008: Incorrect rendering of some code blocks in documentation

2019-11-20 Thread Django
#31008: Incorrect rendering of some code blocks in documentation
---+
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Mariusz Felisiak ):

 In [changeset:"ae2e13504b9a72a4e816af578d66bf14c9cbf1bb" ae2e135]:
 {{{
 #!CommitTicketReference repository=""
 revision="ae2e13504b9a72a4e816af578d66bf14c9cbf1bb"
 [3.0.x] Fixed #31008 -- Fixed typos in docs/topics/logging.txt.

 Backport of 3e5b349535f011a51dc308898924786143000631 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b598b0d2fd9e2488e045d369b6d68072%40djangoproject.com.


Re: [Django] #31008: Incorrect rendering of some code blocks in documentation

2019-11-20 Thread Django
#31008: Incorrect rendering of some code blocks in documentation
---+
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by GitHub ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3e5b349535f011a51dc308898924786143000631" 3e5b349]:
 {{{
 #!CommitTicketReference repository=""
 revision="3e5b349535f011a51dc308898924786143000631"
 Fixed #31008 -- Fixed typos in docs/topics/logging.txt.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c63f58d0b31406e4fd30c4b0a3a3ac24%40djangoproject.com.


Re: [Django] #31008: Incorrect rendering of some code blocks in documentation

2019-11-20 Thread Django
#31008: Incorrect rendering of some code blocks in documentation
---+
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/12114 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.64ca304e0921380dbcd085da81f4948b%40djangoproject.com.


Re: [Django] #31008: Incorrect rendering of some code blocks in documentation

2019-11-20 Thread Django
#31008: Incorrect rendering of some code blocks in documentation
---+
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Yep. Good catch. Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5364b4491aa49025b7517907e8a2a485%40djangoproject.com.


[Django] #31008: Incorrect rendering of some code blocks in documentation

2019-11-20 Thread Django
#31008: Incorrect rendering of some code blocks in documentation
-+
   Reporter:  Baptiste Mispelon  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  master
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 There seem to be a rendering issue for some of the code blocks on the
 [https://docs.djangoproject.com/en/dev/topics/logging/#examples logging
 documentation page].

 The code blocks have the following text on the top:
 {{{
 .. code-block:: python
   :caption: settings.py
 }}}

 Only the `dev` and `3.0` versions of the documentation seem affected (at
 the time of the report anyway).
 I'm not sure if other pages are affected.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.f20d8c893a50aa3d3330bb3e67bd0fa7%40djangoproject.com.


Re: [Django] #30993: Class based views and syndications are similar, but not exactly the same

2019-11-20 Thread Django
#30993: Class based views and syndications are similar, but not exactly the same
-+-
 Reporter:  Tobias Bengfort  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.syndication  |  Version:  2.2
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Hi Tobias.

 I know what you mean. But I think this is too vague as it stands.
 ''Rewrite the syndication views'' is a big ticket, and would need a plan,
 in the form of a DEP probably, outline what that would look like. Yes,
 maybe there's room for improvement here... but something concrete to go on
 would be needed to push that forward.

 I hope that makes sense. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/060.0e0dae839c66ed8d72cf9763053c6f10%40djangoproject.com.


Re: [Django] #30995: Feature/docs: how should url converters decline to match for a named route?

2019-11-20 Thread Django
#30995: Feature/docs: how should url converters decline to match for a named 
route?
-+-
 Reporter:  Jack Cushman |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  reverse, urls,   | Triage Stage:  Accepted
  converter  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * version:  2.2 => master
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 OK, good. You're right about the number of args and keyword arguments
 case. Super. Sorry for missing that.
 (Is your second "Resolution based on values" example right? It should be
 **number** of positional args, rather then type, no? Doesn't matter.)

 The issue here is that in your case the kwarg is `obj` both times. So
 reverse can't currently pick it up. Fine.

 Then, yes, your suggestion to raise a `ValueError` seems plausible enough.
 Want to take that on?
 (I've unchecked "Easy pickings" as I think there's probably more in this
 than that entails.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5e42d93c6f6aeb75669ad652ace6b92f%40djangoproject.com.


[Django] #31007: Make it possible to change the default AutoField to BigAutoField

2019-11-20 Thread Django
#31007: Make it possible to change the default AutoField to BigAutoField
-+-
   Reporter:  Caio   |  Owner:  Caio Ariede
  Ariede |
   Type:  New| Status:  assigned
  feature|
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 This was initially proposed in this comment/PR:
 https://github.com/django/django/pull/8924#issuecomment-516792989

 1. I really like the proposed approach of having a `DEFAULT_AUTOFIELD`
 setting.
 2. For backwards compatibility, when `DEFAULT_AUTOFIELD` is not set, we
 should keep the default behavior: `django.db.models.AutoField`
 3. Whenever this setting is changed, it would affect all existing AND new
 fields (pk and fk)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.e04437705d9e023dd274e1afd8f132a5%40djangoproject.com.


Re: [Django] #31003: Suggesting: Documentation update for bulk_create method

2019-11-20 Thread Django
#31003: Suggesting: Documentation update for bulk_create method
-+-
 Reporter:  Peter Vlasveld   |Owner:  Peter
 Type:   |  Vlasveld
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:  bulk_create, | Triage Stage:  Accepted
  database, query,   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Peter Vlasveld):

 * status:  new => assigned
 * owner:  nobody => Peter Vlasveld


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.075befaaaecf132fbd6610348d17f302%40djangoproject.com.


Re: [Django] #30625: DatabaseCache backend raises TypeError if get/delete received key as integer.

2019-11-20 Thread Django
#30625: DatabaseCache backend raises TypeError if get/delete received key as
integer.
-+-
 Reporter:  Hiroki Kiyohara  |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 I made a [https://github.com/django/django/pull/12111 PR] to add note to
 `backward incompatible changes` section in Django 2.2 release note.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9a69e84847a5a85aea786f21a0f18554%40djangoproject.com.


Re: [Django] #27164: Database routers examples could be more realistic

2019-11-20 Thread Django
#27164: Database routers examples could be more realistic
-+-
 Reporter:  michaeloconnor   |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  multiple databases   | Triage Stage:  Accepted
  docs   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11e42001d9b4d91ad1f7161b7242ddff5457f56a" 11e42001]:
 {{{
 #!CommitTicketReference repository=""
 revision="11e42001d9b4d91ad1f7161b7242ddff5457f56a"
 [2.2.x] Fixed #27164 -- Fixed an example of using routers in multiple
 databases docs.

 Make sure that AuthRouter includes ContentType in the same database.

 Backport of 608e06023e6eaf75f744134a0fd203853260e616 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.edf945647a0b34c5e5324a5d3f00880b%40djangoproject.com.


Re: [Django] #27164: Database routers examples could be more realistic

2019-11-20 Thread Django
#27164: Database routers examples could be more realistic
-+-
 Reporter:  michaeloconnor   |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  multiple databases   | Triage Stage:  Accepted
  docs   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"608e06023e6eaf75f744134a0fd203853260e616" 608e0602]:
 {{{
 #!CommitTicketReference repository=""
 revision="608e06023e6eaf75f744134a0fd203853260e616"
 Fixed #27164 -- Fixed an example of using routers in multiple databases
 docs.

 Make sure that AuthRouter includes ContentType in the same database.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.ba69f4e3c1f0d3ceb51f01f99092275d%40djangoproject.com.


Re: [Django] #27164: Database routers examples could be more realistic

2019-11-20 Thread Django
#27164: Database routers examples could be more realistic
-+-
 Reporter:  michaeloconnor   |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  multiple databases   | Triage Stage:  Accepted
  docs   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"5f24b18e6cf052b7b6175d9d024bbd206c247be5" 5f24b18e]:
 {{{
 #!CommitTicketReference repository=""
 revision="5f24b18e6cf052b7b6175d9d024bbd206c247be5"
 [3.0.x] Fixed #27164 -- Fixed an example of using routers in multiple
 databases docs.

 Make sure that AuthRouter includes ContentType in the same database.

 Backport of 608e06023e6eaf75f744134a0fd203853260e616 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.45182a9d18d08365268eb5e5a6989241%40djangoproject.com.


Re: [Django] #30991: Optional removal of transaction and extra get() in get_or_create().

2019-11-20 Thread Django
#30991: Optional removal of transaction and extra get() in get_or_create().
-+-
 Reporter:  Michael Korobov  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  get_or_create| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Michael Korobov):

 Thanks for your time and a reply. We will be keeping these changes as a
 patch in our app.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e2ce1096d3db1df8fd03597e9ff34259%40djangoproject.com.


Re: [Django] #30484: Add conditional expression support to CheckConstraint.

2019-11-20 Thread Django
#30484: Add conditional expression support to CheckConstraint.
-+-
 Reporter:  David Sanders|Owner:  Simon
 |  Charette
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8d7a3f97567275d0b58719fca5d556b5%40djangoproject.com.


Re: [Django] #31004: Using FilteredRelation on M2M relationship duplicates result rows.

2019-11-20 Thread Django
#31004: Using FilteredRelation on M2M relationship duplicates result rows.
-+-
 Reporter:  idemchenko-wrk   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  FilteredRelation | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thanks for this report. You're using a nullable relations i.e. you don't
 filter by `available_discounts` that's why we need to use `LEFT OUTER
 JOIN` because you want to get items with and without matching discounts.
 You can use `distinct()` or split your query. I don't think that's
 anything that we can change in Django to make it works better.

 Closing per TicketClosingReasons/UseSupportChannels.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2da51672b89119443f1f6e0e5e95a83a%40djangoproject.com.