Re: [Django] #29056: Required SelectDateWidget renders invalid HTML

[Django]

#29056: Required SelectDateWidget renders invalid HTML
+--
 Reporter:  Vlastimil Zíma  |Owner:  Hasan Ramezani
 Type:  Bug |   Status:  closed
Component:  Forms   |  Version:  master
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Vlastimil Zíma):

 When reported, the `SelectDateWidget` actually rendered invalid HTML, but
 it was fixed as a side-effect of #29036. Looks like I've created this
 ticket during the discussion and forgot to close it afterwards.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.80a2ede4666d4e2f2615725b617557c0%40djangoproject.com.

Re: [Django] #31007: Make it possible to change the default AutoField to BigAutoField. (was: Make it possible to change the default AutoField to BigAutoField)

[Django]

#31007: Make it possible to change the default AutoField to BigAutoField.
-+-
 Reporter:  Caio Ariede  |Owner:  Caio
 |  Ariede
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 I think we need a discussion and consensus on the DevelopersMailingList
 before we move forward with this ticket. Adding a new setting is always a
 bit controversial and changing the "default" `AutoField` for all tables is
 a complicated and error-prone task. That's why we need a clear path, I'm
 closing before we finish a discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0346a594db7aa6fddd198a7a7c4da7cc%40djangoproject.com.

Re: [Django] #31018: Update FAQ about NoSQL databases.

[Django]

#31018: Update FAQ about NoSQL databases.
--+
 Reporter:  Thomas Güttler|Owner:  felixxm
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * status:  new => assigned
 * owner:  nobody => felixxm
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/12144 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.12bdf87e4ef33afec8b20aa903c6dc7c%40djangoproject.com.

Re: [Django] #31032: Document the minimal supported version of browsers for the admin

[Django]

#31032: Document the minimal supported version of browsers for the admin
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.68ca0fc4082d094ad2038d8c91adcb3a%40djangoproject.com.

Re: [Django] #31018: Update FAQ about NoSQL databases.

[Django]

#31018: Update FAQ about NoSQL databases.
--+
 Reporter:  Thomas Güttler|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Claude Paroz):

 Looks good!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.81f20d2d89d89d0927978f4279c30470%40djangoproject.com.

Re: [Django] #31028: Use JavaScript classList API

[Django]

#31028: Use JavaScript classList API
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


Comment:

 Fair, if it is already used, then let's go ahead.

 I created #31032 for the docs issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9a20c008dc4b0d25182bdb0613c3cb3c%40djangoproject.com.

[Django] #31032: Document the minimal supported version of browsers for the admin

[Django]

#31032: Document the minimal supported version of browsers for the admin
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 This [https://docs.djangoproject.com/en/2.2/faq/admin/#what-browsers-are-
 supported-for-using-the-admin current FAQ entry] states:
 `The admin provides a fully-functional experience to YUI’s A-grade
 browsers, with the notable exception of IE6, which is not supported.`

 I think it's outdated because more recent versions of IE are currently not
 fully supported, especially since the responsive patch.
 Can we find a way to indicate something more specific without having to
 list versions of all possible browsers? It would be great for Django admin
 devs to know which JS API they can use or not.
 Read also [https://groups.google.com/forum/#!msg/django-
 developers/MN9nz5rJODY/MAIOEVKCAQAJ this django-developers] discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.7a9bcd70420eb1f013f64c39527a1f39%40djangoproject.com.

Re: [Django] #31026: Switch form rendering to template engine

[Django]

#31026: Switch form rendering to template engine
--+
 Reporter:  Johannes Hoppe|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Johannes Hoppe):

 Ok, I have a working patch now. It does not change tests, or removes much
 code to prove its backwards compatible.
 However, I'd like to introduce some changes, to improve the resulting
 architecture and output.


 1. Change the position of hidden inputs. Currently, they are injected at a
 certain index. I'd like to simply amend them. It would greatly simplify
 the templates. Since they are hidden, it shouldn't change browser
 rendering.
 2. I'd like to deprecate the now unused
 `django.forms.BaseForm._html_output`. Yes, it is private, but we have
 tests running against it and it's referenced in some tickets. This gives
 me the impression is more commonly used than we'd like.
 3. I'd like to deprecate `django.forms.boundfield.BoundField.label_tag`.
 The label can be generated with a template with a simple include. I
 believe this to be the better implementation.
 4. Errors I would not change. I am not 100% happy with the design,
 however, it is based on templates now, which makes adding changes simple.

 I haven't written any documentation yet, this will be another monster
 task. I'd like to get some feedback on the code side first, to avoid back
 and forth.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3be23632b6662fac6794413477e51680%40djangoproject.com.

Re: [Django] #31031: Possible data loss in admin changeform view when using regex special characters in formset prefix

[Django]

#31031: Possible data loss in admin changeform view when using regex special
characters in formset prefix
---+
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  2.2
 Severity:  Release blocker|   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Simon Charette):

 * version:  3.0 => 2.2
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Marking as a release blocker since it's technically a data loss regression
 in a change introduced in 2.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ab1affd28f6d00e27c7da2c49041c657%40djangoproject.com.

Re: [Django] #31030: register SQLite functions as deterministic on Python 3.8

[Django]

#31030: register SQLite functions as deterministic on Python 3.8
-+-
 Reporter:  Sergey Fedoseev  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 We'll want to makes to not do so for function using global or connection
 state (e.g. timezone).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.37bf0aac71ae6848c6355a88ef679f02%40djangoproject.com.

Re: [Django] #31031: Possible data loss in admin changeform view when using regex special characters in formset prefix

[Django]

#31031: Possible data loss in admin changeform view when using regex special
characters in formset prefix
---+--
 Reporter:  Baptiste Mispelon  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Old description:

> While browsing the code in `admin/options.py` [1] (working on an
> unrelated ticket), I came across that line:
>
> {{{
> #!python
> pk_pattern = re.compile(r'{}-\d+-{}$'.format(prefix,
> self.model._meta.pk.name))
> }}}
>
> Generating a regex like this using string formatting can cause problems
> when the arguments contain special regex characters.
>
> `self.model._meta.pk.name` is probably safe (I'm not 100% sure about
> this) since it has to follow Python's syntax rules about identifiers.
> However `prefix` has no such restrictions [2] and could contain any
> number of special regex characters.
>
> The fix is quite straightforward (use `re.escape()`) but it's hard to
> tell if there might be other occurrences of a similar pattern in Django's
> code.
>
> Some quick grepping (using `git grep -E
> '(re_compile|re\.(compile|search|match))' -- 'django/**.py'`) currently
> yields about 200 results. I had a superficial glance through the list and
> didn't spot other instances of the same usage pattern.
>
> [1]
> https://github.com/django/django/blob/ef93fd4683645635d3597e17c23f9ed862dd716b/django/contrib/admin/options.py#L1634
> [2]
> https://docs.djangoproject.com/en/dev/topics/forms/formsets/#customizing-a-formset-s-prefix

New description:

 While browsing the code in `admin/options.py` [1] (working on an unrelated
 ticket), I came across that line:

 {{{
 #!python
 pk_pattern = re.compile(r'{}-\d+-{}$'.format(prefix,
 self.model._meta.pk.name))
 }}}

 Generating a regex like this using string formatting can cause problems
 when the arguments contain special regex characters.

 `self.model._meta.pk.name` is probably safe (I'm not 100% sure about this)
 since it has to follow Python's syntax rules about identifiers.
 However `prefix` has no such restrictions [2] and could contain any number
 of special regex characters.

 The fix is quite straightforward (use `re.escape()`) but it's hard to tell
 if there might be other occurrences of a similar pattern in Django's code.

 Some quick grepping (using `git grep -E
 '(re_compile|re\.(compile|search|match))' -- 'django/**.py'`) currently
 yields about 200 results. I had a superficial glance through the list and
 didn't spot other instances of the same usage pattern.

 **EDIT** I forgot to mention, but this bug is technically a regression
 (introduced in b18650a2634890aa758abae2f33875daa13a9ba3).

 [1]
 
https://github.com/django/django/blob/ef93fd4683645635d3597e17c23f9ed862dd716b/django/contrib/admin/options.py#L1634
 [2]
 
https://docs.djangoproject.com/en/dev/topics/forms/formsets/#customizing-a-formset-s-prefix

--

Comment (by Baptiste Mispelon):

 [https://github.com/django/django/pull/12143 PR here]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2c20197b6b506b1e593dcd25b6873d06%40djangoproject.com.

[Django] #31031: Possible data loss in admin changeform view when using regex special characters in formset prefix

[Django]

#31031: Possible data loss in admin changeform view when using regex special
characters in formset prefix
-+
   Reporter:  Baptiste Mispelon  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.admin  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 While browsing the code in `admin/options.py` [1] (working on an unrelated
 ticket), I came across that line:

 {{{
 #!python
 pk_pattern = re.compile(r'{}-\d+-{}$'.format(prefix,
 self.model._meta.pk.name))
 }}}

 Generating a regex like this using string formatting can cause problems
 when the arguments contain special regex characters.

 `self.model._meta.pk.name` is probably safe (I'm not 100% sure about this)
 since it has to follow Python's syntax rules about identifiers.
 However `prefix` has no such restrictions [2] and could contain any number
 of special regex characters.

 The fix is quite straightforward (use `re.escape()`) but it's hard to tell
 if there might be other occurrences of a similar pattern in Django's code.

 Some quick grepping (using `git grep -E
 '(re_compile|re\.(compile|search|match))' -- 'django/**.py'`) currently
 yields about 200 results. I had a superficial glance through the list and
 didn't spot other instances of the same usage pattern.

 [1]
 
https://github.com/django/django/blob/ef93fd4683645635d3597e17c23f9ed862dd716b/django/contrib/admin/options.py#L1634
 [2]
 
https://docs.djangoproject.com/en/dev/topics/forms/formsets/#customizing-a-formset-s-prefix

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.6afc6a013b39ded1920e1317bad6efff%40djangoproject.com.

Re: [Django] #31018: Update FAQ about NoSQL databases. (was: This FAQ is outdated (Does Django support NoSQL databases?))

[Django]

#31018: Update FAQ about NoSQL databases.
--+
 Reporter:  Thomas Güttler|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * type:  Uncategorized => Cleanup/optimization
 * component:  Uncategorized => Documentation
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Django doesn't support NoSQL databases, so I don't think that we should
 extend this FAQ. However I also agree that we shouldn't recommend `django-
 nonreal` in our docs. It looks that [https://nesdis.github.io/djongo/
 djongo] is a better alternative but it's already mentioned in a wiki page
 and should stay there. I would suggest a small cleanup, e.g.:

 {{{
 diff --git a/docs/faq/models.txt b/docs/faq/models.txt
 index 89bbbd1724..9c3951efa0 100644
 --- a/docs/faq/models.txt
 +++ b/docs/faq/models.txt
 @@ -69,11 +69,10 @@ Does Django support NoSQL databases?

  NoSQL databases are not officially supported by Django itself. There are,
  however, a number of side project and forks which allow NoSQL
 functionality in
 -Django, like `Django non-rel`_.
 +Django.

 -You can also take a look on `the wiki page`_ which discusses some
 alternatives.
 +You can take a look on `the wiki page`_ which discusses some projects.

 -.. _`Django non-rel`: http://django-nonrel.org/
  .. _`the wiki page`: https://code.djangoproject.com/wiki/NoSqlSupport

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fba39959bfbc89b188204bd588ab50fc%40djangoproject.com.

Re: [Django] #31027: Prefer DOM object properties over Element.getAttribute() and Element.setAttribute(). (was: Prefer DOM object properties over Element.getAttribute() and Element.setAttribute())

[Django]

#31027: Prefer DOM object properties over Element.getAttribute() and
Element.setAttribute().
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


Comment:

 I agree that we should prefer DOM properties but we need to be aware of
 differences and caveats (see [https://javascript.info/dom-attributes-and-
 properties comparison]). For example `href` is quite tricky because as a
 DOM property it's always a full URL, even if the attribute contains a
 relative URL or just a `#` and of course on IE it doesn't work that way.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8da9f11065d83115b91458346e829670%40djangoproject.com.

Re: [Django] #31028: Use JavaScript classList API

[Django]

#31028: Use JavaScript classList API
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jon Dufresne):

 Thanks. The `classList` API is already in use by the Django admin.

 {{{
 django/contrib/admin/static/admin/js/collapse.js
 21   elem.classList.add('collapsed');
 39   if (fieldset.classList.contains('collapsed')) {
 42   fieldset.classList.remove('collapsed');
 46   fieldset.classList.add('collapsed');
 }}}

 The commit where this was introduced is
 ba83378a7762c51be235b521aa5b48233d6c6c82. This shipped with 2.2.

 So this change is not introducing a new, untested API.

 I think being more explicit about support is a great idea and a solid
 improvement. I just question why it should guard this particular change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b8eb8f162caf08ef6224f7c770c144f4%40djangoproject.com.

[Django] #31030: register SQLite functions as deterministic on Python 3.8

[Django]

#31030: register SQLite functions as deterministic on Python 3.8
-+-
   Reporter:  Sergey |  Owner:  nobody
  Fedoseev   |
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  sqlite
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 On Python 3.8 `deterministic` parameter was added to
 
[https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_function
 sqlite3.Connection.create_function() ], it should be used when possible to
 allow SQLite to perform additional optimizations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.fd25d5397e689e555da5eaad17cff620%40djangoproject.com.

Re: [Django] #31013: Remove jQuery dependency from SelectBox.js

[Django]

#31013: Remove jQuery dependency from SelectBox.js
-+-
 Reporter:  Johannes Hoppe   |Owner:  Johannes
 Type:   |  Hoppe
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ef93fd4683645635d3597e17c23f9ed862dd716b" ef93fd46]:
 {{{
 #!CommitTicketReference repository=""
 revision="ef93fd4683645635d3597e17c23f9ed862dd716b"
 Fixed #31013 -- Removed jQuery usage in SelectBox.js.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e08f62ed11c66241e71fa50fa31cd277%40djangoproject.com.

Re: [Django] #31002: AttributeError when using a GIS filter against a subquery annotation.

[Django]

#31002: AttributeError when using a GIS filter against a subquery annotation.
-+-
 Reporter:  Vasileios Bouzas |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0290e01d5a202507e9a71294ac9cb31725c951bb" 0290e01]:
 {{{
 #!CommitTicketReference repository=""
 revision="0290e01d5a202507e9a71294ac9cb31725c951bb"
 Fixed #31002 -- Fixed GIS lookups crash against a subquery annotation.

 Thanks Vasileios Bouzas for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.5efc65f05198a053332ee589e7554c0f%40djangoproject.com.

Re: [Django] #30803: Dateparse function should support comma separators for milliseconds according to ISO-8601

[Django]

#30803: Dateparse function should support comma separators for milliseconds
according to ISO-8601
-+--
 Reporter:  Ben Wilber   |Owner:  Farhaan Bukhsh
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by felixxm):

 * owner:  Ben Wilber => Farhaan Bukhsh
 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/12141 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.56a02333156177358e75ec8fa40b2e46%40djangoproject.com.

Re: [Django] #23950: Adding 'deconstruct' method breaks serialization of type

[Django]

#23950: Adding 'deconstruct' method breaks serialization of type
+-
 Reporter:  Gavin Wahl  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak ):

 In [changeset:"ba5760965ed52d1b310097e060f8511f9bad7631" ba57609]:
 {{{
 #!CommitTicketReference repository=""
 revision="ba5760965ed52d1b310097e060f8511f9bad7631"
 [3.0.x] Refs #23950 --- Moved test DeconstructibleInstances class to a
 module level.

 DeconstructibleInstances was not importable from the asserted path.

 Backport of 8008795a3899d979d65832ca7c4946903de206f7 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6e024d0e525d9b62f635a4ca561b59f3%40djangoproject.com.

Re: [Django] #23950: Adding 'deconstruct' method breaks serialization of type

[Django]

#23950: Adding 'deconstruct' method breaks serialization of type
+-
 Reporter:  Gavin Wahl  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak ):

 In [changeset:"8008795a3899d979d65832ca7c4946903de206f7" 8008795a]:
 {{{
 #!CommitTicketReference repository=""
 revision="8008795a3899d979d65832ca7c4946903de206f7"
 Refs #23950 --- Moved test DeconstructibleInstances class to a module
 level.

 DeconstructibleInstances was not importable from the asserted path.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4fc5baf4735df06f074c4e6b7847d3b3%40djangoproject.com.

Re: [Django] #27914: makemigrations produces incorrect path for inner classes

[Django]

#27914: makemigrations produces incorrect path for inner classes
-+-
 Reporter:  Serge van den Boom   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"b6cbc88f26aa7a4279a71cd8895dc0a1aa6ff398" b6cbc88f]:
 {{{
 #!CommitTicketReference repository=""
 revision="b6cbc88f26aa7a4279a71cd8895dc0a1aa6ff398"
 [3.0.x] Fixed #27914 -- Fixed serialization of nested classes in
 migrations.

 Backport of 29d8198841ea39af44f3bc835d646e642d498475 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e3158cf64891d77bd28cee9cf5149e3f%40djangoproject.com.

Re: [Django] #27914: makemigrations produces incorrect path for inner classes

[Django]

#27914: makemigrations produces incorrect path for inner classes
-+-
 Reporter:  Serge van den Boom   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"29d8198841ea39af44f3bc835d646e642d498475" 29d8198]:
 {{{
 #!CommitTicketReference repository=""
 revision="29d8198841ea39af44f3bc835d646e642d498475"
 Fixed #27914 -- Fixed serialization of nested classes in migrations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8a38a5ab684e7f16e61b82069a75dd8b%40djangoproject.com.

Re: [Django] #31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.

[Django]

#31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"28dd5362ae17a975c4d273d6019aeb8e890e3576" 28dd536]:
 {{{
 #!CommitTicketReference repository=""
 revision="28dd5362ae17a975c4d273d6019aeb8e890e3576"
 [2.2.x] Fixed #31025 -- Fixed highlightlinenothreshold deprecation warning
 on Sphinx 1.8+.

 Backport of 89d41cba392b759732ba9f1db4ff29ed47da6a56 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.77b96db4b836c6c890a9c484328c0bc2%40djangoproject.com.

Re: [Django] #31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.

[Django]

#31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"641deb4d50e2ae3c7031739dcf9d1524492dc095" 641deb4]:
 {{{
 #!CommitTicketReference repository=""
 revision="641deb4d50e2ae3c7031739dcf9d1524492dc095"
 [3.0.x] Fixed #31025 -- Fixed highlightlinenothreshold deprecation warning
 on Sphinx 1.8+.

 Backport of 89d41cba392b759732ba9f1db4ff29ed47da6a56 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c930a1559432b9771b87dc83b5a6c1ff%40djangoproject.com.

Re: [Django] #31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.

[Django]

#31025: HTMLTranslator.highlightlinenothreshold will be removed in Sphinx 3.0.
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"89d41cba392b759732ba9f1db4ff29ed47da6a56" 89d41cba]:
 {{{
 #!CommitTicketReference repository=""
 revision="89d41cba392b759732ba9f1db4ff29ed47da6a56"
 Fixed #31025 -- Fixed highlightlinenothreshold deprecation warning on
 Sphinx 1.8+.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ee018b0d82a7550ad4f06c5750b214b0%40djangoproject.com.

Re: [Django] #31002: AttributeError when using a GIS filter against a subquery annotation.

[Django]

#31002: AttributeError when using a GIS filter against a subquery annotation.
-+-
 Reporter:  Vasileios Bouzas |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * version:  2.2 => master
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.6e7ef8a9dd5c011f6c5ef02501c3ae0a%40djangoproject.com.

Re: [Django] #31029: Link to more specific sections when using the :rfc: role. (was: Link to more specific sections when using the `:rfc:` role)

[Django]

#31029: Link to more specific sections when using the :rfc: role.
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  nobody => Baptiste Mispelon
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bc08b1ef44a1b88c7123aa318e389411%40djangoproject.com.

Re: [Django] #31029: Link to more specific sections when using the `:rfc:` role

[Django]

#31029: Link to more specific sections when using the `:rfc:` role
-+-
 Reporter:  Baptiste Mispelon|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Baptiste Mispelon):

 [https://github.com/django/django/pull/12142 PR here]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5795978b272afdfaf0255a4cf20a6100%40djangoproject.com.

[Django] #31029: Link to more specific sections when using the `:rfc:` role

[Django]

#31029: Link to more specific sections when using the `:rfc:` role
+
   Reporter:  Baptiste Mispelon |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 While looking at the documentation for the `r` format of the `|date`
 template filter [1], I ended up following the link to the RFC and had to
 look around the page to find the section that was actually relevant.

 It turns out that sphinx's `:ref:` role supports linking to a specific
 section of an RFC (this feature is already used in a few places in
 Django's docs).
 I think it would be useful to use that when possible and/or relevant.


 So I did some grepping (using {{{git grep -E ':rfc:\`[0-9]+\`'}}}) and for
 each match I tried to see if there was a specific section that was
 relevant to the context.
 I skipped the release notes to save myself some work and because all the
 matches there were for unsupported versions anyway (10 matches with the
 latest one for the 1.10 release).

 I also added a paragraph in the contributing guide so that other
 contributors might know about the feature too.

 [1] https://docs.djangoproject.com/en/dev/ref/templates/builtins/#date

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.24a744e8762d1d581023959247dec374%40djangoproject.com.

Re: [Django] #25388: Allow disabling of all migrations during tests

[Django]

#25388: Allow disabling of all migrations during tests
-+-
 Reporter:  Markus Holtermann|Owner:  Mariusz
 |  Felisiak 
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"a69c4d626afe9e56131aeb624caf3137ddd98bcb" a69c4d62]:
 {{{
 #!CommitTicketReference repository=""
 revision="a69c4d626afe9e56131aeb624caf3137ddd98bcb"
 Refs #25388 -- Corrected value of TEST MIGRATE setting in
 MIGRATION_MODULES docs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.922e0bc4e5580f61052f7be91335fb23%40djangoproject.com.

Re: [Django] #31026: Switch form rendering to template engine

[Django]

#31026: Switch form rendering to template engine
--+
 Reporter:  Johannes Hoppe|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Johannes Hoppe):

 With that change I'd also like to drop
 [error_class]https://docs.djangoproject.com/en/2.2/ref/forms/api
 /#customizing-the-error-list-format support, since this would be a
 template too. However, this is a documented API, though not widely used. I
 will work around it for now, but I'd really like to remove it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.288051e2fd67d35a781b4f567a3cf4aa%40djangoproject.com.