Re: [Django] #29249: Make serializers consistently unicode by default.

2020-04-27 Thread Django
#29249: Make serializers consistently unicode by default.
-+-
 Reporter:  hakib|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  dumpdata, unicode| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1f091046a2673252f00f7a405deda74c%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Braunson):

 Replying to [comment:24 Andrew Godwin]:
 > Oh, OK. Note that you can use those under WSGI Django as well and
 they'll perform very similarly - Django 3.0 does not have a true-
 asynchronous request path, so it's using one thread per request anyway.

 Thanks, we'll just not use asgi for now then :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.183c968a198358081536e48b5ddf7068%40djangoproject.com.


Re: [Django] #30372: Django (moderately) High CPU usage at Idle

2020-04-27 Thread Django
#30372: Django (moderately) High CPU usage at Idle
-+-
 Reporter:  Benjamin Schollnick  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  2.2
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andy Terra):

 Replying to [comment:15 Tom Forbes]:
 > Hey Andy,
 >
 > I have a hunch about where some of this excess load comes from. If
 you're willing it would be very helpful if you could try installing my
 branch:
 >
 > {{{
 > pip install https://github.com/orf/django/archive/30372-speedups.zip
 > }}}
 >
 > Alternatively you could set the `USE_I18N` setting to `False` in your
 project.
 >
 > I think it's the code that recurses through the `locale` directories to
 watch for changes to `.mo` files. Django ships with a large number of
 built in translation files that never change, and iterating through the
 several hundred directories might be the cause of some of the slowdown
 you're seeing.

 Tom,

 Just wanted to say I saw your comment yesterday and will look into it. I'm
 having trouble replicating the high CPU load now, even though it was
 consistent for *months*... will let you know once I find anything more
 definitive.


 Best,
 Andy

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.dd1ebd5b09ca15bec1c0c26d02123646%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Andrew Godwin):

 Oh, OK. Note that you can use those under WSGI Django as well and they'll
 perform very similarly - Django 3.0 does not have a true-asynchronous
 request path, so it's using one thread per request anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9bce3751aac028a98331710015b1cdb8%40djangoproject.com.


Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-27 Thread Django
#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
---+--
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by thenewguy):

 Created draft PR https://github.com/django/django/pull/12810

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e3fccff7e7e7259905448255f6bbded2%40djangoproject.com.


[Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-27 Thread Django
#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
-+
   Reporter:  thenewguy  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I am using ManifestStaticFilesStorage and was under the impression that
 subclassing and setting `manifest_strict=False` would allow pages to
 render if a static file is missing (perhaps due to a template typo)
 instead of raising a ValueError.

 However, if the file is missing from disk a ValueError is raised.

 I believe this is an oversight as it would be preferrable for a typo to
 cause a 404 instead of preventing a page from rendering.

 Adding this try/except block lets the page render and the tests below
 pass.  Otherwise they fail when the files do not exist.


 {{{

 if cache_name is None:
 if self.manifest_strict:
 raise ValueError("Missing staticfiles manifest entry for
 '%s'" % clean_name)
 try:
 hashed = self.hashed_name(name)
 except ValueError:
 hashed = name
 cache_name = self.clean_name(hashed)

 }}}


 This is what the reworked function looks like:


 {{{
 def stored_name(self, name):
 parsed_name = urlsplit(unquote(name))
 clean_name = parsed_name.path.strip()
 hash_key = self.hash_key(clean_name)
 cache_name = self.hashed_files.get(hash_key)
 if cache_name is None:
 if self.manifest_strict:
 raise ValueError("Missing staticfiles manifest entry for
 '%s'" % clean_name)
 try:
 hashed = self.hashed_name(name)
 except ValueError:
 hashed = name
 cache_name = self.clean_name(hashed)
 unparsed_name = list(parsed_name)
 unparsed_name[2] = cache_name
 # Special casing for a @font-face hack, like
 url(myfont.eot?#iefix")
 # http://www.fontspring.com/blog/the-new-bulletproof-font-face-
 syntax
 if '?#' in name and not unparsed_name[3]:
 unparsed_name[2] += '?'
 return urlunsplit(unparsed_name)
 }}}


 And here are the tests:

 {{{
 from os.path import exists

 from django.conf import settings
 from django.templatetags.static import static
 from django.test import SimpleTestCase, override_settings


 @override_settings(STATIC_URL='/static/')
 class StaticResolveTest(SimpleTestCase):
 def test_existing_static_path_resolves(self):
 location = 'admin/js/vendor/jquery/jquery.js'
 path = join(settings.STATIC_ROOT, location)
 self.assertTrue(exists(path), 'Path "%s" did not exist' % path)

 static_location = static(location)
 static_location_parts = static_location.split('.')
 self.assertEqual(static_location_parts[0],
 '/static/admin/js/vendor/jquery/jquery')
 self.assertEqual(static_location_parts[-1], 'js')

 def test_missing_static_path_resolves(self):
 location = 'does-not-exist.txt'
 path = join(settings.STATIC_ROOT, location)
 self.assertFalse(exists(path), 'Path "%s" was not supposed to
 exist' % path)
 self.assertEqual(static(location), '/static/does-not-exist.txt')

 def test_served_static_response(self):
 location = 'admin/js/vendor/jquery/jquery.js'
 path = join(settings.STATIC_ROOT, location)
 self.assertTrue(exists(path), 'Path "%s" did not exist' % path)

 response = self.client.get(static(location))
 self.assertEqual(response.status_code, 200)

 self.assertTrue(response.streaming)
 response_content = b''.join(response.streaming_content)
 with open(path, 'rb') as fp:
 disk_content = fp.read()
 self.assertEqual(response_content, disk_content)

 def test_missing_static_response(self):
 location = 'does-not-exist.txt'
 path = join(settings.STATIC_ROOT, location)
 self.assertFalse(exists(path), 'Path "%s" was not supposed to
 exist' % path)

 response = self.client.get(static(location))
 self.assertEqual(response.status_code, 404)

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, 

Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Braunson):

 Replying to [comment:22 Andrew Godwin]:
 > Wait, how are you able to use async third party libraries in Django 3.0?
 While it has ASGI support, that's only to run in synchronous mode; if
 you're doing your own async stuff from Django views you want to be careful
 or you can cause issues like this.

 Using the @async_to_sync decorators for some functions where awaits might
 be required

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1660c4023a45d0b8e0928eb58be80c69%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Andrew Godwin):

 Wait, how are you able to use async third party libraries in Django 3.0?
 While it has ASGI support, that's only to run in synchronous mode; if
 you're doing your own async stuff from Django views you want to be careful
 or you can cause issues like this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e1937ef1d892f59be01e8fbaa07d1e14%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Braunson):

 Replying to [comment:20 Andrew Godwin]:
 > Well, we would have to find exactly where the bug is first before fixing
 it. Nothing I know of in my quick glance through the code made it obvious
 where it could be; we seem to correctly handle the `close_old_connections`
 call even in Django 3.0 ASGI mode (not calling `close_old_connections` is
 often the cause of this bug).
 >
 > I never figured out why during Channels development, but the MySQL
 backend seems specifically prone to these sorts of issues even when it
 should be fine. I think if you set a non-zero CONN_MAX_AGE it should clear
 itself up, if you can take that operationally, otherwise I think you may
 have to run on WSGI rather than ASGI for now (unless we track down exactly
 what is doing this)

 I did actually try setting a non-zero `CONN_MAX_AGE` but the issue
 persists. And unfortunately we developed some features that rely on ASGI
 due to using async third party libraries.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.419fd878e9b9ba5f39fbe8adbc1fd7f7%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Andrew Godwin):

 Well, we would have to find exactly where the bug is first before fixing
 it. Nothing I know of in my quick glance through the code made it obvious
 where it could be; we seem to correctly handle the `close_old_connections`
 call even in Django 3.0 ASGI mode (not calling `close_old_connections` is
 basically the cause of this bug).

 I never figured out why during Channels development, but the MySQL backend
 seems specifically prone to these sorts of issues even when it should be
 fine. I think if you set a non-zero MAX_AGE it should clear itself up, if
 you can take that operationally, otherwise I think you may have to run on
 WSGI rather than ASGI for now (unless we track down exactly what is doing
 this)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.46050a3544e5886742880ca303d93dad%40djangoproject.com.


Re: [Django] #31356: Update IRC links in documentation.

2020-04-27 Thread Django
#31356: Update IRC links in documentation.
-+-
 Reporter:  Adam (Chainz)|Owner:  Hasan
  Johnson|  Ramezani
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  Sarthak Kumar => Hasan Ramezani
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b7e2d31b9ba850afdf87ed3362ee4cfc%40djangoproject.com.


Re: [Django] #31517: ManifestFilesMixin.file_hash() returning None get's included in hashed filename as 'None'.

2020-04-27 Thread Django
#31517: ManifestFilesMixin.file_hash() returning None get's included in hashed
filename as 'None'.
-+-
 Reporter:  Richard Campen   |Owner:  Richard
 Type:   |  Campen
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  HashedFilesMixin,| Triage Stage:  Accepted
  ManifestFilesMixin, file_hash, |
  hashed_name|
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Richard Campen):

 Thanks for the feedback. I've update the PR as per your recommendations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d08e4397cda518513a5a20cb4aafc07e%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Braunson):

 Replying to [comment:18 felixxm]:
 > Django 3.0 supports ASGI, however it can be really tricky to backport a
 fix from master. There is a big risk of introducing new regressions, so
 IMO we should document this limitation in Django 3.0.
 >
 > I will try to add a proper regression test.

 There's no possible way for an end user to solve this in 3.0.5 then? Even
 if I set a really high timeout value for the SQL server, they still would
 have to expire eventually and Django will try to use them. It makes any
 database operations on 3.0.5 sort of impossible without having a timeout
 eventually no?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.972fd77fac304d1668d0bac0d60f4889%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by felixxm):

 * component:  Database layer (models, ORM) => Documentation
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Django 3.0 supports ASGI, however it can be really tricky to backport a
 fix from master. There is a big risk of introducing new regressions, so
 IMO we should document this limitation in Django 3.0.

 I will try to add a proper regression test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b7f47fc857e1d0dad37c7e6a2585a2d2%40djangoproject.com.


Re: [Django] #31519: Unclosed tags don't cause syntax errors in templates. (was: Unclosed tags don't cause Syntax errors in Templates)

2020-04-27 Thread Django
#31519: Unclosed tags don't cause syntax errors in templates.
-+--
 Reporter:  Bithive  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  Tags | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by felixxm):

 * status:  new => closed
 * type:  Uncategorized => New feature
 * resolution:   => wontfix


Comment:

 Thanks for this ticket, however
 [https://docs.djangoproject.com/en/3.0/ref/templates/language/#the-django-
 template-language DTL] parses only properly closed tags: ''"Django's
 template parser looks for the first occurrence of `%}` after a `{%`..."''
 and I think we shouldn't change this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f85728eb64a96be14288070700f1c9e1%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Braunson):

 Replying to [comment:16 felixxm]:
 > Braunson, see [https://code.djangoproject.com/wiki/Version3.1Roadmap
 Version3.1Roadmap].

 Ouch August for this fix? Is there any plan to backport it? Results in a
 lot of 500 errors from timed out connections.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.495a1e575cfeb72d8e3b201a4c5c4ad2%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Braunson, see [https://code.djangoproject.com/wiki/Version3.1Roadmap
 Version3.1Roadmap].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fe207beece2ee8e999c299b2213fc00b%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Braunson):

 Replying to [comment:14 Andrew Godwin]:
 > Well, the current `master` has a whole swathe of different async fixes
 due to the work done around the async views work - I would not be
 surprised if this is what fixed it if you are comparing to 3.0. The signal
 handling, especially, was fixed, and not running the start/end request
 signals properly is one of the main causes of this kind of bug.

 Awesome. Glad to hear it's supposedly been fixed then. Is there a
 roadmap/schedule I can look at for when the master changes will make it
 into a release?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a6c2433ddcd420b22bb9b01d78e4df5a%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrew Godwin):

 Well, the current `master` has a whole swathe of different async fixes due
 to the work done around the async views work - I would not be surprised if
 this is what fixed it if you are comparing to 3.0. The signal handling,
 especially, was fixed, and not running the start/end request signals
 properly is one of the main causes of this kind of bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a8d7fb1386d5780cacab561300a1868f%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Braunson):

 Replying to [comment:12 felixxm]:
 > Andrew, it works properly with `asgiref==3.2.7` on master. You can
 reproduce this issue on Django 3.0 with the same version of `asgiref` 樂.

 So it's broken in 3.0.5 with the latest `asgiref` but is working in master
 somehow? Which would mean the next release fixed it inadvertently?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.856c052c841caa9c3f01817f3bc4296b%40djangoproject.com.


Re: [Django] #31511: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields

2020-04-27 Thread Django
#31511: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields
-+-
 Reporter:  Andy Chosak  |Owner:  (none)
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  urlify, slugify, | Triage Stage:
  slug   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by felixxm):

 Scott, we have multiple tickets about `slugify` and `URLify`  that we can
 basically split them into two categories, language specific behavior and
 inconsistency. #11157 is about inconsistency with stopwords, your propose
 is to not strip stopwords which will make their behavior consistent. IMO
 we can treat this as a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dc6e533dbed3f5e0e9a131a786a4b6f0%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Andrew, it works properly with `asgiref==3.2.7` on master. You can
 reproduce this issue on Django 3.0 with the same version of `asgiref` 樂.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.28c8372fa383bc0cb65c64ed80265ee5%40djangoproject.com.


Re: [Django] #31505: Document possible email address enumeration in PasswordResetView.

2020-04-27 Thread Django
#31505: Document possible email address enumeration in PasswordResetView.
-+-
 Reporter:  Mohammad Almazroa|Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  User Enumeration | Triage Stage:  Accepted
  Security Bug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"04bc3577eddef6bef52d440f4f53877bcae264c5" 04bc3577]:
 {{{
 #!CommitTicketReference repository=""
 revision="04bc3577eddef6bef52d440f4f53877bcae264c5"
 [3.0.x] Fixed #31505 -- Doc'd possible email addresses enumeration in
 PasswordResetView.

 Backport of ca769c8c13df46b8153a0a4ab3d748e88d6e26f9 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a49a3b610e21ca1f513141aa767d27bd%40djangoproject.com.


Re: [Django] #31505: Document possible email address enumeration in PasswordResetView.

2020-04-27 Thread Django
#31505: Document possible email address enumeration in PasswordResetView.
-+-
 Reporter:  Mohammad Almazroa|Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  User Enumeration | Triage Stage:  Accepted
  Security Bug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ca769c8c13df46b8153a0a4ab3d748e88d6e26f9" ca769c8]:
 {{{
 #!CommitTicketReference repository=""
 revision="ca769c8c13df46b8153a0a4ab3d748e88d6e26f9"
 Fixed #31505 -- Doc'd possible email addresses enumeration in
 PasswordResetView.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9fa92bcd098ab1665b76054ec32b4e2a%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrew Godwin):

 This really should have been handled by that most recent asgiref release
 as you discussed above - unless gevent or something else is in there
 screwing up the threading module, I'm not sure what's happening here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d664af26a6f35b4ca542304450545b98%40djangoproject.com.


Re: [Django] #31511: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields

2020-04-27 Thread Django
#31511: Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields
-+-
 Reporter:  Andy Chosak  |Owner:  (none)
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  urlify, slugify, | Triage Stage:
  slug   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Scott Cranfill):

 Hi Mariusz,

 Thanks for your feedback. Andy and I weren't sure how long to wait for
 more feedback on the mailing list discussion we opened, so we thought
 starting the ticket and offering a patch might move things along. Happy to
 take the discussion back there, but I will respond to your comment here,
 since you haven't commented there yet.

 We respectfully disagree that this is a duplicate of #11157. That ticket
 was more general, addressing the question of whether `slugify` and
 `URLify` should behave the same. The issue we are raising is about
 changing a specific behavior that exists only in `URLify`, independent of
 anything to do with `slugify`.

 Looking forward to further discussion!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ba280068f3508f109a542f971424c196%40djangoproject.com.


[Django] #31519: Unclosed tags don't cause Syntax errors in Templates

2020-04-27 Thread Django
#31519: Unclosed tags don't cause Syntax errors in Templates
---+
   Reporter:  Bithive  |  Owner:  nobody
   Type:  Uncategorized| Status:  new
  Component:  Template system  |Version:  3.0
   Severity:  Normal   |   Keywords:  Tags
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Unclosed Tags e.g. "{% extends '_base" don't trow syntax errors.

 These problems are hard to detect via tests maybe Django should throw a
 syntax error

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.e1361ddbde00110f8e234b7cb103222e%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Also, I cannot reproduce this issue on the current master, connections are
 closed properly at the end of each request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.71ae0a70266a1161c7bc3a3f59aa2e98%40djangoproject.com.


Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-27 Thread Django
#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+-
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Using cache and sync method are unrelated, I can reproduce the same
 behavior with:
 {{{
 def home(request):
 users = UserProxy.objects.all()
 num = 1
 users[0].discord = num
 users[0].save()
 return render(request, 'home.html', {'users': users[0], 'num': num})
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fe7aa11d0829a94c48f1becf0cdd2163%40djangoproject.com.


Re: [Django] #18325: Wrap management stdout/stderr

2020-04-27 Thread Django
#18325: Wrap management stdout/stderr
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"71d9876e39abafe81e031b92ecd300c7d13346ea" 71d9876e]:
 {{{
 #!CommitTicketReference repository=""
 revision="71d9876e39abafe81e031b92ecd300c7d13346ea"
 Refs #18325 -- Removed unnecessary line endings in management commands.

 The OutputWrapper automatically adds \n when it’s not present.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0145598862b58f4e81971107c5ae8aa1%40djangoproject.com.


Re: [Django] #31504: Allow makemigrations to skip database consistency checks

2020-04-27 Thread Django
#31504: Allow makemigrations to skip database consistency checks
-+
 Reporter:  Tom Forbes   |Owner:  wtkm11
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by felixxm):

 * needs_better_patch:  0 => 1


Comment:

 I agree with Tom, this is quite niche so I would also prefer to fail
 gracefully. IMO we don't need a new option.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.e4dd3b7d3bf384b97f4b87310e4b109a%40djangoproject.com.