Re: [Django] #32189: test.client.AsyncClient request POST failing

[Django]

#32189: test.client.AsyncClient request POST failing
---+--
 Reporter:  perryjrandall  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by perryjrandall):

 Wow you're totally right, I guess I misunderstood that part of the
 framework

 Thanks for clarifying!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a4b830e990534aef0ad3e19045a5e371%40djangoproject.com.

Re: [Django] #27590: Prevent public access of staticfiles manifest

[Django]

#27590: Prevent public access of staticfiles manifest
-+-
 Reporter:  David Sanders|Owner:  Jarosław
 Type:   |  Wygoda
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1bdb59a80a5e8483b79934695022b0a0%40djangoproject.com.

Re: [Django] #32120: Add DatabaseFeatures.indexes_foreign_keys

[Django]

#32120: Add DatabaseFeatures.indexes_foreign_keys
-+-
 Reporter:  Tim Graham   |Owner:  Tim
 |  Graham
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"8ed024b9b9ca4491fcb17cb15b3b5f18a8f60ff8" 8ed024b]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ed024b9b9ca4491fcb17cb15b3b5f18a8f60ff8"
 Refs #32120 -- Fixed test_add_inline_fk_index_update_data for
 DatabaseFeatures.indexes_foreign_keys.

 This test creates an index with editor.add_index() so it's present
 regardless of the database's behavior. Reverted the change from
 ede9fac75807fe5810df66280a60e7068cc97e4a.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.65ae0e93f6f188568b29325778250a61%40djangoproject.com.

Re: [Django] #32190: Support for model relationships defined pre-save

[Django]

#32190: Support for model relationships defined pre-save
-+-
 Reporter:  Ryan Vinzent |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * type:  New feature => Bug
 * resolution:   => duplicate


Comment:

 Duplicate of #29497. It was fixed in
 10f8b82d195caa3745ba37d9424893763f89653e (Django 3.2+).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.18ada9573aad2c7ef82bad2f795c6f9a%40djangoproject.com.

Re: [Django] #30272: get_language_from_request(..., check_path=True) not respecting i18n_patterns prefix_default_language=False

[Django]

#30272: get_language_from_request(..., check_path=True) not respecting
i18n_patterns prefix_default_language=False
--+
 Reporter:  Stefan Wehrmeyer  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


Comment:

 Landed here from surfing GitHub. Don't see comments here or on the PR for
 the author to address, so resetting review flags for now. (Forgive me
 Carlton if I missed something!)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e35e417bb40facad253d765009f6475%40djangoproject.com.

[Django] #32190: Support for model relationships defined pre-save

[Django]

#32190: Support for model relationships defined pre-save
-+-
   Reporter:  Ryan   |  Owner:  nobody
  Vinzent|
   Type:  New| Status:  new
  feature|
  Component:  Database   |Version:  3.1
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 There are many situations where it is optimal to define a bunch of
 objects, and then later commit them in bulk. When the objects define a FK
 relationship, this strategy requires a bit of hacking that I would prefer
 not to do. Take the following example:

 {{{#!python
 class Parent(models.Model):
 name = models.TextField()

 class Child(models.Model):
 name = models.TextField()
 parent = models.ForeignKey(Parent, on_delete=models.RESTRICT)
 }}}

 Now if we have some function that defines a bunch of these objects to
 later commit them in bulk:

 {{{#!python
 def build_objects(parent_child_mapping):
 parents = []
 children = []
 # {"father": ["son", "daughter"], ...}
 for parent_name, child_names in parent_child_mapping.items():
 parent = Parent(name=parent_name)
 parents.append(parent)
 children.extend(Child(parent=parent, name=child_name) for
 child_name in child_names)

 # now commit all objects in bulk
 Parent.objects.bulk_create(parents)

 # fails with IntegrityError: parent_id is not nullable
 Child.objects.bulk_create(children)
 }}}

 I would expect the above to work fine, given the parent ID's are known
 when inserting the children, however this would throw an `IntegrityError`
 because `parent_id` on the `Child` objects is still `None`.

 Adding a simple hack to the function will let it work fine, but it's
 annoying to do this ''everywhere'' where this pattern of creating objects
 is followed.
 {{{#!python
 def build_objects(parent_child_mapping):
 parents = []
 children = []
 for parent_name, child_names in parent_child_mapping.items():
 parent = Parent(name=parent_name)
 parents.append(parent)
 children.extend(Child(parent=parent, name=child_name) for
 child_name in child_names)

 # now commit all objects in bulk
 Parent.objects.bulk_create(parents)

 # add hack to make sure object IDs are properly assigned
 for child in children:
 child.parent_id = child.parent.id

 # now this call can succeed
 Child.objects.bulk_create(children)
 }}}

 This seems like something that should be supported by Django, and  I
 believe this would make the ORM more consistent overall.

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.391975f17391bcf285a42a5292cb885f%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.929e3bcb4d2d3abc5965656a64835941%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 As per the
 [https://github.com/django/django/pull/13615#issuecomment-726174242
 comment by felixxm] on [https://github.com/django/django/pull/13615 PR], I
 have created a check for the valid locales to not have hyphens.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f304e1a905789ce22af959a1122e739d%40djangoproject.com.

Re: [Django] #25370: Error display when makemigrations' field serializing fails with ValueError

[Django]

#25370: Error display when makemigrations' field serializing fails with 
ValueError
-+-
 Reporter:  torstenrudolf|Owner:  Craig
 Type:   |  Smith
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => wontfix
 * stage:  Accepted => Unreviewed


Comment:

 It looks that it's not feasible to get `..` or even `.` in a reliable way because Django
 serializes instances of `field`s from `django.db.models` not a model
 attributes. Each approach doesn't work in some cases, e.g. constructing
 messages in the `FunctionTypeSerializer` will not work for `lambda`s
 defined in the module
 {{{
 Error during serializing test_one.models.:  ...
 }}}
 or for `lambda`s imported from other modules:
 {{{
 ValueError: Error during serializing test_one.utils.: ...
 }}}
 instead of `ValueError: Error during serializing
 test_one.models.Model1.field1`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.2122cb6a7f3778ba56da5a0d0a37f54e%40djangoproject.com.

Re: [Django] #32149: dateformat.y() doesn't support years < 1000.

[Django]

#32149: dateformat.y() doesn't support years < 1000.
-+-
 Reporter:  Sam  |Owner:  Sam
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  date templatetag | Triage Stage:  Ready for
  filter |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"895f6e49925ed0ae4bb96dc4d3af17fdc9c4846e" 895f6e49]:
 {{{
 #!CommitTicketReference repository=""
 revision="895f6e49925ed0ae4bb96dc4d3af17fdc9c4846e"
 Fixed #32149 -- Added support for years < 1000 to DateFormat.y().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.867ae945dde08d9efb16531db3fcad5a%40djangoproject.com.

Re: [Django] #32149: dateformat.y() doesn't support years < 1000.

[Django]

#32149: dateformat.y() doesn't support years < 1000.
-+-
 Reporter:  Sam  |Owner:  Sam
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:  date templatetag | Triage Stage:  Ready for
  filter |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/13670 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.9a5a3650a0dbbbc843492236187300fa%40djangoproject.com.

Re: [Django] #32187: The .select_related is not necessary in the .update documentation

[Django]

#32187: The .select_related is not necessary in the .update documentation
-+-
 Reporter:  Willem Van Onsem |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  orm, query,  | Triage Stage:  Accepted
  documentation  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"eba8d6f5d73ed315e4b89b6cb92db57c3906bd5d" eba8d6f]:
 {{{
 #!CommitTicketReference repository=""
 revision="eba8d6f5d73ed315e4b89b6cb92db57c3906bd5d"
 [3.1.x] Fixed #32187 -- Removed unnecessary select_related in queries doc.

 Backport of c448e614c60cc97c6194c62052363f4f501e0953 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e50fa43119b1d6c4b6c1544b29b9%40djangoproject.com.

Re: [Django] #32187: The .select_related is not necessary in the .update documentation

[Django]

#32187: The .select_related is not necessary in the .update documentation
-+-
 Reporter:  Willem Van Onsem |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  orm, query,  | Triage Stage:  Accepted
  documentation  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c448e614c60cc97c6194c62052363f4f501e0953" c448e61]:
 {{{
 #!CommitTicketReference repository=""
 revision="c448e614c60cc97c6194c62052363f4f501e0953"
 Fixed #32187 -- Removed unnecessary select_related in queries doc.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.50cf003d36eef1205ea712d883e271ef%40djangoproject.com.

Re: [Django] #32172: Adapt signals to allow async handlers

[Django]

#32172: Adapt signals to allow async handlers
-+-
 Reporter:  Carlton Gibson   |Owner:
 |  Konstantin Volkov
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  async| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/13651 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ff00aa185321c8f5a1adf12c8fcb30e5%40djangoproject.com.

Re: [Django] #32189: test.client.AsyncClient request POST failing

[Django]

#32189: test.client.AsyncClient request POST failing
---+--
 Reporter:  perryjrandall  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 This is expected behaviour. It's exactly the same using the synchronous
 `Client`.

 `request.POST` is not populated for non-form requests, where
 [https://docs.djangoproject.com/en/3.1/ref/request-
 response/#django.http.HttpRequest.body you should use `request.body`]

 Adjusting the view in your test case:

 {{{
 from json import loads

 async def async_generic_view(request):
parsed_body = loads(request.body)
return JsonResponse(parsed_body)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.076c3dff3e3fecfb28aa7525ed8263ab%40djangoproject.com.

Re: [Django] #32187: The .select_related is not necessary in the .update documentation

[Django]

#32187: The .select_related is not necessary in the .update documentation
-+-
 Reporter:  Willem Van Onsem |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:  orm, query,  | Triage Stage:  Accepted
  documentation  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6a5fbc923bb2a775fe094e5620af47d2%40djangoproject.com.

Re: [Django] #32187: The .select_related is not necessary in the .update documentation

[Django]

#32187: The .select_related is not necessary in the .update documentation
-+-
 Reporter:  Willem Van Onsem |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:  orm, query,  | Triage Stage:  Accepted
  documentation  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Yes, looks right.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5756f8fbcc7939dfd3fbebebcf402e84%40djangoproject.com.