Re: [Django] #32194: Issue while rendering view with Django 3.1.3. (was: Issue while rendering view with Django 3.1.3 using render function that works fine with Django 2.2)

[Django]

#32194: Issue while rendering view with Django 3.1.3.
---+--
 Reporter:  @deathdater|Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  3.1
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 It looks that you passed `studiomaster` to the `content_type` which is not
 correct. Please don't use Trac as a support channel and use one of them in
 you have further questions.

 Closing per TicketClosingReasons/UseSupportChannels.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8645abc8200582e133b52169284692e8%40djangoproject.com.

Re: [Django] #32193: Deprecate MemcachedCache.

[Django]

#32193: Deprecate MemcachedCache.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned


Comment:

 [https://groups.google.com/g/django-
 developers/c/tSt___9fk1s/m/ChPGJrQkAQAJ Mailing list discussion]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a308614968bf6f71d3f0637d5bd93de7%40djangoproject.com.

Re: [Django] #32194: Issue while rendering view with Django 3.1.3 using render function that works fine with Django 2.2

[Django]

#32194: Issue while rendering view with Django 3.1.3 using render function that
works fine with Django 2.2
---+--
 Reporter:  deathdater |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Generic views  |  Version:  3.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by deathdater):

 * Attachment "Screen Shot 2020-11-14 at 12.05.10 PM.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.dd8a76f2b50a0f0e775dfb934874abee%40djangoproject.com.

[Django] #32194: Issue while rendering view with Django 3.1.3 using render function that works fine with Django 2.2

[Django]

#32194: Issue while rendering view with Django 3.1.3 using render function that
works fine with Django 2.2
-+
   Reporter:  deathdater |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Generic views  |Version:  3.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 {{{
 def studiolist_page(request,*args,**kwargs):
 studiomaster={'studio_master_key':StudioMaster.objects.all()}
 studiolist_all=StudioDetails.objects.filter(studio_status=10)

 city_query=request.GET.get("cty")
 studio_type_query=request.GET.get("s_type")
 genre_query=request.GET.get("gnre")
 baseprice_query=request.GET.get("price")
 studiolist={'studio_list_key':studiolist_all}
 print(6)

 x=len(studiolist.get('studio_list_key'))
 if x==0:
 y='Sorry!! No Studios Available Here !!'
 else:
 y=str(x)+' Fresh Studios Served !!'
 messages.success(request,y)

 return
 render(request,'studiomaster/studiocard_list.html',studiolist,studiomaster)
 }}}

 I also have tried changing the template to find if its an issue with html,
 but the result is same, So I assume that it might be something to do with
 the View handling itself.

 To my surprise this works fine in Django 2.2 but loads html code on the
 browser when being rendered so the template is being called but the
 loading has some abnormal behaviour .

 Any help here is greatly appreciated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.5b71a4702d977a01a7ed8e66899bcf5a%40djangoproject.com.

[Django] #32193: Deprecate MemcachedCache.

[Django]

#32193: Deprecate MemcachedCache.
+
   Reporter:  Mariusz Felisiak  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (Cache system)   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 `python-memcached` is not maintained anymore (see
 [https://github.com/linsomniac/python-memcached/issues/95 python-
 memcached#95]) and it makes difficulties in fixing some issues (e.g.
 #29867). Moreover we added a cache backend for `pymemcache` (#29887) so we
 have a good builtin alternative.

 I think it's time to deprecate the
 `django.core.cache.backends.memcached.MemcachedCache` backend in Django
 3.2 and remove it in Django 4.1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.7756499168fd3c50e8c63fd3bdc97937%40djangoproject.com.

Re: [Django] #24474: Make display for null fields in Django admin configurable through settings

[Django]

#24474: Make display for null fields in Django admin configurable through 
settings
-+-
 Reporter:  Loek van Gent|Owner:  Loek van
 |  Gent
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"67a1ae68a833358e4b5bf2677e3f9f5719443bea" 67a1ae6]:
 {{{
 #!CommitTicketReference repository=""
 revision="67a1ae68a833358e4b5bf2677e3f9f5719443bea"
 Refs #24474 -- Changed AdminSite.empty_value_display property to an
 attribute.

 This was implemented with a property getter and setter when introduced
 in 0207bdd2d4157c542c981264c86706b78ca246e9.

 There is nothing special occurring here though - a simple read from and
 assign to the underlying private attribute.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.229ec43e05dc2fcaab83716a40fc8103%40djangoproject.com.

Re: [Django] #26583: Add an option to silence collectstatic clashing files warnings

[Django]

#26583: Add an option to silence collectstatic clashing files warnings
-+-
 Reporter:  Justin McCammon  |Owner:
 Type:   |  ryanhunter1836
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ryanhunter1836):

 * owner:  nobody => ryanhunter1836
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d0a76e9734a22de71c7aa3477ea7e058%40djangoproject.com.

Re: [Django] #26607: Add a hook to customize the admin's formsets parameters

[Django]

#26607: Add a hook to customize the admin's formsets parameters
-+-
 Reporter:  David Sanders|Owner:  Manav
 |  Agarwal
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin inline | Triage Stage:  Accepted
  formset initial|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Manav Agarwal):

 * owner:  (none) => Manav Agarwal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.fe33727c0cb2eede6e00efb0130abed2%40djangoproject.com.

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

[Django]

#19580: Unify reverse foreign key and m2m unsaved model querying
-+-
 Reporter:  Anssi Kääriäinen |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Manav Agarwal):

 * owner:  Ahsan Shafiq => Manav Agarwal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.54740081dbc566715abfb16aff4eb46c%40djangoproject.com.

Re: [Django] #31507: Augment QuerySet.exists() optimizations to .union().exists().

[Django]

#31507: Augment QuerySet.exists() optimizations to .union().exists().
-+-
 Reporter:  Simon Charette   |Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e5b11f5d39a1541dfe93977928f4bd2c%40djangoproject.com.

Re: [Django] #32191: Not RFC 6265 compliant cookies in contrib.messages.

[Django]

#32191: Not RFC 6265 compliant cookies in contrib.messages.
--+
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.messages  |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Florian Apolloner):

 Well technically it applies to the whole `request.cookies` interface; but
 I don't see any feasible fix there. It would a) be highly backwards
 incompatible and b) cookies might require coordination with the frontend
 JS -- so it is better if the user can decide what to encode and how. I
 mean in the best case one doesn't store much in cookies either way, they
 do not perform well with concurrent requests for instance…

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c5e5b11e474876020de4641483b5f681%40djangoproject.com.

Re: [Django] #32191: Not RFC 6265 compliant cookies in contrib.messages. (was: Not RFC Compliant Cookie handling)

[Django]

#32191: Not RFC 6265 compliant cookies in contrib.messages.
--+
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.messages  |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * component:  HTTP handling => contrib.messages
 * stage:  Unreviewed => Accepted


Comment:

 Agreed, we should fix cookies values from `contrib.messages`. I
 misunderstood the ticket description. Thanks Florian.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.056d9ae45984723e955215f95132ee59%40djangoproject.com.

Re: [Django] #32192: Replacing the quotation marks with apostrophe marks in admin/base.html

[Django]

#32192: Replacing the quotation marks with apostrophe marks in admin/base.html
-+-
 Reporter:  Sihwan Lee   |Owner:  Sihwan
 Type:   |  Lee
  Cleanup/optimization   |   Status:  closed
Component:  Template system  |  Version:  3.1
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Both versions work fine, so I wouldn't change them in builtin templates.
 We try to avoid bulk updates in code unless it's a big problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2d0f2e3b97203797b53634b7cff4e7d9%40djangoproject.com.

[Django] #32192: Replacing the quotation marks with apostrophe marks in admin/base.html

[Django]

#32192: Replacing the quotation marks with apostrophe marks in admin/base.html
-+-
   Reporter:  Sihwan |  Owner:  Sihwan Lee
  Lee|
   Type: | Status:  assigned
  Cleanup/optimization   |
  Component:  Template   |Version:  3.1
  system |
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 In the django/django/contrib/admin/templates/admin/base.html, the
 quotation marks interfere with some of the html quotation marks, such as:

 {{{
 
 }}}

 the quotation marks inside the  "{% static "admin/css/responsive.css" %}"
 interfere with the quotation marks outside. Needs a bit of cleaning up in
 the html format.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.7c90431632e3d8c92ecf461af9e3ee4d%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  HTTP handling |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Florian Apolloner):

 An initial approach can look like this:
 {{{
 diff --git a/django/contrib/messages/storage/cookie.py
 b/django/contrib/messages/storage/cookie.py
 index b51e292aa0..c75ed75940 100644
 --- a/django/contrib/messages/storage/cookie.py
 +++ b/django/contrib/messages/storage/cookie.py
 @@ -1,5 +1,7 @@
  import json

 +from urllib.parse import quote, unquote
 +
  from django.conf import settings
  from django.contrib.messages.storage.base import BaseStorage, Message
  from django.core import signing
 @@ -8,6 +10,9 @@ from django.utils.crypto import constant_time_compare,
 salted_hmac
  from django.utils.safestring import SafeData, mark_safe


 +SAFE_COOKIE_CHARS = "!#$%&'()*+/:<=>?@[]^`{|}"
 +
 +
  class MessageEncoder(json.JSONEncoder):
  """
  Compactly serialize instances of the ``Message`` class as JSON.
 @@ -24,6 +29,9 @@ class MessageEncoder(json.JSONEncoder):
  return message
  return super().default(obj)

 +def encode(self, obj):
 +return quote(super().encode(obj), safe=SAFE_COOKIE_CHARS)
 +

  class MessageDecoder(json.JSONDecoder):
  """
 @@ -43,7 +51,7 @@ class MessageDecoder(json.JSONDecoder):
  return obj

  def decode(self, s, **kwargs):
 -decoded = super().decode(s, **kwargs)
 +decoded = super().decode(unquote(s), **kwargs)
  return self.process_messages(decoded)


 diff --git a/tests/messages_tests/test_cookie.py
 b/tests/messages_tests/test_cookie.py
 index 5d5fb42d67..af7f36f8d0 100644
 --- a/tests/messages_tests/test_cookie.py
 +++ b/tests/messages_tests/test_cookie.py
 @@ -182,3 +182,12 @@ class CookieTests(BaseTests, SimpleTestCase):
  self.assertEqual(decoded, messages)
  storage_default = self.get_storage()
  self.assertNotEqual(encoded, storage_default._encode(messages))
 +
 +def test_rfc_6265_encoding(self):
 +storage = self.storage_class(self.get_request())
 +msg_1 = Message(constants.INFO, 'Test me')
 +msg_2 = Message(constants.INFO, 'Test me \\again')
 +example_messages = [msg_1, msg_2]
 +encoded = storage._encode(example_messages)
 +expected =
 
'[[%22__json_message%22%2C0%2C20%2C%22Test%20me%22]%2C[%22__json_message%22%2C0%2C20%2C%22Test%20me%20%5C%5Cagain%22]]'
 +self.assertEqual(encoded.split(':')[0], expected)
 }}}

 That said, this makes messages quite a bit longer :/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4cc98fb67cf9090a9d10053933749eb2%40djangoproject.com.

Re: [Django] #24434: Django Custom Field inherits ForeignKey deconstruct() fails

[Django]

#24434: Django Custom Field inherits ForeignKey deconstruct() fails
-+-
 Reporter:  greenbender  |Owner:  Nishant
 |  Sagar
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  deconstruct,migration  |
Has patch:  0|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Hi Nishant. Thanks for the input on the ticket. Can you say how/why it's
 fixed so we know that's OK to close? ("Latest docs say... and ..." — or
 such.) 

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.722bc94a7b56bdee520f1d35ba967ae4%40djangoproject.com.

Re: [Django] #24434: Django Custom Field inherits ForeignKey deconstruct() fails

[Django]

#24434: Django Custom Field inherits ForeignKey deconstruct() fails
-+-
 Reporter:  greenbender  |Owner:  Nishant
 |  Sagar
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.7
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  deconstruct,migration  |
Has patch:  0|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nishant Sagar):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.2cb446c67fe4a53733afbffed4df0437%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  HTTP handling |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Florian Apolloner):

 * status:  closed => new
 * resolution:  wontfix =>


Comment:

 Given that you CC'ed me I am going to reopen this :) The spec is rather
 clear on what is allowed and we should try (when we generate cookies) to
 comply. This should at least apply to cookies Django core/contrib apps
 (d.c.messages) generates. I am not sure if we want to put encoding
 handling into our general cookie handling; I'd probably leave that to the
 enduser if they want to store weird data there :D

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0db086e71ff074c744e5cf3a1dfa6ec3%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  HTTP handling |  Version:  3.1
 Severity:  Normal|   Resolution:  wontfix
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Django uses Python's [https://docs.python.org/3/library/http.cookies.html
 http.cookies.SimpleCookie] class, and as far as I'm aware we don't escape
 any characters in Django. It looks that it has already been reported in
 [https://bugs.python.org/ Python bug tracker], see
 https://bugs.python.org/issue19670.

 I don't think that we should switch to `BaseCookie`. You can start a
 discussion on DevelopersMailingList if you don't agree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dbe00031d23db285a5603483423fd371%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  HTTP handling |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Nico Giefing):

 * status:  closed => new
 * resolution:  needsinfo =>


Comment:

 As described in the RFC, in a cookie value a backslash "\" is not to be
 used.

 The issue is that a " will be seen as the end of the cookie value on every
 device in the middle (WAF) and therefore not the full cookie value will
 get through to the webserver.

 Please let me know if you need more guidance.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.80ba579b1e9e783c418293b088e26511%40djangoproject.com.

Re: [Django] #12075: Add wsgiorg.routing args support

[Django]

#12075: Add wsgiorg.routing args support
-+-
 Reporter:  Gustavo Narea|Owner:  (none)
 Type:  New feature  |   Status:  new
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  WSGI,| Triage Stage:  Accepted
  wsgiorg.routing_args   |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Gustavo Narea => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b921ad975e14a8d70845d12da030128b%40djangoproject.com.

Re: [Django] #12416: Improve KML Serialization

[Django]

#12416: Improve KML Serialization
--+
 Reporter:  jbronn|Owner:  (none)
 Type:  New feature   |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  gis kml 3d style rhr  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  jbronn => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0569ceb5eb40f1775d8b6fd65f445f62%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  Nico Giefing  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  HTTP handling |  Version:  3.1
 Severity:  Normal|   Resolution:  needsinfo
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * cc: Collin Anderson, Florian Apolloner (added)
 * resolution:   => needsinfo
 * status:  new => closed
 * component:  Forms => HTTP handling


Comment:

 Django uses Python's `http.cookies._unquote()` to better match the
 behavior of browsers, see #26158.
 {{{
 messages=\"123\\\"NOTRECEIVED\""
 }}}
 is parsed to `{'messages': '123"NOTRECEIVED"'}` which seems correct to me.
 What value do you expect?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8eb5ae0585cbb064b61d498ce73478e0%40djangoproject.com.

[Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
   Reporter:  nicox   |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Forms   |Version:  3.1
   Severity:  Normal  |   Keywords:  Cookie malformed
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+--
 Hi
 A Customer of mine is using a WAF which is handling Cookies as it is
 described tin the RFC: https://tools.ietf.org/html/rfc6265

 The issue now is that Django is trying to use an escape-character in
 cookie-Values which is not supported in the RFC

 an example of such a cookie: messages=\"123\\\"NOTRECEIVED\""

 Please consider to get this fixed so there can be a protection of this
 system.

 Regards,

 Nico

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.f9e328df8fc4aa4233f8ffc6ae92aa93%40djangoproject.com.

Re: [Django] #32191: Not RFC Compliant Cookie handling

[Django]

#32191: Not RFC Compliant Cookie handling
--+--
 Reporter:  nicox |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Forms |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  Cookie malformed  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Description changed by nicox:

Old description:

> Hi
> A Customer of mine is using a WAF which is handling Cookies as it is
> described tin the RFC: https://tools.ietf.org/html/rfc6265
>
> The issue now is that Django is trying to use an escape-character in
> cookie-Values which is not supported in the RFC
>
> an example of such a cookie: messages=\"123\\\"NOTRECEIVED\""
>
> Please consider to get this fixed so there can be a protection of this
> system.
>
> Regards,
>
> Nico

New description:

 Hi
 A Customer of mine is using a WAF which is handling Cookies as it is
 described tin the RFC: https://tools.ietf.org/html/rfc6265

 The issue now is that Django is trying to use an escape-character in
 cookie-Values which is not supported in the RFC

 an example of such a cookie:
 {{{
 messages=\"123\\\"NOTRECEIVED\""
 }}}


 Please consider to get this fixed so there can be a protection of this
 system.

 Regards,

 Nico

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a023464040c97dc2e34e61797937c586%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f63f3cdf0969c23fd0c05de0f4a2a1df0cd5112e" f63f3cdf]:
 {{{
 #!CommitTicketReference repository=""
 revision="f63f3cdf0969c23fd0c05de0f4a2a1df0cd5112e"
 Fixed #29712 -- Made makemessages warn if locales have hyphens and skip
 them.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bc521916a5e2e7f318edf75c271f7061%40djangoproject.com.

Re: [Django] #31507: Augment QuerySet.exists() optimizations to .union().exists().

[Django]

#31507: Augment QuerySet.exists() optimizations to .union().exists().
-+-
 Reporter:  Simon Charette   |Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4e39b84570e0502d7d37f034fd04c7da%40djangoproject.com.